linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: James Clark <james.clark@linaro.org>
To: Suzuki K Poulose <suzuki.poulose@arm.com>,
	 Mike Leach <mike.leach@linaro.org>,
	 Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	 Jonathan Corbet <corbet@lwn.net>, Leo Yan <leo.yan@arm.com>
Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
	 linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
	 James Clark <james.clark@linaro.org>
Subject: [PATCH v4 02/13] coresight: Repack struct etmv4_drvdata
Date: Wed, 12 Nov 2025 15:22:08 +0000	[thread overview]
Message-ID: <20251112-james-cs-syncfreq-v4-2-165ba21401dc@linaro.org> (raw)
In-Reply-To: <20251112-james-cs-syncfreq-v4-0-165ba21401dc@linaro.org>

Fix holes and convert the long list of bools to single bits to save
some space because there's one of these for each ETM.

Reviewed-by: Leo Yan <leo.yan@arm.com>
Reviewed-by: Mike Leach <mike.leach@linaro.org>
Signed-off-by: James Clark <james.clark@linaro.org>
---
 drivers/hwtracing/coresight/coresight-etm4x.h | 37 ++++++++++++++-------------
 1 file changed, 19 insertions(+), 18 deletions(-)

diff --git a/drivers/hwtracing/coresight/coresight-etm4x.h b/drivers/hwtracing/coresight/coresight-etm4x.h
index 56a359184c6f..8f546764908c 100644
--- a/drivers/hwtracing/coresight/coresight-etm4x.h
+++ b/drivers/hwtracing/coresight/coresight-etm4x.h
@@ -962,26 +962,27 @@ struct etmv4_drvdata {
 	u8				ns_ex_level;
 	u8				q_support;
 	u8				os_lock_model;
-	bool				sticky_enable;
-	bool				boot_enable;
-	bool				os_unlock;
-	bool				instrp0;
-	bool				q_filt;
-	bool				trcbb;
-	bool				trccond;
-	bool				retstack;
-	bool				trccci;
-	bool				trc_error;
-	bool				syncpr;
-	bool				stallctl;
-	bool				sysstall;
-	bool				nooverflow;
-	bool				atbtrig;
-	bool				lpoverride;
+	bool				sticky_enable : 1;
+	bool				boot_enable : 1;
+	bool				os_unlock : 1;
+	bool				instrp0 : 1;
+	bool				q_filt : 1;
+	bool				trcbb : 1;
+	bool				trccond : 1;
+	bool				retstack : 1;
+	bool				trccci : 1;
+	bool				trc_error : 1;
+	bool				syncpr : 1;
+	bool				stallctl : 1;
+	bool				sysstall : 1;
+	bool				nooverflow : 1;
+	bool				atbtrig : 1;
+	bool				lpoverride : 1;
+	bool				skip_power_up : 1;
+	bool				paused : 1;
 	u64				trfcr;
 	struct etmv4_config		config;
-	bool				skip_power_up;
-	bool				paused;
+
 	DECLARE_BITMAP(arch_features, ETM4_IMPDEF_FEATURE_MAX);
 };
 

-- 
2.34.1



  parent reply	other threads:[~2025-11-12 15:22 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-12 15:22 [PATCH v4 00/13] coresight: Update timestamp attribute to be an interval instead of bool James Clark
2025-11-12 15:22 ` [PATCH v4 01/13] coresight: Change syncfreq to be a u8 James Clark
2025-11-14 12:20   ` Leo Yan
2025-11-12 15:22 ` James Clark [this message]
2025-11-12 15:22 ` [PATCH v4 03/13] coresight: Refactor etm4_config_timestamp_event() James Clark
2025-11-12 15:22 ` [PATCH v4 04/13] coresight: Hide unused ETMv3 format attributes James Clark
2025-11-14 14:55   ` Leo Yan
2025-11-18 14:56     ` James Clark
2025-11-12 15:22 ` [PATCH v4 05/13] coresight: Define format attributes with GEN_PMU_FORMAT_ATTR() James Clark
2025-11-14 15:03   ` Leo Yan
2025-11-12 15:22 ` [PATCH v4 06/13] coresight: Interpret ETMv3 config with ATTR_CFG_GET_FLD() James Clark
2025-11-14 15:07   ` Leo Yan
2025-11-12 15:22 ` [PATCH v4 07/13] coresight: Don't reject unrecognized ETMv3 format attributes James Clark
2025-11-14 15:18   ` Leo Yan
2025-11-14 15:21     ` James Clark
2025-11-12 15:22 ` [PATCH v4 08/13] coresight: Interpret perf config with ATTR_CFG_GET_FLD() James Clark
2025-11-14 15:30   ` Leo Yan
2025-11-14 15:34     ` James Clark
2025-11-14 15:41       ` Leo Yan
2025-11-12 15:22 ` [PATCH v4 09/13] coresight: Interpret ETMv4 " James Clark
2025-11-14 16:09   ` Leo Yan
2025-11-12 15:22 ` [PATCH v4 10/13] coresight: Remove misleading definitions James Clark
2025-11-14 16:23   ` Leo Yan
2025-11-12 15:22 ` [PATCH v4 11/13] coresight: Extend width of timestamp format attribute James Clark
2025-11-14 17:10   ` Leo Yan
2025-11-12 15:22 ` [PATCH v4 12/13] coresight: Allow setting the timestamp interval James Clark
2025-11-12 15:22 ` [PATCH v4 13/13] coresight: docs: Document etm4x timestamp interval option James Clark
2025-11-14  5:02   ` Randy Dunlap
2025-11-14  9:59     ` James Clark
2025-11-14 18:05   ` Leo Yan
2025-11-18 16:15     ` James Clark

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251112-james-cs-syncfreq-v4-2-165ba21401dc@linaro.org \
    --to=james.clark@linaro.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=corbet@lwn.net \
    --cc=coresight@lists.linaro.org \
    --cc=leo.yan@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mike.leach@linaro.org \
    --cc=suzuki.poulose@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).