linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Leo Yan <leo.yan@arm.com>
To: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	 Arnaldo Carvalho de Melo <acme@kernel.org>,
	 Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
	 Ian Rogers <irogers@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	 James Clark <james.clark@linaro.org>,
	Mark Rutland <mark.rutland@arm.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>,
	 linux-perf-users@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	 linux-kernel@vger.kernel.org, Leo Yan <leo.yan@arm.com>
Subject: [PATCH v3 17/25] perf arm_spe: Synthesize memory samples for SIMD operations
Date: Wed, 12 Nov 2025 18:24:43 +0000	[thread overview]
Message-ID: <20251112-perf_support_arm_spev1-3-v3-17-e63c9829f9d9@arm.com> (raw)
In-Reply-To: <20251112-perf_support_arm_spev1-3-v3-0-e63c9829f9d9@arm.com>

Synthesize memory samples for SIMD operations (including Advanced SIMD,
SVE, and SME). To provide complete information, also generate data
source entries for SIMD operations.

Since memory operations are not limited to load and store, set
PERF_MEM_OP_STORE if the operation does not fall into these cases.

Signed-off-by: Leo Yan <leo.yan@arm.com>
---
 tools/perf/util/arm-spe.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/tools/perf/util/arm-spe.c b/tools/perf/util/arm-spe.c
index 881257d3958705e725f1b7d47b41a93defd231ea..6a9c61d4aeeb2283a426d0a00ff7072eb5049c31 100644
--- a/tools/perf/util/arm-spe.c
+++ b/tools/perf/util/arm-spe.c
@@ -39,6 +39,11 @@
 
 #define is_ldst_op(op)		(!!((op) & ARM_SPE_OP_LDST))
 
+#define is_simd_op(op)		(!!((op) & (ARM_SPE_OP_SIMD_FP | ARM_SPE_OP_SVE | \
+					    ARM_SPE_OP_SME | ARM_SPE_OP_ASE)))
+
+#define is_mem_op(op)		(is_ldst_op(op) || is_simd_op(op))
+
 #define ARM_SPE_CACHE_EVENT(lvl) \
 	(ARM_SPE_##lvl##_ACCESS | ARM_SPE_##lvl##_MISS)
 
@@ -986,8 +991,7 @@ arm_spe__synth_data_source(struct arm_spe_queue *speq,
 {
 	union perf_mem_data_src	data_src = {};
 
-	/* Only synthesize data source for LDST operations */
-	if (!is_ldst_op(record->op))
+	if (!is_mem_op(record->op))
 		return data_src;
 
 	if (record->op & ARM_SPE_OP_LD)
@@ -995,7 +999,7 @@ arm_spe__synth_data_source(struct arm_spe_queue *speq,
 	else if (record->op & ARM_SPE_OP_ST)
 		data_src.mem_op = PERF_MEM_OP_STORE;
 	else
-		return data_src;
+		data_src.mem_op = PERF_MEM_OP_NA;
 
 	arm_spe__synth_ds(speq, record, &data_src);
 	arm_spe__synth_memory_level(speq, record, &data_src);
@@ -1096,11 +1100,7 @@ static int arm_spe_sample(struct arm_spe_queue *speq)
 			return err;
 	}
 
-	/*
-	 * When data_src is zero it means the record is not a memory operation,
-	 * skip to synthesize memory sample for this case.
-	 */
-	if (spe->sample_memory && is_ldst_op(record->op)) {
+	if (spe->sample_memory && is_mem_op(record->op)) {
 		err = arm_spe__synth_mem_sample(speq, spe->memory_id, data_src);
 		if (err)
 			return err;

-- 
2.34.1



  parent reply	other threads:[~2025-11-12 18:25 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-12 18:24 [PATCH v3 00/25] perf arm_spe: Extend operations Leo Yan
2025-11-12 18:24 ` [PATCH v3 01/25] perf arm_spe: Fix memset subclass in operation Leo Yan
2025-11-12 18:24 ` [PATCH v3 02/25] perf arm_spe: Unify operation naming Leo Yan
2025-11-12 18:24 ` [PATCH v3 03/25] perf arm_spe: Decode GCS operation Leo Yan
2025-11-12 18:24 ` [PATCH v3 04/25] perf arm_spe: Rename SPE_OP_PKT_IS_OTHER_SVE_OP macro Leo Yan
2025-11-12 18:24 ` [PATCH v3 05/25] perf arm_spe: Decode ASE and FP fields in other operation Leo Yan
2025-11-12 18:24 ` [PATCH v3 06/25] perf arm_spe: Decode SME data processing packet Leo Yan
2025-11-12 18:24 ` [PATCH v3 07/25] perf arm_spe: Remove unused operation types Leo Yan
2025-11-12 18:24 ` [PATCH v3 08/25] perf arm_spe: Consolidate " Leo Yan
2025-11-12 18:24 ` [PATCH v3 09/25] perf arm_spe: Introduce data processing macro for SVE operations Leo Yan
2025-11-12 18:24 ` [PATCH v3 10/25] perf arm_spe: Report register access in record Leo Yan
2025-11-12 18:24 ` [PATCH v3 11/25] perf arm_spe: Report MTE allocation tag " Leo Yan
2025-11-12 18:24 ` [PATCH v3 12/25] perf arm_spe: Report extended memory operations in records Leo Yan
2025-11-12 18:24 ` [PATCH v3 13/25] perf arm_spe: Report associated info for SVE / SME operations Leo Yan
2025-11-12 18:24 ` [PATCH v3 14/25] perf arm_spe: Report memset and memcpy in records Leo Yan
2025-11-12 18:24 ` [PATCH v3 15/25] perf arm_spe: Report GCS in record Leo Yan
2025-11-12 18:24 ` [PATCH v3 16/25] perf arm_spe: Expose SIMD information in other operations Leo Yan
2025-11-12 18:24 ` Leo Yan [this message]
2025-11-12 18:24 ` [PATCH v3 18/25] perf/uapi: Extend data source fields Leo Yan
2025-11-18 17:05   ` Leo Yan
2025-11-12 18:24 ` [PATCH v3 19/25] tools/include: Sync uapi/linux/perf.h with the kernel sources Leo Yan
2025-11-12 18:24 ` [PATCH v3 20/25] perf mem: Print extended fields Leo Yan
2025-11-12 18:24 ` [PATCH v3 21/25] perf arm_spe: Set extended fields in data source Leo Yan
2025-11-12 18:24 ` [PATCH v3 22/25] perf sort: Support sort ASE and SME Leo Yan
2025-11-12 18:24 ` [PATCH v3 23/25] perf sort: Sort disabled and full predicated flags Leo Yan
2025-11-12 18:24 ` [PATCH v3 24/25] perf report: Update document for SIMD flags Leo Yan
2025-11-12 18:24 ` [PATCH v3 25/25] perf arm_spe: Improve SIMD flags setting Leo Yan
2025-11-13 17:01 ` [PATCH v3 00/25] perf arm_spe: Extend operations Ian Rogers
2025-11-17  7:20   ` Namhyung Kim
2025-11-18 10:23     ` James Clark
2025-11-19 18:10       ` Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251112-perf_support_arm_spev1-3-v3-17-e63c9829f9d9@arm.com \
    --to=leo.yan@arm.com \
    --cc=acme@kernel.org \
    --cc=acme@redhat.com \
    --cc=adrian.hunter@intel.com \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).