Re: [PATCH v2 2/2] arm64: dts: freescale: add Toradex SMARC iMX95

[Francesco Dolcini <francesco@dolcini.it>]

On Tue, Nov 11, 2025 at 07:01:15PM +0100, Francesco Dolcini wrote:
> Hello Frank,
> 
> On Tue, Nov 11, 2025 at 11:02:56AM -0500, Frank Li wrote:
> > On Tue, Nov 11, 2025 at 04:16:14PM +0100, Francesco Dolcini wrote:
> > > From: Max Krummenacher <max.krummenacher@toradex.com>
> > >
> > > Add DT support for Toradex SMARC iMX95 SoM and Development carrier
> > > board.
> > >
> > > The module consists of an NXP i.MX95 family SoC, up to 16GB of LPDDR5
> > > RAM and up to 128GB of storage, a USB 3.0 Host Hub and 2.0 OTG, two
> > > Gigabit Ethernet PHYs, a 10 Gigabit Ethernet interface, an I2C EEPROM
> > > and Temperature Sensor, an RX8130 RTC, a Quad/Dual lane CSI interface,
> > > and some optional addons: TPM 2.0, DSI, LVDS, DisplayPort (through a
> > > DSI-DP bridge), and Wi-Fi/BT module.
> > >
> > > Link: https://www.toradex.com/computer-on-modules/smarc-arm-family/nxp-imx95
> > > Link: https://www.toradex.com/products/carrier-board/smarc-development-board-kit
> > > Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
> > > Co-developed-by: Ernest Van Hoecke <ernest.vanhoecke@toradex.com>
> > > Signed-off-by: Ernest Van Hoecke <ernest.vanhoecke@toradex.com>
> > > Co-developed-by: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
> > > Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
> > > Co-developed-by: João Paulo Gonçalves <joao.goncalves@toradex.com>
> > > Signed-off-by: João Paulo Gonçalves <joao.goncalves@toradex.com>
> > > Co-developed-by: Vitor Soares <vitor.soares@toradex.com>
> > > Signed-off-by: Vitor Soares <vitor.soares@toradex.com>
> > > Co-developed-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> > > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> > > ---
> > > v2:
> > >  - move enable-active-high after gpio
> > >  - add newline between properties and child node in som_dsi2dp_bridge
> > > ---
> > >  arch/arm64/boot/dts/freescale/Makefile        |    1 +
> > >  .../dts/freescale/imx95-toradex-smarc-dev.dts |  277 ++++
> > >  .../dts/freescale/imx95-toradex-smarc.dtsi    | 1155 +++++++++++++++++
> > >  3 files changed, 1433 insertions(+)
> > >  create mode 100644 arch/arm64/boot/dts/freescale/imx95-toradex-smarc-dev.dts
> > >  create mode 100644 arch/arm64/boot/dts/freescale/imx95-toradex-smarc.dtsi
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
> > > index 75676b908299..28f8eaf18471 100644
> > > --- a/arch/arm64/boot/dts/freescale/Makefile
> > > +++ b/arch/arm64/boot/dts/freescale/Makefile
> > > @@ -390,6 +390,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx943-evk.dtb
> > >  dtb-$(CONFIG_ARCH_MXC) += imx95-15x15-evk.dtb
> > >  dtb-$(CONFIG_ARCH_MXC) += imx95-19x19-evk.dtb
> > >  dtb-$(CONFIG_ARCH_MXC) += imx95-19x19-evk-sof.dtb
> > > +dtb-$(CONFIG_ARCH_MXC) += imx95-toradex-smarc-dev.dtb
> > >  dtb-$(CONFIG_ARCH_MXC) += imx95-tqma9596sa-mb-smarc-2.dtb
> > >
> > ...
> > > +
> > > +/* SMARC PCIE_A / M2 Key B */
> > > +&pcie0 {
> > > +	status = "okay";
> > 
> > Nit: if there are next version, please consider add supports-clkreq.
> 
> What do you expect exactly?
> Maybe what you are looking for is in imx95-toradex-smarc.dtsi?

Found it, you are referring to https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/pci/pci-bus-common.yaml#L155

We would not be able to test it, the required changes in the PCIe driver
are not merged yet, so I would prefer to skip it for this series for the
moment.

Francesco