Re: [GIT PULL] libcrypto/arm64: Move kernel mode FP/SIMD buffer to the stack

[Eric Biggers <ebiggers@kernel.org>]

On Wed, Nov 12, 2025 at 10:32:13AM +0100, Ard Biesheuvel wrote:
> From: Ard Biesheuvel <ardb@kernel.org>
> 
> Hi Eric,
> 
> (cc Catalin)
> 
> I have prepared a branch for libcrypto-next containing all the arm64 FP/SIMD
> changes that are needed to move the kernel mode FP/SIMD buffers to the stack.
> 
> I have created two stable tags [a] and [b] in my tree at [0], containing the
> changes as sent to and reviewed on the list, reordered to accommodate the task
> of merging this into libcrypto-next in a bisectable manner.
> 
>   [a] scoped-ksimd-for-arm-arm64
>   [b] arm64-fpsimd-on-stack-for-v6.19
>   
> On top of [a], two additional lib/crypto patches have been applied to update
> code that has already been queued up in libcrypto-next, moving it to the new
> scoped ksimd API as well. This is better than hiding the changes in a merge
> commit. The merge still resulted in a conflict on the old versions of the files
> that were moved, but this is resolved by simply deleting them.
> 
> Please pull. Or alternatively, if you prefer, recreate the following sequence
> directly on top of libcrypto-next (and resolve the conflict)
> 
>       Merge tag 'ardb/scoped-ksimd-for-arm-arm64'
>       lib/crypto: arm/blake2b: Move to scoped ksimd API
>       lib/crypto: arm64: Move remaining algorithms to scoped ksimd API
>       Merge tag 'arm64-fpsimd-on-stack-for-v6.19' into arm64-fpsimd-on-stack-for-libcrypto
> 
> The following changes since commit f101371e1972df3d897bf2326eda3c28aca2e58c:
> 
>   Merge remote-tracking branch 'ebiggers/libcrypto-aes-gcm' into libcrypto-next (2025-11-11 11:08:57 -0800)
> 
> are available in the Git repository at:
> 
>   [0] git://git.kernel.org/pub/scm/linux/kernel/git/ardb/linux.git arm64-fpsimd-on-stack-for-libcrypto
> 
> for you to fetch changes up to 82ef0a6ac77cc0eaca1b5c2fc3436b18cda6ef83:
> 
>   Merge tag 'arm64-fpsimd-on-stack-for-v6.19' into arm64-fpsimd-on-stack-for-libcrypto (2025-11-12 10:08:20 +0100)

I pulled these into a libcrypto-fpsimd-on-stack branch based on
2dbb6f4a25d38fcf (which is currently the last commit that I'm planning
for the "main" libcrypto pull request).

Then I updated the head of libcrypto-next to be the merge of
libcrypto-tests, libcrypto-aes-gcm, and libcrypto-fpsimd-on-stack.  I'll
send these as separate pull requests after the main libcrypto one.

In theory this should all work out.

Note: I changed "lib/crypto: arm64: Move remaining algorithms to scoped
ksimd API" to remove <asm/neon.h> from lib/crypto/arm64/polyval.h for
consistency with the other files, and to add braces around the for loop.

Thanks!

- Eric