From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 92D62CD3445 for ; Thu, 13 Nov 2025 02:00:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rqhIp8w5isaxKxCD91/n/EagEFsrq/hgVFb7fB0vmi8=; b=qfCLizqWEBf1EbHX6UsjbwYBY7 iBEnVTgbn2LZDGBTz2p5f19LArCMJY7LTBiQY072Ry9jlw/3cSV5hD6L9xrvu037ahxUOdURLREqo 57cIKasHPgVS/a4WrNRH6SnL7jL/tkaTQRmOg9iE5c1EccFF3+XsWbB1HrLUmphbdMuI+8ptTo5xo RMafbfrYaXYwrzZ30LwNODNWVDxK45hCKePQ4PWMh9XKOJPtcgcke234A9d2X7mY6bTgHtOg8SI1g mGuMKvL7g8HVKeAeEfogae4X8V2toHOQYS+e/OyEO78kNOKPBD/thcXZasI8uv9eUn8O3uR/ce34K 73cnyaBA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vJMde-00000009mJW-3bdx; Thu, 13 Nov 2025 02:00:42 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vJMdc-00000009mJ6-11ZV for linux-arm-kernel@lists.infradead.org; Thu, 13 Nov 2025 02:00:41 +0000 Received: from pendragon.ideasonboard.com (unknown [213.216.211.176]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 8B042BD2; Thu, 13 Nov 2025 02:58:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1762999118; bh=m/JsSUuuwvDOeT9RQcGvgVZikLHJyfgvCRC/Km24WVM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Yrx0QE6l81GKJpO7fUpDjtqnA5GrvpgVcKw12mkvhSUeNKwzoA5dm+f8PQQU/pHwQ pOTPOexPfTcmFKdY2Uv+IlpJCWsNnxJaxnQL0L+hG679KyV9uQqt3ii6BXKlD9jxR6 eH9ydbOSbO4wdbNojVfBEQeCE5fR4cuG+zJarzCY= Date: Thu, 13 Nov 2025 04:00:27 +0200 From: Laurent Pinchart To: Frank Li Cc: Guoniu Zhou , Rui Miguel Silva , Martin Kepplinger , Purism Kernel Team , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Philipp Zabel , linux-media@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Guoniu Zhou , Conor Dooley Subject: Re: [PATCH v7 1/5] media: dt-bindings: nxp,imx8mq-mipi-csi2: Add i.MX8ULP compatible string Message-ID: <20251113020027.GE9135@pendragon.ideasonboard.com> References: <20251023-csi2_imx8ulp-v7-0-5ecb081ce79b@nxp.com> <20251023-csi2_imx8ulp-v7-1-5ecb081ce79b@nxp.com> <20251027000537.GM13023@pendragon.ideasonboard.com> <20251111211025.GA26805@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251112_180040_431641_6B87DAA2 X-CRM114-Status: GOOD ( 34.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 11, 2025 at 05:06:02PM -0500, Frank Li wrote: > On Tue, Nov 11, 2025 at 11:10:25PM +0200, Laurent Pinchart wrote: > > On Tue, Nov 11, 2025 at 03:47:51PM -0500, Frank Li wrote: > > > On Mon, Oct 27, 2025 at 02:05:37AM +0200, Laurent Pinchart wrote: > > > > On Thu, Oct 23, 2025 at 05:19:42PM +0800, Guoniu Zhou wrote: > > > > > From: Guoniu Zhou > > > > > > > > > > The CSI-2 receiver in the i.MX8ULP is almost identical to the version > > > > > present in the i.MX8QXP/QM, but i.MX8ULP CSI-2 controller needs pclk > > > > > clock as the input clock for its APB interface of Control and Status > > > > > register(CSR). So add compatible string fsl,imx8ulp-mipi-csi2 and > > > > > increase maxItems of Clocks (clock-names) to 4 from 3. And keep the > > > > > same restriction for existing compatible. > > > > > > > > > > Reviewed-by: Frank Li > > > > > Acked-by: Conor Dooley > > > > > Signed-off-by: Guoniu Zhou > > > > > --- > > > > > .../bindings/media/nxp,imx8mq-mipi-csi2.yaml | 41 ++++++++++++++++++++-- > > > > > 1 file changed, 39 insertions(+), 2 deletions(-) > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/media/nxp,imx8mq-mipi-csi2.yaml b/Documentation/devicetree/bindings/media/nxp,imx8mq-mipi-csi2.yaml > > > > > index 3389bab266a9adbda313c8ad795b998641df12f3..da3978da1cab75292ada3f24837443f7f4ab6418 100644 > > > > > --- a/Documentation/devicetree/bindings/media/nxp,imx8mq-mipi-csi2.yaml > > > > > +++ b/Documentation/devicetree/bindings/media/nxp,imx8mq-mipi-csi2.yaml > > > > > @@ -20,6 +20,7 @@ properties: > > > > > - enum: > > > > > - fsl,imx8mq-mipi-csi2 > > > > > - fsl,imx8qxp-mipi-csi2 > > > > > + - fsl,imx8ulp-mipi-csi2 > > > > > - items: > > > > > - const: fsl,imx8qm-mipi-csi2 > > > > > - const: fsl,imx8qxp-mipi-csi2 > > > > > @@ -39,12 +40,16 @@ properties: > > > > > clock that the RX DPHY receives. > > > > > - description: ui is the pixel clock (phy_ref up to 333Mhz). > > > > > See the reference manual for details. > > > > > + - description: pclk is clock for csr APB interface. > > > > > + minItems: 3 > > > > > > > > > > clock-names: > > > > > items: > > > > > - const: core > > > > > - const: esc > > > > > - const: ui > > > > > + - const: pclk > > > > > + minItems: 3 > > > > > > > > > > power-domains: > > > > > maxItems: 1 > > > > > @@ -130,19 +135,51 @@ allOf: > > > > > compatible: > > > > > contains: > > > > > enum: > > > > > - - fsl,imx8qxp-mipi-csi2 > > > > > + - fsl,imx8ulp-mipi-csi2 > > > > > + then: > > > > > + properties: > > > > > + reg: > > > > > + minItems: 2 > > > > > + resets: > > > > > + minItems: 2 > > > > > + maxItems: 2 > > > > > + clocks: > > > > > + minItems: 4 > > > > > + clock-names: > > > > > + minItems: 4 > > > > > > > > Do we need the clock-names constraint ? The DT schemas will enforce that > > > > clocks and clock-names always have the same number of elements. > > > > > > clock-names list already restrict at top section > > > > > > clock-names: > > > items: > > > - const: core > > > - const: esc > > > - const: ui > > > - const: pclk > > > minItems: 3 > > > > > > Here just restrict need 4 clocks, instead 3 clock for fsl,imx8ulp-mipi-csi2 > > > > I understand that. My point was that the dt-schema will always verify > > that the number of clocks items is equal to the number of clock-names > > items. That's a constraint enforced by the core schemas. As > > clocks: minItems is set to 4, the clock-names: minItems constraint is > > redundant. > > I am not sure when have such features. Previous comments from Rob require > clocks and clock-names keep the same at binding yaml. > > https://lore.kernel.org/linux-devicetree/20251031000012.GA466250-robh@kernel.org/ > > Rob have not said that clock-names can be removed. > > Do you have any thread, which inidicate we only need limit clocks at > if-else branch? > > I also have not found related commit at > https://github.com/devicetree-org/dt-schema.git I think you're right. There are dependencies between clock-names and clocks described in the DT schemas, but I don't see any automatic dependency regarding the number of items. I seem to have dreamt this :-/ Sorry about the noise. > > > > > + > > > > > + - if: > > > > > + properties: > > > > > + compatible: > > > > > + contains: > > > > > + const: fsl,imx8qxp-mipi-csi2 > > > > > then: > > > > > properties: > > > > > reg: > > > > > minItems: 2 > > > > > resets: > > > > > maxItems: 1 > > > > > - else: > > > > > + clocks: > > > > > + maxItems: 3 > > > > > + clock-names: > > > > > + maxItems: 3 > > > > > + > > > > > + - if: > > > > > + properties: > > > > > + compatible: > > > > > + contains: > > > > > + enum: > > > > > + - fsl,imx8mq-mipi-csi2 > > > > > + then: > > > > > properties: > > > > > reg: > > > > > maxItems: 1 > > > > > resets: > > > > > minItems: 3 > > > > > + clocks: > > > > > + maxItems: 3 > > > > > + clock-names: > > > > > + maxItems: 3 > > > > > required: > > > > > - fsl,mipi-phy-gpr > > > > > > > > > > > > > Could you please sort those conditional blocks by alphabetical order of > > > > the compatible strings ? -- Regards, Laurent Pinchart