From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0EC74CCFA18 for ; Thu, 13 Nov 2025 06:13:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:CC:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9JsRaS9ANua2/x9DO+pOgLBjhs5V4OwBAa5L+RuN4Os=; b=zns75OEI0Is17RgmZuYd0kTAe6 EXx+8vxUmnZG26hf6NySPwRIgKih46fWwFx272WMVMuyJp8+9FmB6NEVB1zlmIpy14cIaxmYJGWom gfmYsu8oUAHQrLo66WCupt9MYndAwYou9NGL2HvLRT+/hw+HCwg8bTFITAYwDjAPDAouzjfxghAYj aAMDIcAHZi9MnZlhPQyiZQguxPmTm+KVl8Wnj4CB5iOBM7ZrM4vD9Yc6U6EdDfTKGcm4qMCK8cUay uns5DO2iOu8x1f6AjBM+4ysH86pi16oUkCbnLNSyxzVj+Ut37nSIuaE4o4VwuZuXk0USpgIEJljCW Yzt/I02g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vJQaY-00000009wkO-0t4h; Thu, 13 Nov 2025 06:13:46 +0000 Received: from mail-westus2azlp170120002.outbound.protection.outlook.com ([2a01:111:f403:c007::2] helo=MW6PR02CU001.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vJQaV-00000009wjp-266F for linux-arm-kernel@lists.infradead.org; Thu, 13 Nov 2025 06:13:44 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VVhvtK1iGF2f3ijmJkWL2Nz2jSp4BXXnoWYLcp4MlNaTTf9AJuFwkegJKEBV1vdJY41ZjW45/wHynGpcGDvk5y/UM2YQQfBsN3JpCFKXH15UctLzKPsDCG/wkId/3dYtCRvbAciE00St1599IhSNrIk6oygVdXNOG9fqOaL2b4Ol2iNv+0EwsYylHhtdyb0OWx12SPrSqhTrVO9WSNyDrGzkFWjl66eS0v2AAef80fHEITxlW7z6JR9ZFWxkik6D/J/unJMPrd28qODDyeW/QEoRaaglr44bmJqmhk3C72TyAlKMBnwXhmTmFjejsr0Y4pyIWnLvA1XUn31ArZKsQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9JsRaS9ANua2/x9DO+pOgLBjhs5V4OwBAa5L+RuN4Os=; b=eXAPXJt27wqeBLGWlqmj6cagqjWjeN8C0pPJB0uWD3U1KqMPIulteO1vnOxI9+b4qdM8np0Cf6Fi2/6l6B3+f3LJKVEDCVkGb+HY6wnIGJ+jPgNRPYOqmVhm4ZIL6JV5jzPy7ygHpuA4TDYPGsAtkBBiCEdJENEfZqwT+yCliJ4KKZ/XZyOf7mW4xshP3cYDGeM60reqET/UaVeALGiCNX2gkcoJBewzAkexDrS5atLuzrfbSsV/OsVLIuXE3T2b8SYfa71Iy7r8tsoxbFjWc5aXJ3JVlJEB8bze6xM1U/JpCTcKcQodXsaJMniDLxs2ncrijQ/vHekw3/T7Jqc6sQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.23.194) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9JsRaS9ANua2/x9DO+pOgLBjhs5V4OwBAa5L+RuN4Os=; b=AchGzgI/imnvgZX07qWBCDdygq0nQu/qLWPxyZsgtVG7mh87SaJqOp2I0Nzr99WcLGjPXFN5uttJloGbeFVAsb2GicUhPeSPYsWj6x2NDNXqfDpQy5toMSO7GlwZ4KBU1TE8ga0TakqBYWcU8HGH1OUwgkF0OUz2XlH9w+XNMLU= Received: from SN7PR18CA0022.namprd18.prod.outlook.com (2603:10b6:806:f3::21) by CY8PR10MB6586.namprd10.prod.outlook.com (2603:10b6:930:59::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9320.15; Thu, 13 Nov 2025 06:13:39 +0000 Received: from SA2PEPF00001507.namprd04.prod.outlook.com (2603:10b6:806:f3:cafe::fd) by SN7PR18CA0022.outlook.office365.com (2603:10b6:806:f3::21) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9320.16 via Frontend Transport; Thu, 13 Nov 2025 06:13:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.23.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.23.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.23.194; helo=lewvzet200.ext.ti.com; pr=C Received: from lewvzet200.ext.ti.com (198.47.23.194) by SA2PEPF00001507.mail.protection.outlook.com (10.167.242.39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9320.13 via Frontend Transport; Thu, 13 Nov 2025 06:13:38 +0000 Received: from DLEE204.ent.ti.com (157.170.170.84) by lewvzet200.ext.ti.com (10.4.14.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 13 Nov 2025 00:13:36 -0600 Received: from DLEE209.ent.ti.com (157.170.170.98) by DLEE204.ent.ti.com (157.170.170.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 13 Nov 2025 00:13:36 -0600 Received: from lelvem-mr06.itg.ti.com (10.180.75.8) by DLEE209.ent.ti.com (157.170.170.98) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend Transport; Thu, 13 Nov 2025 00:13:36 -0600 Received: from localhost (lcpd911.dhcp.ti.com [172.24.233.130]) by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 5AD6DZa73985030; Thu, 13 Nov 2025 00:13:35 -0600 Date: Thu, 13 Nov 2025 11:43:34 +0530 From: Dhruva Gole To: "Markus Schneider-Pargmann (TI.com)" CC: Nishanth Menon , Tero Kristo , "Santosh Shilimkar" , Vishal Mahaveer , "Kevin Hilman" , Sebin Francis , "Kendall Willis" , Akashdeep Kaur , , Subject: Re: [PATCH v10 1/3] firmware: ti_sci: Support transfers without response Message-ID: <20251113061334.wqluum2u4joye64z@lcpd911> References: <20251103-topic-am62-partialio-v6-12-b4-v10-0-0557e858d747@baylibre.com> <20251103-topic-am62-partialio-v6-12-b4-v10-1-0557e858d747@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20251103-topic-am62-partialio-v6-12-b4-v10-1-0557e858d747@baylibre.com> X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF00001507:EE_|CY8PR10MB6586:EE_ X-MS-Office365-Filtering-Correlation-Id: 0c273e8a-ccc3-4fce-29d0-08de227bc961 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|376014|1800799024|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?bg8GX78gJA9RcL45D0+BYfdO79K5m6/cSatLBd0qT+7USzXIZC4UHKqQj1hb?= =?us-ascii?Q?VrpQbrwTsjwY2EFZxcKArQKycS9Q2eJhGzDJLy9hrR7ZIVtTxJ9uJX+LAArQ?= =?us-ascii?Q?Vmw3tO3RvLKod2r1OaCxAQNN/1dYnZDo8Lt5lesXNb+LKu5kmHIs9MJBicAa?= =?us-ascii?Q?RVsRjNnnV8OgQ5z4uvIWG8Pfijvj9AxnjVULO3757Tu9/GFlCZYYkR81+KnS?= =?us-ascii?Q?Cg35OMxUT7Sd4pmRNVuokkH3kg0+5yqgQMTbh8tQwACKmUL6H3/ZZ/StZ1QE?= =?us-ascii?Q?f8YTIFriOLBRrk+Trhk7dIUvdTChXnTdXcyb3G5TjJELqFp0ttUmY1nAwAYT?= =?us-ascii?Q?bYUMU8/whjyXBhqu4E70nYcryAbiz5oXiAxklIqmu00uSwY4FnxnAmW5G6g7?= =?us-ascii?Q?VpJix0jgaHyJc9VR7+ZeJYOuu6Rd+b9zCS+xACBwmtz3h8BzuFx3gZ83U7TH?= =?us-ascii?Q?sj5Zmk/QBJlhFXT/lkNp1+AgGml4Eg/4QRHZ6x5rcyWTYDF+NvyosErobZzI?= =?us-ascii?Q?Q5+Yj2S3R0HjnN4z5J/y3TKjWperAiKG7T/uFPTL83bFImncSG0I7qfaQvDa?= =?us-ascii?Q?tjN2FZ62PVQtAxyr4Z1P1f5XLw+BJiDJ3+jJ/MUo1FuUTo5tdV8GOULUWsDR?= =?us-ascii?Q?1P7YxEdlr23JYrSOf2yWzWK9RgFFHkLxuP/mrqH3IfdCZbZM7yiOxs0zTlLo?= =?us-ascii?Q?8j4EJO3/4vVM4AVon8SA2+Bsv6RjVjpuXp6GeeDLJXiYNUBA6/y3lVaMQygm?= =?us-ascii?Q?zSHgm3SkohYIIm0rsH10IIWqOeboD12Ue/dKw71di7PUWB4nZeHedDiRyasc?= =?us-ascii?Q?Q1npAscGXCcsXsgXSX9SJ+0FwqdHRBoitlp+1IiHyNoVyu1OH/OG/oj1PEAT?= =?us-ascii?Q?dm0SR8715cP99/yBWcRowFbY1NmaMIkqPNbJE4A/5BuJdVmUTM6CEgDquKPD?= =?us-ascii?Q?LxQ+SlZ79TxMrKM064uFmSPkcaFF2WDa1ULgQghI9g61yDmRay4dXZYjJaR9?= =?us-ascii?Q?dQ70xVGUi9OZKE+oNrpwikoADjcu3aC9aW7BnS/HyLljFFJu7GlG69inEM4r?= =?us-ascii?Q?VnefLYFp5kuCr0D4FIDDgIbFrriuTNgrVhbd51n6jIl5lfJissHyMP10n9bv?= =?us-ascii?Q?DkWgtQraWSZ0j7tZNZHReisJNfW9s9v4AKSDdbRVrDYqt1Bk4LH39nTNHueb?= =?us-ascii?Q?5ZjUb2vqx0glTw6CRUt9BLXoMAEsSlp48sqQZopXSsUsmCRUb+82IjgXDgUX?= =?us-ascii?Q?wLtwaYlsmU5VW22FazG1rh7oASpuOdYFuCD8bfSY37ij5Ie0HCRNbTzZL+y9?= =?us-ascii?Q?3+fvzC/zgG2oLOm1uvNV+k814jQAkDD4Q7afCQ2Q3JlS46hYtPQyptplAEza?= =?us-ascii?Q?M1yJuqZCMT5f8S6bvKVwlPthTpiLjppoxHC1qlILS50NKPCEjCrZlEbcQBF6?= =?us-ascii?Q?0ucQhU8TPULScezvmemYk1sajfyN09yISbbpIp1pdFym3En0PNbUcTq6q479?= =?us-ascii?Q?3Q2JKW4TqjzPq8WaQtSey8V0syZnWJjfjOG6GcUdYzblr3tAwW4diZbkEo+3?= =?us-ascii?Q?Zzh1xavfaElG4WfcYYM=3D?= X-Forefront-Antispam-Report: CIP:198.47.23.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:lewvzet200.ext.ti.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(376014)(1800799024)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Nov 2025 06:13:38.7339 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0c273e8a-ccc3-4fce-29d0-08de227bc961 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.23.194];Helo=[lewvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF00001507.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR10MB6586 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251112_221343_563450_D248FA6B X-CRM114-Status: GOOD ( 18.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Nov 03, 2025 at 13:42:19 +0100, Markus Schneider-Pargmann (TI.com) wrote: > Check the header flags if an response is expected or not. If it is not > expected skip the receive part of ti_sci_do_xfer(). This prepares the > driver for one-way messages as prepare_sleep for Partial-IO. > > Reviewed-by: Kendall Willis > Signed-off-by: Markus Schneider-Pargmann (TI.com) > --- > drivers/firmware/ti_sci.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c > index 49fd2ae01055d0f425062147422471f0fd49e4bd..2585cb82d1ad8e3d79bca458a2b86cc81a3e627b 100644 > --- a/drivers/firmware/ti_sci.c > +++ b/drivers/firmware/ti_sci.c > @@ -398,6 +398,9 @@ static void ti_sci_put_one_xfer(struct ti_sci_xfers_info *minfo, > static inline int ti_sci_do_xfer(struct ti_sci_info *info, > struct ti_sci_xfer *xfer) > { > + struct ti_sci_msg_hdr *hdr = (struct ti_sci_msg_hdr *)xfer->tx_message.buf; > + bool response_expected = !!(hdr->flags & (TI_SCI_FLAG_REQ_ACK_ON_PROCESSED | > + TI_SCI_FLAG_REQ_ACK_ON_RECEIVED)); > int ret; > int timeout; > struct device *dev = info->dev; > @@ -409,12 +412,12 @@ static inline int ti_sci_do_xfer(struct ti_sci_info *info, > > ret = 0; > > - if (system_state <= SYSTEM_RUNNING) { > + if (response_expected && system_state <= SYSTEM_RUNNING) { > /* And we wait for the response. */ > timeout = msecs_to_jiffies(info->desc->max_rx_timeout_ms); > if (!wait_for_completion_timeout(&xfer->done, timeout)) > ret = -ETIMEDOUT; > - } else { > + } else if (response_expected) { Makes sense to me for one sided communication messages like partial IO which is essentially a power off. Reviewed-by: Dhruva Gole -- Best regards, Dhruva Gole Texas Instruments Incorporated