From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2AA26CD6E78 for ; Thu, 13 Nov 2025 15:16:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=B5PyRXg5WMJnRMO6R3xM4L6tyt6gTVG7sGYymD8rtqM=; b=uCZPkGAordY/j1DuTcg7lq/Bqk h46BCbVhcwGMk6Ys5Kdx1XLroetHDJPiYXVscCCnauXFA7DwI62xqKv1RXF+mZlVKy60ScnbVbWPv tyoJr7mzhIjMViUDWItO8TfNuWG33ZFxPgyL6rkQaUMNMHNUPoZZWME/4v2utpGAcI41mnOb5ojy2 BenE78NkIxFbZ6crkdmXIoPaT6lkRJP+qxWnUuRThgFg2jzLwlF7LvuHfbx7PmEE5Y4Q2MdjtXmaV xfoLVScFOj4RvmkM2HvneP7eVL2VZVqkN3Wg+9emRY1WDbkRG8HlkqPxdTrgYCaUTRYvXD7zvn4bP vOp/klzA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vJZ3h-0000000AgvM-0tOP; Thu, 13 Nov 2025 15:16:25 +0000 Received: from mgamail.intel.com ([192.198.163.11]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vJZ3Z-0000000Agj7-3yZ6; Thu, 13 Nov 2025 15:16:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1763046978; x=1794582978; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=akryAXafWhZQlfplABSdwgarfhhYIf26xngrUAauxhA=; b=gCabsBXnbfaiMJinGaKNL/84RcVt6yC5KPMhimxPF3WdlXGVd8Kd3xPi eJfVueTaYa7SUmBWft3eBQgymMHT1vrsOxd4TBGfQ7TRF00cjo4LYwbA2 DjNPRYmuZq0MEz+zn6Jsfp6lKsgyA0ptJA8OTozUN/frNw45CF82VVw4T ILpBz/1YB0BmyNm+QNsmt29TWRrrfNRK+4clAiD/oInn2Qi8JrVEqaYa7 ANB+s1OPK9i32T/MP3jnXyImMzH89pXcJS+2Z5BQPZiqZwe2Psx7q8Xbo BvvExW3/I3atvzsFVadesTWuhWBSpXZXo5CAcE93Q3cZesRr2DW+A658q g==; X-CSE-ConnectionGUID: gfkedTWpSIGcAkpIUD5h0A== X-CSE-MsgGUID: gQa+3f7vTYWlm8I8cP6tEQ== X-IronPort-AV: E=McAfee;i="6800,10657,11612"; a="75740544" X-IronPort-AV: E=Sophos;i="6.19,302,1754982000"; d="scan'208";a="75740544" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Nov 2025 07:16:17 -0800 X-CSE-ConnectionGUID: ciipLS86TrWoIsMCLMxgLw== X-CSE-MsgGUID: snFg2F5dRgKe8HTqX1Oxmg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.19,302,1754982000"; d="scan'208";a="189792123" Received: from black.igk.intel.com ([10.91.253.5]) by fmviesa008.fm.intel.com with ESMTP; 13 Nov 2025 07:16:12 -0800 Received: by black.igk.intel.com (Postfix, from userid 1003) id DE6D5A0; Thu, 13 Nov 2025 16:16:04 +0100 (CET) From: Andy Shevchenko To: Andy Shevchenko , Bjorn Andersson , Stefan Wahren , Vinod Koul , Thomas Andreatta , Caleb Sander Mateos , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Cc: Olivier Dautricourt , Stefan Roese , Florian Fainelli , Broadcom internal kernel review list , Ray Jui , Scott Branden , Lars-Peter Clausen , Eugeniy Paltsev , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Lizhi Hou , Brian Xu , Raj Kumar Rampelli , Michal Simek , Andrew Morton Subject: [PATCH v3 10/13] dmaengine: qcom: bam_dma: use sg_nents_for_dma() helper Date: Thu, 13 Nov 2025 16:13:06 +0100 Message-ID: <20251113151603.3031717-11-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251113151603.3031717-1-andriy.shevchenko@linux.intel.com> References: <20251113151603.3031717-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251113_071618_011515_08D78704 X-CRM114-Status: GOOD ( 10.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Instead of open coded variant let's use recently introduced helper. Reviewed-by: Bjorn Andersson Signed-off-by: Andy Shevchenko --- drivers/dma/qcom/bam_dma.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/dma/qcom/bam_dma.c b/drivers/dma/qcom/bam_dma.c index 2cf060174795..62b3921f0d11 100644 --- a/drivers/dma/qcom/bam_dma.c +++ b/drivers/dma/qcom/bam_dma.c @@ -655,22 +655,17 @@ static struct dma_async_tx_descriptor *bam_prep_slave_sg(struct dma_chan *chan, struct scatterlist *sg; u32 i; struct bam_desc_hw *desc; - unsigned int num_alloc = 0; - + unsigned int num_alloc; if (!is_slave_direction(direction)) { dev_err(bdev->dev, "invalid dma direction\n"); return NULL; } - /* calculate number of required entries */ - for_each_sg(sgl, sg, sg_len, i) - num_alloc += DIV_ROUND_UP(sg_dma_len(sg), BAM_FIFO_SIZE); - /* allocate enough room to accommodate the number of entries */ + num_alloc = sg_nents_for_dma(sgl, sg_len, BAM_FIFO_SIZE); async_desc = kzalloc(struct_size(async_desc, desc, num_alloc), GFP_NOWAIT); - if (!async_desc) return NULL; -- 2.50.1