From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2944CCD98D1 for ; Fri, 14 Nov 2025 01:25:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ahNR9fd2YMJk4CwYCWhBIEhgapoFugSz6eevmfUYQlE=; b=QgesIn8UMHAmObTKZb9OkQvqzJ oqv9KQ3IcxnfPoqqj1CslXZ6pFY3N8JoIQ3f0+zVRmFu8T8U1uEfwJyscbrK8bACH4L+S3dEmVPVf 4DrofZWUMPJLjMIEq6Bn+Qerw4eWMxTw/Ky1Th2pAnehSGt6rmn2ek2tbCz+naQX4IDLz0yStFdDB l6Bb/EeXfeQbtMpKAoePL6rGpbqN07AvhfLstId+BDIRDY20YRiPb2q1iNr8c+0ncdNrV7vdLURgc kxKHWvCWqjMdeiaz2lA1PrNLzkngaF6u21iUW2qXQs53Ku91BsusZqUayEfXOmKJbXm4bl+ko0+0Z AA75enfw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vJiZM-0000000BNcF-2Lfe; Fri, 14 Nov 2025 01:25:44 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vJiZJ-0000000BNbo-31ZO for linux-arm-kernel@lists.infradead.org; Fri, 14 Nov 2025 01:25:42 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 94F06441E8; Fri, 14 Nov 2025 01:25:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 67573C2BCB0; Fri, 14 Nov 2025 01:25:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763083540; bh=jUpqsgzm9mQmlDwIMnmXwws2iJVd0X9NrGflGeH7Iqg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Z09gLaMZlZrJHbraZakAvPZQ2kqgik/E3cfI2zd2AjI6xpvGjYqFZURz2b+UzBcTc 8SwRLAul1ddhZmoa7yCwX9IFyPmrEIhWuLBuE4sFEpMh/Xj2ayDrZBOlDWhT8JFLCn K8AAzeBFl1lClijNSqUnLKDYyGpjtc9SHPUCKg3gZQchcPRcFs1kpedjTT0p80gN33 nBZ3PHgGXXwZFMdtT0BOjlUvnj/c7xeVt5LlNIMMGA7Rv/7IaPLQFA1I2DV7S1aZEx +YQAP3xbmuM/xOibvOJvy24sED0Q4VX4dZwkiNH1jFlFvXA+HctaCLc3x8eQyQz83/ u7OWf0KRaOl4w== Date: Fri, 14 Nov 2025 01:25:32 +0000 From: Conor Dooley To: Inochi Amaoto Cc: Conor Dooley , Han Gao , Icenowy Zheng , Vivian Wang , Yao Zi , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Chen Wang , Maxime Coquelin , Alexandre Torgue , Heiner Kallweit , Russell King , "Russell King (Oracle)" , netdev@vger.kernel.org, devicetree@vger.kernel.org, sophgo@lists.linux.dev, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Yixun Lan , Longbin Li , Conor Dooley Subject: Re: [PATCH v8 1/3] dt-bindings: net: sophgo,sg2044-dwmac: add phy mode restriction Message-ID: <20251114-apache-sprung-f1a29b873696@spud> References: <20251114003805.494387-1-inochiama@gmail.com> <20251114003805.494387-2-inochiama@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="NIRjo9fMfQbx0LeW" Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251113_172541_803688_DC1AF834 X-CRM114-Status: GOOD ( 22.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --NIRjo9fMfQbx0LeW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 14, 2025 at 08:44:15AM +0800, Inochi Amaoto wrote: > On Fri, Nov 14, 2025 at 08:38:03AM +0800, Inochi Amaoto wrote: > > As the ethernet controller of SG2044 and SG2042 only supports > > RGMII phy. Add phy-mode property to restrict the value. > >=20 > > Also, since SG2042 has internal rx delay in its mac, make > > only "rgmii-txid" and "rgmii-id" valid for phy-mode. > >=20 > > Fixes: e281c48a7336 ("dt-bindings: net: sophgo,sg2044-dwmac: Add suppor= t for Sophgo SG2042 dwmac") > > Signed-off-by: Inochi Amaoto > > Acked-by: Conor Dooley >=20 > > --- > > .../bindings/net/sophgo,sg2044-dwmac.yaml | 19 +++++++++++++++++++ > > 1 file changed, 19 insertions(+) > >=20 > > diff --git a/Documentation/devicetree/bindings/net/sophgo,sg2044-dwmac.= yaml b/Documentation/devicetree/bindings/net/sophgo,sg2044-dwmac.yaml > > index ce21979a2d9a..e8d3814db0e9 100644 > > --- a/Documentation/devicetree/bindings/net/sophgo,sg2044-dwmac.yaml > > +++ b/Documentation/devicetree/bindings/net/sophgo,sg2044-dwmac.yaml > > @@ -70,6 +70,25 @@ required: > > =20 > > allOf: > > - $ref: snps,dwmac.yaml# > > + - if: > > + properties: > > + compatible: > > + contains: > > + const: sophgo,sg2042-dwmac > > + then: > > + properties: > > + phy-mode: > > + enum: >=20 > > + - rgmii-rxid > > + - rgmii-id >=20 > Hi, Conor, >=20 > I have restricted the phy-mode with wrong mode here, it should be > rgmii-rxid instead of rgmii-txid as the SG2042 always add rx delay > in their mac. As this is more like a mistake for me when writing > the binding, I keep you tag with the fix. If you need something > further, please let me know. Yeah that's fine chief. In general, if it is some hardware detail that I couldn't possibly know was correct or incorrect without reading the device's documentation then I probably don't care about the binding change required for it when it's so minimal. Probably the same goes for Rob and Krzysztof. --NIRjo9fMfQbx0LeW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCaRaFDAAKCRB4tDGHoIJi 0sHeAQCiwuHrj6CHOoRLG+GG2NyvoAYv/ledOLpXXMp9wFne6AD/ac6tU8Z1tAkf gGLcZaOgphtF9IndUwUcVjxW0F1kDAM= =Gnn9 -----END PGP SIGNATURE----- --NIRjo9fMfQbx0LeW--