From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 294BECE7B1B for ; Fri, 14 Nov 2025 15:11:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6Z88cIt4bkuwH7lP1X8YYrnTJPptFDIGXgV9h1p1EOM=; b=e/HYlGifBM3vBezE3vV5rWxfZt UOSTcuO2nUaofAo4jprXqyn9rgD9SGQJ79RtAS6UX/cs9Ew1DiSEI+8Of0kO9wleJl3CdshRwCTyF qfXYinhysL8w6DiFgiLno99vspREE76lFORQOlW1Iw3CnfY0NVWD3YPHv/ipkayvuOr5mPdAlRIvx rFzKQL0BRc5cQWX0Urootmb3EmYgYni9rFZslTEVr34Pp1CmYvPWuG2PgBWm/09WBQlB4OkrzJsxU VXUgL9AXiKbDYZ3vPrCPvktokehFMwyplRTA9cLrY6rXz6a3VLR5LpsngwwyWO2jAfCGrHp3wwV93 HRVma6xA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vJvSU-0000000CTIP-3BUT; Fri, 14 Nov 2025 15:11:30 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vJvST-0000000CTHn-3mIm for linux-arm-kernel@bombadil.infradead.org; Fri, 14 Nov 2025 15:11:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:MIME-Version :References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=6Z88cIt4bkuwH7lP1X8YYrnTJPptFDIGXgV9h1p1EOM=; b=TsACrxjAn80j108d430ztbAz7h XU7wAYiwoVkMYzzUfjZsKWlHZMntEJGIAg3ZV5sA5D9b1VHFwk9KUwiQ53QysSVwiEwJ1tqsOLZH9 P0HQIMzNy3LIaXXEsBfToaGywt1c/IBzmH5v63Ibssitj0zZ+sN3f28NIYu8djT4qHlFxZJCAsopf JrWVSqmllfUG2vKI/iUr9YRmZzvHwJfoq+BfX4bVBvOjkEctnVMcnm6fw/N8UTBy6vrbSoHP068lG CmCZrh08crLUgm8aWSa5r41+fuf7YHU0ho2eLBi1jOY82X32Ok3zf+3z66ktiXo8I2Eitl2kBnE8Y HC/qeplQ==; Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by desiato.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vJuam-00000002mDo-26Ky for linux-arm-kernel@lists.infradead.org; Fri, 14 Nov 2025 14:16:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763133086; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6Z88cIt4bkuwH7lP1X8YYrnTJPptFDIGXgV9h1p1EOM=; b=P9revLykPGD0gpHCZvpDKyZo8/QENPjjBjGEj1HN5ApyTWf5JiWXxeIhQTI9HAgmCX3rgh geSIoCgDFNhESEeFzHoADcWPfo+MRp6/wcf4mS8k0573mNehQY1ht54IW7PnK+/DBpHWmf 7Nia5AXjGi3o5ShHWg7jFj0out40hiI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763133086; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6Z88cIt4bkuwH7lP1X8YYrnTJPptFDIGXgV9h1p1EOM=; b=P9revLykPGD0gpHCZvpDKyZo8/QENPjjBjGEj1HN5ApyTWf5JiWXxeIhQTI9HAgmCX3rgh geSIoCgDFNhESEeFzHoADcWPfo+MRp6/wcf4mS8k0573mNehQY1ht54IW7PnK+/DBpHWmf 7Nia5AXjGi3o5ShHWg7jFj0out40hiI= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-141-rdbQPBGSMPqDX7mD8R_GZA-1; Fri, 14 Nov 2025 10:11:20 -0500 X-MC-Unique: rdbQPBGSMPqDX7mD8R_GZA-1 X-Mimecast-MFC-AGG-ID: rdbQPBGSMPqDX7mD8R_GZA_1763133073 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 15A5718AB40A; Fri, 14 Nov 2025 15:11:13 +0000 (UTC) Received: from vschneid-thinkpadt14sgen2i.remote.csb (unknown [10.45.226.10]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id F2CBF300018D; Fri, 14 Nov 2025 15:10:57 +0000 (UTC) From: Valentin Schneider To: linux-kernel@vger.kernel.org, linux-mm@kvack.org, rcu@vger.kernel.org, x86@kernel.org, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-riscv@lists.infradead.org, linux-arch@vger.kernel.org, linux-trace-kernel@vger.kernel.org Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Arnaldo Carvalho de Melo , Josh Poimboeuf , Paolo Bonzini , Arnd Bergmann , Frederic Weisbecker , "Paul E. McKenney" , Jason Baron , Steven Rostedt , Ard Biesheuvel , Sami Tolvanen , "David S. Miller" , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Boqun Feng , Uladzislau Rezki , Mathieu Desnoyers , Mel Gorman , Andrew Morton , Masahiro Yamada , Han Shen , Rik van Riel , Jann Horn , Dan Carpenter , Oleg Nesterov , Juri Lelli , Clark Williams , Yair Podemsky , Marcelo Tosatti , Daniel Wagner , Petr Tesarik , Shrikanth Hegde Subject: [PATCH v7 19/31] sched/clock, x86: Mark __sched_clock_stable key as allowed in .noinstr Date: Fri, 14 Nov 2025 16:10:46 +0100 Message-ID: <20251114151048.1061644-1-vschneid@redhat.com> In-Reply-To: <20251114150133.1056710-1-vschneid@redhat.com> References: <20251114150133.1056710-1-vschneid@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251114_141600_689579_6B28C848 X-CRM114-Status: GOOD ( 15.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Later commits will cause objtool to warn about static keys being used in .noinstr sections in order to safely defer instruction patching IPIs targeted at NOHZ_FULL CPUs. __sched_clock_stable is used in .noinstr code, and can be modified at runtime (e.g. time_cpufreq_notifier()). Suppressing the text_poke_sync() IPI has little benefits for this key, as NOHZ_FULL is incompatible with an unstable TSC anyway. Mark it to let objtool know not to warn about it. Signed-off-by: Valentin Schneider --- kernel/sched/clock.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/kernel/sched/clock.c b/kernel/sched/clock.c index c1a028e99d2cd..5ee27349a4811 100644 --- a/kernel/sched/clock.c +++ b/kernel/sched/clock.c @@ -78,8 +78,11 @@ static DEFINE_STATIC_KEY_FALSE_RO(sched_clock_running); * * Similarly we start with __sched_clock_stable_early, thereby assuming we * will become stable, such that there's only a single 1 -> 0 transition. + * + * NOINSTR: an unstable TLC is incompatible with NOHZ_FULL, thus the text + * patching IPI would be the least of our concerns. */ -static DEFINE_STATIC_KEY_FALSE(__sched_clock_stable); +static DEFINE_STATIC_KEY_FALSE_NOINSTR(__sched_clock_stable); static int __sched_clock_stable_early = 1; /* -- 2.51.0