From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5CEBECE8D6B for ; Mon, 17 Nov 2025 19:13:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IFqIzOro0d3lq4Vo75sb6L8BPjvhx6xu8i74ayza3nA=; b=TdDL8Vd8VDrWqWScZ3dJDXnQiQ qxzdWCAejHB5btehaNbOJQXVYwrH0phZKZNmS9W6AqTwwk1jiJTLO+zqZr4q+U6wDfzW4NzmUjYaB MMIFlIvC7hw0qCTE1VytGKzZc/AbWqx6mMQPFoiJA6L80DLz7anrqYQY/dlL6S6pimm95Yv6O72Kc F08aD5yFdW4BZSOYPKJzckd+oEU4ITra95eKn6g5KbR+LO1zlwHCcqW6LE43NY8qgg459qX87FEz9 NHPMBRcjMyyYp9ghqK+Jke2VNf2T+t/Fo1dFSLvxr/YD5gN/RauWzhtzolOW0bq4QcChQMGzDfjj8 HohYghDg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vL4f7-0000000Gi45-18bX; Mon, 17 Nov 2025 19:13:17 +0000 Received: from sender4-pp-f112.zoho.com ([136.143.188.112]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vL4f0-0000000Gi0W-1Rwe; Mon, 17 Nov 2025 19:13:11 +0000 ARC-Seal: i=1; a=rsa-sha256; t=1763406748; cv=none; d=zohomail.com; s=zohoarc; b=X2RM4BdP9ipXAbgjVzZrq4mEodia6cTJsmPMrJVDBUtCM4k2ewzGMBuE/bp2HGQjhmmRv+o+hywZbvuHaeA5X/uLoD82w2aQq0A5PYuixbPeYkLkl06YBkpfWlAfZ1rKLLQQ6HNBHtVk0IWMU2MMp8fRQog0hcA8mv8w9NN+oJQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1763406748; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=IFqIzOro0d3lq4Vo75sb6L8BPjvhx6xu8i74ayza3nA=; b=jvx3cXzjMbOFC3z6qP1LCTEdSEEeXMuq+EHmMItjXrM2rq6CEVPm+4fAL8/7Q9x8WCZ5o3RGHRtW9r/rBtjypcswSSodxqPiUSbTpK6JaQCLCQEbiL1aVg+Tjlj11psk0nA1D7cU2DHcajwAO0k1dv2GjnW/F4agKFMtNu8L1A4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1763406748; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=IFqIzOro0d3lq4Vo75sb6L8BPjvhx6xu8i74ayza3nA=; b=g6yUbczFgqEaZmTLlxozYa7pRHWG0uL83fqFYNLJa2CJlE8e/CT8uWHGSAWGd1GA cmMjDmoWiBvl1ar8+wk51vENdQ8D9/DhWIdJRtcrZMp2Nzx2zG60et/34V8uSHH79by U1o75L7te4Xq6AzPXnetGsWpqqlpIUOJGLfjP2XY= Received: by mx.zohomail.com with SMTPS id 1763406746438363.0031747030447; Mon, 17 Nov 2025 11:12:26 -0800 (PST) From: Nicolas Frattaroli Date: Mon, 17 Nov 2025 20:11:45 +0100 Subject: [PATCH v4 01/10] drm/amd/display: Remove unnecessary SIGNAL_TYPE_HDMI_TYPE_A check MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20251117-color-format-v4-1-0ded72bd1b00@collabora.com> References: <20251117-color-format-v4-0-0ded72bd1b00@collabora.com> In-Reply-To: <20251117-color-format-v4-0-0ded72bd1b00@collabora.com> To: Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , Andy Yan , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin Cc: kernel@collabora.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, Nicolas Frattaroli , Werner Sembach , Andri Yngvason X-Mailer: b4 0.14.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251117_111310_436127_138C9432 X-CRM114-Status: GOOD ( 12.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Werner Sembach Remove unnecessary SIGNAL_TYPE_HDMI_TYPE_A check that was performed in the drm_mode_is_420_only() case, but not in the drm_mode_is_420_also() && force_yuv420_output case. Without further knowledge if YCbCr 4:2:0 is supported outside of HDMI, there is no reason to use RGB when the display reports drm_mode_is_420_only() even on a non HDMI connection. This patch also moves both checks in the same if-case. This eliminates an extra else-if-case. Signed-off-by: Werner Sembach Signed-off-by: Andri Yngvason Tested-by: Andri Yngvason --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index e6728fd12eeb..598dc3ce993c 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -6522,12 +6522,8 @@ static void fill_stream_properties_from_drm_display_mode( timing_out->v_border_top = 0; timing_out->v_border_bottom = 0; /* TODO: un-hardcode */ - if (drm_mode_is_420_only(info, mode_in) - && stream->signal == SIGNAL_TYPE_HDMI_TYPE_A) - timing_out->pixel_encoding = PIXEL_ENCODING_YCBCR420; - else if (drm_mode_is_420_also(info, mode_in) - && aconnector - && aconnector->force_yuv420_output) + if (drm_mode_is_420_only(info, mode_in) || (drm_mode_is_420_also(info, mode_in) && + aconnector && aconnector->force_yuv420_output)) timing_out->pixel_encoding = PIXEL_ENCODING_YCBCR420; else if ((connector->display_info.color_formats & DRM_COLOR_FORMAT_YCBCR422) && aconnector -- 2.51.2