Re: [PATCH v2 2/3] iommu/amd: Don't call report_iommu_fault()

[Jason Gunthorpe <jgg@nvidia.com>]

On Mon, Nov 17, 2025 at 06:38:51AM +0000, Tian, Kevin wrote:
> > From: Jason Gunthorpe <jgg@nvidia.com>
> > Sent: Friday, November 7, 2025 4:35 AM
> > 
> > This old style API is only used by drivers/gpu/drm/msm,
> > drivers/remoteproc/omap_remoteproc.c, and
> > drivers/remoteproc/qcom_q6v5_adsp.c none are used on x86 HW.
> > 
> > Remove the dead code to discourage new users.
> > 
> > Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> > ---
> >  drivers/iommu/amd/iommu.c | 7 -------
> >  1 file changed, 7 deletions(-)
> > 
> > diff --git a/drivers/iommu/amd/iommu.c b/drivers/iommu/amd/iommu.c
> > index 2e1865daa1cee8..d4d9a5dbfa6333 100644
> > --- a/drivers/iommu/amd/iommu.c
> > +++ b/drivers/iommu/amd/iommu.c
> > @@ -854,13 +854,6 @@ static void amd_iommu_report_page_fault(struct
> > amd_iommu *iommu,
> >  						   PCI_FUNC(devid),
> > domain_id);
> >  				goto out;
> >  			}
> > -
> > -			if (!report_iommu_fault(&dev_data->domain-
> > >domain,
> > -						&pdev->dev, address,
> > -						IS_WRITE_REQUEST(flags) ?
> > -
> > 	IOMMU_FAULT_WRITE :
> > -
> > 	IOMMU_FAULT_READ))
> > -				goto out;
> >  		}
> > 
> >  		if (__ratelimit(&dev_data->rs)) {
> 
> Remove amd_iommu_report_page_fault() too?

I don't understand this remark?

amd_iommu_report_page_fault() generates the dmesg logging on iommu
faults?

Jason