From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C4832CF257C for ; Wed, 19 Nov 2025 04:17:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QyGaMKdQ16v7FsqxzMPOhepkjaBF+qxTwaihhWBqoCc=; b=1Qtj7nqsoW9MPgP4oZG07ZGsRk ELMBsd1APj3noBCLBD+M2N+1bnmZb5os0g753wJLiKsKLkhJz6ZMcHIjiUsBkUGRj1LydniVkjsBk 9OqVY0OlYFllDUQ9mg8q4fPyj9K996e+ZFZlsAIjEbRpjCG01fNSq+irjwjoBFy3JAODtPdsdhnhd I3JPPKmhkNd/LlN3mfj6TnBs0GUY87+hlFBe7uUKco6SUV46SldHuCb2onwRvSGW0Oy83bjkF8C1+ PNZcv2YGu7O0MsipMa2QZRyGWylz4/5pKiNX1psiE3aGhs6frRaKMeP++WlX/c4iLK8LUofnJ/dcY BZEEQlGQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vLZdG-00000001doL-3LNB; Wed, 19 Nov 2025 04:17:26 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vLZdE-00000001dlN-1CH3; Wed, 19 Nov 2025 04:17:25 +0000 Received: from pendragon.ideasonboard.com (unknown [205.220.129.225]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 41432195E; Wed, 19 Nov 2025 05:15:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1763525718; bh=+XBafT8tgTo/WbpW+oGia40uv+dDUQUOTr/OLoWFMQU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=baGp/sXCYN72pf9xw4rgyvUhSXjziHl0zQK/lvbPBAB3zG1S/f9KW80inB3O1kSuH XsV38UgYru8gG2OqmoPaDNCNavWZsW+Tc4oywrySLutBxNeJE4iG1IEYv5jvjVh/eG mHQt4W0LKJJjEawmucbCIIv/Q6RFBlOS5rck9SrM= Date: Wed, 19 Nov 2025 13:16:48 +0900 From: Laurent Pinchart To: Nicolas Frattaroli Cc: Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , Christian =?utf-8?B?S8O2bmln?= , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Andrzej Hajda , Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , Sandy Huang , Heiko =?utf-8?Q?St=C3=BCbner?= , Andy Yan , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , kernel@collabora.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, Marius Vlad Subject: Re: [PATCH v4 03/10] drm: Add enum conversion from/to HDMI_COLORSPACE to DRM_COLOR_FORMAT Message-ID: <20251119041648.GD10711@pendragon.ideasonboard.com> References: <20251117-color-format-v4-0-0ded72bd1b00@collabora.com> <20251117-color-format-v4-3-0ded72bd1b00@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20251117-color-format-v4-3-0ded72bd1b00@collabora.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251118_201724_461673_2552C36D X-CRM114-Status: GOOD ( 20.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 17, 2025 at 08:11:47PM +0100, Nicolas Frattaroli wrote: > From: Marius Vlad > > This would please the compiler to have a enum transformation from one to > another even though the values are the same. It should also make things The hdmi_colorspace enumerators are defined as (with comments added to make the values explicit) enum hdmi_colorspace { HDMI_COLORSPACE_RGB, /* 0 */ HDMI_COLORSPACE_YUV422, /* 1 */ HDMI_COLORSPACE_YUV444, /* 2 */ HDMI_COLORSPACE_YUV420, /* 3 */ HDMI_COLORSPACE_RESERVED4, /* 4 */ HDMI_COLORSPACE_RESERVED5, /* 5 */ HDMI_COLORSPACE_RESERVED6, /* 6 */ HDMI_COLORSPACE_IDO_DEFINED, /* 7 */ }; and the DRM color formats as (after patch 02/10) enum drm_color_format { DRM_COLOR_FORMAT_NONE = 0, /* 0 */ DRM_COLOR_FORMAT_RGB444 = (1 << 0), /* 1 */ DRM_COLOR_FORMAT_YCBCR422 = (1 << 1), /* 2 */ DRM_COLOR_FORMAT_YCBCR444 = (1 << 2), /* 4 */ DRM_COLOR_FORMAT_YCBCR420 = (1 << 3), /* 8 */ /* auto case, driver will set the color_format */ DRM_COLOR_FORMAT_AUTO = (1 << 4), /* 16 */ }; Contrary to what is stated in the commit message, the values are not the same. Maybe you confused DRM_COLOR_FORMAT_* with DRM_MODE_COLOR_FORMAT_* ? > obvious that we use different enums. > > Signed-off-by: Marius Vlad > --- > drivers/gpu/drm/drm_connector.c | 18 ++++++++++++++++++ > include/drm/drm_connector.h | 3 +++ > 2 files changed, 21 insertions(+) > > diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c > index 0ad7be0a2d09..61c077b67ac3 100644 > --- a/drivers/gpu/drm/drm_connector.c > +++ b/drivers/gpu/drm/drm_connector.c > @@ -1384,6 +1384,24 @@ drm_color_format_enum_to_color_format(enum drm_color_format_enum fmt_enum) > } > } > > +enum hdmi_colorspace > +color_format_to_hdmi_colorspace(enum drm_color_format fmt) > +{ > + switch (fmt) { > + default: > + case DRM_COLOR_FORMAT_AUTO: > + case DRM_COLOR_FORMAT_RGB444: > + return HDMI_COLORSPACE_RGB; > + case DRM_COLOR_FORMAT_YCBCR444: > + return HDMI_COLORSPACE_YUV444; > + case DRM_COLOR_FORMAT_YCBCR422: > + return HDMI_COLORSPACE_YUV422; > + case DRM_COLOR_FORMAT_YCBCR420: > + return HDMI_COLORSPACE_YUV420; > + } > +} > +EXPORT_SYMBOL(color_format_to_hdmi_colorspace); > + > /** > * drm_get_color_format_name - return a string for color format > * @colorspace: color format to compute name of > diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h > index a071079fd3ad..e044976c8d76 100644 > --- a/include/drm/drm_connector.h > +++ b/include/drm/drm_connector.h > @@ -2586,6 +2586,9 @@ drm_color_format_to_color_format_enum(enum drm_color_format fmt); > u32 > drm_color_format_enum_to_color_format(enum drm_color_format_enum fmt_enum); > > +enum hdmi_colorspace > +color_format_to_hdmi_colorspace(enum drm_color_format fmt); > + > /** > * drm_for_each_connector_iter - connector_list iterator macro > * @connector: &struct drm_connector pointer used as cursor -- Regards, Laurent Pinchart