From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 32EFCCF2582 for ; Wed, 19 Nov 2025 05:03:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zJZBQJPzH9tvp+p6BfNbmxCYQjyOiKvAtq5q92gsz0E=; b=llctA9/f5N+rsWWjh901xP8jLG l8qOgbsRg8SkvUbc7RkKtOr4ZPzuRkcIUG7JygUGJz+GeR1b2UD5mjxlZyqc5MrpSImE8nizibM+s lKSvAaCx5NvslSBxP0Z7LgeQt8DfC7AvFucKLI3ANLJ4izpDia7bNSuXpZK9Inc9aG0OvISOWk/sp EGFxFVJKYUcDyl391camGHy11YwebAonkgrgHRxs39oeEGM9aJ/jMu+G95ML41A5NJv8yekWtQowD Mfgw4pLYLzIpjUfXywDqx6wknEyOSWRJiq85XzOyxnhH/HNHKgIR96z3LxJ+YgljyAToRxR13evBD ON8OTY+g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vLaLg-000000020rR-1CSm; Wed, 19 Nov 2025 05:03:20 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vLaLa-000000020mA-3LJM for linux-arm-kernel@lists.infradead.org; Wed, 19 Nov 2025 05:03:18 +0000 Received: from pendragon.ideasonboard.com (unknown [205.220.129.225]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 53739195E; Wed, 19 Nov 2025 06:01:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1763528468; bh=6f04bYijyMFsZjVjgltBRwZEr1RHbFar8/wn5NeBitM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fUFcaMcA4k5pMNwr3yRgoRddLq9BLebhEBuD47UPiZg1bPfq9Hb69MKVNFtE+5/be v5nT1KiTI04S8GGb9elvBgOOgb5AyShKEstDfnB+0f5AtvlsG0wLpvaw7LGP7iKnlA oTyQ5jAKw/+U4TnzntuqvjuC2l5qxsB1LwfuYigw= Date: Wed, 19 Nov 2025 14:02:39 +0900 From: Laurent Pinchart To: Frank Li Cc: Philipp Zabel , Mauro Carvalho Chehab , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Rui Miguel Silva , Martin Kepplinger-Novakovic , Purism Kernel Team , linux-media@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] media: nxp: use cleanup __free(fwnode_handle) simplify code Message-ID: <20251119050239.GA16725@pendragon.ideasonboard.com> References: <20251117-cam_cleanup-v1-0-6cd42872db79@nxp.com> <20251117-cam_cleanup-v1-4-6cd42872db79@nxp.com> <20251119042505.GO10711@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20251119042505.GO10711@pendragon.ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251118_210316_867880_E6D5B53E X-CRM114-Status: GOOD ( 28.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 19, 2025 at 01:25:29PM +0900, Laurent Pinchart wrote: > On Mon, Nov 17, 2025 at 01:58:14PM -0500, Frank Li wrote: > > Use cleanup __free(fwnode_handle) simplify code. Change to dev_err_probe() > > because replace goto with return. > > > > Add missed "\n" at error message. > > > > No functional change. > > > > Signed-off-by: Frank Li > > --- > > drivers/media/platform/nxp/imx-mipi-csis.c | 31 +++++++++------------------ > > drivers/media/platform/nxp/imx8mq-mipi-csi2.c | 31 +++++++++------------------ > > 2 files changed, 20 insertions(+), 42 deletions(-) > > > > diff --git a/drivers/media/platform/nxp/imx-mipi-csis.c b/drivers/media/platform/nxp/imx-mipi-csis.c > > index ce93d868746f002c22e2f86b1e0aa84ec1a76061..d924adb406a30797b66f0094ab17e98ad44fefac 100644 > > --- a/drivers/media/platform/nxp/imx-mipi-csis.c > > +++ b/drivers/media/platform/nxp/imx-mipi-csis.c > > @@ -12,6 +12,7 @@ > > * > > */ > > > > +#include > > #include > > #include > > #include > > @@ -1349,28 +1350,25 @@ static int mipi_csis_async_register(struct mipi_csis_device *csis) > > .bus_type = V4L2_MBUS_CSI2_DPHY, > > }; > > struct v4l2_async_connection *asd; > uuu> - struct fwnode_handle *ep; > > unsigned int i; > > int ret; > > > > v4l2_async_subdev_nf_init(&csis->notifier, &csis->sd); > > > > - ep = fwnode_graph_get_endpoint_by_id(dev_fwnode(csis->dev), 0, 0, > > - FWNODE_GRAPH_ENDPOINT_NEXT); > > + struct fwnode_handle *ep __free(fwnode_handle) = > > + fwnode_graph_get_endpoint_by_id(dev_fwnode(csis->dev), 0, 0, > > + FWNODE_GRAPH_ENDPOINT_NEXT); > > Let's avoid mixing variable declarations and code, this is a style > change that is not widely accepted (yet). You can write > > struct fwnode_handle *ep __free(fwnode_handle) = NULL; > struct v4l2_async_connection *asd; > unsigned int i; > int ret; > > v4l2_async_subdev_nf_init(&csis->notifier, &csis->sd); > > ep = fwnode_graph_get_endpoint_by_id(dev_fwnode(csis->dev), 0, 0, > FWNODE_GRAPH_ENDPOINT_NEXT); Quite a coincidence, there's an ongoing mail thread on LKML about this topic: http://lore.kernel.org/r/CAHk-=whPZoi03ZwphxiW6cuWPtC3nyKYS8_BThgztCdgPWP1WA@mail.gmail.com > > if (!ep) > > return -ENOTCONN; > > > > ret = v4l2_fwnode_endpoint_parse(ep, &vep); > > if (ret) > > - goto err_parse; > > + return ret; > > > > for (i = 0; i < vep.bus.mipi_csi2.num_data_lanes; ++i) { > > - if (vep.bus.mipi_csi2.data_lanes[i] != i + 1) { > > - dev_err(csis->dev, > > - "data lanes reordering is not supported"); > > - ret = -EINVAL; > > - goto err_parse; > > - } > > + if (vep.bus.mipi_csi2.data_lanes[i] != i + 1) > > + return dev_err_probe(csis->dev, -EINVAL, > > + "data lanes reordering is not supported\n"); > > To switch to dev_err_probe(), we should drop the error message in the > probe() function when mipi_csis_async_register() fails, and make sure > every error path in this function prints a message. I'd prefer splitting > that to a separate patch. > > > } > > > > csis->bus = vep.bus.mipi_csi2; > > @@ -1381,12 +1379,8 @@ static int mipi_csis_async_register(struct mipi_csis_device *csis) > > > > asd = v4l2_async_nf_add_fwnode_remote(&csis->notifier, ep, > > struct v4l2_async_connection); > > - if (IS_ERR(asd)) { > > - ret = PTR_ERR(asd); > > - goto err_parse; > > - } > > - > > - fwnode_handle_put(ep); > > + if (IS_ERR(asd)) > > + return PTR_ERR(asd); > > > > csis->notifier.ops = &mipi_csis_notify_ops; > > > > @@ -1395,11 +1389,6 @@ static int mipi_csis_async_register(struct mipi_csis_device *csis) > > return ret; > > > > return v4l2_async_register_subdev(&csis->sd); > > - > > -err_parse: > > - fwnode_handle_put(ep); > > - > > - return ret; > > } > > > > /* ----------------------------------------------------------------------------- > > diff --git a/drivers/media/platform/nxp/imx8mq-mipi-csi2.c b/drivers/media/platform/nxp/imx8mq-mipi-csi2.c > > index 75709161fb26a61239b94430365849e022fdc14f..94882568405db55593c5c51722db2233a64d53e4 100644 > > --- a/drivers/media/platform/nxp/imx8mq-mipi-csi2.c > > +++ b/drivers/media/platform/nxp/imx8mq-mipi-csi2.c > > @@ -6,6 +6,7 @@ > > */ > > > > #include > > +#include > > #include > > #include > > #include > > @@ -717,28 +718,25 @@ static int imx8mq_mipi_csi_async_register(struct csi_state *state) > > .bus_type = V4L2_MBUS_CSI2_DPHY, > > }; > > struct v4l2_async_connection *asd; > > - struct fwnode_handle *ep; > > unsigned int i; > > int ret; > > > > v4l2_async_subdev_nf_init(&state->notifier, &state->sd); > > > > - ep = fwnode_graph_get_endpoint_by_id(dev_fwnode(state->dev), 0, 0, > > - FWNODE_GRAPH_ENDPOINT_NEXT); > > + struct fwnode_handle *ep __free(fwnode_handle) = > > + fwnode_graph_get_endpoint_by_id(dev_fwnode(state->dev), 0, 0, > > + FWNODE_GRAPH_ENDPOINT_NEXT); > > Same comment as above. > > > if (!ep) > > return -ENOTCONN; > > > > ret = v4l2_fwnode_endpoint_parse(ep, &vep); > > if (ret) > > - goto err_parse; > > + return ret; > > > > for (i = 0; i < vep.bus.mipi_csi2.num_data_lanes; ++i) { > > - if (vep.bus.mipi_csi2.data_lanes[i] != i + 1) { > > - dev_err(state->dev, > > - "data lanes reordering is not supported"); > > - ret = -EINVAL; > > - goto err_parse; > > - } > > + if (vep.bus.mipi_csi2.data_lanes[i] != i + 1) > > + return dev_err_probe(state->dev, -EINVAL, > > + "data lanes reordering is not supported\n"); > > And here too. > > Usage of __free(fwnode_handle) looks good, it just needs to be split to > a patch of its own. > > > } > > > > state->bus = vep.bus.mipi_csi2; > > @@ -749,12 +747,8 @@ static int imx8mq_mipi_csi_async_register(struct csi_state *state) > > > > asd = v4l2_async_nf_add_fwnode_remote(&state->notifier, ep, > > struct v4l2_async_connection); > > - if (IS_ERR(asd)) { > > - ret = PTR_ERR(asd); > > - goto err_parse; > > - } > > - > > - fwnode_handle_put(ep); > > + if (IS_ERR(asd)) > > + return PTR_ERR(asd); > > > > state->notifier.ops = &imx8mq_mipi_csi_notify_ops; > > > > @@ -763,11 +757,6 @@ static int imx8mq_mipi_csi_async_register(struct csi_state *state) > > return ret; > > > > return v4l2_async_register_subdev(&state->sd); > > - > > -err_parse: > > - fwnode_handle_put(ep); > > - > > - return ret; > > } > > > > /* ----------------------------------------------------------------------------- -- Regards, Laurent Pinchart