[PATCH v2 0/5] rtc: Enhance RTC driver with BBPU bit definitions and shutdown handling

[PATCH v2 0/5] rtc: Enhance RTC driver with BBPU bit definitions and shutdown handling

[ot_shunxi.zhang]

From: Shunxi Zhang <ot_shunxi.zhang@mediatek.com>

(1) Add new bits definitions for RTC_BBPU register.
(2) Add new functions to reset the BBPU alarm status in mt6397 RTC driver
(3) Add mtk_rtc_shutdown function to handle RTC shutdown events.
(4) For the V1 version comments, the following modifications are made: 
(4.1)the formatting changes are separated into a distinct patch. 
(4.2)Since the rtc-mt6397.c file is a fusion of multiple RTC drivers 
for the mt6358, mt6359, and mt6357 RTCs, the definitions of certain bits 
in the RTC_BBPU register differ among these RTCs. The mt6359 supports 
the alarm status bit, while both mt6358 and mt6357 do not. Therefore, 
the alarm-sta-supported property is added in the mt6359.dtsi file to 
differentiate between the different RTCs. 
(4.3)Additionally, the operation to disable IRQ in the shutdown function 
is removed.

Shunxi Zhang (5):
  mfd: mt6397: Fix formatting of RTC_BBPU_KEY definition
  mfd: mt6397: Add bit definitions and struct members to support alarm
    status
  rtc: mt6397: Fix formatting of platform driver structure
  rtc: mt6397: Add BBPU alarm status reset and shutdown handling
  arm64: dts: mediatek: mt6359: Add alarm-sta-supported property to RTC
    node

 arch/arm64/boot/dts/mediatek/mt6359.dtsi |  1 +
 drivers/rtc/rtc-mt6397.c                 | 32 +++++++++++++++++++++++-
 include/linux/mfd/mt6397/rtc.h           |  5 +++-
 3 files changed, 36 insertions(+), 2 deletions(-)

-- 
2.45.2

[PATCH v2 1/5] mfd: mt6397: Fix formatting of RTC_BBPU_KEY definition

[ot_shunxi.zhang]

From: Shunxi Zhang <ot_shunxi.zhang@mediatek.com>

Adjust the whitespace alignment for the RTC_BBPU_KEY macro definition
in the mt6397 RTC header file. This is a cosmetic change to improve
code consistency.

Signed-off-by: Shunxi Zhang <ot_shunxi.zhang@mediatek.com>
---
 include/linux/mfd/mt6397/rtc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/mfd/mt6397/rtc.h b/include/linux/mfd/mt6397/rtc.h
index 27883af44f87..6d0bb1ea151b 100644
--- a/include/linux/mfd/mt6397/rtc.h
+++ b/include/linux/mfd/mt6397/rtc.h
@@ -16,7 +16,7 @@
 
 #define RTC_BBPU               0x0000
 #define RTC_BBPU_CBUSY         BIT(6)
-#define RTC_BBPU_KEY            (0x43 << 8)
+#define RTC_BBPU_KEY           (0x43 << 8)
 
 #define RTC_WRTGR_MT6358       0x003a
 #define RTC_WRTGR_MT6397       0x003c
-- 
2.45.2

Re: [PATCH v2 1/5] mfd: mt6397: Fix formatting of RTC_BBPU_KEY definition

[Krzysztof Kozlowski]

On 20/11/2025 13:17, ot_shunxi.zhang@mediatek.com wrote:
> From: Shunxi Zhang <ot_shunxi.zhang@mediatek.com>
> 
> Adjust the whitespace alignment for the RTC_BBPU_KEY macro definition
> in the mt6397 RTC header file. This is a cosmetic change to improve
> code consistency.

Please don't send such changes line by line.. You have other patches
here doing the same. Organize all such trivial stuff, including for
other drivers not only this one (!!),  in one patch. This is just churn.



Best regards,
Krzysztof

Re: [PATCH v2 1/5] mfd: mt6397: Fix formatting of RTC_BBPU_KEY definition

[Shunxi Zhang (章顺喜)]

On Thu, 2025-11-20 at 14:38 +0100, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On 20/11/2025 13:17, ot_shunxi.zhang@mediatek.com wrote:
> > From: Shunxi Zhang <ot_shunxi.zhang@mediatek.com>
> > 
> > Adjust the whitespace alignment for the RTC_BBPU_KEY macro
> > definition
> > in the mt6397 RTC header file. This is a cosmetic change to improve
> > code consistency.
> 
> Please don't send such changes line by line.. You have other patches
> here doing the same. Organize all such trivial stuff, including for
> other drivers not only this one (!!),  in one patch. This is just
> churn.
> 
> 
> 
> Best regards,
> Krzysztof

Dear sir,
Execuse me,
do you mean we shouldn't make the "formatting changes" a separate
patch? This was based on a previous comment: 
https://patchwork.kernel.org/project/linux-mediatek/patch/20250811081543.4377-2-ot_shunxi.zhang@mediatek.com/#26517538. If it doesn't need to be a separate patch, I will make it into a patch with other changes in the next version.

Best Regards
Shunxi Zhang

Re: [PATCH v2 1/5] mfd: mt6397: Fix formatting of RTC_BBPU_KEY definition

[Krzysztof Kozlowski]

On 21/11/2025 04:07, Shunxi Zhang (章顺喜) wrote:
> On Thu, 2025-11-20 at 14:38 +0100, Krzysztof Kozlowski wrote:
>> External email : Please do not click links or open attachments until
>> you have verified the sender or the content.
>>
>>
>> On 20/11/2025 13:17, ot_shunxi.zhang@mediatek.com wrote:
>>> From: Shunxi Zhang <ot_shunxi.zhang@mediatek.com>
>>>
>>> Adjust the whitespace alignment for the RTC_BBPU_KEY macro
>>> definition
>>> in the mt6397 RTC header file. This is a cosmetic change to improve
>>> code consistency.
>>
>> Please don't send such changes line by line.. You have other patches
>> here doing the same. Organize all such trivial stuff, including for
>> other drivers not only this one (!!),  in one patch. This is just
>> churn.
>>
>>
>>
>> Best regards,
>> Krzysztof
> 
> Dear sir,
> Execuse me,
> do you mean we shouldn't make the "formatting changes" a separate
> patch? This was based on a previous comment: 

Fix entire subsystem or multiple drivers not only one line.


Best regards,
Krzysztof

[PATCH v2 2/5] mfd: mt6397: Add bit definitions and struct members to support alarm status

[ot_shunxi.zhang]

From: Shunxi Zhang <ot_shunxi.zhang@mediatek.com>

This patch adds new bit definitions for the RTC_BBPU register and one
members in the mt6397_rtc_data structure in the mt6397 RTC header file
to support alarm status functionality in the MT6397 RTC driver.

Signed-off-by: Shunxi Zhang <ot_shunxi.zhang@mediatek.com>
---
 include/linux/mfd/mt6397/rtc.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/include/linux/mfd/mt6397/rtc.h b/include/linux/mfd/mt6397/rtc.h
index 6d0bb1ea151b..fb320719f676 100644
--- a/include/linux/mfd/mt6397/rtc.h
+++ b/include/linux/mfd/mt6397/rtc.h
@@ -15,6 +15,8 @@
 #include <linux/rtc.h>
 
 #define RTC_BBPU               0x0000
+#define RTC_BBPU_PWREN         BIT(0)
+#define RTC_BBPU_RESET_AL      BIT(3)
 #define RTC_BBPU_CBUSY         BIT(6)
 #define RTC_BBPU_KEY           (0x43 << 8)
 
@@ -76,6 +78,7 @@ struct mt6397_rtc {
 	int                     irq;
 	u32                     addr_base;
 	const struct mtk_rtc_data *data;
+	bool                    alarm_sta_supported;
 };
 
 #endif /* _LINUX_MFD_MT6397_RTC_H_ */
-- 
2.45.2

[PATCH v2 3/5] rtc: mt6397: Fix formatting of platform driver structure

[ot_shunxi.zhang]

From: Shunxi Zhang <ot_shunxi.zhang@mediatek.com>

This is a cosmetic change to improve code consistency.

Signed-off-by: Shunxi Zhang <ot_shunxi.zhang@mediatek.com>
---
 drivers/rtc/rtc-mt6397.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c
index 692c00ff544b..b8f44a00de5d 100644
--- a/drivers/rtc/rtc-mt6397.c
+++ b/drivers/rtc/rtc-mt6397.c
@@ -345,7 +345,7 @@ static struct platform_driver mtk_rtc_driver = {
 		.of_match_table = mt6397_rtc_of_match,
 		.pm = &mt6397_pm_ops,
 	},
-	.probe	= mtk_rtc_probe,
+	.probe = mtk_rtc_probe,
 };
 
 module_platform_driver(mtk_rtc_driver);
-- 
2.45.2

Re: [PATCH v2 3/5] rtc: mt6397: Fix formatting of platform driver structure

[Krzysztof Kozlowski]

On 20/11/2025 13:17, ot_shunxi.zhang@mediatek.com wrote:
> From: Shunxi Zhang <ot_shunxi.zhang@mediatek.com>
> 
> This is a cosmetic change to improve code consistency.
> 

Churn. Don't send individual patches like this. Fix entire subsystem please.

Best regards,
Krzysztof

Re: [PATCH v2 3/5] rtc: mt6397: Fix formatting of platform driver structure

[Shunxi Zhang (章顺喜)]

On Thu, 2025-11-20 at 14:38 +0100, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On 20/11/2025 13:17, ot_shunxi.zhang@mediatek.com wrote:
> > From: Shunxi Zhang <ot_shunxi.zhang@mediatek.com>
> > 
> > This is a cosmetic change to improve code consistency.
> > 
> 
> Churn. Don't send individual patches like this. Fix entire subsystem
> please.
> 
> Best regards,
> Krzysztof

Dear sir,
Excuse me, do you mean we shouldn't make the "formatting changes" a
separate patch? 
If it doesn't need to modify, I will remove the "fomatting
changes"patch in the next version.

Best Regards
Shunxi Zhang

Re: [PATCH v2 3/5] rtc: mt6397: Fix formatting of platform driver structure

[Alexandre Belloni]

On 20/11/2025 20:17:59+0800, ot_shunxi.zhang@mediatek.com wrote:
> From: Shunxi Zhang <ot_shunxi.zhang@mediatek.com>
> 
> This is a cosmetic change to improve code consistency.
> 

But, is it?

> Signed-off-by: Shunxi Zhang <ot_shunxi.zhang@mediatek.com>
> ---
>  drivers/rtc/rtc-mt6397.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c
> index 692c00ff544b..b8f44a00de5d 100644
> --- a/drivers/rtc/rtc-mt6397.c
> +++ b/drivers/rtc/rtc-mt6397.c
> @@ -345,7 +345,7 @@ static struct platform_driver mtk_rtc_driver = {
>  		.of_match_table = mt6397_rtc_of_match,
>  		.pm = &mt6397_pm_ops,
>  	},
> -	.probe	= mtk_rtc_probe,

I guess the original author wanted to align with the members of the
.drivers struct above. I won't take a patch to change just that as the
next guys wanting to improve his KPIs will do the exact opposite.


> +	.probe = mtk_rtc_probe,
>  };
>  
>  module_platform_driver(mtk_rtc_driver);
> -- 
> 2.45.2
> 

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[PATCH v2 4/5] rtc: mt6397: Add BBPU alarm status reset and shutdown handling

[ot_shunxi.zhang]

From: Shunxi Zhang <ot_shunxi.zhang@mediatek.com>

Function "mtk_rtc_reset_bbpu_alarm_status" is added to address the
issue that the RTC BBPU alarm state remains after the RTC alarm
has occurred.

Additionally, function "mtk_rtc_shutdown" is added to address the
issue of the platform being powered on again after shutdown because
the RTC_BBPU alarm state was not cleared.

Signed-off-by: Shunxi Zhang <ot_shunxi.zhang@mediatek.com>
---
 drivers/rtc/rtc-mt6397.c | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c
index b8f44a00de5d..8bf7e0822ef0 100644
--- a/drivers/rtc/rtc-mt6397.c
+++ b/drivers/rtc/rtc-mt6397.c
@@ -37,6 +37,21 @@ static int mtk_rtc_write_trigger(struct mt6397_rtc *rtc)
 	return ret;
 }
 
+static void mtk_rtc_reset_bbpu_alarm_status(struct mt6397_rtc *rtc)
+{
+	u32 bbpu = RTC_BBPU_KEY | RTC_BBPU_PWREN | RTC_BBPU_RESET_AL;
+	int ret;
+
+	ret = regmap_write(rtc->regmap, rtc->addr_base + RTC_BBPU, bbpu);
+	if (ret < 0) {
+		dev_err(rtc->rtc_dev->dev.parent, "%s: write rtc bbpu error\n",
+			__func__);
+		return;
+	}
+
+	mtk_rtc_write_trigger(rtc);
+}
+
 static irqreturn_t mtk_rtc_irq_handler_thread(int irq, void *data)
 {
 	struct mt6397_rtc *rtc = data;
@@ -51,6 +66,9 @@ static irqreturn_t mtk_rtc_irq_handler_thread(int irq, void *data)
 		if (regmap_write(rtc->regmap, rtc->addr_base + RTC_IRQ_EN,
 				 irqen) == 0)
 			mtk_rtc_write_trigger(rtc);
+
+		if (rtc->alarm_sta_supported)
+			mtk_rtc_reset_bbpu_alarm_status(rtc);
 		mutex_unlock(&rtc->lock);
 
 		return IRQ_HANDLED;
@@ -249,6 +267,7 @@ static int mtk_rtc_probe(struct platform_device *pdev)
 	struct resource *res;
 	struct mt6397_chip *mt6397_chip = dev_get_drvdata(pdev->dev.parent);
 	struct mt6397_rtc *rtc;
+	struct device_node *np = pdev->dev.of_node;
 	int ret;
 
 	rtc = devm_kzalloc(&pdev->dev, sizeof(struct mt6397_rtc), GFP_KERNEL);
@@ -275,6 +294,8 @@ static int mtk_rtc_probe(struct platform_device *pdev)
 	if (IS_ERR(rtc->rtc_dev))
 		return PTR_ERR(rtc->rtc_dev);
 
+	rtc->alarm_sta_supported = of_property_read_bool(np, "mediatek,alarm-sta-supported");
+
 	ret = devm_request_threaded_irq(&pdev->dev, rtc->irq, NULL,
 					mtk_rtc_irq_handler_thread,
 					IRQF_ONESHOT | IRQF_TRIGGER_HIGH,
@@ -297,6 +318,14 @@ static int mtk_rtc_probe(struct platform_device *pdev)
 	return devm_rtc_register_device(rtc->rtc_dev);
 }
 
+static void mtk_rtc_shutdown(struct platform_device *pdev)
+{
+	struct mt6397_rtc *rtc = platform_get_drvdata(pdev);
+
+	if (rtc->alarm_sta_supported)
+		mtk_rtc_reset_bbpu_alarm_status(rtc);
+}
+
 #ifdef CONFIG_PM_SLEEP
 static int mt6397_rtc_suspend(struct device *dev)
 {
@@ -346,6 +375,7 @@ static struct platform_driver mtk_rtc_driver = {
 		.pm = &mt6397_pm_ops,
 	},
 	.probe = mtk_rtc_probe,
+	.shutdown = mtk_rtc_shutdown,
 };
 
 module_platform_driver(mtk_rtc_driver);
-- 
2.45.2

Re: [PATCH v2 4/5] rtc: mt6397: Add BBPU alarm status reset and shutdown handling

[Krzysztof Kozlowski]

On 20/11/2025 13:18, ot_shunxi.zhang@mediatek.com wrote:
>  
>  	rtc = devm_kzalloc(&pdev->dev, sizeof(struct mt6397_rtc), GFP_KERNEL);
> @@ -275,6 +294,8 @@ static int mtk_rtc_probe(struct platform_device *pdev)
>  	if (IS_ERR(rtc->rtc_dev))
>  		return PTR_ERR(rtc->rtc_dev);
>  
> +	rtc->alarm_sta_supported = of_property_read_bool(np, "mediatek,alarm-sta-supported");

You cannot add undocumented ABI. Read carefully Linux documentation.

Best regards,
Krzysztof

Re: [PATCH v2 4/5] rtc: mt6397: Add BBPU alarm status reset and shutdown handling

[Shunxi Zhang (章顺喜)]

On Thu, 2025-11-20 at 14:40 +0100, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On 20/11/2025 13:18, ot_shunxi.zhang@mediatek.com wrote:
> > 
> >       rtc = devm_kzalloc(&pdev->dev, sizeof(struct mt6397_rtc),
> > GFP_KERNEL);
> > @@ -275,6 +294,8 @@ static int mtk_rtc_probe(struct platform_device
> > *pdev)
> >       if (IS_ERR(rtc->rtc_dev))
> >               return PTR_ERR(rtc->rtc_dev);
> > 
> > +     rtc->alarm_sta_supported = of_property_read_bool(np,
> > "mediatek,alarm-sta-supported");
> 
> You cannot add undocumented ABI. Read carefully Linux documentation.
> 
> Best regards,
> Krzysztof

Dear sir,
  Thanks for your comment, I will read & check linux documentation.
It will be revised in the next version.

Best Regards
Shunxi Zhang

Re: [PATCH v2 4/5] rtc: mt6397: Add BBPU alarm status reset and shutdown handling

[AngeloGioacchino Del Regno]

Il 20/11/25 13:18, ot_shunxi.zhang@mediatek.com ha scritto:
> From: Shunxi Zhang <ot_shunxi.zhang@mediatek.com>
> 
> Function "mtk_rtc_reset_bbpu_alarm_status" is added to address the
> issue that the RTC BBPU alarm state remains after the RTC alarm
> has occurred.
> 
> Additionally, function "mtk_rtc_shutdown" is added to address the
> issue of the platform being powered on again after shutdown because
> the RTC_BBPU alarm state was not cleared.
> 
> Signed-off-by: Shunxi Zhang <ot_shunxi.zhang@mediatek.com>
> ---
>   drivers/rtc/rtc-mt6397.c | 30 ++++++++++++++++++++++++++++++
>   1 file changed, 30 insertions(+)
> 
> diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c
> index b8f44a00de5d..8bf7e0822ef0 100644
> --- a/drivers/rtc/rtc-mt6397.c
> +++ b/drivers/rtc/rtc-mt6397.c
> @@ -37,6 +37,21 @@ static int mtk_rtc_write_trigger(struct mt6397_rtc *rtc)
>   	return ret;
>   }
>   
> +static void mtk_rtc_reset_bbpu_alarm_status(struct mt6397_rtc *rtc)
> +{
> +	u32 bbpu = RTC_BBPU_KEY | RTC_BBPU_PWREN | RTC_BBPU_RESET_AL;
> +	int ret;
> +
> +	ret = regmap_write(rtc->regmap, rtc->addr_base + RTC_BBPU, bbpu);
> +	if (ret < 0) {
> +		dev_err(rtc->rtc_dev->dev.parent, "%s: write rtc bbpu error\n",
> +			__func__);
> +		return;
> +	}
> +
> +	mtk_rtc_write_trigger(rtc);
> +}
> +
>   static irqreturn_t mtk_rtc_irq_handler_thread(int irq, void *data)
>   {
>   	struct mt6397_rtc *rtc = data;
> @@ -51,6 +66,9 @@ static irqreturn_t mtk_rtc_irq_handler_thread(int irq, void *data)
>   		if (regmap_write(rtc->regmap, rtc->addr_base + RTC_IRQ_EN,
>   				 irqen) == 0)
>   			mtk_rtc_write_trigger(rtc);
> +
> +		if (rtc->alarm_sta_supported)
> +			mtk_rtc_reset_bbpu_alarm_status(rtc);
>   		mutex_unlock(&rtc->lock);
>   
>   		return IRQ_HANDLED;
> @@ -249,6 +267,7 @@ static int mtk_rtc_probe(struct platform_device *pdev)
>   	struct resource *res;
>   	struct mt6397_chip *mt6397_chip = dev_get_drvdata(pdev->dev.parent);
>   	struct mt6397_rtc *rtc;
> +	struct device_node *np = pdev->dev.of_node;
>   	int ret;
>   
>   	rtc = devm_kzalloc(&pdev->dev, sizeof(struct mt6397_rtc), GFP_KERNEL);
> @@ -275,6 +294,8 @@ static int mtk_rtc_probe(struct platform_device *pdev)
>   	if (IS_ERR(rtc->rtc_dev))
>   		return PTR_ERR(rtc->rtc_dev);
>   
> +	rtc->alarm_sta_supported = of_property_read_bool(np, "mediatek,alarm-sta-supported");

You don't need a DT property - the PMIC dictates support for that, not the board.

This means that you also don't need the alarm_sta_supported variable, and you
don't need to check for it.

Just execute the mtk_rtc_reset_bbpu_alarm_status() function when you have to,
without any check.

Cheers,
Angelo

> +
>   	ret = devm_request_threaded_irq(&pdev->dev, rtc->irq, NULL,
>   					mtk_rtc_irq_handler_thread,
>   					IRQF_ONESHOT | IRQF_TRIGGER_HIGH,
> @@ -297,6 +318,14 @@ static int mtk_rtc_probe(struct platform_device *pdev)
>   	return devm_rtc_register_device(rtc->rtc_dev);
>   }
>   
> +static void mtk_rtc_shutdown(struct platform_device *pdev)
> +{
> +	struct mt6397_rtc *rtc = platform_get_drvdata(pdev);
> +
> +	if (rtc->alarm_sta_supported)
> +		mtk_rtc_reset_bbpu_alarm_status(rtc);
> +}
> +
>   #ifdef CONFIG_PM_SLEEP
>   static int mt6397_rtc_suspend(struct device *dev)
>   {
> @@ -346,6 +375,7 @@ static struct platform_driver mtk_rtc_driver = {
>   		.pm = &mt6397_pm_ops,
>   	},
>   	.probe = mtk_rtc_probe,
> +	.shutdown = mtk_rtc_shutdown,
>   };
>   
>   module_platform_driver(mtk_rtc_driver);

Re: [PATCH v2 4/5] rtc: mt6397: Add BBPU alarm status reset and shutdown handling

[Shunxi Zhang (章顺喜)]

On Thu, 2025-11-20 at 15:42 +0100, AngeloGioacchino Del Regno wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> Il 20/11/25 13:18, ot_shunxi.zhang@mediatek.com ha scritto:
> > From: Shunxi Zhang <ot_shunxi.zhang@mediatek.com>
> > 
> > Function "mtk_rtc_reset_bbpu_alarm_status" is added to address the
> > issue that the RTC BBPU alarm state remains after the RTC alarm
> > has occurred.
> > 
> > Additionally, function "mtk_rtc_shutdown" is added to address the
> > issue of the platform being powered on again after shutdown because
> > the RTC_BBPU alarm state was not cleared.
> > 
> > Signed-off-by: Shunxi Zhang <ot_shunxi.zhang@mediatek.com>
> > ---
> >   drivers/rtc/rtc-mt6397.c | 30 ++++++++++++++++++++++++++++++
> >   1 file changed, 30 insertions(+)
> > 
> > diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c
> > index b8f44a00de5d..8bf7e0822ef0 100644
> > --- a/drivers/rtc/rtc-mt6397.c
> > +++ b/drivers/rtc/rtc-mt6397.c
> > @@ -37,6 +37,21 @@ static int mtk_rtc_write_trigger(struct
> > mt6397_rtc *rtc)
> >       return ret;
> >   }
> > 
> > +static void mtk_rtc_reset_bbpu_alarm_status(struct mt6397_rtc
> > *rtc)
> > +{
> > +     u32 bbpu = RTC_BBPU_KEY | RTC_BBPU_PWREN | RTC_BBPU_RESET_AL;
> > +     int ret;
> > +
> > +     ret = regmap_write(rtc->regmap, rtc->addr_base + RTC_BBPU,
> > bbpu);
> > +     if (ret < 0) {
> > +             dev_err(rtc->rtc_dev->dev.parent, "%s: write rtc bbpu
> > error\n",
> > +                     __func__);
> > +             return;
> > +     }
> > +
> > +     mtk_rtc_write_trigger(rtc);
> > +}
> > +
> >   static irqreturn_t mtk_rtc_irq_handler_thread(int irq, void
> > *data)
> >   {
> >       struct mt6397_rtc *rtc = data;
> > @@ -51,6 +66,9 @@ static irqreturn_t mtk_rtc_irq_handler_thread(int
> > irq, void *data)
> >               if (regmap_write(rtc->regmap, rtc->addr_base +
> > RTC_IRQ_EN,
> >                                irqen) == 0)
> >                       mtk_rtc_write_trigger(rtc);
> > +
> > +             if (rtc->alarm_sta_supported)
> > +                     mtk_rtc_reset_bbpu_alarm_status(rtc);
> >               mutex_unlock(&rtc->lock);
> > 
> >               return IRQ_HANDLED;
> > @@ -249,6 +267,7 @@ static int mtk_rtc_probe(struct platform_device
> > *pdev)
> >       struct resource *res;
> >       struct mt6397_chip *mt6397_chip = dev_get_drvdata(pdev-
> > >dev.parent);
> >       struct mt6397_rtc *rtc;
> > +     struct device_node *np = pdev->dev.of_node;
> >       int ret;
> > 
> >       rtc = devm_kzalloc(&pdev->dev, sizeof(struct mt6397_rtc),
> > GFP_KERNEL);
> > @@ -275,6 +294,8 @@ static int mtk_rtc_probe(struct platform_device
> > *pdev)
> >       if (IS_ERR(rtc->rtc_dev))
> >               return PTR_ERR(rtc->rtc_dev);
> > 
> > +     rtc->alarm_sta_supported = of_property_read_bool(np,
> > "mediatek,alarm-sta-supported");
> 
> You don't need a DT property - the PMIC dictates support for that,
> not the board.
> 
> This means that you also don't need the alarm_sta_supported variable,
> and you
> don't need to check for it.
> 
> Just execute the mtk_rtc_reset_bbpu_alarm_status() function when you
> have to,
> without any check.
> 
> Cheers,
> Angelo

Dear sir,
Thanks for your comment. This check is base on the last comment(
https://patchwork.kernel.org/project/linux-mediatek/patch/20250811081543.4377-2-ot_shunxi.zhang@mediatek.com/#26517538
) reply:
"The MT6397 is an integration of several ICs and does not have a
separate IC specification. I will check the relevant IC datasheets
again. I will remove the useless define in next version".

Only the MT6359 has the "BBPU alarm status" function, so this attribute
needs to be added to the RTC function in MT6359.dtsi for judgment. This
ensures compatibility with other PMICs (MT6358, etc.) in rtc-mt6397.c.

Excuse me, do you have any further suggestions on better compatibility?
I will improve and modify it in the next version.

Best Regards
Shunxi Zhang

> 
> > +
> >       ret = devm_request_threaded_irq(&pdev->dev, rtc->irq, NULL,
> >                                       mtk_rtc_irq_handler_thread,
> >                                       IRQF_ONESHOT |
> > IRQF_TRIGGER_HIGH,
> > @@ -297,6 +318,14 @@ static int mtk_rtc_probe(struct
> > platform_device *pdev)
> >       return devm_rtc_register_device(rtc->rtc_dev);
> >   }
> > 
> > +static void mtk_rtc_shutdown(struct platform_device *pdev)
> > +{
> > +     struct mt6397_rtc *rtc = platform_get_drvdata(pdev);
> > +
> > +     if (rtc->alarm_sta_supported)
> > +             mtk_rtc_reset_bbpu_alarm_status(rtc);
> > +}
> > +
> >   #ifdef CONFIG_PM_SLEEP
> >   static int mt6397_rtc_suspend(struct device *dev)
> >   {
> > @@ -346,6 +375,7 @@ static struct platform_driver mtk_rtc_driver =
> > {
> >               .pm = &mt6397_pm_ops,
> >       },
> >       .probe = mtk_rtc_probe,
> > +     .shutdown = mtk_rtc_shutdown,
> >   };
> > 
> >   module_platform_driver(mtk_rtc_driver);
> 
> 

[PATCH v2 5/5] arm64: dts: mediatek: mt6359: Add alarm-sta-supported property to RTC node

[ot_shunxi.zhang]

From: Shunxi Zhang <ot_shunxi.zhang@mediatek.com>

This patch adds the 'mediatek,alarm-sta-supported' property to the RTC
node in the MediaTek MT6359 device tree source file. This property
indicates that the RTC supports alarm status functionality, which is
essential for proper power management and wake-up events.

Signed-off-by: Shunxi Zhang <ot_shunxi.zhang@mediatek.com>
---
 arch/arm64/boot/dts/mediatek/mt6359.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/mediatek/mt6359.dtsi b/arch/arm64/boot/dts/mediatek/mt6359.dtsi
index 467d8a4c2aa7..62a2d745c8d2 100644
--- a/arch/arm64/boot/dts/mediatek/mt6359.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt6359.dtsi
@@ -302,6 +302,7 @@ mt6359_vsram_others_sshub_ldo: ldo_vsram_others_sshub {
 
 		mt6359rtc: rtc {
 			compatible = "mediatek,mt6358-rtc";
+			mediatek,alarm-sta-supported;
 		};
 	};
 };
-- 
2.45.2

Re: [PATCH v2 5/5] arm64: dts: mediatek: mt6359: Add alarm-sta-supported property to RTC node

[Krzysztof Kozlowski]

On 20/11/2025 13:18, ot_shunxi.zhang@mediatek.com wrote:
> From: Shunxi Zhang <ot_shunxi.zhang@mediatek.com>
> 
> This patch adds the 'mediatek,alarm-sta-supported' property to the RTC


Please do not use "This commit/patch/change", but imperative mood. See
longer explanation here:
https://elixir.bootlin.com/linux/v6.16/source/Documentation/process/submitting-patches.rst#L94

> node in the MediaTek MT6359 device tree source file. This property
> indicates that the RTC supports alarm status functionality, which is
> essential for proper power management and wake-up events.
> 
> Signed-off-by: Shunxi Zhang <ot_shunxi.zhang@mediatek.com>
> ---
>  arch/arm64/boot/dts/mediatek/mt6359.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt6359.dtsi b/arch/arm64/boot/dts/mediatek/mt6359.dtsi
> index 467d8a4c2aa7..62a2d745c8d2 100644
> --- a/arch/arm64/boot/dts/mediatek/mt6359.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt6359.dtsi
> @@ -302,6 +302,7 @@ mt6359_vsram_others_sshub_ldo: ldo_vsram_others_sshub {
>  
>  		mt6359rtc: rtc {
>  			compatible = "mediatek,mt6358-rtc";
> +			mediatek,alarm-sta-supported;

NAK, there is no such ABI.

Test your code BEFORE you send it.

It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
Maybe you need to update your dtschema and yamllint. Don't rely on
distro packages for dtschema and be sure you are using the latest
released dtschema.


Best regards,
Krzysztof

Re: [PATCH v2 5/5] arm64: dts: mediatek: mt6359: Add alarm-sta-supported property to RTC node

[Shunxi Zhang (章顺喜)]

On Thu, 2025-11-20 at 14:39 +0100, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On 20/11/2025 13:18, ot_shunxi.zhang@mediatek.com wrote:
> > From: Shunxi Zhang <ot_shunxi.zhang@mediatek.com>
> > 
> > This patch adds the 'mediatek,alarm-sta-supported' property to the
> > RTC
> 
> 
> Please do not use "This commit/patch/change", but imperative mood.
> See
> longer explanation here:
> 
https://urldefense.com/v3/__https://elixir.bootlin.com/linux/v6.16/source/Documentation/process/submitting-patches.rst*L94__;Iw!!CTRNKA9wMg0ARbw!lG60Q7FoClLZKplNF6BZMm2F_K445Atp1fNnFeABA24zxGbEsB2YpbGS4mjeA99Ir53IUlM3GQTbHQYWg1iJ$
> 
> > node in the MediaTek MT6359 device tree source file. This property
> > indicates that the RTC supports alarm status functionality, which
> > is
> > essential for proper power management and wake-up events.
> > 
> > Signed-off-by: Shunxi Zhang <ot_shunxi.zhang@mediatek.com>
> > ---
> >  arch/arm64/boot/dts/mediatek/mt6359.dtsi | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/arch/arm64/boot/dts/mediatek/mt6359.dtsi
> > b/arch/arm64/boot/dts/mediatek/mt6359.dtsi
> > index 467d8a4c2aa7..62a2d745c8d2 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt6359.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt6359.dtsi
> > @@ -302,6 +302,7 @@ mt6359_vsram_others_sshub_ldo:
> > ldo_vsram_others_sshub {
> > 
> >               mt6359rtc: rtc {
> >                       compatible = "mediatek,mt6358-rtc";
> > +                     mediatek,alarm-sta-supported;
> 
> NAK, there is no such ABI.
> 
> Test your code BEFORE you send it.
> 
> It does not look like you tested the DTS against bindings. Please run
> `make dtbs_check W=1` (see
> Documentation/devicetree/bindings/writing-schema.rst or
> 
https://urldefense.com/v3/__https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/__;!!CTRNKA9wMg0ARbw!lG60Q7FoClLZKplNF6BZMm2F_K445Atp1fNnFeABA24zxGbEsB2YpbGS4mjeA99Ir53IUlM3GQTbHR2UEECz$
> for instructions).
> Maybe you need to update your dtschema and yamllint. Don't rely on
> distro packages for dtschema and be sure you are using the latest
> released dtschema.
> 
> 
> Best regards,
> Krzysztof

Dir sir,
  Thanks for comments; I will check the DTS file again according to the
method you posted. It will be revised in the next version.

Best Regards
Shunxi Zhang

Re: [PATCH v2 0/5] rtc: Enhance RTC driver with BBPU bit definitions and shutdown handling

[Rob Herring]

On Thu, 20 Nov 2025 20:17:56 +0800, ot_shunxi.zhang@mediatek.com wrote:
> From: Shunxi Zhang <ot_shunxi.zhang@mediatek.com>
> 
> (1) Add new bits definitions for RTC_BBPU register.
> (2) Add new functions to reset the BBPU alarm status in mt6397 RTC driver
> (3) Add mtk_rtc_shutdown function to handle RTC shutdown events.
> (4) For the V1 version comments, the following modifications are made:
> (4.1)the formatting changes are separated into a distinct patch.
> (4.2)Since the rtc-mt6397.c file is a fusion of multiple RTC drivers
> for the mt6358, mt6359, and mt6357 RTCs, the definitions of certain bits
> in the RTC_BBPU register differ among these RTCs. The mt6359 supports
> the alarm status bit, while both mt6358 and mt6357 do not. Therefore,
> the alarm-sta-supported property is added in the mt6359.dtsi file to
> differentiate between the different RTCs.
> (4.3)Additionally, the operation to disable IRQ in the shutdown function
> is removed.
> 
> Shunxi Zhang (5):
>   mfd: mt6397: Fix formatting of RTC_BBPU_KEY definition
>   mfd: mt6397: Add bit definitions and struct members to support alarm
>     status
>   rtc: mt6397: Fix formatting of platform driver structure
>   rtc: mt6397: Add BBPU alarm status reset and shutdown handling
>   arm64: dts: mediatek: mt6359: Add alarm-sta-supported property to RTC
>     node
> 
>  arch/arm64/boot/dts/mediatek/mt6359.dtsi |  1 +
>  drivers/rtc/rtc-mt6397.c                 | 32 +++++++++++++++++++++++-
>  include/linux/mfd/mt6397/rtc.h           |  5 +++-
>  3 files changed, 36 insertions(+), 2 deletions(-)
> 
> --
> 2.45.2
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


This patch series was applied (using b4) to base:
 Base: attempting to guess base-commit...
 Base: tags/next-20251119 (exact match)
 Base: tags/next-20251119 (use --merge-base to override)

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/mediatek/' for 20251120121805.6775-1-ot_shunxi.zhang@mediatek.com:

arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dtb: pmic (mediatek,mt6359): rtc: Unevaluated properties are not allowed ('mediatek,alarm-sta-supported' was unexpected)
	from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml
arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dtb: pmic (mediatek,mt6359): rtc: Unevaluated properties are not allowed ('mediatek,alarm-sta-supported' was unexpected)
	from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml
arch/arm64/boot/dts/mediatek/mt8395-kontron-3-5-sbc-i1200.dtb: pmic (mediatek,mt6359): rtc: Unevaluated properties are not allowed ('mediatek,alarm-sta-supported' was unexpected)
	from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml
arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk-ufs.dtb: pmic (mediatek,mt6359): rtc: Unevaluated properties are not allowed ('mediatek,alarm-sta-supported' was unexpected)
	from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml
arch/arm64/boot/dts/mediatek/mt8188-geralt-ciri-sku4.dtb: pmic (mediatek,mt6359): rtc: Unevaluated properties are not allowed ('mediatek,alarm-sta-supported' was unexpected)
	from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml
arch/arm64/boot/dts/mediatek/mt8370-genio-510-evk.dtb: pmic (mediatek,mt6359): rtc: Unevaluated properties are not allowed ('mediatek,alarm-sta-supported' was unexpected)
	from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml
arch/arm64/boot/dts/mediatek/mt8188-geralt-ciri-sku1.dtb: pmic (mediatek,mt6359): rtc: Unevaluated properties are not allowed ('mediatek,alarm-sta-supported' was unexpected)
	from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml
arch/arm64/boot/dts/mediatek/mt8390-genio-700-evk.dtb: pmic (mediatek,mt6359): rtc: Unevaluated properties are not allowed ('mediatek,alarm-sta-supported' was unexpected)
	from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml
arch/arm64/boot/dts/mediatek/mt8195-demo.dtb: pmic (mediatek,mt6359): rtc: Unevaluated properties are not allowed ('mediatek,alarm-sta-supported' was unexpected)
	from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml
arch/arm64/boot/dts/mediatek/mt8192-asurada-hayato-r1.dtb: pmic (mediatek,mt6359): rtc: Unevaluated properties are not allowed ('mediatek,alarm-sta-supported' was unexpected)
	from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml
arch/arm64/boot/dts/mediatek/mt8192-asurada-spherion-r0.dtb: pmic (mediatek,mt6359): rtc: Unevaluated properties are not allowed ('mediatek,alarm-sta-supported' was unexpected)
	from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml
arch/arm64/boot/dts/mediatek/mt8188-evb.dtb: pmic (mediatek,mt6359): rtc: Unevaluated properties are not allowed ('mediatek,alarm-sta-supported' was unexpected)
	from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml
arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dtb: pmic (mediatek,mt6359): rtc: Unevaluated properties are not allowed ('mediatek,alarm-sta-supported' was unexpected)
	from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml
arch/arm64/boot/dts/mediatek/mt8370-grinn-genio-510-sbc.dtb: pmic (mediatek,mt6359): rtc: Unevaluated properties are not allowed ('mediatek,alarm-sta-supported' was unexpected)
	from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml
arch/arm64/boot/dts/mediatek/mt8188-geralt-ciri-sku7.dtb: pmic (mediatek,mt6359): rtc: Unevaluated properties are not allowed ('mediatek,alarm-sta-supported' was unexpected)
	from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml
arch/arm64/boot/dts/mediatek/mt8188-geralt-ciri-sku6.dtb: pmic (mediatek,mt6359): rtc: Unevaluated properties are not allowed ('mediatek,alarm-sta-supported' was unexpected)
	from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml
arch/arm64/boot/dts/mediatek/mt8188-geralt-ciri-sku3.dtb: pmic (mediatek,mt6359): rtc: Unevaluated properties are not allowed ('mediatek,alarm-sta-supported' was unexpected)
	from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml
arch/arm64/boot/dts/mediatek/mt8188-geralt-ciri-sku0.dtb: pmic (mediatek,mt6359): rtc: Unevaluated properties are not allowed ('mediatek,alarm-sta-supported' was unexpected)
	from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml
arch/arm64/boot/dts/mediatek/mt8390-grinn-genio-700-sbc.dtb: pmic (mediatek,mt6359): rtc: Unevaluated properties are not allowed ('mediatek,alarm-sta-supported' was unexpected)
	from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml
arch/arm64/boot/dts/mediatek/mt8195-cherry-dojo-r1.dtb: pmic (mediatek,mt6359): rtc: Unevaluated properties are not allowed ('mediatek,alarm-sta-supported' was unexpected)
	from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml
arch/arm64/boot/dts/mediatek/mt8192-evb.dtb: pmic (mediatek,mt6359): rtc: Unevaluated properties are not allowed ('mediatek,alarm-sta-supported' was unexpected)
	from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml
arch/arm64/boot/dts/mediatek/mt8188-geralt-ciri-sku2.dtb: pmic (mediatek,mt6359): rtc: Unevaluated properties are not allowed ('mediatek,alarm-sta-supported' was unexpected)
	from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml
arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dtb: pmic (mediatek,mt6359): rtc: Unevaluated properties are not allowed ('mediatek,alarm-sta-supported' was unexpected)
	from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml
arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dtb: pmic (mediatek,mt6359): rtc: Unevaluated properties are not allowed ('mediatek,alarm-sta-supported' was unexpected)
	from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml
arch/arm64/boot/dts/mediatek/mt8188-geralt-ciri-sku5.dtb: pmic (mediatek,mt6359): rtc: Unevaluated properties are not allowed ('mediatek,alarm-sta-supported' was unexpected)
	from schema $id: http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml

Re: [PATCH v2 0/5] rtc: Enhance RTC driver with BBPU bit definitions and shutdown handling

[Shunxi Zhang (章顺喜)]

On Thu, 2025-11-20 at 08:14 -0600, Rob Herring wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On Thu, 20 Nov 2025 20:17:56 +0800, ot_shunxi.zhang@mediatek.com
> wrote:
> > From: Shunxi Zhang <ot_shunxi.zhang@mediatek.com>
> > 
> > (1) Add new bits definitions for RTC_BBPU register.
> > (2) Add new functions to reset the BBPU alarm status in mt6397 RTC
> > driver
> > (3) Add mtk_rtc_shutdown function to handle RTC shutdown events.
> > (4) For the V1 version comments, the following modifications are
> > made:
> > (4.1)the formatting changes are separated into a distinct patch.
> > (4.2)Since the rtc-mt6397.c file is a fusion of multiple RTC
> > drivers
> > for the mt6358, mt6359, and mt6357 RTCs, the definitions of certain
> > bits
> > in the RTC_BBPU register differ among these RTCs. The mt6359
> > supports
> > the alarm status bit, while both mt6358 and mt6357 do not.
> > Therefore,
> > the alarm-sta-supported property is added in the mt6359.dtsi file
> > to
> > differentiate between the different RTCs.
> > (4.3)Additionally, the operation to disable IRQ in the shutdown
> > function
> > is removed.
> > 
> > Shunxi Zhang (5):
> >   mfd: mt6397: Fix formatting of RTC_BBPU_KEY definition
> >   mfd: mt6397: Add bit definitions and struct members to support
> > alarm
> >     status
> >   rtc: mt6397: Fix formatting of platform driver structure
> >   rtc: mt6397: Add BBPU alarm status reset and shutdown handling
> >   arm64: dts: mediatek: mt6359: Add alarm-sta-supported property to
> > RTC
> >     node
> > 
> >  arch/arm64/boot/dts/mediatek/mt6359.dtsi |  1 +
> >  drivers/rtc/rtc-mt6397.c                 | 32
> > +++++++++++++++++++++++-
> >  include/linux/mfd/mt6397/rtc.h           |  5 +++-
> >  3 files changed, 36 insertions(+), 2 deletions(-)
> > 
> > --
> > 2.45.2
> > 
> > 
> > 
> 
> 
> My bot found new DTB warnings on the .dts files added or changed in
> this
> series.
> 
> Some warnings may be from an existing SoC .dtsi. Or perhaps the
> warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to
> reply
> unless the platform maintainer has comments.
> 
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
> 
>   pip3 install dtschema --upgrade
> 
Dir sir,
Thank you for your comment; I will check the DTS file again according
to the method you posted.

Best Regards
Shunxi Zhang

> 
> This patch series was applied (using b4) to base:
>  Base: attempting to guess base-commit...
>  Base: tags/next-20251119 (exact match)
>  Base: tags/next-20251119 (use --merge-base to override)
> 
> If this is not the correct base, please add 'base-commit' tag
> (or use b4 which does this automatically)
> 
> New warnings running 'make CHECK_DTBS=y for
> arch/arm64/boot/dts/mediatek/' for 
> 20251120121805.6775-1-ot_shunxi.zhang@mediatek.com:
> 
> arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dtb: pmic
> (mediatek,mt6359): rtc: Unevaluated properties are not allowed
> ('mediatek,alarm-sta-supported' was unexpected)
>         from schema $id: 
> https://urldefense.com/v3/__http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml__;!!CTRNKA9wMg0ARbw!nQw6Qn5fbdrGrDMcdCNFw42XaQlpDm620noZTXdteN4gm8gBgWrGRQgqriHI20DZb-6rPCLoZoG4nzBhZFlr$
> arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dtb: pmic
> (mediatek,mt6359): rtc: Unevaluated properties are not allowed
> ('mediatek,alarm-sta-supported' was unexpected)
>         from schema $id: 
> https://urldefense.com/v3/__http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml__;!!CTRNKA9wMg0ARbw!nQw6Qn5fbdrGrDMcdCNFw42XaQlpDm620noZTXdteN4gm8gBgWrGRQgqriHI20DZb-6rPCLoZoG4nzBhZFlr$
> arch/arm64/boot/dts/mediatek/mt8395-kontron-3-5-sbc-i1200.dtb: pmic
> (mediatek,mt6359): rtc: Unevaluated properties are not allowed
> ('mediatek,alarm-sta-supported' was unexpected)
>         from schema $id: 
> https://urldefense.com/v3/__http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml__;!!CTRNKA9wMg0ARbw!nQw6Qn5fbdrGrDMcdCNFw42XaQlpDm620noZTXdteN4gm8gBgWrGRQgqriHI20DZb-6rPCLoZoG4nzBhZFlr$
> arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk-ufs.dtb: pmic
> (mediatek,mt6359): rtc: Unevaluated properties are not allowed
> ('mediatek,alarm-sta-supported' was unexpected)
>         from schema $id: 
> https://urldefense.com/v3/__http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml__;!!CTRNKA9wMg0ARbw!nQw6Qn5fbdrGrDMcdCNFw42XaQlpDm620noZTXdteN4gm8gBgWrGRQgqriHI20DZb-6rPCLoZoG4nzBhZFlr$
> arch/arm64/boot/dts/mediatek/mt8188-geralt-ciri-sku4.dtb: pmic
> (mediatek,mt6359): rtc: Unevaluated properties are not allowed
> ('mediatek,alarm-sta-supported' was unexpected)
>         from schema $id: 
> https://urldefense.com/v3/__http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml__;!!CTRNKA9wMg0ARbw!nQw6Qn5fbdrGrDMcdCNFw42XaQlpDm620noZTXdteN4gm8gBgWrGRQgqriHI20DZb-6rPCLoZoG4nzBhZFlr$
> arch/arm64/boot/dts/mediatek/mt8370-genio-510-evk.dtb: pmic
> (mediatek,mt6359): rtc: Unevaluated properties are not allowed
> ('mediatek,alarm-sta-supported' was unexpected)
>         from schema $id: 
> https://urldefense.com/v3/__http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml__;!!CTRNKA9wMg0ARbw!nQw6Qn5fbdrGrDMcdCNFw42XaQlpDm620noZTXdteN4gm8gBgWrGRQgqriHI20DZb-6rPCLoZoG4nzBhZFlr$
> arch/arm64/boot/dts/mediatek/mt8188-geralt-ciri-sku1.dtb: pmic
> (mediatek,mt6359): rtc: Unevaluated properties are not allowed
> ('mediatek,alarm-sta-supported' was unexpected)
>         from schema $id: 
> https://urldefense.com/v3/__http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml__;!!CTRNKA9wMg0ARbw!nQw6Qn5fbdrGrDMcdCNFw42XaQlpDm620noZTXdteN4gm8gBgWrGRQgqriHI20DZb-6rPCLoZoG4nzBhZFlr$
> arch/arm64/boot/dts/mediatek/mt8390-genio-700-evk.dtb: pmic
> (mediatek,mt6359): rtc: Unevaluated properties are not allowed
> ('mediatek,alarm-sta-supported' was unexpected)
>         from schema $id: 
> https://urldefense.com/v3/__http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml__;!!CTRNKA9wMg0ARbw!nQw6Qn5fbdrGrDMcdCNFw42XaQlpDm620noZTXdteN4gm8gBgWrGRQgqriHI20DZb-6rPCLoZoG4nzBhZFlr$
> arch/arm64/boot/dts/mediatek/mt8195-demo.dtb: pmic (mediatek,mt6359):
> rtc: Unevaluated properties are not allowed ('mediatek,alarm-sta-
> supported' was unexpected)
>         from schema $id: 
> https://urldefense.com/v3/__http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml__;!!CTRNKA9wMg0ARbw!nQw6Qn5fbdrGrDMcdCNFw42XaQlpDm620noZTXdteN4gm8gBgWrGRQgqriHI20DZb-6rPCLoZoG4nzBhZFlr$
> arch/arm64/boot/dts/mediatek/mt8192-asurada-hayato-r1.dtb: pmic
> (mediatek,mt6359): rtc: Unevaluated properties are not allowed
> ('mediatek,alarm-sta-supported' was unexpected)
>         from schema $id: 
> https://urldefense.com/v3/__http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml__;!!CTRNKA9wMg0ARbw!nQw6Qn5fbdrGrDMcdCNFw42XaQlpDm620noZTXdteN4gm8gBgWrGRQgqriHI20DZb-6rPCLoZoG4nzBhZFlr$
> arch/arm64/boot/dts/mediatek/mt8192-asurada-spherion-r0.dtb: pmic
> (mediatek,mt6359): rtc: Unevaluated properties are not allowed
> ('mediatek,alarm-sta-supported' was unexpected)
>         from schema $id: 
> https://urldefense.com/v3/__http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml__;!!CTRNKA9wMg0ARbw!nQw6Qn5fbdrGrDMcdCNFw42XaQlpDm620noZTXdteN4gm8gBgWrGRQgqriHI20DZb-6rPCLoZoG4nzBhZFlr$
> arch/arm64/boot/dts/mediatek/mt8188-evb.dtb: pmic (mediatek,mt6359):
> rtc: Unevaluated properties are not allowed ('mediatek,alarm-sta-
> supported' was unexpected)
>         from schema $id: 
> https://urldefense.com/v3/__http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml__;!!CTRNKA9wMg0ARbw!nQw6Qn5fbdrGrDMcdCNFw42XaQlpDm620noZTXdteN4gm8gBgWrGRQgqriHI20DZb-6rPCLoZoG4nzBhZFlr$
> arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dtb: pmic
> (mediatek,mt6359): rtc: Unevaluated properties are not allowed
> ('mediatek,alarm-sta-supported' was unexpected)
>         from schema $id: 
> https://urldefense.com/v3/__http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml__;!!CTRNKA9wMg0ARbw!nQw6Qn5fbdrGrDMcdCNFw42XaQlpDm620noZTXdteN4gm8gBgWrGRQgqriHI20DZb-6rPCLoZoG4nzBhZFlr$
> arch/arm64/boot/dts/mediatek/mt8370-grinn-genio-510-sbc.dtb: pmic
> (mediatek,mt6359): rtc: Unevaluated properties are not allowed
> ('mediatek,alarm-sta-supported' was unexpected)
>         from schema $id: 
> https://urldefense.com/v3/__http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml__;!!CTRNKA9wMg0ARbw!nQw6Qn5fbdrGrDMcdCNFw42XaQlpDm620noZTXdteN4gm8gBgWrGRQgqriHI20DZb-6rPCLoZoG4nzBhZFlr$
> arch/arm64/boot/dts/mediatek/mt8188-geralt-ciri-sku7.dtb: pmic
> (mediatek,mt6359): rtc: Unevaluated properties are not allowed
> ('mediatek,alarm-sta-supported' was unexpected)
>         from schema $id: 
> https://urldefense.com/v3/__http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml__;!!CTRNKA9wMg0ARbw!nQw6Qn5fbdrGrDMcdCNFw42XaQlpDm620noZTXdteN4gm8gBgWrGRQgqriHI20DZb-6rPCLoZoG4nzBhZFlr$
> arch/arm64/boot/dts/mediatek/mt8188-geralt-ciri-sku6.dtb: pmic
> (mediatek,mt6359): rtc: Unevaluated properties are not allowed
> ('mediatek,alarm-sta-supported' was unexpected)
>         from schema $id: 
> https://urldefense.com/v3/__http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml__;!!CTRNKA9wMg0ARbw!nQw6Qn5fbdrGrDMcdCNFw42XaQlpDm620noZTXdteN4gm8gBgWrGRQgqriHI20DZb-6rPCLoZoG4nzBhZFlr$
> arch/arm64/boot/dts/mediatek/mt8188-geralt-ciri-sku3.dtb: pmic
> (mediatek,mt6359): rtc: Unevaluated properties are not allowed
> ('mediatek,alarm-sta-supported' was unexpected)
>         from schema $id: 
> https://urldefense.com/v3/__http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml__;!!CTRNKA9wMg0ARbw!nQw6Qn5fbdrGrDMcdCNFw42XaQlpDm620noZTXdteN4gm8gBgWrGRQgqriHI20DZb-6rPCLoZoG4nzBhZFlr$
> arch/arm64/boot/dts/mediatek/mt8188-geralt-ciri-sku0.dtb: pmic
> (mediatek,mt6359): rtc: Unevaluated properties are not allowed
> ('mediatek,alarm-sta-supported' was unexpected)
>         from schema $id: 
> https://urldefense.com/v3/__http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml__;!!CTRNKA9wMg0ARbw!nQw6Qn5fbdrGrDMcdCNFw42XaQlpDm620noZTXdteN4gm8gBgWrGRQgqriHI20DZb-6rPCLoZoG4nzBhZFlr$
> arch/arm64/boot/dts/mediatek/mt8390-grinn-genio-700-sbc.dtb: pmic
> (mediatek,mt6359): rtc: Unevaluated properties are not allowed
> ('mediatek,alarm-sta-supported' was unexpected)
>         from schema $id: 
> https://urldefense.com/v3/__http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml__;!!CTRNKA9wMg0ARbw!nQw6Qn5fbdrGrDMcdCNFw42XaQlpDm620noZTXdteN4gm8gBgWrGRQgqriHI20DZb-6rPCLoZoG4nzBhZFlr$
> arch/arm64/boot/dts/mediatek/mt8195-cherry-dojo-r1.dtb: pmic
> (mediatek,mt6359): rtc: Unevaluated properties are not allowed
> ('mediatek,alarm-sta-supported' was unexpected)
>         from schema $id: 
> https://urldefense.com/v3/__http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml__;!!CTRNKA9wMg0ARbw!nQw6Qn5fbdrGrDMcdCNFw42XaQlpDm620noZTXdteN4gm8gBgWrGRQgqriHI20DZb-6rPCLoZoG4nzBhZFlr$
> arch/arm64/boot/dts/mediatek/mt8192-evb.dtb: pmic (mediatek,mt6359):
> rtc: Unevaluated properties are not allowed ('mediatek,alarm-sta-
> supported' was unexpected)
>         from schema $id: 
> https://urldefense.com/v3/__http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml__;!!CTRNKA9wMg0ARbw!nQw6Qn5fbdrGrDMcdCNFw42XaQlpDm620noZTXdteN4gm8gBgWrGRQgqriHI20DZb-6rPCLoZoG4nzBhZFlr$
> arch/arm64/boot/dts/mediatek/mt8188-geralt-ciri-sku2.dtb: pmic
> (mediatek,mt6359): rtc: Unevaluated properties are not allowed
> ('mediatek,alarm-sta-supported' was unexpected)
>         from schema $id: 
> https://urldefense.com/v3/__http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml__;!!CTRNKA9wMg0ARbw!nQw6Qn5fbdrGrDMcdCNFw42XaQlpDm620noZTXdteN4gm8gBgWrGRQgqriHI20DZb-6rPCLoZoG4nzBhZFlr$
> arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dtb: pmic
> (mediatek,mt6359): rtc: Unevaluated properties are not allowed
> ('mediatek,alarm-sta-supported' was unexpected)
>         from schema $id: 
> https://urldefense.com/v3/__http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml__;!!CTRNKA9wMg0ARbw!nQw6Qn5fbdrGrDMcdCNFw42XaQlpDm620noZTXdteN4gm8gBgWrGRQgqriHI20DZb-6rPCLoZoG4nzBhZFlr$
> arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dtb: pmic
> (mediatek,mt6359): rtc: Unevaluated properties are not allowed
> ('mediatek,alarm-sta-supported' was unexpected)
>         from schema $id: 
> https://urldefense.com/v3/__http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml__;!!CTRNKA9wMg0ARbw!nQw6Qn5fbdrGrDMcdCNFw42XaQlpDm620noZTXdteN4gm8gBgWrGRQgqriHI20DZb-6rPCLoZoG4nzBhZFlr$
> arch/arm64/boot/dts/mediatek/mt8188-geralt-ciri-sku5.dtb: pmic
> (mediatek,mt6359): rtc: Unevaluated properties are not allowed
> ('mediatek,alarm-sta-supported' was unexpected)
>         from schema $id: 
> https://urldefense.com/v3/__http://devicetree.org/schemas/mfd/mediatek,mt6397.yaml__;!!CTRNKA9wMg0ARbw!nQw6Qn5fbdrGrDMcdCNFw42XaQlpDm620noZTXdteN4gm8gBgWrGRQgqriHI20DZb-6rPCLoZoG4nzBhZFlr$
> 
> 
> 
> 
>