* [PATCH 1/3] dt-bindings: ARM: samsung: Add Samsung Manta (Google Nexus 10) [not found] <20251120144018.961604-1-linux@timmermann.space> @ 2025-11-20 14:40 ` Lukas Timmermann 2025-11-21 9:04 ` Krzysztof Kozlowski 2025-11-20 14:40 ` [PATCH 2/3] ARM: dts: exynos: " Lukas Timmermann 2025-11-20 14:40 ` [PATCH 3/3] ARM: samsung: exynos5250: Allow CPU1 to boot Lukas Timmermann 2 siblings, 1 reply; 12+ messages in thread From: Lukas Timmermann @ 2025-11-20 14:40 UTC (permalink / raw) To: Krzysztof Kozlowski, Alim Akhtar, Rob Herring, Conor Dooley Cc: Alexandre Marquet, Lukas Timmermann, linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel From: Alexandre Marquet <tb@a-marquet.fr> Add the Google Nexus 10 board to documentation. Signed-off-by: Alexandre Marquet <tb@a-marquet.fr> Signed-off-by: Lukas Timmermann <linux@timmermann.space> --- .../devicetree/bindings/arm/samsung/samsung-boards.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml index f8e20e602c20..97a5a678f43c 100644 --- a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml +++ b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml @@ -120,6 +120,7 @@ properties: - google,snow-rev5 # Google Snow Rev 5+ - google,spring # Google Spring - insignal,arndale # Insignal Arndale + - samsung,nexus10-manta # Samsung Manta (Google Nexus 10) - samsung,smdk5250 # Samsung SMDK5250 eval - const: samsung,exynos5250 - const: samsung,exynos5 -- 2.52.0 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 1/3] dt-bindings: ARM: samsung: Add Samsung Manta (Google Nexus 10) 2025-11-20 14:40 ` [PATCH 1/3] dt-bindings: ARM: samsung: Add Samsung Manta (Google Nexus 10) Lukas Timmermann @ 2025-11-21 9:04 ` Krzysztof Kozlowski 2025-11-21 13:45 ` Lukas Timmermann 0 siblings, 1 reply; 12+ messages in thread From: Krzysztof Kozlowski @ 2025-11-21 9:04 UTC (permalink / raw) To: Lukas Timmermann Cc: Alim Akhtar, Rob Herring, Conor Dooley, Alexandre Marquet, linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel On Thu, Nov 20, 2025 at 03:40:14PM +0100, Lukas Timmermann wrote: > From: Alexandre Marquet <tb@a-marquet.fr> > > Add the Google Nexus 10 board to documentation. > > Signed-off-by: Alexandre Marquet <tb@a-marquet.fr> > Signed-off-by: Lukas Timmermann <linux@timmermann.space> > --- > .../devicetree/bindings/arm/samsung/samsung-boards.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml > index f8e20e602c20..97a5a678f43c 100644 > --- a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml > +++ b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml > @@ -120,6 +120,7 @@ properties: > - google,snow-rev5 # Google Snow Rev 5+ > - google,spring # Google Spring > - insignal,arndale # Insignal Arndale > + - samsung,nexus10-manta # Samsung Manta (Google Nexus 10) Google Nexus or Samsung Nexus or Samsung Manta? I am sorry, but I am 100% sure that Samsung and Google are two different companies. Google products use only google prefixes, see all other Google devices. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/3] dt-bindings: ARM: samsung: Add Samsung Manta (Google Nexus 10) 2025-11-21 9:04 ` Krzysztof Kozlowski @ 2025-11-21 13:45 ` Lukas Timmermann 2025-11-21 17:24 ` Krzysztof Kozlowski 0 siblings, 1 reply; 12+ messages in thread From: Lukas Timmermann @ 2025-11-21 13:45 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Alim Akhtar, Rob Herring, Conor Dooley, Alexandre Marquet, linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel On Fri, Nov 21, 2025 at 10:04:43AM +0100, Krzysztof Kozlowski wrote: > On Thu, Nov 20, 2025 at 03:40:14PM +0100, Lukas Timmermann wrote: > > From: Alexandre Marquet <tb@a-marquet.fr> > > > > Add the Google Nexus 10 board to documentation. > > > > Signed-off-by: Alexandre Marquet <tb@a-marquet.fr> > > Signed-off-by: Lukas Timmermann <linux@timmermann.space> > > --- > > .../devicetree/bindings/arm/samsung/samsung-boards.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml > > index f8e20e602c20..97a5a678f43c 100644 > > --- a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml > > +++ b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml > > @@ -120,6 +120,7 @@ properties: > > - google,snow-rev5 # Google Snow Rev 5+ > > - google,spring # Google Spring > > - insignal,arndale # Insignal Arndale > > + - samsung,nexus10-manta # Samsung Manta (Google Nexus 10) > > Google Nexus or Samsung Nexus or Samsung Manta? I am sorry, but I am > 100% sure that Samsung and Google are two different companies. Google > products use only google prefixes, see all other Google devices. > > Best regards, > Krzysztof > Google sold the device under it's Nexus brand. But it was built by Samsung, not just it's SoC. It's codename is "manta". Google places it in the Samsung directory instead of their own. See: https://android.googlesource.com/device/samsung/manta/ It is a Samsung board, but also a Google device. Best regards, Lukas Timmermann ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/3] dt-bindings: ARM: samsung: Add Samsung Manta (Google Nexus 10) 2025-11-21 13:45 ` Lukas Timmermann @ 2025-11-21 17:24 ` Krzysztof Kozlowski 2025-11-21 18:07 ` Lukas Timmermann 0 siblings, 1 reply; 12+ messages in thread From: Krzysztof Kozlowski @ 2025-11-21 17:24 UTC (permalink / raw) To: Lukas Timmermann Cc: Alim Akhtar, Rob Herring, Conor Dooley, Alexandre Marquet, linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel On 21/11/2025 14:45, Lukas Timmermann wrote: > On Fri, Nov 21, 2025 at 10:04:43AM +0100, Krzysztof Kozlowski wrote: >> On Thu, Nov 20, 2025 at 03:40:14PM +0100, Lukas Timmermann wrote: >>> From: Alexandre Marquet <tb@a-marquet.fr> >>> >>> Add the Google Nexus 10 board to documentation. >>> >>> Signed-off-by: Alexandre Marquet <tb@a-marquet.fr> >>> Signed-off-by: Lukas Timmermann <linux@timmermann.space> >>> --- >>> .../devicetree/bindings/arm/samsung/samsung-boards.yaml | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml >>> index f8e20e602c20..97a5a678f43c 100644 >>> --- a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml >>> +++ b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml >>> @@ -120,6 +120,7 @@ properties: >>> - google,snow-rev5 # Google Snow Rev 5+ >>> - google,spring # Google Spring >>> - insignal,arndale # Insignal Arndale >>> + - samsung,nexus10-manta # Samsung Manta (Google Nexus 10) >> >> Google Nexus or Samsung Nexus or Samsung Manta? I am sorry, but I am >> 100% sure that Samsung and Google are two different companies. Google >> products use only google prefixes, see all other Google devices. >> >> Best regards, >> Krzysztof >> > Google sold the device under it's Nexus brand. But it was built by > Samsung, not just it's SoC. It's codename is "manta". Google places it > in the Samsung directory instead of their own. > See: https://android.googlesource.com/device/samsung/manta/ > It is a Samsung board, but also a Google device. As I said, all Google end-user made by Samsung have Google names, not Samsung. Do you see there samsung,spring? Or samsung,nexus for other Nexuses? No. There is just no such thing as samsung,nexus. Never was, so you cannot use that as product. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/3] dt-bindings: ARM: samsung: Add Samsung Manta (Google Nexus 10) 2025-11-21 17:24 ` Krzysztof Kozlowski @ 2025-11-21 18:07 ` Lukas Timmermann 2025-11-21 18:10 ` Krzysztof Kozlowski 0 siblings, 1 reply; 12+ messages in thread From: Lukas Timmermann @ 2025-11-21 18:07 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Alim Akhtar, Rob Herring, Conor Dooley, Alexandre Marquet, linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel On Fri, Nov 21, 2025 at 06:24:36PM +0100, Krzysztof Kozlowski wrote: > On 21/11/2025 14:45, Lukas Timmermann wrote: > > On Fri, Nov 21, 2025 at 10:04:43AM +0100, Krzysztof Kozlowski wrote: > >> On Thu, Nov 20, 2025 at 03:40:14PM +0100, Lukas Timmermann wrote: > >>> From: Alexandre Marquet <tb@a-marquet.fr> > >>> > >>> Add the Google Nexus 10 board to documentation. > >>> > >>> Signed-off-by: Alexandre Marquet <tb@a-marquet.fr> > >>> Signed-off-by: Lukas Timmermann <linux@timmermann.space> > >>> --- > >>> .../devicetree/bindings/arm/samsung/samsung-boards.yaml | 1 + > >>> 1 file changed, 1 insertion(+) > >>> > >>> diff --git a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml > >>> index f8e20e602c20..97a5a678f43c 100644 > >>> --- a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml > >>> +++ b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml > >>> @@ -120,6 +120,7 @@ properties: > >>> - google,snow-rev5 # Google Snow Rev 5+ > >>> - google,spring # Google Spring > >>> - insignal,arndale # Insignal Arndale > >>> + - samsung,nexus10-manta # Samsung Manta (Google Nexus 10) > >> > >> Google Nexus or Samsung Nexus or Samsung Manta? I am sorry, but I am > >> 100% sure that Samsung and Google are two different companies. Google > >> products use only google prefixes, see all other Google devices. > >> > >> Best regards, > >> Krzysztof > >> > > Google sold the device under it's Nexus brand. But it was built by > > Samsung, not just it's SoC. It's codename is "manta". Google places it > > in the Samsung directory instead of their own. > > See: https://android.googlesource.com/device/samsung/manta/ > > It is a Samsung board, but also a Google device. > > As I said, all Google end-user made by Samsung have Google names, not > Samsung. Do you see there samsung,spring? Or samsung,nexus for other > Nexuses? No. > > There is just no such thing as samsung,nexus. Never was, so you cannot > use that as product. > > Best regards, > Krzysztof > I compared some Pixel and Nexus devices and now understand what you meant. So "google,manta" should be the correct name here? As seen in "google,sargo" -> Google Pixel 3a Thanks for your input. Best regards, Lukas Timmermann ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/3] dt-bindings: ARM: samsung: Add Samsung Manta (Google Nexus 10) 2025-11-21 18:07 ` Lukas Timmermann @ 2025-11-21 18:10 ` Krzysztof Kozlowski 0 siblings, 0 replies; 12+ messages in thread From: Krzysztof Kozlowski @ 2025-11-21 18:10 UTC (permalink / raw) To: Lukas Timmermann Cc: Alim Akhtar, Rob Herring, Conor Dooley, Alexandre Marquet, linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel On 21/11/2025 19:07, Lukas Timmermann wrote: > On Fri, Nov 21, 2025 at 06:24:36PM +0100, Krzysztof Kozlowski wrote: >> On 21/11/2025 14:45, Lukas Timmermann wrote: >>> On Fri, Nov 21, 2025 at 10:04:43AM +0100, Krzysztof Kozlowski wrote: >>>> On Thu, Nov 20, 2025 at 03:40:14PM +0100, Lukas Timmermann wrote: >>>>> From: Alexandre Marquet <tb@a-marquet.fr> >>>>> >>>>> Add the Google Nexus 10 board to documentation. >>>>> >>>>> Signed-off-by: Alexandre Marquet <tb@a-marquet.fr> >>>>> Signed-off-by: Lukas Timmermann <linux@timmermann.space> >>>>> --- >>>>> .../devicetree/bindings/arm/samsung/samsung-boards.yaml | 1 + >>>>> 1 file changed, 1 insertion(+) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml >>>>> index f8e20e602c20..97a5a678f43c 100644 >>>>> --- a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml >>>>> +++ b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml >>>>> @@ -120,6 +120,7 @@ properties: >>>>> - google,snow-rev5 # Google Snow Rev 5+ >>>>> - google,spring # Google Spring >>>>> - insignal,arndale # Insignal Arndale >>>>> + - samsung,nexus10-manta # Samsung Manta (Google Nexus 10) >>>> >>>> Google Nexus or Samsung Nexus or Samsung Manta? I am sorry, but I am >>>> 100% sure that Samsung and Google are two different companies. Google >>>> products use only google prefixes, see all other Google devices. >>>> >>>> Best regards, >>>> Krzysztof >>>> >>> Google sold the device under it's Nexus brand. But it was built by >>> Samsung, not just it's SoC. It's codename is "manta". Google places it >>> in the Samsung directory instead of their own. >>> See: https://android.googlesource.com/device/samsung/manta/ >>> It is a Samsung board, but also a Google device. >> >> As I said, all Google end-user made by Samsung have Google names, not >> Samsung. Do you see there samsung,spring? Or samsung,nexus for other >> Nexuses? No. >> >> There is just no such thing as samsung,nexus. Never was, so you cannot >> use that as product. >> >> Best regards, >> Krzysztof >> > I compared some Pixel and Nexus devices and now understand what you > meant. So "google,manta" should be the correct name here? > As seen in "google,sargo" -> Google Pixel 3a I don't know what is Manta. If Google calls it code name Manta, can be Manta. We use code names everywhere and it is fine. But if Google calls it only Nexus10, should be rather nexus. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 2/3] ARM: dts: exynos: Add Samsung Manta (Google Nexus 10) [not found] <20251120144018.961604-1-linux@timmermann.space> 2025-11-20 14:40 ` [PATCH 1/3] dt-bindings: ARM: samsung: Add Samsung Manta (Google Nexus 10) Lukas Timmermann @ 2025-11-20 14:40 ` Lukas Timmermann 2025-11-20 17:31 ` Henrik Grimler 2025-11-20 14:40 ` [PATCH 3/3] ARM: samsung: exynos5250: Allow CPU1 to boot Lukas Timmermann 2 siblings, 1 reply; 12+ messages in thread From: Lukas Timmermann @ 2025-11-20 14:40 UTC (permalink / raw) To: Krzysztof Kozlowski, Alim Akhtar, Rob Herring, Conor Dooley Cc: Alexandre Marquet, Lukas Timmermann, linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel From: Alexandre Marquet <tb@a-marquet.fr> Manta is the code name for Google Nexus 10, and was manufactured by Samsung. This patch adds initial device-tree file for this board. Co-developed-by: Alexandre Marquet <tb@a-marquet.fr> Signed-off-by: Alexandre Marquet <tb@a-marquet.fr> Co-developed-by: Lukas Timmermann <linux@timmermann.space> Signed-off-by: Lukas Timmermann <linux@timmermann.space> --- arch/arm/boot/dts/samsung/Makefile | 1 + .../exynos5250-samsung-nexus10-manta.dts | 516 ++++++++++++++++++ 2 files changed, 517 insertions(+) create mode 100644 arch/arm/boot/dts/samsung/exynos5250-samsung-nexus10-manta.dts diff --git a/arch/arm/boot/dts/samsung/Makefile b/arch/arm/boot/dts/samsung/Makefile index 7becf36656b1..c9cb06a8ff97 100644 --- a/arch/arm/boot/dts/samsung/Makefile +++ b/arch/arm/boot/dts/samsung/Makefile @@ -26,6 +26,7 @@ dtb-$(CONFIG_ARCH_EXYNOS4) += \ exynos4412-trats2.dtb dtb-$(CONFIG_ARCH_EXYNOS5) += \ exynos5250-arndale.dtb \ + exynos5250-samsung-nexus10-manta.dtb \ exynos5250-smdk5250.dtb \ exynos5250-snow.dtb \ exynos5250-snow-rev5.dtb \ diff --git a/arch/arm/boot/dts/samsung/exynos5250-samsung-nexus10-manta.dts b/arch/arm/boot/dts/samsung/exynos5250-samsung-nexus10-manta.dts new file mode 100644 index 000000000000..84df54941bcd --- /dev/null +++ b/arch/arm/boot/dts/samsung/exynos5250-samsung-nexus10-manta.dts @@ -0,0 +1,516 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Samsung Manta (Google Nexus 10) board device tree source + * + * Copyright (c) 2023-2025 Alexandre Marquet + * Copyright (c) 2025 Lukas Timmermann + */ + +/dts-v1/; +#include <dt-bindings/leds/common.h> +#include <dt-bindings/gpio/gpio.h> +#include <dt-bindings/clock/maxim,max77686.h> +#include <dt-bindings/input/linux-event-codes.h> +#include "exynos-pinctrl.h" +#include "exynos5250.dtsi" +#include "exynos-mfc-reserved-memory.dtsi" + +/ { + model = "Google Nexus 10"; + compatible = "samsung,nexus10-manta", "samsung,exynos5250", "samsung,exynos5"; + + aliases { + mmc0 = &mmc_0; /* eMMC */ + mmc1 = &mmc_1; /* WiFi */ + }; + + memory@40000000 { + device_type = "memory"; + reg = <0x40000000 0x20000000 + 0x60000000 0x20000000 + 0x80000000 0x20000000 + 0xa0000000 0x1FF00000>; + }; + + chosen { + stdout-path = &serial_2; + }; + + firmware@204f000 { + compatible = "samsung,secure-firmware"; + reg = <0x0204f000 0x1000>; + }; + + fixed-rate-clocks { + xxti { + compatible = "samsung,clock-xxti"; + clock-frequency = <24000000>; + }; + + xusbxti { + compatible = "samsung,clock-xusbxti"; + clock-frequency = <24000000>; + }; + }; + + gpio-keys { + compatible = "gpio-keys"; + pinctrl-names = "default"; + pinctrl-0 = <&gpio_keys>; + + key-down { + gpios = <&gpx2 1 GPIO_ACTIVE_LOW>; + linux,code = <KEY_VOLUMEDOWN>; + label = "volume down"; + debounce-interval = <5>; + }; + + key-up { + gpios = <&gpx2 0 GPIO_ACTIVE_LOW>; + linux,code = <KEY_VOLUMEUP>; + label = "volume up"; + debounce-interval = <5>; + }; + + key-power { + gpios = <&gpx2 7 GPIO_ACTIVE_LOW>; + linux,code = <KEY_POWER>; + label = "power"; + debounce-interval = <5>; + wakeup-source; + }; + + lid-switch { + label = "Lid"; + gpios = <&gpx1 3 GPIO_ACTIVE_LOW>; + linux,input-type = <5>; /* EV_SW */ + linux,code = <0>; /* SW_LID */ + debounce-interval = <10>; + wakeup-source; + }; + }; + + multi-led { + compatible = "leds-group-multicolor"; + color = <LED_COLOR_ID_RGB>; + function = LED_FUNCTION_STATUS; + leds = <&status_red>, <&status_green>, <&status_blue>, <&status_white>; + }; + + wlan_pwrseq: mmc1-pwrseq { + compatible = "mmc-pwrseq-simple"; + reset-gpios = <&gpv1 0 GPIO_ACTIVE_LOW>; + pinctrl-0 = <&wlan_pmena>; + pinctrl-names = "default"; + clocks = <&max77686 MAX77686_CLK_PMIC>; + clock-names = "ext_clock"; + post-power-on-delay-ms = <300>; + power-off-delay-us = <50>; + }; + + bmp180_vddd_reg: regulator-bmp180-vddd { + compatible = "regulator-fixed"; + regulator-name = "BMP180_VDDD"; + }; + + bmp180_vdda_reg: regulator-bmp180-vdda { + compatible = "regulator-fixed"; + regulator-name = "BMP180_VDDA"; + }; +}; + +&clock { + assigned-clocks = <&clock CLK_FOUT_APLL>; + assigned-clock-rates = <1000000000>; +}; + +&cpu0 { + cpu0-supply = <&buck2_reg>; +}; + +&ehci { + status = "disabled"; +}; + +&i2c_0 { + status = "okay"; + samsung,i2c-sda-delay = <100>; + samsung,i2c-slave-addr = <0x10>; +}; + +&i2c_1 { + status = "okay"; + + pressure@77 { + compatible = "bosch,bmp180"; + reg = <0x77>; + vddd-supply = <&bmp180_vddd_reg>; + vdda-supply = <&bmp180_vdda_reg>; + }; + + imu@68 { + compatible = "invensense,mpu6050"; + reg = <0x68>; + pinctrl-names = "default"; + pinctrl-0 = <&acc_int>; + interrupt-parent = <&gpx1>; + interrupts = <4 IRQ_TYPE_EDGE_RISING>; + mount-matrix = "0", "-1", "0", + "-1", "0", "0", + "0", "0", "-1"; + + i2c-gate { + #address-cells = <1>; + #size-cells = <0>; + + magnetometer@c { + compatible = "asahi-kasei,ak8963"; + reg = <0x0c>; + pinctrl-names = "default"; + pinctrl-0 = <&msense_rst>; + mount-matrix = "-1", "0", "0", + "0", "1", "0", + "0", "0", "-1"; + }; + }; + }; + + led-controller@42 { + compatible = "ams,as3668"; + reg = <0x42>; + #address-cells = <1>; + #size-cells = <0>; + + status_red: led@0 { + reg = <0x0>; + function = LED_FUNCTION_STATUS; + color = <LED_COLOR_ID_RED>; + }; + + status_green: led@1 { + reg = <0x1>; + function = LED_FUNCTION_STATUS; + color = <LED_COLOR_ID_GREEN>; + }; + + status_blue: led@2 { + reg = <0x2>; + function = LED_FUNCTION_STATUS; + color = <LED_COLOR_ID_BLUE>; + }; + + status_white: led@3 { + reg = <0x3>; + function = LED_FUNCTION_STATUS; + color = <LED_COLOR_ID_WHITE>; + }; + }; +}; + +&i2c_2 { + status = "okay"; + + light-sensor@23 { + compatible = "rohm,bh1721"; + reg = <0x23>; + pinctrl-names = "default"; + pinctrl-0 = <&bh1721fvc_reset>; + reset-gpios = <&gph1 2 GPIO_ACTIVE_LOW>; + }; + + onewire@18 { + compatible = "maxim,ds2484"; + reg = <0x18>; + + pinctrl-names = "default"; + pinctrl-0 = <&onewire_sleep>; + }; +}; + +&i2c_5 { + status = "okay"; + samsung,i2c-sda-delay = <100>; + + max77686: pmic@9 { + compatible = "maxim,max77686"; + reg = <0x09>; + interrupt-parent = <&gpx0>; + interrupts = <2 IRQ_TYPE_LEVEL_LOW>; + pinctrl-names = "default"; + pinctrl-0 = <&max77686_irq>; + #clock-cells = <1>; + wakeup-source; + + voltage-regulators { + ldo3_reg: LDO3 { + regulator-name = "VCC_1.8V_AP"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-always-on; + regulator-boot-on; + }; + ldo8_reg: LDO8 { + regulator-name = "VMIPI_1.0V"; + regulator-min-microvolt = <1000000>; + regulator-max-microvolt = <1000000>; + regulator-always-on; + regulator-boot-on; + }; + ldo9_reg: LDO9 { + regulator-name = "TOUCH_VDD_1.8V"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + }; + ldo10_reg: LDO10 { + regulator-name = "VMIPI_1.8V"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-always-on; + regulator-boot-on; + }; + ldo12_reg: LDO12 { + regulator-name = "VUOTG_3.0V"; + regulator-min-microvolt = <3000000>; + regulator-max-microvolt = <3000000>; + regulator-always-on; + regulator-boot-on; + }; + ldo15_reg: LDO15 { + regulator-name = "VHSIC_1.0V"; + regulator-min-microvolt = <1000000>; + regulator-max-microvolt = <1000000>; + regulator-always-on; + regulator-boot-on; + }; + ldo16_reg: LDO16 { + regulator-name = "VHSIC_1.8V"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-always-on; + regulator-boot-on; + }; + ldo17_reg: LDO17 { + regulator-name = "5M_CORE_1.5V"; + regulator-min-microvolt = <1500000>; + regulator-max-microvolt = <1500000>; + }; + ldo18_reg: LDO18 { + regulator-name = "CAM_IO_1.8V"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + }; + ldo19_reg: LDO19 { + regulator-name = "VT_CAM_1.8V"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + }; + ldo20_reg: LDO20 { + regulator-name = "TA_CHECK_1.35V"; + regulator-min-microvolt = <1350000>; + regulator-max-microvolt = <1350000>; + }; + ldo23_reg: LDO23 { + regulator-name = "TSP_AVDD_2.8V"; + regulator-min-microvolt = <2800000>; + regulator-max-microvolt = <2800000>; + }; + ldo24_reg: LDO24 { + regulator-name = "CAM_AF_2.8V"; + regulator-min-microvolt = <2800000>; + regulator-max-microvolt = <2800000>; + }; + ldo25_reg: LDO25 { + regulator-name = "VADC_3.3V"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-always-on; + regulator-boot-on; + }; + buck1_reg: BUCK1 { + regulator-name = "vdd_mif"; + regulator-min-microvolt = <850000>; + regulator-max-microvolt = <1200000>; + regulator-always-on; + regulator-boot-on; + }; + buck2_reg: BUCK2 { + regulator-name = "vdd_arm"; + regulator-min-microvolt = <850000>; + regulator-max-microvolt = <1200000>; + regulator-always-on; + regulator-boot-on; + }; + buck3_reg: BUCK3 { + regulator-name = "vdd_int"; + regulator-min-microvolt = <850000>; + regulator-max-microvolt = <1200000>; + regulator-always-on; + regulator-boot-on; + }; + buck4_reg: BUCK4 { + regulator-name = "vdd_g3d"; + regulator-min-microvolt = <850000>; + regulator-max-microvolt = <1200000>; + regulator-boot-on; + }; + }; + }; +}; + +&mali { + status = "okay"; + mali-supply = <&buck4_reg>; +}; + +&mixer { + status = "okay"; +}; + +/* eMMC */ +&mmc_0 { + status = "okay"; + non-removable; + max-frequency = <200000000>; + sd-uhs-ddr50; + mmc-ddr-1_8v; + cap-mmc-hw-reset; + mmc-hs200-1_8v; + bus-width = <8>; + card-detect-delay = <200>; + samsung,dw-mshc-ciu-div = <3>; + samsung,dw-mshc-sdr-timing = <1 2>; + samsung,dw-mshc-ddr-timing = <2 3>; + pinctrl-names = "default"; + pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8>; +}; + +/* WiFi */ +&mmc_1 { + status = "okay"; + non-removable; + max-frequency = <100000000>; + sd-uhs-sdr50; + cap-sd-highspeed; + keep-power-in-suspend; + bus-width = <4>; + card-detect-delay = <0>; + samsung,dw-mshc-ciu-div = <3>; + samsung,dw-mshc-sdr-timing = <2 4>; + samsung,dw-mshc-ddr-timing = <2 3>; + pinctrl-names = "default"; + pinctrl-0 = <&sd1_clk &sd1_cmd &sd1_bus4>; + mmc-pwrseq = <&wlan_pwrseq>; + + wifi@1 { + compatible = "brcm,bcm4330-fmac", "brcm,bcm4329-fmac"; + reg = <1>; + interrupt-parent = <&gpx2>; + interrupts = <5 IRQ_TYPE_NONE>; + interrupt-names = "host-wake"; + pinctrl-names = "default"; + pinctrl-0 = <&wlan_irq>; + }; +}; + +&ohci { + status = "disabled"; +}; + +&pinctrl_0 { + acc_int: acc-int-pins { + samsung,pins = "gpx1-4"; + samsung,pin-function = <EXYNOS_PIN_FUNC_EINT>; + samsung,pin-pud = <EXYNOS_PIN_PULL_UP>; + }; + + max77686_irq: max77686-irq-pins { + samsung,pins = "gpx0-2"; + samsung,pin-function = <EXYNOS_PIN_FUNC_F>; + samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>; + samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>; + }; + gpio_keys: gpio-keys-pins-pins { + samsung,pins = "gpx2-0", "gpx2-1", "gpx2-7", "gpx1-3"; + samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>; + }; + wlan_irq: wlan-irq-pins { + samsung,pins = "gpx2-5"; + samsung,pin-function = <EXYNOS_PIN_FUNC_INPUT>; + samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>; + samsung,pin-drv = <EXYNOS4_PIN_DRV_LV3>; + }; +}; + +&pinctrl_1 { + bh1721fvc_reset: bh1721fvc-reset-pins { + samsung,pins = "gph1-2"; + samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>; + samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>; + }; + msense_rst: msense-rst-pins { + samsung,pins = "gpg2-0"; + samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>; + }; + onewire_sleep: onewire-sleep-pins { + samsung,pins = "gpg0-0"; + samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>; + samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>; + samsung,pin-con-pdn = <EXYNOS_PIN_PDN_INPUT>; + samsung,pin-pud-pdn = <EXYNOS_PIN_PULL_NONE>; + }; +}; + +&pinctrl_2 { + wlan_pmena: wlan-pmena-pins { + samsung,pins = "gpv1-0"; + samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>; + samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>; + samsung,pin-drv = <EXYNOS4_PIN_DRV_LV3>; + samsung,pin-con-pdn = <EXYNOS_PIN_PDN_PREV>; + samsung,pin-val = <0>; + }; +}; + +&pmu_system_controller { + assigned-clocks = <&pmu_system_controller 0>; + assigned-clock-parents = <&clock CLK_FIN_PLL>; +}; + +&sd1_bus4 { + samsung,pin-con-pdn = <EXYNOS_PIN_PDN_INPUT>; + samsung,pin-pud-pdn = <EXYNOS_PIN_PULL_NONE>; +}; + +&sd1_cmd { + samsung,pin-con-pdn = <EXYNOS_PIN_PDN_INPUT>; + samsung,pin-pud-pdn = <EXYNOS_PIN_PULL_NONE>; +}; + +/* Bluetooth */ +&serial_0 { + status = "disabled"; +}; + +&serial_1 { + pinctrl-names = "default", "flow-control"; + pinctrl-0 = <&uart1_data>; + pinctrl-1 = <&uart1_data>, <&uart1_fctl>; +}; + +&serial_2 { + pinctrl-names = "default", "flow-control"; + pinctrl-0 = <&uart2_data>; + pinctrl-1 = <&uart2_data>, <&uart2_fctl>; +}; + +&usbdrd { + status = "disabled"; +}; + +&usbdrd_dwc3 { + status = "disabled"; +}; + +&usbdrd_phy { + status = "disabled"; +}; -- 2.52.0 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 2/3] ARM: dts: exynos: Add Samsung Manta (Google Nexus 10) 2025-11-20 14:40 ` [PATCH 2/3] ARM: dts: exynos: " Lukas Timmermann @ 2025-11-20 17:31 ` Henrik Grimler 2025-11-20 17:36 ` Krzysztof Kozlowski 2025-11-20 20:29 ` Lukas Timmermann 0 siblings, 2 replies; 12+ messages in thread From: Henrik Grimler @ 2025-11-20 17:31 UTC (permalink / raw) To: Lukas Timmermann Cc: Krzysztof Kozlowski, Alim Akhtar, Rob Herring, Conor Dooley, Alexandre Marquet, linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel Hi Lukas, On Thu, Nov 20, 2025 at 03:40:15PM +0100, Lukas Timmermann wrote: > From: Alexandre Marquet <tb@a-marquet.fr> > > Manta is the code name for Google Nexus 10, and was manufactured by > Samsung. This patch adds initial device-tree file for this board. > > Co-developed-by: Alexandre Marquet <tb@a-marquet.fr> > Signed-off-by: Alexandre Marquet <tb@a-marquet.fr> > Co-developed-by: Lukas Timmermann <linux@timmermann.space> > Signed-off-by: Lukas Timmermann <linux@timmermann.space> Awesome! I think this series would benefit from a cover letter explaining what features are working, and perhaps saying something about other patches that will be sent separately (if any). The as3668 led driver and bindings for example has not been merged, right? Adding the lore link in a cover letter would therefore help reviewers. One nitpick below that I happened to notice. > --- > arch/arm/boot/dts/samsung/Makefile | 1 + > .../exynos5250-samsung-nexus10-manta.dts | 516 ++++++++++++++++++ > 2 files changed, 517 insertions(+) > create mode 100644 arch/arm/boot/dts/samsung/exynos5250-samsung-nexus10-manta.dts > > diff --git a/arch/arm/boot/dts/samsung/Makefile b/arch/arm/boot/dts/samsung/Makefile > index 7becf36656b1..c9cb06a8ff97 100644 > --- a/arch/arm/boot/dts/samsung/Makefile > +++ b/arch/arm/boot/dts/samsung/Makefile > @@ -26,6 +26,7 @@ dtb-$(CONFIG_ARCH_EXYNOS4) += \ > exynos4412-trats2.dtb > dtb-$(CONFIG_ARCH_EXYNOS5) += \ > exynos5250-arndale.dtb \ > + exynos5250-samsung-nexus10-manta.dtb \ > exynos5250-smdk5250.dtb \ > exynos5250-snow.dtb \ > exynos5250-snow-rev5.dtb \ > diff --git a/arch/arm/boot/dts/samsung/exynos5250-samsung-nexus10-manta.dts b/arch/arm/boot/dts/samsung/exynos5250-samsung-nexus10-manta.dts > new file mode 100644 > index 000000000000..84df54941bcd > --- /dev/null > +++ b/arch/arm/boot/dts/samsung/exynos5250-samsung-nexus10-manta.dts > @@ -0,0 +1,516 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Samsung Manta (Google Nexus 10) board device tree source > + * > + * Copyright (c) 2023-2025 Alexandre Marquet > + * Copyright (c) 2025 Lukas Timmermann > + */ > + > +/dts-v1/; > +#include <dt-bindings/leds/common.h> > +#include <dt-bindings/gpio/gpio.h> > +#include <dt-bindings/clock/maxim,max77686.h> > +#include <dt-bindings/input/linux-event-codes.h> > +#include "exynos-pinctrl.h" > +#include "exynos5250.dtsi" > +#include "exynos-mfc-reserved-memory.dtsi" > + > +/ { > + model = "Google Nexus 10"; > + compatible = "samsung,nexus10-manta", "samsung,exynos5250", "samsung,exynos5"; > + > + aliases { > + mmc0 = &mmc_0; /* eMMC */ > + mmc1 = &mmc_1; /* WiFi */ > + }; > + > + memory@40000000 { > + device_type = "memory"; > + reg = <0x40000000 0x20000000 > + 0x60000000 0x20000000 > + 0x80000000 0x20000000 > + 0xa0000000 0x1FF00000>; Please use lower case letters, 0x1ff00000. Best regards, Henrik Grimler > + }; > + > + chosen { > + stdout-path = &serial_2; > + }; > + > + firmware@204f000 { > + compatible = "samsung,secure-firmware"; > + reg = <0x0204f000 0x1000>; > + }; > + > + fixed-rate-clocks { > + xxti { > + compatible = "samsung,clock-xxti"; > + clock-frequency = <24000000>; > + }; > + > + xusbxti { > + compatible = "samsung,clock-xusbxti"; > + clock-frequency = <24000000>; > + }; > + }; > + > + gpio-keys { > + compatible = "gpio-keys"; > + pinctrl-names = "default"; > + pinctrl-0 = <&gpio_keys>; > + > + key-down { > + gpios = <&gpx2 1 GPIO_ACTIVE_LOW>; > + linux,code = <KEY_VOLUMEDOWN>; > + label = "volume down"; > + debounce-interval = <5>; > + }; > + > + key-up { > + gpios = <&gpx2 0 GPIO_ACTIVE_LOW>; > + linux,code = <KEY_VOLUMEUP>; > + label = "volume up"; > + debounce-interval = <5>; > + }; > + > + key-power { > + gpios = <&gpx2 7 GPIO_ACTIVE_LOW>; > + linux,code = <KEY_POWER>; > + label = "power"; > + debounce-interval = <5>; > + wakeup-source; > + }; > + > + lid-switch { > + label = "Lid"; > + gpios = <&gpx1 3 GPIO_ACTIVE_LOW>; > + linux,input-type = <5>; /* EV_SW */ > + linux,code = <0>; /* SW_LID */ > + debounce-interval = <10>; > + wakeup-source; > + }; > + }; > + > + multi-led { > + compatible = "leds-group-multicolor"; > + color = <LED_COLOR_ID_RGB>; > + function = LED_FUNCTION_STATUS; > + leds = <&status_red>, <&status_green>, <&status_blue>, <&status_white>; > + }; > + > + wlan_pwrseq: mmc1-pwrseq { > + compatible = "mmc-pwrseq-simple"; > + reset-gpios = <&gpv1 0 GPIO_ACTIVE_LOW>; > + pinctrl-0 = <&wlan_pmena>; > + pinctrl-names = "default"; > + clocks = <&max77686 MAX77686_CLK_PMIC>; > + clock-names = "ext_clock"; > + post-power-on-delay-ms = <300>; > + power-off-delay-us = <50>; > + }; > + > + bmp180_vddd_reg: regulator-bmp180-vddd { > + compatible = "regulator-fixed"; > + regulator-name = "BMP180_VDDD"; > + }; > + > + bmp180_vdda_reg: regulator-bmp180-vdda { > + compatible = "regulator-fixed"; > + regulator-name = "BMP180_VDDA"; > + }; > +}; > + > +&clock { > + assigned-clocks = <&clock CLK_FOUT_APLL>; > + assigned-clock-rates = <1000000000>; > +}; > + > +&cpu0 { > + cpu0-supply = <&buck2_reg>; > +}; > + > +&ehci { > + status = "disabled"; > +}; > + > +&i2c_0 { > + status = "okay"; > + samsung,i2c-sda-delay = <100>; > + samsung,i2c-slave-addr = <0x10>; > +}; > + > +&i2c_1 { > + status = "okay"; > + > + pressure@77 { > + compatible = "bosch,bmp180"; > + reg = <0x77>; > + vddd-supply = <&bmp180_vddd_reg>; > + vdda-supply = <&bmp180_vdda_reg>; > + }; > + > + imu@68 { > + compatible = "invensense,mpu6050"; > + reg = <0x68>; > + pinctrl-names = "default"; > + pinctrl-0 = <&acc_int>; > + interrupt-parent = <&gpx1>; > + interrupts = <4 IRQ_TYPE_EDGE_RISING>; > + mount-matrix = "0", "-1", "0", > + "-1", "0", "0", > + "0", "0", "-1"; > + > + i2c-gate { > + #address-cells = <1>; > + #size-cells = <0>; > + > + magnetometer@c { > + compatible = "asahi-kasei,ak8963"; > + reg = <0x0c>; > + pinctrl-names = "default"; > + pinctrl-0 = <&msense_rst>; > + mount-matrix = "-1", "0", "0", > + "0", "1", "0", > + "0", "0", "-1"; > + }; > + }; > + }; > + > + led-controller@42 { > + compatible = "ams,as3668"; > + reg = <0x42>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + status_red: led@0 { > + reg = <0x0>; > + function = LED_FUNCTION_STATUS; > + color = <LED_COLOR_ID_RED>; > + }; > + > + status_green: led@1 { > + reg = <0x1>; > + function = LED_FUNCTION_STATUS; > + color = <LED_COLOR_ID_GREEN>; > + }; > + > + status_blue: led@2 { > + reg = <0x2>; > + function = LED_FUNCTION_STATUS; > + color = <LED_COLOR_ID_BLUE>; > + }; > + > + status_white: led@3 { > + reg = <0x3>; > + function = LED_FUNCTION_STATUS; > + color = <LED_COLOR_ID_WHITE>; > + }; > + }; > +}; > + > +&i2c_2 { > + status = "okay"; > + > + light-sensor@23 { > + compatible = "rohm,bh1721"; > + reg = <0x23>; > + pinctrl-names = "default"; > + pinctrl-0 = <&bh1721fvc_reset>; > + reset-gpios = <&gph1 2 GPIO_ACTIVE_LOW>; > + }; > + > + onewire@18 { > + compatible = "maxim,ds2484"; > + reg = <0x18>; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&onewire_sleep>; > + }; > +}; > + > +&i2c_5 { > + status = "okay"; > + samsung,i2c-sda-delay = <100>; > + > + max77686: pmic@9 { > + compatible = "maxim,max77686"; > + reg = <0x09>; > + interrupt-parent = <&gpx0>; > + interrupts = <2 IRQ_TYPE_LEVEL_LOW>; > + pinctrl-names = "default"; > + pinctrl-0 = <&max77686_irq>; > + #clock-cells = <1>; > + wakeup-source; > + > + voltage-regulators { > + ldo3_reg: LDO3 { > + regulator-name = "VCC_1.8V_AP"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-always-on; > + regulator-boot-on; > + }; > + ldo8_reg: LDO8 { > + regulator-name = "VMIPI_1.0V"; > + regulator-min-microvolt = <1000000>; > + regulator-max-microvolt = <1000000>; > + regulator-always-on; > + regulator-boot-on; > + }; > + ldo9_reg: LDO9 { > + regulator-name = "TOUCH_VDD_1.8V"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + }; > + ldo10_reg: LDO10 { > + regulator-name = "VMIPI_1.8V"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-always-on; > + regulator-boot-on; > + }; > + ldo12_reg: LDO12 { > + regulator-name = "VUOTG_3.0V"; > + regulator-min-microvolt = <3000000>; > + regulator-max-microvolt = <3000000>; > + regulator-always-on; > + regulator-boot-on; > + }; > + ldo15_reg: LDO15 { > + regulator-name = "VHSIC_1.0V"; > + regulator-min-microvolt = <1000000>; > + regulator-max-microvolt = <1000000>; > + regulator-always-on; > + regulator-boot-on; > + }; > + ldo16_reg: LDO16 { > + regulator-name = "VHSIC_1.8V"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-always-on; > + regulator-boot-on; > + }; > + ldo17_reg: LDO17 { > + regulator-name = "5M_CORE_1.5V"; > + regulator-min-microvolt = <1500000>; > + regulator-max-microvolt = <1500000>; > + }; > + ldo18_reg: LDO18 { > + regulator-name = "CAM_IO_1.8V"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + }; > + ldo19_reg: LDO19 { > + regulator-name = "VT_CAM_1.8V"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + }; > + ldo20_reg: LDO20 { > + regulator-name = "TA_CHECK_1.35V"; > + regulator-min-microvolt = <1350000>; > + regulator-max-microvolt = <1350000>; > + }; > + ldo23_reg: LDO23 { > + regulator-name = "TSP_AVDD_2.8V"; > + regulator-min-microvolt = <2800000>; > + regulator-max-microvolt = <2800000>; > + }; > + ldo24_reg: LDO24 { > + regulator-name = "CAM_AF_2.8V"; > + regulator-min-microvolt = <2800000>; > + regulator-max-microvolt = <2800000>; > + }; > + ldo25_reg: LDO25 { > + regulator-name = "VADC_3.3V"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-always-on; > + regulator-boot-on; > + }; > + buck1_reg: BUCK1 { > + regulator-name = "vdd_mif"; > + regulator-min-microvolt = <850000>; > + regulator-max-microvolt = <1200000>; > + regulator-always-on; > + regulator-boot-on; > + }; > + buck2_reg: BUCK2 { > + regulator-name = "vdd_arm"; > + regulator-min-microvolt = <850000>; > + regulator-max-microvolt = <1200000>; > + regulator-always-on; > + regulator-boot-on; > + }; > + buck3_reg: BUCK3 { > + regulator-name = "vdd_int"; > + regulator-min-microvolt = <850000>; > + regulator-max-microvolt = <1200000>; > + regulator-always-on; > + regulator-boot-on; > + }; > + buck4_reg: BUCK4 { > + regulator-name = "vdd_g3d"; > + regulator-min-microvolt = <850000>; > + regulator-max-microvolt = <1200000>; > + regulator-boot-on; > + }; > + }; > + }; > +}; > + > +&mali { > + status = "okay"; > + mali-supply = <&buck4_reg>; > +}; > + > +&mixer { > + status = "okay"; > +}; > + > +/* eMMC */ > +&mmc_0 { > + status = "okay"; > + non-removable; > + max-frequency = <200000000>; > + sd-uhs-ddr50; > + mmc-ddr-1_8v; > + cap-mmc-hw-reset; > + mmc-hs200-1_8v; > + bus-width = <8>; > + card-detect-delay = <200>; > + samsung,dw-mshc-ciu-div = <3>; > + samsung,dw-mshc-sdr-timing = <1 2>; > + samsung,dw-mshc-ddr-timing = <2 3>; > + pinctrl-names = "default"; > + pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8>; > +}; > + > +/* WiFi */ > +&mmc_1 { > + status = "okay"; > + non-removable; > + max-frequency = <100000000>; > + sd-uhs-sdr50; > + cap-sd-highspeed; > + keep-power-in-suspend; > + bus-width = <4>; > + card-detect-delay = <0>; > + samsung,dw-mshc-ciu-div = <3>; > + samsung,dw-mshc-sdr-timing = <2 4>; > + samsung,dw-mshc-ddr-timing = <2 3>; > + pinctrl-names = "default"; > + pinctrl-0 = <&sd1_clk &sd1_cmd &sd1_bus4>; > + mmc-pwrseq = <&wlan_pwrseq>; > + > + wifi@1 { > + compatible = "brcm,bcm4330-fmac", "brcm,bcm4329-fmac"; > + reg = <1>; > + interrupt-parent = <&gpx2>; > + interrupts = <5 IRQ_TYPE_NONE>; > + interrupt-names = "host-wake"; > + pinctrl-names = "default"; > + pinctrl-0 = <&wlan_irq>; > + }; > +}; > + > +&ohci { > + status = "disabled"; > +}; > + > +&pinctrl_0 { > + acc_int: acc-int-pins { > + samsung,pins = "gpx1-4"; > + samsung,pin-function = <EXYNOS_PIN_FUNC_EINT>; > + samsung,pin-pud = <EXYNOS_PIN_PULL_UP>; > + }; > + > + max77686_irq: max77686-irq-pins { > + samsung,pins = "gpx0-2"; > + samsung,pin-function = <EXYNOS_PIN_FUNC_F>; > + samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>; > + samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>; > + }; > + gpio_keys: gpio-keys-pins-pins { > + samsung,pins = "gpx2-0", "gpx2-1", "gpx2-7", "gpx1-3"; > + samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>; > + }; > + wlan_irq: wlan-irq-pins { > + samsung,pins = "gpx2-5"; > + samsung,pin-function = <EXYNOS_PIN_FUNC_INPUT>; > + samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>; > + samsung,pin-drv = <EXYNOS4_PIN_DRV_LV3>; > + }; > +}; > + > +&pinctrl_1 { > + bh1721fvc_reset: bh1721fvc-reset-pins { > + samsung,pins = "gph1-2"; > + samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>; > + samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>; > + }; > + msense_rst: msense-rst-pins { > + samsung,pins = "gpg2-0"; > + samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>; > + }; > + onewire_sleep: onewire-sleep-pins { > + samsung,pins = "gpg0-0"; > + samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>; > + samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>; > + samsung,pin-con-pdn = <EXYNOS_PIN_PDN_INPUT>; > + samsung,pin-pud-pdn = <EXYNOS_PIN_PULL_NONE>; > + }; > +}; > + > +&pinctrl_2 { > + wlan_pmena: wlan-pmena-pins { > + samsung,pins = "gpv1-0"; > + samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>; > + samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>; > + samsung,pin-drv = <EXYNOS4_PIN_DRV_LV3>; > + samsung,pin-con-pdn = <EXYNOS_PIN_PDN_PREV>; > + samsung,pin-val = <0>; > + }; > +}; > + > +&pmu_system_controller { > + assigned-clocks = <&pmu_system_controller 0>; > + assigned-clock-parents = <&clock CLK_FIN_PLL>; > +}; > + > +&sd1_bus4 { > + samsung,pin-con-pdn = <EXYNOS_PIN_PDN_INPUT>; > + samsung,pin-pud-pdn = <EXYNOS_PIN_PULL_NONE>; > +}; > + > +&sd1_cmd { > + samsung,pin-con-pdn = <EXYNOS_PIN_PDN_INPUT>; > + samsung,pin-pud-pdn = <EXYNOS_PIN_PULL_NONE>; > +}; > + > +/* Bluetooth */ > +&serial_0 { > + status = "disabled"; > +}; > + > +&serial_1 { > + pinctrl-names = "default", "flow-control"; > + pinctrl-0 = <&uart1_data>; > + pinctrl-1 = <&uart1_data>, <&uart1_fctl>; > +}; > + > +&serial_2 { > + pinctrl-names = "default", "flow-control"; > + pinctrl-0 = <&uart2_data>; > + pinctrl-1 = <&uart2_data>, <&uart2_fctl>; > +}; > + > +&usbdrd { > + status = "disabled"; > +}; > + > +&usbdrd_dwc3 { > + status = "disabled"; > +}; > + > +&usbdrd_phy { > + status = "disabled"; > +}; > -- > 2.52.0 > > ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/3] ARM: dts: exynos: Add Samsung Manta (Google Nexus 10) 2025-11-20 17:31 ` Henrik Grimler @ 2025-11-20 17:36 ` Krzysztof Kozlowski 2025-11-20 20:27 ` Lukas Timmermann 2025-11-20 20:29 ` Lukas Timmermann 1 sibling, 1 reply; 12+ messages in thread From: Krzysztof Kozlowski @ 2025-11-20 17:36 UTC (permalink / raw) To: Henrik Grimler, Lukas Timmermann Cc: Alim Akhtar, Rob Herring, Conor Dooley, Alexandre Marquet, linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel On 20/11/2025 18:31, Henrik Grimler wrote: > Hi Lukas, > > On Thu, Nov 20, 2025 at 03:40:15PM +0100, Lukas Timmermann wrote: >> From: Alexandre Marquet <tb@a-marquet.fr> >> >> Manta is the code name for Google Nexus 10, and was manufactured by >> Samsung. This patch adds initial device-tree file for this board. >> >> Co-developed-by: Alexandre Marquet <tb@a-marquet.fr> >> Signed-off-by: Alexandre Marquet <tb@a-marquet.fr> >> Co-developed-by: Lukas Timmermann <linux@timmermann.space> >> Signed-off-by: Lukas Timmermann <linux@timmermann.space> > > Awesome! I think this series would benefit from a cover letter > explaining what features are working, and perhaps saying something > about other patches that will be sent separately (if any). The as3668 > led driver and bindings for example has not been merged, right? Adding > the lore link in a cover letter would therefore help reviewers. If "not merged" in the meaning of not taken by maintainer for next, then this is quite important because it not only blocks this patch but would cause failures in CI leading me to being grumpy. Samsung SoC follows maintainer-soc-clean-dts profile. Please always explicitly document such stuff (bindings in fly). Best regards, Krzysztof ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/3] ARM: dts: exynos: Add Samsung Manta (Google Nexus 10) 2025-11-20 17:36 ` Krzysztof Kozlowski @ 2025-11-20 20:27 ` Lukas Timmermann 0 siblings, 0 replies; 12+ messages in thread From: Lukas Timmermann @ 2025-11-20 20:27 UTC (permalink / raw) To: Krzysztof Kozlowski, Henrik Grimler Cc: Alim Akhtar, Rob Herring, Conor Dooley, Alexandre Marquet, linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel On Thu, Nov 20, 2025 at 06:36:29PM +0100, Krzysztof Kozlowski wrote: > On 20/11/2025 18:31, Henrik Grimler wrote: > > Hi Lukas, > > > > On Thu, Nov 20, 2025 at 03:40:15PM +0100, Lukas Timmermann wrote: > >> From: Alexandre Marquet <tb@a-marquet.fr> > >> > >> Manta is the code name for Google Nexus 10, and was manufactured by > >> Samsung. This patch adds initial device-tree file for this board. > >> > >> Co-developed-by: Alexandre Marquet <tb@a-marquet.fr> > >> Signed-off-by: Alexandre Marquet <tb@a-marquet.fr> > >> Co-developed-by: Lukas Timmermann <linux@timmermann.space> > >> Signed-off-by: Lukas Timmermann <linux@timmermann.space> > > > > Awesome! I think this series would benefit from a cover letter > > explaining what features are working, and perhaps saying something > > about other patches that will be sent separately (if any). The as3668 > > led driver and bindings for example has not been merged, right? Adding > > the lore link in a cover letter would therefore help reviewers. > > If "not merged" in the meaning of not taken by maintainer for next, then > this is quite important because it not only blocks this patch but would > cause failures in CI leading me to being grumpy. > > Samsung SoC follows maintainer-soc-clean-dts profile. Please always > explicitly document such stuff (bindings in fly). > > Best regards, > Krzysztof > I just noticed, that my cover letter did not get send to the mailing. That was unintentional. In there, I wrote that this patch depends on an earlier patch which still needs some work. Should I also add that to the individual patch in future mails? I'm still quite new to the mailing list workflow. I'm sorry for any misunderstandings. Best regards, Lukas Timmermann ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/3] ARM: dts: exynos: Add Samsung Manta (Google Nexus 10) 2025-11-20 17:31 ` Henrik Grimler 2025-11-20 17:36 ` Krzysztof Kozlowski @ 2025-11-20 20:29 ` Lukas Timmermann 1 sibling, 0 replies; 12+ messages in thread From: Lukas Timmermann @ 2025-11-20 20:29 UTC (permalink / raw) To: Henrik Grimler Cc: Krzysztof Kozlowski, Alim Akhtar, Rob Herring, Conor Dooley, Alexandre Marquet, linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel On Thu, Nov 20, 2025 at 06:31:20PM +0100, Henrik Grimler wrote: > Hi Lukas, > > On Thu, Nov 20, 2025 at 03:40:15PM +0100, Lukas Timmermann wrote: > > From: Alexandre Marquet <tb@a-marquet.fr> > > > > Manta is the code name for Google Nexus 10, and was manufactured by > > Samsung. This patch adds initial device-tree file for this board. > > > > Co-developed-by: Alexandre Marquet <tb@a-marquet.fr> > > Signed-off-by: Alexandre Marquet <tb@a-marquet.fr> > > Co-developed-by: Lukas Timmermann <linux@timmermann.space> > > Signed-off-by: Lukas Timmermann <linux@timmermann.space> > > Awesome! I think this series would benefit from a cover letter > explaining what features are working, and perhaps saying something > about other patches that will be sent separately (if any). The as3668 > led driver and bindings for example has not been merged, right? Adding > the lore link in a cover letter would therefore help reviewers. > I sent the cover letter just now. There was a mistake on my side. Sorry. > One nitpick below that I happened to notice. > > > --- > > arch/arm/boot/dts/samsung/Makefile | 1 + > > .../exynos5250-samsung-nexus10-manta.dts | 516 ++++++++++++++++++ > > 2 files changed, 517 insertions(+) > > create mode 100644 arch/arm/boot/dts/samsung/exynos5250-samsung-nexus10-manta.dts > > > > diff --git a/arch/arm/boot/dts/samsung/Makefile b/arch/arm/boot/dts/samsung/Makefile > > index 7becf36656b1..c9cb06a8ff97 100644 > > --- a/arch/arm/boot/dts/samsung/Makefile > > +++ b/arch/arm/boot/dts/samsung/Makefile > > @@ -26,6 +26,7 @@ dtb-$(CONFIG_ARCH_EXYNOS4) += \ > > exynos4412-trats2.dtb > > dtb-$(CONFIG_ARCH_EXYNOS5) += \ > > exynos5250-arndale.dtb \ > > + exynos5250-samsung-nexus10-manta.dtb \ > > exynos5250-smdk5250.dtb \ > > exynos5250-snow.dtb \ > > exynos5250-snow-rev5.dtb \ > > diff --git a/arch/arm/boot/dts/samsung/exynos5250-samsung-nexus10-manta.dts b/arch/arm/boot/dts/samsung/exynos5250-samsung-nexus10-manta.dts > > new file mode 100644 > > index 000000000000..84df54941bcd > > --- /dev/null > > +++ b/arch/arm/boot/dts/samsung/exynos5250-samsung-nexus10-manta.dts > > @@ -0,0 +1,516 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Samsung Manta (Google Nexus 10) board device tree source > > + * > > + * Copyright (c) 2023-2025 Alexandre Marquet > > + * Copyright (c) 2025 Lukas Timmermann > > + */ > > + > > +/dts-v1/; > > +#include <dt-bindings/leds/common.h> > > +#include <dt-bindings/gpio/gpio.h> > > +#include <dt-bindings/clock/maxim,max77686.h> > > +#include <dt-bindings/input/linux-event-codes.h> > > +#include "exynos-pinctrl.h" > > +#include "exynos5250.dtsi" > > +#include "exynos-mfc-reserved-memory.dtsi" > > + > > +/ { > > + model = "Google Nexus 10"; > > + compatible = "samsung,nexus10-manta", "samsung,exynos5250", "samsung,exynos5"; > > + > > + aliases { > > + mmc0 = &mmc_0; /* eMMC */ > > + mmc1 = &mmc_1; /* WiFi */ > > + }; > > + > > + memory@40000000 { > > + device_type = "memory"; > > + reg = <0x40000000 0x20000000 > > + 0x60000000 0x20000000 > > + 0x80000000 0x20000000 > > + 0xa0000000 0x1FF00000>; > > Please use lower case letters, 0x1ff00000. > > Best regards, > Henrik Grimler > Thanks. I will fix that. Best regards, Lukas Timmermann > > + }; > > + > > + chosen { > > + stdout-path = &serial_2; > > + }; > > + > > + firmware@204f000 { > > + compatible = "samsung,secure-firmware"; > > + reg = <0x0204f000 0x1000>; > > + }; > > + > > + fixed-rate-clocks { > > + xxti { > > + compatible = "samsung,clock-xxti"; > > + clock-frequency = <24000000>; > > + }; > > + > > + xusbxti { > > + compatible = "samsung,clock-xusbxti"; > > + clock-frequency = <24000000>; > > + }; > > + }; > > + > > + gpio-keys { > > + compatible = "gpio-keys"; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&gpio_keys>; > > + > > + key-down { > > + gpios = <&gpx2 1 GPIO_ACTIVE_LOW>; > > + linux,code = <KEY_VOLUMEDOWN>; > > + label = "volume down"; > > + debounce-interval = <5>; > > + }; > > + > > + key-up { > > + gpios = <&gpx2 0 GPIO_ACTIVE_LOW>; > > + linux,code = <KEY_VOLUMEUP>; > > + label = "volume up"; > > + debounce-interval = <5>; > > + }; > > + > > + key-power { > > + gpios = <&gpx2 7 GPIO_ACTIVE_LOW>; > > + linux,code = <KEY_POWER>; > > + label = "power"; > > + debounce-interval = <5>; > > + wakeup-source; > > + }; > > + > > + lid-switch { > > + label = "Lid"; > > + gpios = <&gpx1 3 GPIO_ACTIVE_LOW>; > > + linux,input-type = <5>; /* EV_SW */ > > + linux,code = <0>; /* SW_LID */ > > + debounce-interval = <10>; > > + wakeup-source; > > + }; > > + }; > > + > > + multi-led { > > + compatible = "leds-group-multicolor"; > > + color = <LED_COLOR_ID_RGB>; > > + function = LED_FUNCTION_STATUS; > > + leds = <&status_red>, <&status_green>, <&status_blue>, <&status_white>; > > + }; > > + > > + wlan_pwrseq: mmc1-pwrseq { > > + compatible = "mmc-pwrseq-simple"; > > + reset-gpios = <&gpv1 0 GPIO_ACTIVE_LOW>; > > + pinctrl-0 = <&wlan_pmena>; > > + pinctrl-names = "default"; > > + clocks = <&max77686 MAX77686_CLK_PMIC>; > > + clock-names = "ext_clock"; > > + post-power-on-delay-ms = <300>; > > + power-off-delay-us = <50>; > > + }; > > + > > + bmp180_vddd_reg: regulator-bmp180-vddd { > > + compatible = "regulator-fixed"; > > + regulator-name = "BMP180_VDDD"; > > + }; > > + > > + bmp180_vdda_reg: regulator-bmp180-vdda { > > + compatible = "regulator-fixed"; > > + regulator-name = "BMP180_VDDA"; > > + }; > > +}; > > + > > +&clock { > > + assigned-clocks = <&clock CLK_FOUT_APLL>; > > + assigned-clock-rates = <1000000000>; > > +}; > > + > > +&cpu0 { > > + cpu0-supply = <&buck2_reg>; > > +}; > > + > > +&ehci { > > + status = "disabled"; > > +}; > > + > > +&i2c_0 { > > + status = "okay"; > > + samsung,i2c-sda-delay = <100>; > > + samsung,i2c-slave-addr = <0x10>; > > +}; > > + > > +&i2c_1 { > > + status = "okay"; > > + > > + pressure@77 { > > + compatible = "bosch,bmp180"; > > + reg = <0x77>; > > + vddd-supply = <&bmp180_vddd_reg>; > > + vdda-supply = <&bmp180_vdda_reg>; > > + }; > > + > > + imu@68 { > > + compatible = "invensense,mpu6050"; > > + reg = <0x68>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&acc_int>; > > + interrupt-parent = <&gpx1>; > > + interrupts = <4 IRQ_TYPE_EDGE_RISING>; > > + mount-matrix = "0", "-1", "0", > > + "-1", "0", "0", > > + "0", "0", "-1"; > > + > > + i2c-gate { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + magnetometer@c { > > + compatible = "asahi-kasei,ak8963"; > > + reg = <0x0c>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&msense_rst>; > > + mount-matrix = "-1", "0", "0", > > + "0", "1", "0", > > + "0", "0", "-1"; > > + }; > > + }; > > + }; > > + > > + led-controller@42 { > > + compatible = "ams,as3668"; > > + reg = <0x42>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + status_red: led@0 { > > + reg = <0x0>; > > + function = LED_FUNCTION_STATUS; > > + color = <LED_COLOR_ID_RED>; > > + }; > > + > > + status_green: led@1 { > > + reg = <0x1>; > > + function = LED_FUNCTION_STATUS; > > + color = <LED_COLOR_ID_GREEN>; > > + }; > > + > > + status_blue: led@2 { > > + reg = <0x2>; > > + function = LED_FUNCTION_STATUS; > > + color = <LED_COLOR_ID_BLUE>; > > + }; > > + > > + status_white: led@3 { > > + reg = <0x3>; > > + function = LED_FUNCTION_STATUS; > > + color = <LED_COLOR_ID_WHITE>; > > + }; > > + }; > > +}; > > + > > +&i2c_2 { > > + status = "okay"; > > + > > + light-sensor@23 { > > + compatible = "rohm,bh1721"; > > + reg = <0x23>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&bh1721fvc_reset>; > > + reset-gpios = <&gph1 2 GPIO_ACTIVE_LOW>; > > + }; > > + > > + onewire@18 { > > + compatible = "maxim,ds2484"; > > + reg = <0x18>; > > + > > + pinctrl-names = "default"; > > + pinctrl-0 = <&onewire_sleep>; > > + }; > > +}; > > + > > +&i2c_5 { > > + status = "okay"; > > + samsung,i2c-sda-delay = <100>; > > + > > + max77686: pmic@9 { > > + compatible = "maxim,max77686"; > > + reg = <0x09>; > > + interrupt-parent = <&gpx0>; > > + interrupts = <2 IRQ_TYPE_LEVEL_LOW>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&max77686_irq>; > > + #clock-cells = <1>; > > + wakeup-source; > > + > > + voltage-regulators { > > + ldo3_reg: LDO3 { > > + regulator-name = "VCC_1.8V_AP"; > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <1800000>; > > + regulator-always-on; > > + regulator-boot-on; > > + }; > > + ldo8_reg: LDO8 { > > + regulator-name = "VMIPI_1.0V"; > > + regulator-min-microvolt = <1000000>; > > + regulator-max-microvolt = <1000000>; > > + regulator-always-on; > > + regulator-boot-on; > > + }; > > + ldo9_reg: LDO9 { > > + regulator-name = "TOUCH_VDD_1.8V"; > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <1800000>; > > + }; > > + ldo10_reg: LDO10 { > > + regulator-name = "VMIPI_1.8V"; > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <1800000>; > > + regulator-always-on; > > + regulator-boot-on; > > + }; > > + ldo12_reg: LDO12 { > > + regulator-name = "VUOTG_3.0V"; > > + regulator-min-microvolt = <3000000>; > > + regulator-max-microvolt = <3000000>; > > + regulator-always-on; > > + regulator-boot-on; > > + }; > > + ldo15_reg: LDO15 { > > + regulator-name = "VHSIC_1.0V"; > > + regulator-min-microvolt = <1000000>; > > + regulator-max-microvolt = <1000000>; > > + regulator-always-on; > > + regulator-boot-on; > > + }; > > + ldo16_reg: LDO16 { > > + regulator-name = "VHSIC_1.8V"; > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <1800000>; > > + regulator-always-on; > > + regulator-boot-on; > > + }; > > + ldo17_reg: LDO17 { > > + regulator-name = "5M_CORE_1.5V"; > > + regulator-min-microvolt = <1500000>; > > + regulator-max-microvolt = <1500000>; > > + }; > > + ldo18_reg: LDO18 { > > + regulator-name = "CAM_IO_1.8V"; > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <1800000>; > > + }; > > + ldo19_reg: LDO19 { > > + regulator-name = "VT_CAM_1.8V"; > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <1800000>; > > + }; > > + ldo20_reg: LDO20 { > > + regulator-name = "TA_CHECK_1.35V"; > > + regulator-min-microvolt = <1350000>; > > + regulator-max-microvolt = <1350000>; > > + }; > > + ldo23_reg: LDO23 { > > + regulator-name = "TSP_AVDD_2.8V"; > > + regulator-min-microvolt = <2800000>; > > + regulator-max-microvolt = <2800000>; > > + }; > > + ldo24_reg: LDO24 { > > + regulator-name = "CAM_AF_2.8V"; > > + regulator-min-microvolt = <2800000>; > > + regulator-max-microvolt = <2800000>; > > + }; > > + ldo25_reg: LDO25 { > > + regulator-name = "VADC_3.3V"; > > + regulator-min-microvolt = <3300000>; > > + regulator-max-microvolt = <3300000>; > > + regulator-always-on; > > + regulator-boot-on; > > + }; > > + buck1_reg: BUCK1 { > > + regulator-name = "vdd_mif"; > > + regulator-min-microvolt = <850000>; > > + regulator-max-microvolt = <1200000>; > > + regulator-always-on; > > + regulator-boot-on; > > + }; > > + buck2_reg: BUCK2 { > > + regulator-name = "vdd_arm"; > > + regulator-min-microvolt = <850000>; > > + regulator-max-microvolt = <1200000>; > > + regulator-always-on; > > + regulator-boot-on; > > + }; > > + buck3_reg: BUCK3 { > > + regulator-name = "vdd_int"; > > + regulator-min-microvolt = <850000>; > > + regulator-max-microvolt = <1200000>; > > + regulator-always-on; > > + regulator-boot-on; > > + }; > > + buck4_reg: BUCK4 { > > + regulator-name = "vdd_g3d"; > > + regulator-min-microvolt = <850000>; > > + regulator-max-microvolt = <1200000>; > > + regulator-boot-on; > > + }; > > + }; > > + }; > > +}; > > + > > +&mali { > > + status = "okay"; > > + mali-supply = <&buck4_reg>; > > +}; > > + > > +&mixer { > > + status = "okay"; > > +}; > > + > > +/* eMMC */ > > +&mmc_0 { > > + status = "okay"; > > + non-removable; > > + max-frequency = <200000000>; > > + sd-uhs-ddr50; > > + mmc-ddr-1_8v; > > + cap-mmc-hw-reset; > > + mmc-hs200-1_8v; > > + bus-width = <8>; > > + card-detect-delay = <200>; > > + samsung,dw-mshc-ciu-div = <3>; > > + samsung,dw-mshc-sdr-timing = <1 2>; > > + samsung,dw-mshc-ddr-timing = <2 3>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8>; > > +}; > > + > > +/* WiFi */ > > +&mmc_1 { > > + status = "okay"; > > + non-removable; > > + max-frequency = <100000000>; > > + sd-uhs-sdr50; > > + cap-sd-highspeed; > > + keep-power-in-suspend; > > + bus-width = <4>; > > + card-detect-delay = <0>; > > + samsung,dw-mshc-ciu-div = <3>; > > + samsung,dw-mshc-sdr-timing = <2 4>; > > + samsung,dw-mshc-ddr-timing = <2 3>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&sd1_clk &sd1_cmd &sd1_bus4>; > > + mmc-pwrseq = <&wlan_pwrseq>; > > + > > + wifi@1 { > > + compatible = "brcm,bcm4330-fmac", "brcm,bcm4329-fmac"; > > + reg = <1>; > > + interrupt-parent = <&gpx2>; > > + interrupts = <5 IRQ_TYPE_NONE>; > > + interrupt-names = "host-wake"; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&wlan_irq>; > > + }; > > +}; > > + > > +&ohci { > > + status = "disabled"; > > +}; > > + > > +&pinctrl_0 { > > + acc_int: acc-int-pins { > > + samsung,pins = "gpx1-4"; > > + samsung,pin-function = <EXYNOS_PIN_FUNC_EINT>; > > + samsung,pin-pud = <EXYNOS_PIN_PULL_UP>; > > + }; > > + > > + max77686_irq: max77686-irq-pins { > > + samsung,pins = "gpx0-2"; > > + samsung,pin-function = <EXYNOS_PIN_FUNC_F>; > > + samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>; > > + samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>; > > + }; > > + gpio_keys: gpio-keys-pins-pins { > > + samsung,pins = "gpx2-0", "gpx2-1", "gpx2-7", "gpx1-3"; > > + samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>; > > + }; > > + wlan_irq: wlan-irq-pins { > > + samsung,pins = "gpx2-5"; > > + samsung,pin-function = <EXYNOS_PIN_FUNC_INPUT>; > > + samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>; > > + samsung,pin-drv = <EXYNOS4_PIN_DRV_LV3>; > > + }; > > +}; > > + > > +&pinctrl_1 { > > + bh1721fvc_reset: bh1721fvc-reset-pins { > > + samsung,pins = "gph1-2"; > > + samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>; > > + samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>; > > + }; > > + msense_rst: msense-rst-pins { > > + samsung,pins = "gpg2-0"; > > + samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>; > > + }; > > + onewire_sleep: onewire-sleep-pins { > > + samsung,pins = "gpg0-0"; > > + samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>; > > + samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>; > > + samsung,pin-con-pdn = <EXYNOS_PIN_PDN_INPUT>; > > + samsung,pin-pud-pdn = <EXYNOS_PIN_PULL_NONE>; > > + }; > > +}; > > + > > +&pinctrl_2 { > > + wlan_pmena: wlan-pmena-pins { > > + samsung,pins = "gpv1-0"; > > + samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>; > > + samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>; > > + samsung,pin-drv = <EXYNOS4_PIN_DRV_LV3>; > > + samsung,pin-con-pdn = <EXYNOS_PIN_PDN_PREV>; > > + samsung,pin-val = <0>; > > + }; > > +}; > > + > > +&pmu_system_controller { > > + assigned-clocks = <&pmu_system_controller 0>; > > + assigned-clock-parents = <&clock CLK_FIN_PLL>; > > +}; > > + > > +&sd1_bus4 { > > + samsung,pin-con-pdn = <EXYNOS_PIN_PDN_INPUT>; > > + samsung,pin-pud-pdn = <EXYNOS_PIN_PULL_NONE>; > > +}; > > + > > +&sd1_cmd { > > + samsung,pin-con-pdn = <EXYNOS_PIN_PDN_INPUT>; > > + samsung,pin-pud-pdn = <EXYNOS_PIN_PULL_NONE>; > > +}; > > + > > +/* Bluetooth */ > > +&serial_0 { > > + status = "disabled"; > > +}; > > + > > +&serial_1 { > > + pinctrl-names = "default", "flow-control"; > > + pinctrl-0 = <&uart1_data>; > > + pinctrl-1 = <&uart1_data>, <&uart1_fctl>; > > +}; > > + > > +&serial_2 { > > + pinctrl-names = "default", "flow-control"; > > + pinctrl-0 = <&uart2_data>; > > + pinctrl-1 = <&uart2_data>, <&uart2_fctl>; > > +}; > > + > > +&usbdrd { > > + status = "disabled"; > > +}; > > + > > +&usbdrd_dwc3 { > > + status = "disabled"; > > +}; > > + > > +&usbdrd_phy { > > + status = "disabled"; > > +}; > > -- > > 2.52.0 > > > > > ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 3/3] ARM: samsung: exynos5250: Allow CPU1 to boot [not found] <20251120144018.961604-1-linux@timmermann.space> 2025-11-20 14:40 ` [PATCH 1/3] dt-bindings: ARM: samsung: Add Samsung Manta (Google Nexus 10) Lukas Timmermann 2025-11-20 14:40 ` [PATCH 2/3] ARM: dts: exynos: " Lukas Timmermann @ 2025-11-20 14:40 ` Lukas Timmermann 2 siblings, 0 replies; 12+ messages in thread From: Lukas Timmermann @ 2025-11-20 14:40 UTC (permalink / raw) To: Russell King, Krzysztof Kozlowski, Alim Akhtar Cc: Alexandre Marquet, Lukas Timmermann, linux-arm-kernel, linux-samsung-soc, linux-kernel From: Alexandre Marquet <tb@a-marquet.fr> Add an exception to let the secondary CPU boot. Signed-off-by: Alexandre Marquet <tb@a-marquet.fr> Signed-off-by: Lukas Timmermann <linux@timmermann.space> --- arch/arm/mach-exynos/firmware.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-exynos/firmware.c b/arch/arm/mach-exynos/firmware.c index a5e22678e27b..80e645b4d338 100644 --- a/arch/arm/mach-exynos/firmware.c +++ b/arch/arm/mach-exynos/firmware.c @@ -61,10 +61,10 @@ static int exynos_cpu_boot(int cpu) * Exynos3250 doesn't need to send smc command for secondary CPU boot * because Exynos3250 removes WFE in secure mode. * - * On Exynos5 devices the call is ignored by trustzone firmware. + * On most Exynos5 devices the call is ignored by trustzone firmware. */ if (!soc_is_exynos4210() && !soc_is_exynos4212() && - !soc_is_exynos4412()) + !soc_is_exynos4412() && !of_machine_is_compatible("samsung,nexus10-manta")) return 0; /* -- 2.52.0 ^ permalink raw reply related [flat|nested] 12+ messages in thread
end of thread, other threads:[~2025-11-21 18:10 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20251120144018.961604-1-linux@timmermann.space>
2025-11-20 14:40 ` [PATCH 1/3] dt-bindings: ARM: samsung: Add Samsung Manta (Google Nexus 10) Lukas Timmermann
2025-11-21 9:04 ` Krzysztof Kozlowski
2025-11-21 13:45 ` Lukas Timmermann
2025-11-21 17:24 ` Krzysztof Kozlowski
2025-11-21 18:07 ` Lukas Timmermann
2025-11-21 18:10 ` Krzysztof Kozlowski
2025-11-20 14:40 ` [PATCH 2/3] ARM: dts: exynos: " Lukas Timmermann
2025-11-20 17:31 ` Henrik Grimler
2025-11-20 17:36 ` Krzysztof Kozlowski
2025-11-20 20:27 ` Lukas Timmermann
2025-11-20 20:29 ` Lukas Timmermann
2025-11-20 14:40 ` [PATCH 3/3] ARM: samsung: exynos5250: Allow CPU1 to boot Lukas Timmermann
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).