From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6C99BCFA46B for ; Sun, 23 Nov 2025 05:38:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fdTAoGIkVJdTBNn5w5JezM40NIKQVYvjlSA7P/AFoaY=; b=oXCaVqGy1seu6lLRqxWub18INw FqEmg1YIME8UPTA/P6J2yYMKzwdcnEXfBYlN5gSeqxdMekz5kC63vm8/pZNTVzkUIYRzN7DQZRW0H LNpngCcpJM3Zcbu8R5H0ehZCcxI3hD93TKf2R4Iyx9LE/rFsbp32swdTIr/CYrfJAyfOhEsJflg4H uf2I2G8LRcB1cQTEF2J+tSRZRyVQABq8zEVpP9O3uZAE/Lfn3ssUDPhoXTUs1YV7cjt0TkC+opA5a misQaoB0vXXjNZZRmY5SkxF6MXYMbsHxZDAGiaGvrZv66yph7BEDl0WP0yY+96XDwgOP01zdjGBYc 32/7V/dw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vN2nv-0000000AA5i-1NfW; Sun, 23 Nov 2025 05:38:31 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vN2ns-0000000AA5N-45Xo for linux-arm-kernel@lists.infradead.org; Sun, 23 Nov 2025 05:38:30 +0000 Received: from pendragon.ideasonboard.com (fs276ed015.tkyc509.ap.nuro.jp [39.110.208.21]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 1ACF39CE; Sun, 23 Nov 2025 06:36:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1763876180; bh=He+lt4QQh/rQAbv/9qG6zLXqw96LteC0N/tPxNFTT9Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=l+vRVvw/93ZcT4UkaXR21OlThwf3YkZfWidDUFelwrcI4c9O/cHW2aeEbmsNYiNXP wtipELrgx72t+eaWhoYJn6EhgZIvMjpMkwmjLY4BUdXbTZmVr6Alog0Tq1EHDu8NVb ai1oUz3t9lPbyycsjkmH2jMkA8MbH7fmRdLYyVu4= Date: Sun, 23 Nov 2025 14:38:02 +0900 From: Laurent Pinchart To: "Russell King (Oracle)" Cc: Wei Fang , Clark Wang , Oleksij Rempel , Emanuele Ghidoli , "devicetree@vger.kernel.org" , "imx@lists.linux.dev" , "linux-arm-kernel@lists.infradead.org" , Daniel Scally , Kieran Bingham , Stefan Klug , Conor Dooley , Fabio Estevam , Krzysztof Kozlowski , Pengutronix Kernel Team , Rob Herring , Sascha Hauer , Shawn Guo Subject: Re: [PATCH] arm64: dts: imx8mp-debix-model-a: Disable EEE for 1000T Message-ID: <20251123053802.GA25329@pendragon.ideasonboard.com> References: <20251028071817.GX13023@pendragon.ideasonboard.com> <20251111235434.GA25874@pendragon.ideasonboard.com> <20251112222551.GB9135@pendragon.ideasonboard.com> <20251113010627.GC9135@pendragon.ideasonboard.com> <20251114222654.GI30434@pendragon.ideasonboard.com> <20251122072246.GA16239@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251122_213829_170874_AE8933BC X-CRM114-Status: GOOD ( 30.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Russell, On Sat, Nov 22, 2025 at 09:57:49AM +0000, Russell King (Oracle) wrote: > On Sat, Nov 22, 2025 at 04:22:46PM +0900, Laurent Pinchart wrote: > > Hello Wei, > > > > On Tue, Nov 18, 2025 at 01:50:55AM +0000, Wei Fang wrote: > > > Sorry, I only have a little experience with DWMac, add Clark to help look > > > at this issue. > > > > Thank you. > > > > I think we're getting close to having a good understanding of the > > problem. I've debugged it as far as I could based on the information > > available publicly. Let's try to get to the bottom of this issue, it > > impacts quite a lot of people and it would be very nice to fix it > > properly in mainline. > > > > The short summary is that I'm experiencing an interrupt storm on IRQ 135 > > when EEE is enabled with the EQOS interface. > > > > My current theory is that > > > > - The lpi_intr_o signal of the EQOS is OR'ed into IRQ 135. > > - The issue is triggerted by the PHY exiting LPI mode > > - When it exits LPI mode, the PHY restarts generating the RX clock > > (clk_rx_i). > > - The MAC detects exit from LPI, and asserts lpi_intr_o. > > - Before the CPU has time to process the interrupt, the PHY enters LPI > > mode again, and stops generating the RX clock. > > - The CPU processes the interrupt and reads the GMAC4_LPI_CTRL_STATUS > > registers. This does not clear lpi_intr_o as there's no clk_rx_i. > > Please try setting STMMAC_FLAG_RX_CLK_RUNS_IN_LPI in dwmac-imx.c and > see whether that changes the behaviour. I have tested that and it worked like a charm ! I have submitted https://lore.kernel.org/r/20251123053518.8478-1-laurent.pinchart@ideasonboard.com That was quite an adventure. Thank you so much for all your support, I'm not sure I would have managed without you (or at least I would have needed way more time). I really really appreciate it. If the above patch gets accepted, we will probably be able to remove the eee-broken-* properties from the i.MX8MP device tree files (and possibly from i.MX8DXL and i.MX93 as well). I have mentioned that below the commit message of the patch, with a test procedure as it should be tested on each board. -- Regards, Laurent Pinchart