From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AABAECFA466 for ; Mon, 24 Nov 2025 12:13:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=saeB5OiStGs8l05ktMlJ7ny6DvCLlNba1SyKFxlo1BI=; b=ZppVSPcWwD2Oq69vN0TqRI4QS1 e7hXREoXzq99Sum5zKHJRK2NCBoNwlJpQ29y040WufJKYsQUWW4H+Nk7WpVpfnDO5qTqmgNleed34 2mFGHRC/+KxdPcSFDRCMtwHgbj8z7hQ2LjBxQjszfDkEHvKDTr7mW+Oz599+iYBRNo4iJF237KYeO gqqApN2u8wL72kL7QikeAwAkQY1A6aU4js+Bkbaa+9e3UqWErG5uM+KFUiunPDzb2RHMLQU0W24vY 1jQ2E5Doa4zPYe997bRepffbUsW9kJYgxwPVsftjdR+uyy09GaZJ9eMv2Td+1X/fEHI+Z3Md30JuZ v+lPFsgg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vNVRA-0000000BcuW-2Yf6; Mon, 24 Nov 2025 12:12:56 +0000 Received: from mgamail.intel.com ([192.198.163.12]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vNVQX-0000000BcPH-32Q0; Mon, 24 Nov 2025 12:12:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1763986337; x=1795522337; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=noDJxCmlGW2l/RNKrw+Y3WhNwmbPyJ6mAjM7+Omfh0g=; b=g0bA7ym2Yd/AYzCI/H0ml6HOM/2F0hsmB19x6e366+2DUgE2bEXAz2qy 1CB34BfBo4hLiY0j5XSlDRzgBD3j070jv1htQRb6xwVomCGHEsZWcGEFv J8rxE416geWT0qwEuhQSGcKEFiJIjrW41TBJfsXiHIfZd0kHVssZDPX76 KrQLcO7lsZeX+ncpoyZRnh0KHPralB7DIV95OuhX4Fdw/esD8ZP6MpE1M 9hGr+6Hw126VWDcOJuUEyOPQnizIBEs2hjmEt3Zb/v9LtDQKfPMVAMalF MZLtNms9kUnbzUScqxUMyGBZ0IqajzeKZ+VApN4djgmf13Ocw/1OOBpRf A==; X-CSE-ConnectionGUID: Vrcvjp3oTlaNvC31LWMjqw== X-CSE-MsgGUID: syjhbfuER/6M+cwHuWvddg== X-IronPort-AV: E=McAfee;i="6800,10657,11622"; a="69847622" X-IronPort-AV: E=Sophos;i="6.20,222,1758610800"; d="scan'208";a="69847622" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Nov 2025 04:12:16 -0800 X-CSE-ConnectionGUID: ul+nTSsMTxuky5teU59mmA== X-CSE-MsgGUID: Lw/TYoX5SQSD+IXZODL5KQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.20,222,1758610800"; d="scan'208";a="222970345" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa002.jf.intel.com with ESMTP; 24 Nov 2025 04:12:10 -0800 Received: by black.igk.intel.com (Postfix, from userid 1003) id 6F30AA9; Mon, 24 Nov 2025 13:12:03 +0100 (CET) From: Andy Shevchenko To: Bjorn Andersson , Andy Shevchenko , Stefan Wahren , Vinod Koul , Thomas Andreatta , Caleb Sander Mateos , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Cc: Olivier Dautricourt , Stefan Roese , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Lars-Peter Clausen , Eugeniy Paltsev , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Lizhi Hou , Brian Xu , Raj Kumar Rampelli , Michal Simek , Andrew Morton Subject: [PATCH v4 09/13] dmaengine: qcom: adm: use sg_nents_for_dma() helper Date: Mon, 24 Nov 2025 13:09:27 +0100 Message-ID: <20251124121202.424072-10-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251124121202.424072-1-andriy.shevchenko@linux.intel.com> References: <20251124121202.424072-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251124_041217_773195_4908858B X-CRM114-Status: GOOD ( 11.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Instead of open coded variant let's use recently introduced helper. Reviewed-by: Bjorn Andersson Signed-off-by: Andy Shevchenko --- drivers/dma/qcom/qcom_adm.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/dma/qcom/qcom_adm.c b/drivers/dma/qcom/qcom_adm.c index e0f0c6f42c1f..aeb01b7087e2 100644 --- a/drivers/dma/qcom/qcom_adm.c +++ b/drivers/dma/qcom/qcom_adm.c @@ -390,16 +390,15 @@ static struct dma_async_tx_descriptor *adm_prep_slave_sg(struct dma_chan *chan, } /* iterate through sgs and compute allocation size of structures */ - for_each_sg(sgl, sg, sg_len, i) { - if (achan->slave.device_fc) { + if (achan->slave.device_fc) { + for_each_sg(sgl, sg, sg_len, i) { box_count += DIV_ROUND_UP(sg_dma_len(sg) / burst, ADM_MAX_ROWS); if (sg_dma_len(sg) % burst) single_count++; - } else { - single_count += DIV_ROUND_UP(sg_dma_len(sg), - ADM_MAX_XFER); } + } else { + single_count = sg_nents_for_dma(sgl, sg_len, ADM_MAX_XFER); } async_desc = kzalloc(sizeof(*async_desc), GFP_NOWAIT); -- 2.50.1