From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 75906D0EE13 for ; Tue, 25 Nov 2025 19:19:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To: Content-Type:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WE9pH5M36PWvy8ZmKtuDN0jrmNAsbllTRTJChQ7LC3I=; b=2QOC4TP7gbqSXSwSbwBD+3iY0E /AdOAj6EuHVkEVd3HmzIWzBWpru7cVyReA5XthfjmmBo5Vp2HNAuL0K04J3U0ewlSgyiMotvjQf3R XMWPqskZSQdduam5Ew/Ft5q3qtSFP4nj8Y3i8mtKymFBpqc7e96KP59yODialICZcV1Gmp7FKvmNB rhO3twYP2ZBX43UKXv1jdvnDCDCcGYbAXyx4/nzCkjB+yZlvC9PFVRNDZV4PAZIRvF6aimNdWScnD HHuVWkacv0Q2vE5FO/uByR3Mhqmh2bphFJUQJe0Q/dV9MpWB645Ie50VzMOIxCijls+J6hTWuky5C BQZs6B4g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vNyZv-0000000Dp9p-39Vo; Tue, 25 Nov 2025 19:19:55 +0000 Received: from mail-southcentralusazon11013016.outbound.protection.outlook.com ([40.93.196.16] helo=SA9PR02CU001.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vNyZs-0000000Dp9E-236Z for linux-arm-kernel@lists.infradead.org; Tue, 25 Nov 2025 19:19:54 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=n83VEMHG8UG4/mi3JzE8vK+BMKhx3d1kgnH3QfGF0XulpnN8ZkJjGwWq82vsHbPEe7B0GQbrTomhAyVd35ZUrn2KaLm6tg5VKpPjJ0enhVlXC4Wm6VnA/DUyl3JgjQl9nU13ngp10B1JTj/Aery7yWfv5trBjcOmaOOLlN4pTHznYruuq6+YAlSxzc8n1XUPklPIMlhkYLoX1VemhMQREqOIJ/wjnoKs6EGtYOFWYL4PSC+jCJDFmdYhnAamlaZtoNKtqESY2nJvAWoP/hWq1QetQu8Xu6U5dGAHCTkd6hmIRby6bpFD6/vnEPxPX158+Pr4IEeWOrArB3CSd3HcXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WE9pH5M36PWvy8ZmKtuDN0jrmNAsbllTRTJChQ7LC3I=; b=vLBkECKP7mFFXSsBoZ36EakRRBW1Jl1lKlpLkd6SwgVaAx97EQk9ZNbxHEVyUP0xofhzOZS/g345+4kJzEA5RcbEZHmRXza7ArXTL4TrzIETd0ptz4HEGax9mhAORoEzwXngaAstEP6d16dcDg98RfD6at2bzGc70FqMRDzLnwy/9hLEvD9MjEWXZxQI36EHHas/wblg56PZ8sqxp2LpqCjgDw8stl0I/Knv19PgYRK2wYHDqG07rjedEFmw1dnOpIv8gg4CpXKA2s88ejr5WiK/z8Wl3xOazOYB2tucAtEOosahTO18UELetQPgT2WTjtnDz1eJ+91m9MWzsIggyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WE9pH5M36PWvy8ZmKtuDN0jrmNAsbllTRTJChQ7LC3I=; b=HoGvsDjjdNU66zZHcb2lZg2QFgC+/wwg3NDhDPU6e9lQJqSPz4dt1ZwRyVBCO7c6kCvTv61WiS07DwAjz4MiYehv2h5Q3czdvZ79s/zDSA9BbBXRojrG9OSOzBguiPjjstIkaJ2slAjRvtGVyBJvnmZM9bdCQQLiRS+OoY1YBh6dkCEibPM7o1d6E6Fs5D3bqjVSSjd0k6mCR71JYfYHWyZ4pFCnNxvvKuE7puEu6X2qBHZZle5xKlVydD68b+Qg9uHtbdd7+2SRyZc0m5D+Pu/oJs6x0sY4LtwUCDh3P18hA8fSfr+VcJytMD4zos1E+rc7IDWu/TMqDodJfd01WQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from MN2PR12MB3613.namprd12.prod.outlook.com (2603:10b6:208:c1::17) by DM4PR12MB7552.namprd12.prod.outlook.com (2603:10b6:8:10c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9366.11; Tue, 25 Nov 2025 19:19:43 +0000 Received: from MN2PR12MB3613.namprd12.prod.outlook.com ([fe80::1b3b:64f5:9211:608b]) by MN2PR12MB3613.namprd12.prod.outlook.com ([fe80::1b3b:64f5:9211:608b%4]) with mapi id 15.20.9343.009; Tue, 25 Nov 2025 19:19:43 +0000 Date: Tue, 25 Nov 2025 15:19:42 -0400 From: Jason Gunthorpe To: Nicolin Chen Cc: joro@8bytes.org, afael@kernel.org, bhelgaas@google.com, alex@shazbot.org, will@kernel.org, robin.murphy@arm.com, lenb@kernel.org, kevin.tian@intel.com, baolu.lu@linux.intel.com, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, patches@lists.linux.dev, pjaroszynski@nvidia.com, vsethi@nvidia.com, helgaas@kernel.org, etzhao1900@gmail.com Subject: Re: [PATCH v7 2/5] iommu: Tidy domain for iommu_setup_dma_ops() Message-ID: <20251125191942.GD520526@nvidia.com> References: <6e8aacd34b038e7534fc5cb3fa21ab31b1af01ad.1763775108.git.nicolinc@nvidia.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6e8aacd34b038e7534fc5cb3fa21ab31b1af01ad.1763775108.git.nicolinc@nvidia.com> X-ClientProxiedBy: BLAPR05CA0009.namprd05.prod.outlook.com (2603:10b6:208:36e::16) To MN2PR12MB3613.namprd12.prod.outlook.com (2603:10b6:208:c1::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR12MB3613:EE_|DM4PR12MB7552:EE_ X-MS-Office365-Filtering-Correlation-Id: c0b81465-0914-4461-a89a-08de2c579652 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|7416014|376014|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?lzSXOfLP44buBb6jCwnjmPxnqtz05PeOzGJKzgbY+oNEakNvyShAnaLGMQSE?= =?us-ascii?Q?3jA7dI6jf3o5QYk4LHRct47QVHPK4BbFNQGzYoRaSqXy4xI6rJc63dz1/y79?= =?us-ascii?Q?E7WHmgtt3RyIEfeUpMd+An3C6tbh6AGzM/LrKq7YzHfvX87HqVt+4SxGVT44?= =?us-ascii?Q?XepPAdqiMfNyEnmTdNWWIqyaSnTUppRNIYhoXutO7jtt3ABOTtoBumFTPaoQ?= =?us-ascii?Q?+jcJ43AbCa8d/XO7ZPULQA2XXijiSlaMuU1mOG3rhsYVFS3RtuP6HGd+fDR+?= =?us-ascii?Q?PWGgSKXbPOzLQC6EwL7MxebfxLAMFM6UvJEsGXbovbqTO+2Vmdf+ILTj3z/o?= =?us-ascii?Q?Y80oCAM1+X/wNM1huy7sCGQYKwHlgnbioUtN8rp7IopS5otEt534TKr9/AOT?= =?us-ascii?Q?mOQXq+jXJ3xBE82ZJxTtpHcMl/0irBXJ+4iG1/EOSRDOI9xGwvwybSOLMhBd?= =?us-ascii?Q?X36zmoOyVKZfURreRHus22OxpBytO7JRWvQ97iDZ2y0X/hwv2Pva8b/DZ77N?= =?us-ascii?Q?i77XMJuWGgHQXw+IUAOJn6CeIdwjNTnnZlmxB7FyVXycHB278w8h3K6Y1PXJ?= =?us-ascii?Q?Ur7C/CPznUlOuqBbe3oFnA3JkUabFMUH2KoaMdIc89YweRn8+fGfUv8BGGEM?= =?us-ascii?Q?tYNs9wFwOQPFSecHCyCwZSfePjIgEoUVJukyOGFWz2l0KNS+qdPoBEC2aQvs?= =?us-ascii?Q?U1TTLfoSZTMJMWeKOYYteMAtPEgyq/otAl/QP9EOi8tPPFdN2sF6qEbR64y4?= =?us-ascii?Q?xnXni18xmiQEnlef1/pi8XHWEz39HgVKT6LmkSmdIRHh+x87B6UtIv6Hq6w8?= =?us-ascii?Q?5QIwcsRI/k3W94gaUU5V+Y7UjGhXFouRjlJxKxmoPwVXkmynyNCxmsoNh9JV?= =?us-ascii?Q?UURZ9YkJDuuNgDbTCsE7R/S14i3j134FYDmfRx7fLKq3JQoaCKpdKjPtuob5?= =?us-ascii?Q?D/Hv4WHki+nI8p/ynBNVeN7hgTRWA50u9+m2onMeT2Q4Vbn38RYxWblrBeeH?= =?us-ascii?Q?BIIX7vBKko1kmefo4sM85dZ6Zx7RRljAjISLNa22ywMR/VCyXYCmld6hLuv7?= =?us-ascii?Q?IvE0hlQLbjO3XhWyay+XMDabXqPwSiatidsp2C+8TtWJ7jEwyeAiRmJ6CfgW?= =?us-ascii?Q?HDz8k4G9fOye3UOkTrXKzh929PYSDdZxS8ID8hdUxFiM0KNSlp38KSpbOLse?= =?us-ascii?Q?r7znsi3R+/1dvBSKa7I0mJJfUk/Tx87KmjCn/3LDDwv3fs29gbnqPgfWQq9V?= =?us-ascii?Q?rDCycZp0DvfC2eW1mSFD/RdN0bqheH8yx+/PhV/vyovtbmZhroAJVl04sBJQ?= =?us-ascii?Q?lyTsQbM/TOriAeBQW59ivVhtKLFkGKsuVws9kydzJbW3DWTK/y8sr4ipL/QR?= =?us-ascii?Q?9NUAuVAl/1mOuOgprd1TgiuQov3Ncmex/XRXJoIv7eLkVLa6t4aLeVTMzhjL?= =?us-ascii?Q?eEStaIqzlK/iUVDariz5UgdjH33Qsish?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3613.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(7416014)(376014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?C9by6Uc5AOIfdo0iMKCfJuFGpkzqckbz33jwnLauaiVY+QXA4JFiWZa/EMnV?= =?us-ascii?Q?JEqMdu9TLzCg3vtwnx8Pd4qYbZExw8692nL9GQ5LDgcp2HqpYPC/9hM0/bMd?= =?us-ascii?Q?7J0hm+t465uxK02Dtyh7jbeupquzQ9qc7BGUhRBQ8HPoC95m2gzQXtbK/RwD?= =?us-ascii?Q?pXnqpQy0nuRlfLx14LhCI6lAcVRljny9bPbRCdGmOHHxRWtYWuxyYGS57MUG?= =?us-ascii?Q?jFXH9crv6R8GfYlnPBwES4Clqx+STS3h0FOKOQNFR7W8lCnBI+fl1J1Vkx22?= =?us-ascii?Q?G8IRRgSBVf9jlizIXt38MgPqZCvyuho8396Wkkxw9UZUL2HbJNgQiwqscrwi?= =?us-ascii?Q?eKBGV6hxiF5yoTpn1D7vlM3yt8rR/d1ddtjOy7J/dbmduYGsvS8wGdqHwWct?= =?us-ascii?Q?4/lSELGhu50EsEyj0lM4+X1SPUOLfQUC96yeMqmtjHXabLiAUaydFUh2Z2+a?= =?us-ascii?Q?CdLCnFrjAQjilywElIGPZmeN41GAoWtNmWsszivPaPoplcQyf/qsH4SXiWj6?= =?us-ascii?Q?z0PtTFEBOuyMzPE+R56OnjLg7JdA713bOdYf5fl43TbBdw7mDs3TUUVAZSrl?= =?us-ascii?Q?QXyosrJwnrSfj9FasBvr79kfkUqFFKrbzaBwUjdMun7SPY/1bNGByRVqFaU0?= =?us-ascii?Q?vWVLqAYjCDAm88oSVXWas8LINGxFXiD4bwf2SmhLa5Ayi8NwmBgCRHBOFcxl?= =?us-ascii?Q?UxzO7dzANNTigKAWuAqabcciyf8HLChNhIdt4gqdCg18Z9REo/wOTCtg1wXR?= =?us-ascii?Q?0mFnMHCjVab70OuvhZl6n8eIXz6hNgMFRD2YPVlGCSI2bmFGF8qptdujuhTp?= =?us-ascii?Q?Wyyu08u0OjGXEKHEGq/iRmptT3el/m1hh0wuWRFDyLyvHuUBnQDVMf3KTmKT?= =?us-ascii?Q?Do5pRQTJw+G6FO70ViRMEHZ+9h5StddR8SoDpEK+M4GHFPoeec4iSqGjZVRk?= =?us-ascii?Q?Z68F5/lIB8QfRim8mwRxPh94OEIwk4WPS7o0FQCf6lalaisfD5kN3uG3r3w8?= =?us-ascii?Q?btuspOALazA5m/vD1nOB1i8USXpuJXlgaGyfIlDKLms5x8khQA0sXz58yeo4?= =?us-ascii?Q?B1pAuVhEnTvttZFPViRuJP+1K+PfX31g78/ttvL7GDbb4XqG7Lf2sKkYBWA0?= =?us-ascii?Q?y4KufEXeB5fsvbY8qZMSTBgosT06r7cVrg4ieyNRNUW2zEwYoUrlgk73wMM1?= =?us-ascii?Q?3k7GG/fZSTnqPHBG7eWZlb3FiNFYFdqydwcP3A0tyFWfv5OBMmpIVyaoO/vG?= =?us-ascii?Q?3yHhrdr51IcJ0yP4jnGjJHYwISr6+tBXdJFtr9UWacO8UeQjWu66FX89EAHV?= =?us-ascii?Q?MT81KYStfx/URDdgSGEqG/7vfi6fPapZRTWeK/jW3fD+T1VKGx14JrsFUuXW?= =?us-ascii?Q?jDHkTM/h++JEOPfWRlotrXADzyiEIbro6i+Hk9sdRHc1O1d3xju087G8kyMn?= =?us-ascii?Q?n3nil8fhWZpfsDft82ef0XZPnl7+frprfN9ye27picIJ6XhVHv229hjvPumN?= =?us-ascii?Q?CG6sZCOKUN38K6hruqDaWRAXfR2kDjqSpWS5YIpQMBIVJAyOULRJZUFKtml3?= =?us-ascii?Q?QsHkgz4BERMXodH6E/Q=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: c0b81465-0914-4461-a89a-08de2c579652 X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3613.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2025 19:19:43.0286 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iNpeFHJW6zMFZPAzKKdW/iV9L5BdMDhszg+zMstG+0K0lCwjxeYwuQNLisqJERVs X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7552 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251125_111952_710884_412AD84C X-CRM114-Status: GOOD ( 12.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 21, 2025 at 05:57:29PM -0800, Nicolin Chen wrote: > This function can only be called on the default_domain. Trivally pass it > in. In all three existing cases, the default domain was just attached to > the device. > > This avoids iommu_setup_dma_ops() calling iommu_get_domain_for_dev() that > will be used by external callers. > > Suggested-by: Jason Gunthorpe > Reviewed-by: Kevin Tian > Reviewed-by: Lu Baolu > Signed-off-by: Nicolin Chen > --- > drivers/iommu/dma-iommu.h | 5 +++-- > drivers/iommu/dma-iommu.c | 4 +--- > drivers/iommu/iommu.c | 6 +++--- > 3 files changed, 7 insertions(+), 8 deletions(-) Reviewed-by: Jason Gunthorpe Jason