From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 813A4D0EE0F for ; Tue, 25 Nov 2025 19:28:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To: Content-Type:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=J/HAsNDQj1qE/ffAZxv18f1V91dREcJYRt/WA/SuQPM=; b=HHqvg3lCOVDuW871X6oVmFIbW3 4h5c+qljbFVfh+y4BnXRb/uRJX4G6Gt4nB0wMpYfO371uj2x1XMt7KQSYsiZYZdeTWoTeJT050EyK 8qvol7nvmjt1x/74DuLCv6HqO2giHZweIcO93Dxb8LuvtjxEkzWhFunWBMi2tSDjtkZREGV2DM/5b OXeBlaV4DA2KGKOURa3B3JbuVO8/f4oW3J3Mv6XOuK0F9hfeY6+ZD9fAlwjAViIKQjUkPCsxsYzd0 Pgw7vYBFqGTI8nUxtBsE1/YRph+RA4+WtUG2FjqYWYtcrdusUlH/hfPusWNESp4ssrwvXrOSfK2uN bQjpIFnw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vNyiN-0000000Dq3r-0Weo; Tue, 25 Nov 2025 19:28:39 +0000 Received: from mail-northcentralusazon11013005.outbound.protection.outlook.com ([40.107.201.5] helo=CH4PR04CU002.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vNyiK-0000000Dq37-34gB for linux-arm-kernel@lists.infradead.org; Tue, 25 Nov 2025 19:28:37 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=S7LUIjsOqhYXGRwh/21U9MQAVKSeWzDmNXO/EwQCzjKPLLuFKyDAqW9QsxdePl3UZRxzBxwEwfVbRJCJulM54gk4JPHHS6hwXm6QztWUxNAITc0T4V9ti+RUkjj1HbvuW6kqsX2yclne5AIwU4OqRhEA/msdbEGhAfFvxEDv5P6H7Nd3qVDbuBvFteYNzGZ0Nig6siS17bmDRt+YhE9JKcMREVMBt+7nQH3ITlsGSf6NxjrMURBRXlwdGcgF3KlgqIFZRPc8xT2PExpAmvAscmYHkxpKIz0wzUfwffaOZk3rB/M+5o+/KeMx++CJjoq3jZZHuGpaI+9qPEd7v9ekLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J/HAsNDQj1qE/ffAZxv18f1V91dREcJYRt/WA/SuQPM=; b=k6U46vVN5CUIcHJNqh6eD46qY1SpqdakLWi1t/Y6A6AqkILNLvkkwvo3SnQoFacpyegtG91eUAtjRqdh4rVkkwEUhW2C5IC+86PA7c0j7OAddFn0/p43HeUR+3cIbcRzrizNzDF7YQGFAH3+4kou/etkrSAs3NicTZ3WJMfG45F+Ss5PG4A0cAg9zhy3wLbCN4vdwdI0I4OfvxoRNREDhWe79E2u1it1t3mktgagwLsMoEkxtfhE2iU+w0ApugTCifKdNbgbXC6FVX+piRUmQbWzkbJCr0nYRnyCtZ7RrkSJIkJhe50GnX1euGEC9EwXdRYv/aLhTCWjckp9Avo7+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J/HAsNDQj1qE/ffAZxv18f1V91dREcJYRt/WA/SuQPM=; b=frsl9waxJUzdOpRrf/+89N9z0H2s4WIx1lOKDEZh9eEY+6VQDZsWKTdtG+noOTBwUawOdGbzUEiDnQ+4jaLAhbBeIe23R+GAU8vPbaRmz0RDSFY2AhwvMUpspM+zlexNB9WJGWbli6e2vpWGxIlF6Fh3V6fHPbWF8tCX2dz93JzyO+1fhJdS2IRCeqf68H8M++CLeJESHgjFgFc7cTQvHfNRhaRnPJJyl9htEMXqCWHGG47t0cdzNDE0kWt2m4IRMgQLiY2O4THkrg9g1CxzzlsptWwWmT0RgYvcjGQ4gdWC5x3pX0U52cK4ImAqcqlNSqRVoKyoma3ZSZemE+E03Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from MN2PR12MB3613.namprd12.prod.outlook.com (2603:10b6:208:c1::17) by SA1PR12MB7221.namprd12.prod.outlook.com (2603:10b6:806:2bd::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.16; Tue, 25 Nov 2025 19:28:30 +0000 Received: from MN2PR12MB3613.namprd12.prod.outlook.com ([fe80::1b3b:64f5:9211:608b]) by MN2PR12MB3613.namprd12.prod.outlook.com ([fe80::1b3b:64f5:9211:608b%4]) with mapi id 15.20.9343.009; Tue, 25 Nov 2025 19:28:30 +0000 Date: Tue, 25 Nov 2025 15:28:29 -0400 From: Jason Gunthorpe To: Nicolin Chen Cc: joro@8bytes.org, afael@kernel.org, bhelgaas@google.com, alex@shazbot.org, will@kernel.org, robin.murphy@arm.com, lenb@kernel.org, kevin.tian@intel.com, baolu.lu@linux.intel.com, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, patches@lists.linux.dev, pjaroszynski@nvidia.com, vsethi@nvidia.com, helgaas@kernel.org, etzhao1900@gmail.com Subject: Re: [PATCH v7 5/5] PCI: Suspend iommu function prior to resetting a device Message-ID: <20251125192829.GG520526@nvidia.com> References: <4d2444cc52cf3885bfd5c8d86d5eeea8a5f67df8.1763775108.git.nicolinc@nvidia.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4d2444cc52cf3885bfd5c8d86d5eeea8a5f67df8.1763775108.git.nicolinc@nvidia.com> X-ClientProxiedBy: MN2PR13CA0025.namprd13.prod.outlook.com (2603:10b6:208:160::38) To MN2PR12MB3613.namprd12.prod.outlook.com (2603:10b6:208:c1::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR12MB3613:EE_|SA1PR12MB7221:EE_ X-MS-Office365-Filtering-Correlation-Id: c3dad913-e97d-4020-83dd-08de2c58d078 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|7416014|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?tXfQLkEi66AErwbb5AjLZ6fLu5x7Jt2X6l+dQxSWdD9k2xbeg3YAZYkb7fZP?= =?us-ascii?Q?+Gq8ez+VhFHkN4dn0daEj2fM99YMeX6Vljq0BqqJJcHU8zOuuaSREcC8hSrc?= =?us-ascii?Q?8qUg8UuMWA1jrExV/5B5h9TCVXMcQX1My+v5ikwp0VFTeFL034kTP9plPwD7?= =?us-ascii?Q?OeknzxrZkJscRz2E7MAh4zhO7e5RwVbBLDcW93Q7iFE+bhOcsXPWOtMskZva?= =?us-ascii?Q?diYDLPmRaRjyXdMk4C+u5RjzOtG6EHKe7M9yFTU/0ijPRgJQoYs4fK6N2Fv+?= =?us-ascii?Q?SOH22U6SlWFgr8lwaLE29dWAAeN02Gia13fiJWwRSSe2nju41jknLlT4It68?= =?us-ascii?Q?dYjxwOeDUBnq4+7NynC27/J+J0ENgRpYmNSr6X2A8xTVNBXn4cO1jSlgvW0m?= =?us-ascii?Q?TwLAuJEp+YXi6dXYYo4d0LMoTdgYFkYSMED3Y3QMf9neAwtEx3r7w8L5cJWK?= =?us-ascii?Q?+88T/wUvTpaQd8RGzs8P/w55UA/Ozzkg40tSfFLnVSnNGez+s0ZhPDETI1SG?= =?us-ascii?Q?p1UtI0fVlWenOd7CiWd49nmdHP0r+4HYNxprK8hGeJcrGXITOp6wjFwFP07J?= =?us-ascii?Q?P2nrsR0avY5g87/CQ5Og7G0RCmNHAtQMEsGOL7VwhHhJOnumGUf5v9/ZDv6f?= =?us-ascii?Q?rl/D2HMVoj1VTFXC1n0lXUrK/y3kJ3TpOPqu9Tu1lUP1+u+i6C2X6E4gU4iG?= =?us-ascii?Q?eSzJRGaDYwqugBewLdCCyGgJ0ZP1Pcc9NSLR84c6cVPvRT91p8wfWQUHVsn6?= =?us-ascii?Q?eHpgbZl9yKIWj4GTLGLbyjxN6+WaowP3YnT99CXZXyNfa/UsNoYEMS2PcxKo?= =?us-ascii?Q?r/DPju4E9cF622WaT3F5d1iCrzPNeltKY5TmHmB8wBq+AjEk35OgGQ9g7ABM?= =?us-ascii?Q?ck5FqjOcszLvrPSENETcQ1nyNMcBkbApraMTAaNiFKUYqhnV0DolazaEBlrj?= =?us-ascii?Q?NDLfoE90zWXXEVpy1UJwk9Jfczym5Mf8lrjdNfODyuYJYFXuvPMgWrk5T2Qp?= =?us-ascii?Q?9sIqAKsI+F4A4gxzbYghFH+S5JlkvljfM5dhPpwMQqOSA2Dr7m3bFaHMfbPk?= =?us-ascii?Q?E+STmliOFChG+UEmro1YoWzlENHVyQg/MejlOD2I+YUKiMjbbgBvjXgzNfkF?= =?us-ascii?Q?gvyi6SZI1RmKRpPRmUzbRjpXCfWPQo/eCBP0zmTbCVmhUkWfTLuLGntspr7Y?= =?us-ascii?Q?Pyn8kIFADHRJEwcYiTcOTgqUzOoj680KWQj5HPpDTvvf6XI0zUAWH7HOvqkG?= =?us-ascii?Q?vCUmp05zB1QNGYh+ua1XN9kOYH4UmErl805V6JACdml3E5R+mhkslXE8RdOq?= =?us-ascii?Q?NOWvVxLKwLHqWLQQohl8JAypGBS4xhspXL/f4VBFvolw/78U0WSdFyXsXypP?= =?us-ascii?Q?KpWX+vejrX9y+dB5kGNdRUnYt4S2DSBmKrLpSzczn+uXlSvtKl7pojroJxTf?= =?us-ascii?Q?Dc4Re8lDUloLMoWQkQ7kZiCfLQro++cz?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3613.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(7416014)(376014)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/0QTmTYCWzns6T2JwJv0xOQXih8OasXyuoDlrpDGXCkHL94pdLiQA0/yysE1?= =?us-ascii?Q?kDKZPPSCaYVTf2ng4MwgCbeWA4ppYLDpUY52MZfvRjUCEFZnz4OtUvOEkuHK?= =?us-ascii?Q?U4p2EtN2CaT4o1jB+/cl+ihmH6gSPmZQLHH56nWntPSvHk7CyyF9SVD8wPOX?= =?us-ascii?Q?5e231jSHulIX3DxUb2RMMVPcILGv2BhHGejPBEndAJTM0kzrFuYhfewgk6Nb?= =?us-ascii?Q?MqTEglGyuez7bRWIE55uPc7RCbXLg4qNI2OBp7+9+JRRB2HesBDIkbpnGVop?= =?us-ascii?Q?5200I5SU1LupYI+++qtZG2mrHmce/rh6FpQXPkk+TyyfCBgYrno5mONXKWvI?= =?us-ascii?Q?bBGUtRXJ+hcBuBo2FHHn4zD09AvxZClkmDN6Uy8VxMb6fFnc7kgQA9jSsIvr?= =?us-ascii?Q?m7ZiFzgNf5gYFzzKPCyfbcuRQkd/iMkH0FqXVikawBLkCwK5F0v5r8NSoDr+?= =?us-ascii?Q?SRokMk/+ka3y59WsJiCSjXxrVe2kDO7HWU2hDFdWVlk8lQts3NUfEwoJ8eJ7?= =?us-ascii?Q?cpjGzjK7BlGPePYvHrvRtpLiVAsfideYi/akPSgMrLGTGNwmIWDrG63zVMCG?= =?us-ascii?Q?lPYjIk/XsEommcgLqv+TZhLR2C1+dGj5PVculzDSF2ZhaQmFI0WKWObkKB+7?= =?us-ascii?Q?9y9QzqVOLjHyZPVmcWrow2iIxLjKpk1mrpOw8cJnYtx1B4cU63OP+RLk2lkU?= =?us-ascii?Q?NFggr7EUAPi/PbyX9Tf9W8GySlta82I1W301rbj86wpSrVUnPkEj9xh2CxoI?= =?us-ascii?Q?RwdyDw1TJzlTTla69MDzCnEqxxgilQhYRC6UKRhCR7AaRO6GFJFy7x5b/Mh+?= =?us-ascii?Q?CARO4fnOBUCJL7SGh3elXjs7TBO5uNZNpzWK/zRWnhmTM+PkvRwL1Qy/dVeh?= =?us-ascii?Q?owRH1Ksp1UaBJ5ryNoeSKsENFkqkLudtpYDNSLD/+xLOAHw6/Tq9ck1ZlZJB?= =?us-ascii?Q?DchHUrz2LatDpMO9vC+xZoJ8rQog/sSXggTpiCod++Ym7HimakBB2ZYkJ25Y?= =?us-ascii?Q?QJlJDyQYJsmabO4QafW2yKsFqkd9yZ3miRnbGPXawR0eOj30hOmBGX3jjNcw?= =?us-ascii?Q?o5pAbFu4zdOf70eV6cf/4BlskRsCwxemFonF5nlysxZMFUm9Kk0G80HdjZ2f?= =?us-ascii?Q?t2+BXb3umrhT87f7MqsPJAN8YzpQ+Tgo51YykqFpNfRFhubPOi+F1CbsZev9?= =?us-ascii?Q?H5MyP+b1P/Ljzg/r4fAXm8fl+672V8SJuS+pY6y484UlifyZk1UZdckXp49R?= =?us-ascii?Q?T2JDtOWyjvRbl8MkcqgJStk+G58GNERZyrQAQxM9lvYw5WdR3aXxhJHw/IpO?= =?us-ascii?Q?op4KpkhQTBQNzU3jH11cRjBtuf40+0tVd4XV5R31hUc5q1Vxe3/tVHD71pCF?= =?us-ascii?Q?GC5O3jRHbU1eUMkZ0NBDCnhl4QGClkhzdVoMCG7xZxIHaek840hY6LdqIz+u?= =?us-ascii?Q?fvghQfZUiM68iJpFsO0zswko6L6Pj5QBdjbuVP7vKKv+G/B8oL7/J3wqhJEo?= =?us-ascii?Q?bVDJ7f7j69km4OoaY4Gd4HQ7hb4OpB1J+ZYCj1nhWkVpo+qVsF0O0Dwq0zfg?= =?us-ascii?Q?RjdkZ7EFHD5vxUdLxwU=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: c3dad913-e97d-4020-83dd-08de2c58d078 X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3613.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2025 19:28:30.1454 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EFnLDE+qTP5/xwwm7RmAJkZp1zodKm4IzzfausHCNunrLfrWWW+7U8DiOkloBH5c X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7221 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251125_112836_770824_FDB72ED3 X-CRM114-Status: GOOD ( 15.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 21, 2025 at 05:57:32PM -0800, Nicolin Chen wrote: > PCIe permits a device to ignore ATS invalidation TLPs while processing a > reset. This creates a problem visible to the OS where an ATS invalidation > command will time out: e.g. an SVA domain will have no coordination with a > reset event and can racily issue ATS invalidations to a resetting device. > > The PCIe r6.0, sec 10.3.1 IMPLEMENTATION NOTE recommends SW to disable and > block ATS before initiating a Function Level Reset. It also mentions that > other reset methods could have the same vulnerability as well. > > The IOMMU subsystem provides pci_dev_reset_iommu_prepare/done() callback > helpers for this matter. Use them in all the existing reset functions. > > This will attach the device to its iommu_group->blocking_domain during the > device reset, so as to allow IOMMU driver to: > - invoke pci_disable_ats() and pci_enable_ats(), if necessary > - wait for all ATS invalidations to complete > - stop issuing new ATS invalidations > - fence any incoming ATS queries > > Reviewed-by: Kevin Tian > Signed-off-by: Nicolin Chen > --- > drivers/pci/pci-acpi.c | 13 +++++++-- > drivers/pci/pci.c | 65 +++++++++++++++++++++++++++++++++++++----- > drivers/pci/quirks.c | 19 +++++++++++- > 3 files changed, 87 insertions(+), 10 deletions(-) Reviewed-by: Jason Gunthorpe Jason