From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 47EA3D1118B for ; Wed, 26 Nov 2025 17:38:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gtwGPUSYrT3C7fb4DdUoNkStAAhzJrloynTtI6PT9qQ=; b=Egz8HIA14eUJG8BYZ0hhxSon07 pvIic62LDiqmT4SVBcrU+pJthYIgygyJEsuFgrsVltFVsn3tx4wa/ZfTQSsHRVJwbm1qGtXh2FpVD cbXr+dYtgYmzkTIzpEaK8tN0DmcvGsBlt15N/Jd/Q6hPn2OlrXvG5YcKTRiVXxUYFO17DNUr3upI0 RS8lkbIpqMXGR4eDeqlrfE3yZcBts7jk0Y9WocniLdGqdcKH4Zce4qPX+MiZmJzxiAJjFaErON2QI 0diCnFrcvV1DavIuJSVV+t1WANGpvSug0Q60i+GdVSLjTWL211LGD5sln43UhiMXYN4+xqd7ozIYL tSQlv+5g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vOJSk-0000000FPSk-3XXn; Wed, 26 Nov 2025 17:37:54 +0000 Received: from smtpout-03.galae.net ([185.246.85.4]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vOJSS-0000000FPAD-3vE8 for linux-arm-kernel@lists.infradead.org; Wed, 26 Nov 2025 17:37:38 +0000 Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 737B34E418DB; Wed, 26 Nov 2025 17:37:35 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 4885960721; Wed, 26 Nov 2025 17:37:35 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id A8F90102F1D8D; Wed, 26 Nov 2025 18:37:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1764178653; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=gtwGPUSYrT3C7fb4DdUoNkStAAhzJrloynTtI6PT9qQ=; b=EHHfyEiD/ZIiNwX6xnOOl5d1kgfFcBablmaVmdt4fytDu5PczzIEB1L9aCqASmjiZJ+FEd gL07rp6pvw0o6AjNqJyZmVzpse5QceVPJeSYclGXijdSr3DwUrmKKlqLBbyvcx/UD32K1c 3tAbk1wMLcyfOc/jLD/KSos0DD/kVmjpao+JQKJQeqaFDISYfBYheHtj5/j+aLrSQy7O/K 3GW7Vki5caC1p0B2tQ4HOgx30Zdpyau4Mz3flOYBf7L5yvHHIyNFacoJkorc6S5LKqLUYw XTOX4/g/4PVIUYSmuIQmnZ3Q+4X/aFi2zmL9zCdGggwohV7gp8sfzSdBBYSh/g== From: "Kory Maincent (TI.com)" Date: Wed, 26 Nov 2025 18:35:59 +0100 Subject: [PATCH 17/21] drm/bridge: tda998x: Remove component support MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20251126-feature_tilcdc-v1-17-49b9ef2e3aa0@bootlin.com> References: <20251126-feature_tilcdc-v1-0-49b9ef2e3aa0@bootlin.com> In-Reply-To: <20251126-feature_tilcdc-v1-0-49b9ef2e3aa0@bootlin.com> To: Jyri Sarha , Tomi Valkeinen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Russell King , Bartosz Golaszewski , Tony Lindgren , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec Cc: Markus Schneider-Pargmann , Luca Ceresoli , Louis Chauvet , Thomas Petazzoni , Miguel Gazquez , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, "Kory Maincent (TI.com)" X-Mailer: b4 0.14.3 X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251126_093737_136616_6A1C145B X-CRM114-Status: GOOD ( 14.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The tilcdc driver no longer uses the component framework to bind the tda998x bridge driver. The component bind/unbind operations and the encoder initialization code are now dead code and can be safely removed. Signed-off-by: Kory Maincent (TI.com) --- drivers/gpu/drm/bridge/tda998x_drv.c | 69 +----------------------------------- 1 file changed, 1 insertion(+), 68 deletions(-) diff --git a/drivers/gpu/drm/bridge/tda998x_drv.c b/drivers/gpu/drm/bridge/tda998x_drv.c index e636459d91857..865285ba2bd8c 100644 --- a/drivers/gpu/drm/bridge/tda998x_drv.c +++ b/drivers/gpu/drm/bridge/tda998x_drv.c @@ -4,7 +4,6 @@ * Author: Rob Clark */ -#include #include #include #include @@ -1963,85 +1962,19 @@ static int tda998x_create(struct device *dev) return ret; } -/* DRM encoder functions */ - -static int tda998x_encoder_init(struct device *dev, struct drm_device *drm) -{ - struct tda998x_priv *priv = dev_get_drvdata(dev); - u32 crtcs = 0; - int ret; - - if (dev->of_node) - crtcs = drm_of_find_possible_crtcs(drm, dev->of_node); - - /* If no CRTCs were found, fall back to our old behaviour */ - if (crtcs == 0) { - dev_warn(dev, "Falling back to first CRTC\n"); - crtcs = 1 << 0; - } - - priv->encoder.possible_crtcs = crtcs; - - ret = drm_simple_encoder_init(drm, &priv->encoder, - DRM_MODE_ENCODER_TMDS); - if (ret) - goto err_encoder; - - ret = drm_bridge_attach(&priv->encoder, &priv->bridge, NULL, 0); - if (ret) - goto err_bridge; - - return 0; - -err_bridge: - drm_encoder_cleanup(&priv->encoder); -err_encoder: - return ret; -} - -static int tda998x_bind(struct device *dev, struct device *master, void *data) -{ - struct drm_device *drm = data; - - return tda998x_encoder_init(dev, drm); -} - -static void tda998x_unbind(struct device *dev, struct device *master, - void *data) -{ - struct tda998x_priv *priv = dev_get_drvdata(dev); - - drm_encoder_cleanup(&priv->encoder); -} - -static const struct component_ops tda998x_ops = { - .bind = tda998x_bind, - .unbind = tda998x_unbind, -}; - static int tda998x_probe(struct i2c_client *client) { - int ret; - if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) { dev_warn(&client->dev, "adapter does not support I2C\n"); return -EIO; } - ret = tda998x_create(&client->dev); - if (ret) - return ret; - - ret = component_add(&client->dev, &tda998x_ops); - if (ret) - tda998x_destroy(&client->dev); - return ret; + return tda998x_create(&client->dev); } static void tda998x_remove(struct i2c_client *client) { - component_del(&client->dev, &tda998x_ops); tda998x_destroy(&client->dev); } -- 2.43.0