Re: [PATCH] MEDIATEK: serial: 8250_mtk: Add ACPI support

Zhiyong Tao (陶志勇)
2026-03-25T06:40:09Z

On Wed, 2026-03-18 at 15:19 +0100, gregkh@linuxfoundation.org wrote:
> On Wed, Mar 18, 2026 at 12:12:36PM +0000, Zhiyong Tao (陶志勇) wrote:
> > On Wed, 2026-01-21 at 14:23 +0800, Zhiyong Tao wrote:
> > > On Tue, 2026-01-06 at 11:02 +0100, Greg KH wrote:
> > > > On Mon, Jan 05, 2026 at 10:39:55AM +0800, Zhiyong Tao wrote:
> > > > > From: "Zhiyong.Tao" <zhiyong.tao@mediatek.com>
> > > > >
> > > > > Add ACPI support to 8250_mtk driver. This makes it possible
> > > > > to
> > > > > use UART on ARM-based desktops with EDK2 UEFI firmware.
> > > > >
> > > > > Signed-off-by: Yenchia Chen <yenchia.chen@mediatek.com>
> > > > > Signed-off-by: Zhiyong.Tao <zhiyong.tao@mediatek.com>
> > > > > ---
> > > > >  drivers/tty/serial/8250/8250_mtk.c | 23 +++++++++++++++++++-
> > > > > ---
> > > > >  1 file changed, 19 insertions(+), 4 deletions(-)

==>Hi Greg,

Yes, it is a resend of the previous version to rebase to tip for
friendly ping. it is based on the latest linux-next version.

Thanks

> > > >
> > > > This is a resend of the previous version, right?  Or did
> > > > something
> > > > change?
> > > >
> > > > confused,
> > > >
> > > > greg k-h
> > >
> > > ==> Hi Greg,
> > > Yes, previously Yenchia Chen helped to send out a version.
> > > Currently,
> > > this solution is specifically for the GB10 project and was made
> > > to
> > > support Windows ACPI settings.
> > >
> > > In actual application scenarios, the apdma clk will not be turned
> > > off
> > > in normal mode. It is only turned off in the SSPM microprocessor
> > > after
> > > entering standby, and when resuming, the apdma clk is re-enabled
> > > by
> > > SSPM.
> > >
> > > As for other Linux projects, apdma still uses the DTS node.
> > >
> > > Thanks
> > >
> >
> > Hi Greg,
> > Do you have other suggestion for this?
>
> You can't just resend something and not say why you are resending it.
> Also, the authorship information seems to be backwards.
>
> thanks,
>
> greg k-h