From: Jakub Kicinski <kuba@kernel.org>
To: Parvathi Pudi <parvathi@couthit.com>
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, danishanwar@ti.com, rogerq@kernel.org,
pmohan@couthit.com, basharath@couthit.com, afd@ti.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, alok.a.tiwari@oracle.com,
horms@kernel.org, pratheesh@ti.com, j-rameshbabu@ti.com,
vigneshr@ti.com, praneeth@ti.com, srk@ti.com, rogerq@ti.com,
krishna@couthit.com, mohan@couthit.com
Subject: Re: [PATCH net-next v8 1/3] net: ti: icssm-prueth: Add helper functions to configure and maintain FDB
Date: Mon, 1 Dec 2025 14:18:58 -0800 [thread overview]
Message-ID: <20251201141858.399fff62@kernel.org> (raw)
In-Reply-To: <20251126163056.2697668-2-parvathi@couthit.com>
On Wed, 26 Nov 2025 21:57:12 +0530 Parvathi Pudi wrote:
> + u8 hash_val, mac_tbl_idx;
Using narrow types is generally quite counter productive.
It can easily mask out-of-range accesses and subtle errors,
given that max is outside of the range of the u8 type:
+#define FDB_INDEX_TBL_MAX_ENTRIES 256
+#define FDB_MAC_TBL_MAX_ENTRIES 256
You should consider changing all the local variables to unsigned int.
next prev parent reply other threads:[~2025-12-01 22:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-26 16:27 [PATCH net-next v8 0/3] STP/RSTP SWITCH support for PRU-ICSSM Ethernet driver Parvathi Pudi
2025-11-26 16:27 ` [PATCH net-next v8 1/3] net: ti: icssm-prueth: Add helper functions to configure and maintain FDB Parvathi Pudi
2025-12-01 22:18 ` Jakub Kicinski [this message]
2025-12-03 8:40 ` Parvathi Pudi
2025-11-26 16:27 ` [PATCH net-next v8 2/3] net: ti: icssm-prueth: Add switchdev support for icssm_prueth driver Parvathi Pudi
2025-12-01 22:16 ` Jakub Kicinski
2025-12-03 8:37 ` Parvathi Pudi
2025-11-26 16:27 ` [PATCH net-next v8 3/3] net: ti: icssm-prueth: Add support for ICSSM RSTP switch Parvathi Pudi
2025-11-28 2:43 ` [PATCH net-next v8 0/3] STP/RSTP SWITCH support for PRU-ICSSM Ethernet driver Jakub Kicinski
2025-11-28 12:34 ` Parvathi Pudi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251201141858.399fff62@kernel.org \
--to=kuba@kernel.org \
--cc=afd@ti.com \
--cc=alok.a.tiwari@oracle.com \
--cc=andrew+netdev@lunn.ch \
--cc=basharath@couthit.com \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=j-rameshbabu@ti.com \
--cc=krishna@couthit.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mohan@couthit.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=parvathi@couthit.com \
--cc=pmohan@couthit.com \
--cc=praneeth@ti.com \
--cc=pratheesh@ti.com \
--cc=rogerq@kernel.org \
--cc=rogerq@ti.com \
--cc=srk@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).