From: Carlos Song <carlos.song@nxp.com>
To: frank.li@nxp.com, mkl@pengutronix.de, broonie@kernel.org,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, kees@kernel.org,
gustavoars@kernel.org
Cc: linux-spi@vger.kernel.org, imx@lists.linux.dev,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-hardening@vger.kernel.org,
Carlos Song <carlos.song@nxp.com>, Frank Li <Frank.Li@nxp.com>
Subject: [PATCH v2 1/6] spi: imx: group spi_imx_dma_configure() with spi_imx_dma_transfer()
Date: Tue, 2 Dec 2025 15:54:58 +0800 [thread overview]
Message-ID: <20251202075503.2448339-2-carlos.song@nxp.com> (raw)
In-Reply-To: <20251202075503.2448339-1-carlos.song@nxp.com>
Relocate spi_imx_dma_configure() next to spi_imx_dma_transfer() so that
all DMA-related functions are grouped together for better readability.
No functional changes.
Signed-off-by: Carlos Song <carlos.song@nxp.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
---
drivers/spi/spi-imx.c | 88 +++++++++++++++++++++----------------------
1 file changed, 44 insertions(+), 44 deletions(-)
diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c
index b8b79bb7fec3..e78e02a84b50 100644
--- a/drivers/spi/spi-imx.c
+++ b/drivers/spi/spi-imx.c
@@ -1282,50 +1282,6 @@ static irqreturn_t spi_imx_isr(int irq, void *dev_id)
return IRQ_HANDLED;
}
-static int spi_imx_dma_configure(struct spi_controller *controller)
-{
- int ret;
- enum dma_slave_buswidth buswidth;
- struct dma_slave_config rx = {}, tx = {};
- struct spi_imx_data *spi_imx = spi_controller_get_devdata(controller);
-
- switch (spi_imx_bytes_per_word(spi_imx->bits_per_word)) {
- case 4:
- buswidth = DMA_SLAVE_BUSWIDTH_4_BYTES;
- break;
- case 2:
- buswidth = DMA_SLAVE_BUSWIDTH_2_BYTES;
- break;
- case 1:
- buswidth = DMA_SLAVE_BUSWIDTH_1_BYTE;
- break;
- default:
- return -EINVAL;
- }
-
- tx.direction = DMA_MEM_TO_DEV;
- tx.dst_addr = spi_imx->base_phys + MXC_CSPITXDATA;
- tx.dst_addr_width = buswidth;
- tx.dst_maxburst = spi_imx->wml;
- ret = dmaengine_slave_config(controller->dma_tx, &tx);
- if (ret) {
- dev_err(spi_imx->dev, "TX dma configuration failed with %d\n", ret);
- return ret;
- }
-
- rx.direction = DMA_DEV_TO_MEM;
- rx.src_addr = spi_imx->base_phys + MXC_CSPIRXDATA;
- rx.src_addr_width = buswidth;
- rx.src_maxburst = spi_imx->wml;
- ret = dmaengine_slave_config(controller->dma_rx, &rx);
- if (ret) {
- dev_err(spi_imx->dev, "RX dma configuration failed with %d\n", ret);
- return ret;
- }
-
- return 0;
-}
-
static int spi_imx_setupxfer(struct spi_device *spi,
struct spi_transfer *t)
{
@@ -1481,6 +1437,50 @@ static int spi_imx_calculate_timeout(struct spi_imx_data *spi_imx, int size)
return secs_to_jiffies(2 * timeout);
}
+static int spi_imx_dma_configure(struct spi_controller *controller)
+{
+ int ret;
+ enum dma_slave_buswidth buswidth;
+ struct dma_slave_config rx = {}, tx = {};
+ struct spi_imx_data *spi_imx = spi_controller_get_devdata(controller);
+
+ switch (spi_imx_bytes_per_word(spi_imx->bits_per_word)) {
+ case 4:
+ buswidth = DMA_SLAVE_BUSWIDTH_4_BYTES;
+ break;
+ case 2:
+ buswidth = DMA_SLAVE_BUSWIDTH_2_BYTES;
+ break;
+ case 1:
+ buswidth = DMA_SLAVE_BUSWIDTH_1_BYTE;
+ break;
+ default:
+ return -EINVAL;
+ }
+
+ tx.direction = DMA_MEM_TO_DEV;
+ tx.dst_addr = spi_imx->base_phys + MXC_CSPITXDATA;
+ tx.dst_addr_width = buswidth;
+ tx.dst_maxburst = spi_imx->wml;
+ ret = dmaengine_slave_config(controller->dma_tx, &tx);
+ if (ret) {
+ dev_err(spi_imx->dev, "TX dma configuration failed with %d\n", ret);
+ return ret;
+ }
+
+ rx.direction = DMA_DEV_TO_MEM;
+ rx.src_addr = spi_imx->base_phys + MXC_CSPIRXDATA;
+ rx.src_addr_width = buswidth;
+ rx.src_maxburst = spi_imx->wml;
+ ret = dmaengine_slave_config(controller->dma_rx, &rx);
+ if (ret) {
+ dev_err(spi_imx->dev, "RX dma configuration failed with %d\n", ret);
+ return ret;
+ }
+
+ return 0;
+}
+
static int spi_imx_dma_transfer(struct spi_imx_data *spi_imx,
struct spi_transfer *transfer)
{
--
2.34.1
next prev parent reply other threads:[~2025-12-02 7:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-02 7:54 [PATCH v2 0/6] Support ECSPI dynamic burst feature for DMA mode Carlos Song
2025-12-02 7:54 ` Carlos Song [this message]
2025-12-02 7:54 ` [PATCH v2 2/6] spi: imx: introduce helper to clear DMA mode logic Carlos Song
2025-12-02 7:55 ` [PATCH v2 3/6] spi: imx: avoid dmaengine_terminate_all() on TX prep failure Carlos Song
2025-12-02 7:55 ` [PATCH v2 4/6] spi: imx: handle DMA submission errors with dma_submit_error() Carlos Song
2025-12-02 7:55 ` [PATCH v2 5/6] spi: imx: support dynamic burst length for ECSPI DMA mode Carlos Song
2025-12-02 15:06 ` Frank Li
2025-12-03 6:59 ` kernel test robot
2025-12-02 7:55 ` [PATCH v2 6/6] spi: imx: enable DMA mode for target operation Carlos Song
2025-12-02 14:52 ` Frank Li
2025-12-15 13:59 ` [PATCH v2 0/6] Support ECSPI dynamic burst feature for DMA mode Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251202075503.2448339-2-carlos.song@nxp.com \
--to=carlos.song@nxp.com \
--cc=broonie@kernel.org \
--cc=festevam@gmail.com \
--cc=frank.li@nxp.com \
--cc=gustavoars@kernel.org \
--cc=imx@lists.linux.dev \
--cc=kees@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox