From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E9CD2CFD376 for ; Tue, 2 Dec 2025 07:56:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AsjHYHNLwrkWNxGNsJ2qgEZe4Qdgqq+BoLSOrD9LpHU=; b=GUGxqjJxE0IFNJxrIGu+PaSBV4 n0lBACSv9hLOTNT+U6dvFo9JFt0Vrbd78weWdn7L5DbT9whZMcfM8zJ9jbC8Y66C5Wm+iBmPH3z/U qBsJBDjgvegvDwXewF6dZU6Jqze4XurxfsyHSR/KImEAlGpUpaz+DALV/JFsR2bFJh5He1Kz5UUB+ CQJrmeUQKenZjvSL83jNvcZ5QeqUlSCHARZ+Mu7Jtr/V/94SiTmfD9zh65nXlV/ZAkswEiwZC39mT NuBwbefFoLLJ3EBYeVb22de2GOsMOi/enLeX4H+qhZ+ZmioL1w0n1fFhyzh4aHefZQVLwVN0S2lLw x8sTm8QQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vQLEx-000000050Uh-284y; Tue, 02 Dec 2025 07:56:05 +0000 Received: from mail-westeuropeazon11010048.outbound.protection.outlook.com ([52.101.69.48] helo=AM0PR83CU005.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vQLEv-000000050TE-19yu for linux-arm-kernel@lists.infradead.org; Tue, 02 Dec 2025 07:56:02 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=y1hFtUk85Y5wmjUmOqRjx94VOgHZiGN9JeCSwJTbjTomnKwgqsEpZxOy4AfQof+dc+bHsc3B6wiArrx1X5K7KmeoNdQqJYdq/8YDl14Pc3vt39iMnpAoVvklipW/ntMXXD7YbsYzdXhfsfn0uiwZeykLaByl7ER3ZkwwBomMZadgl45oAmqcOfhq3PWbZN/e8zKkWl4b6RDBxWBiKuCWrSHD40c6uiFIhQ2i/SV+QNqiyEDEP5fRJihRQUaOuE3LfoUl2IBnkpX9EW3UamE6gYUDi2fDLWkQIIrow7trnUeisLLU8HVJjHkcGz1C0+GMrxDP/aROzpJbkxZD059XZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AsjHYHNLwrkWNxGNsJ2qgEZe4Qdgqq+BoLSOrD9LpHU=; b=SdAwqswmLeicLV+P3Jne9upaxaKNEA8nFJzNrPEUEV6+wL9qcEkuC3zofAV37nIxUGfZrPbDEM9MSfvmNzf+U6QpKHDZ40Q0MAMxbjAvvsA7bhj2aI16xVv+7CV29kxQdGqwRag761hmpFBBZO5bP8cfLJG0YDFA0OX3DU4eMcxdB2tq+w2YzS3menTpCA+jBtFdYekNfDi8YzwULGr3UTh2pTFLqXI50h7KhpNu1V97cdKQCC2r8JTDM12FOKkX28ZN26MlMXE2XhVvU6VPwGni82alaQ1rEvKoB+cnsmYFNzn+xnZ7cUHW+qnFIUmCP5lVb3rE0MNfVlY3KC/ygA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AsjHYHNLwrkWNxGNsJ2qgEZe4Qdgqq+BoLSOrD9LpHU=; b=TwIID5/mCGFvW8iTW7aq2ym/Q6x0Fj0KPQJcFmF8QTpLXNEJnPchxTOaphH21uxW4KFBvrQ5mUiXeSqqqeFMMRkpbzJOS9dfIk9TRVE7vesWa4WD++5WXkZhtf98OIYpg0LHRKVYa0UOF3FoHuPcBGrlu8J0gsJWRSWmZ8izZx/3f6Awx/2hqDzUnCcYSJXttpUN8HKcKenV5HBS6sTTeBuk4WjVo7P7Tx2mUBp6M6Tn2G2TxmbiGPxfC8FYmuItavf5Jt94BSNDXn9/YgRdFNVhYJwHE/y96ItxIzE2v9pw0IoKvOtFRK9K4CnTugH/CGBAPvvOpHTRN3MBsC/WDA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from VI2PR04MB11147.eurprd04.prod.outlook.com (2603:10a6:800:293::14) by DBBPR04MB7900.eurprd04.prod.outlook.com (2603:10a6:10:1e8::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9388.9; Tue, 2 Dec 2025 07:55:56 +0000 Received: from VI2PR04MB11147.eurprd04.prod.outlook.com ([fe80::75ad:fac7:cfe7:b687]) by VI2PR04MB11147.eurprd04.prod.outlook.com ([fe80::75ad:fac7:cfe7:b687%6]) with mapi id 15.20.9366.012; Tue, 2 Dec 2025 07:55:56 +0000 From: Carlos Song To: frank.li@nxp.com, mkl@pengutronix.de, broonie@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, kees@kernel.org, gustavoars@kernel.org Cc: linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hardening@vger.kernel.org, Carlos Song , Frank Li Subject: [PATCH v2 3/6] spi: imx: avoid dmaengine_terminate_all() on TX prep failure Date: Tue, 2 Dec 2025 15:55:00 +0800 Message-Id: <20251202075503.2448339-4-carlos.song@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251202075503.2448339-1-carlos.song@nxp.com> References: <20251202075503.2448339-1-carlos.song@nxp.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: AS4P189CA0052.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:659::21) To VI2PR04MB11147.eurprd04.prod.outlook.com (2603:10a6:800:293::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI2PR04MB11147:EE_|DBBPR04MB7900:EE_ X-MS-Office365-Filtering-Correlation-Id: 620fc7ac-d382-443a-8eda-08de3178390f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|7416014|376014|366016|1800799024|19092799006|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?pNBLPBr0otFmH7aetpKQO1DgUh1OKp4wOxVreFy18nWC1K7M6kw6DC/Asv9W?= =?us-ascii?Q?kYysyW0BXLYx5gcUvz5rGzInCK72hFVeTImsMCWS0ITfIQmt37bJunadP424?= =?us-ascii?Q?NRGre3z24EmKZreHGvxZvBOkG9rZQ9RQruqRePnHo4sBD+gBTfDNrV1/n8yW?= =?us-ascii?Q?iW33+Pbc+cyul1rysmG2Bf0kk63taY5Wq4Ky6KRjUmdwOpcxdOaCJBR8kr1E?= =?us-ascii?Q?xpj6i4Cvwvn3x3VXKdtVlFij8jB7PJKkLqKE9IMhGxntR/Wx4siWAH1eIaBh?= =?us-ascii?Q?YVZfcyaUfYS6v6RfdpuO7BY4O7jj9SwOcityL/2ZtTrYzr89I3zfGw/QJGMX?= =?us-ascii?Q?uAv8XTYAlTlHTWyrrLpS/TqTZr+p85VlCaM4ef+pb0VFfM1LiS9tlkkzP3K9?= =?us-ascii?Q?TUuXqrS1zzce0dCfhYOSYmhvTyU1rs9/1zCEOYpIf7+FTHKjIQ1Rg2NWqdnO?= =?us-ascii?Q?tq5B5mcjsZwMsEPbu/3wPntc+utv8Z1BMV+BJ3hExzM+Lt9wMdusHcypv0pT?= =?us-ascii?Q?T1HjT8Ct+1KLTqtnlRcp+xEKCTdXKSBnXBv1YZN2E6WGifYOX70yfYAdNWEP?= =?us-ascii?Q?7DatxYJEoyEx07mJaMAj7nuPJ2g+LbtI0y4TGtoMjUAfYvRPt4xyOIKNwr/h?= =?us-ascii?Q?KMfcGvT5qveK8fI0lS7GMrqu/tplhDxpxvE9oOxfKh3STVklEtI/cHU8n0+r?= =?us-ascii?Q?fjEkAdUOYbsPCSE+zkjlC5Aobkh9qXIm5Q7nDyS9KY1/jCyBLfrTF7aYLsHH?= =?us-ascii?Q?n9DStZpEAbNGIfm1lyBIap8HFQTNtBa5i/5t9YNKC0gqnB5pP9FM+gK0ugoT?= =?us-ascii?Q?k4HA+uMAgv2PTrTlRa2qEHGhFP2a0fhKyCw4yheQTvAm2jWqIE8/K/rDaD0k?= =?us-ascii?Q?vYsaFT0jo1lymAGQ2ZPHZM867+lU6Objj2V2YohIjlbwoD2r7qwmnJqNcL9l?= =?us-ascii?Q?xv5IjLgva1Ii66IGGwoQXYvLY4uFmcfqGurfCZ5NBTBE+vPCi9OWxI1hwMIS?= =?us-ascii?Q?YSGW7dt1rIxwxAR8YKtz+S7sUqtgDRyEC9dVTVZBjn2owrA1YSDebOyQvMHB?= =?us-ascii?Q?pxi8DcLsrwX2wFUSsqn4L7BRQO6iAu0+gGFTGrx7eLe73gYXOjjUHHnXdk04?= =?us-ascii?Q?whefpJ+oxZMSGhdquaIbvqoDxhBO2Ud1epzXO9xISWk5wmlxZJSHBGZceTHa?= =?us-ascii?Q?IAyRLjAhxrnIx8JCxnGgsp/01QJBZA6w5GWQ6sCdVy3C27vr3KimhhwvD58X?= =?us-ascii?Q?goWMYZcFPdN0MvnZ/V+8Yqdlo8baz+J/XnTIWXnQHEbNB8xKueMu+1j+tM++?= =?us-ascii?Q?eoGWeGFynJ2WP5c34Gab9lCSlLEvaYe+SH7GV04hqjl6nqA1TwL++G7/IcPG?= =?us-ascii?Q?9KWJkjUCDOCxXj1uwGgsvyzBPdzLTUe5gIoNhUuuGpcUo5v6vioHUVznSlFy?= =?us-ascii?Q?JZVKALinhJtT3QqR4a26HtjM0/iUM/X9fd51G7B7J4IfyYS+foUFeTRhB5cj?= =?us-ascii?Q?fimKAouBzjAWZ6rhKjVSwZ5rYCajfQ4a1jAd?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI2PR04MB11147.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(7416014)(376014)(366016)(1800799024)(19092799006)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4RRgjIG3Lq54BHgT+Rwl0K0bTxRvpLWvw7Z+teWVv65dN/VyBWBZIIxS/0n6?= =?us-ascii?Q?uo9GhDj8DIwU5YbNOKnlWVLKDWQu2YHG0S6a5qXmcuGA5XBaqoxMxASrlsvp?= =?us-ascii?Q?tropH3/QB+ZGZvwUealYYfML0iXTHf3X2+VO/a02rXR/hsac92/dF+Lz8M9l?= =?us-ascii?Q?7lhvUg5P5BFCB6RTKgNj4uNkejUQ4VTaE++imtgrJpzajRAJuOavZo1L5kc9?= =?us-ascii?Q?LJ+8EcLUzG26Gwl5Wh0h9NnwjK/dhg+rY0SzNzXYhAFczCf/atToJOQfg1MM?= =?us-ascii?Q?lznSLAXAE+rQI5SgyP5KTZp3sAXpAc481oBppvmuzAIIDrhYaeL4ulDsbXcb?= =?us-ascii?Q?tJ6oWgcZ+/zcbyby/UdqVXLVZ+8gSTBaj5lLtpMcxED/SGmdD9Pw0AdzdmRu?= =?us-ascii?Q?j4BpkuWdImrNUsGL3fvowXvEECtYRY33Z2WNBkxcjS8O6wOByaZ1HfGY3l47?= =?us-ascii?Q?qaavd4Eai8yFhY/ezNrmogGB5sTHNd70cJU9sfFPaew1SkdTABnmB4et83Dn?= =?us-ascii?Q?yvtotlnXnwhgNpLMZRs28opMEGu8d/ZfBzgWPDfQvNQr3mKhbmcNR6Qr6NN7?= =?us-ascii?Q?fXhRJDozmbWu4ijIc0a5mMmkhxY3NHmUTsbh3rxKNeIX0rl9eKSqTM8VJo6w?= =?us-ascii?Q?AcS0MIpKxad7EUlH+jw/y8ulPDJTB09Q/M2hvUfb8PbgwBg58Bs8j9tSUeuH?= =?us-ascii?Q?lnvjYpjqGXbguU4WLs3aPxGP4BI0ieOx54gQG/7MbjGVneMFHCv5rqpDxowR?= =?us-ascii?Q?zWcigqUgVkT0soOaQp+kT48fd7wPO7JbAsRgHJKRtDH9Buawc+w2GpeqLMu2?= =?us-ascii?Q?XqiFXFhOHODMnNflT+gQcVAXYN1HZ/v4Oaj5Yz6lN8UZxzTW7L2zEZBSU75C?= =?us-ascii?Q?4pSxiOzM0wpnNZoK39cYa1xinVR+lSTs5foYF3J4g7iSsSaWmFjr1bm9Bltf?= =?us-ascii?Q?H+HRaIWdbmM3CksSn90Bz26n+kuoPWQYDKCtEK+6lEFRgq7PtBD6qC6fd8bk?= =?us-ascii?Q?7AQIgQX9LzAZEXB6Tf5LwD+OseRWOIPtLW3hgdxLzyi7OcLtFXnsx9smp5ir?= =?us-ascii?Q?Irq2cChFmtEr339rFf9R9/IxDXMRXxTge9cAYel6OG5CXNLc6+AePc+XLa8K?= =?us-ascii?Q?4/KXTlh1Jq/leLuAa4rN4CBZMD36YTA4v1qTYvcffl/zdy9+BMfA5eRAJjAB?= =?us-ascii?Q?uhnhlmaXIk4l6GPIlPDFCHI7Cq8yX/tUv9113wLlOSVjSrkoXEsASRLoBt9p?= =?us-ascii?Q?boPo8etKT1AwuMf23/qe2RYhtRhRXOxUHmosAp77jnUKr7nmacLmP0ddhixF?= =?us-ascii?Q?n98nP/5QQ9lzRz3Hy24YdtmZjHQcAhEpumPChWnOxMgg1KLJCGxYJ21KFcze?= =?us-ascii?Q?Pc0PQl4frC550JlPpMOwmqocu2zI4bR8TKU+1uxSnY3opbG9AZH5QBDecjmV?= =?us-ascii?Q?m7cmDUL4tq/lpXnDwZvjirSmeHZ6n5GkqCPf+Ekqh2uAkhMcDO9VVUCkLq5o?= =?us-ascii?Q?wmKnfCJWKDQDy3N85ABCPE/D3g/CWs6RSSz6ZyKyTQTW3TP1pCzWIhbskuXl?= =?us-ascii?Q?txhibzZ2iCg1EGg6r1JQgqYRUhbykMd8cen8OYcx?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 620fc7ac-d382-443a-8eda-08de3178390f X-MS-Exchange-CrossTenant-AuthSource: VI2PR04MB11147.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2025 07:55:56.0614 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vqg4MWy50Hc9wFC06tk/3kVDFVQpBuTus/GmxCJmXcJLfTpRzHf9FsAPwPfmXU4GJhfZ0OpDkELW35tar5USxQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7900 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251201_235601_321428_FC2461DC X-CRM114-Status: GOOD ( 10.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org If dmaengine_prep_slave_sg() fails, no descriptor is submitted to the TX channel and DMA is never started. Therefore, calling dmaengine_terminate_all() for the TX DMA channel is unnecessary. Signed-off-by: Carlos Song Reviewed-by: Frank Li --- drivers/spi/spi-imx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c index 012f5bcbf73f..186963d3d2e0 100644 --- a/drivers/spi/spi-imx.c +++ b/drivers/spi/spi-imx.c @@ -1468,7 +1468,6 @@ static int spi_imx_dma_submit(struct spi_imx_data *spi_imx, tx->sgl, tx->nents, DMA_MEM_TO_DEV, DMA_PREP_INTERRUPT | DMA_CTRL_ACK); if (!desc_tx) { - dmaengine_terminate_all(controller->dma_tx); dmaengine_terminate_all(controller->dma_rx); return -EINVAL; } -- 2.34.1