From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9B476CFD2F6 for ; Tue, 2 Dec 2025 09:37:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:Cc:To:From: Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+urX4bYsJY4uNvVnW0RPoXjdHSG5o+44VhSDvcUY5g8=; b=RvR3GMhucFEAh602eDL/pF86St Si3IZ9KMeadTLECZb3/hIZbFcuppLFQdVqilLTku2UBrcGjbhvKXPSEOTpZqIOeVEjyng2k0HILcC Mv9ybRRcaPpUUFWuHFDduYUtirU8zzIaRSGxDPouXf4TckDV3cYe8HCU309D8sONfAIrtlgMNDnL3 HAPg8Vq/hHW3nJgaNqk3ebs6vujD28MvAJ8aaozvJRX9Q4tPysi8ygRorWT46qdIoDehnQoeiSOFF FuxaLFvprD6doV1zR2MExDGg/SqcYWA2EBYTGKWFDkCUeEZsZIlUozklsPZFwLMmrjhb1GkeiRihq C4YQnhew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vQMp3-000000058sS-0rHZ; Tue, 02 Dec 2025 09:37:25 +0000 Received: from mail-wr1-f74.google.com ([209.85.221.74]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vQMoZ-000000058GF-2Ktn for linux-arm-kernel@lists.infradead.org; Tue, 02 Dec 2025 09:37:04 +0000 Received: by mail-wr1-f74.google.com with SMTP id ffacd0b85a97d-42b3b5ed793so4189779f8f.2 for ; Tue, 02 Dec 2025 01:36:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1764668212; x=1765273012; darn=lists.infradead.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=+urX4bYsJY4uNvVnW0RPoXjdHSG5o+44VhSDvcUY5g8=; b=cw9zTVPrWzMK2cty5RVG1i77bVEeqjG8eWqvyZjulfnZSXdDKUEhBo2Hn/WAlRdrC1 ItWTZ3QoB446WtnPOtqUKs5S+W1Bom3XgoCS9z2BuSftdcb/V+B2J9w605HKrVIFTagg edRqI7tZkS7O1W57KZLzn4zMUmB27RFkEMZx48aRgeMAvxFyX4H8pI1HWiQRFCXR1eO0 1WYTiOu+0OWbF29qfyaJqvAKRZDMk+jQtIEbzcdjvf0ZzPK7olJ1aF8Ax7cT0BSlZoWj iFhxXYxyRNt453vBgS7nxqNYl2XrufjlZj5H6SXFg06MVYcb7TImU2yeWqBuyTJfhRh1 V/Cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764668212; x=1765273012; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+urX4bYsJY4uNvVnW0RPoXjdHSG5o+44VhSDvcUY5g8=; b=Orv+hraW2XX2py2Eb6e+MJs47KKHYnc6sQRPMUPIluVaYiuTisBJI7suvUkMUWh6i0 QgB7sP6FLakErlDgxHh1UVIiNqRrrFbzyF9JJqmTYeiIrudOxQMvA4DlaVl8nt6BRRWb 2ivOSFeQkTPfppRtHb/YTzvF0eCxOt6ZlzzVlJhH3nYL2RATISm/34irbJyVEgZqmztU IQwu+NrqgaJkUkbokRnl/34drITZg7xMBuWqYa/CbtaLLVmrF2Syvs6vYMtHtxlcHZZj 913HMeiit8fSaTPi2Eg++B1DXrHWEjGIqz8149tHUNu3uoJNGqOZYF1dHABpcCTdI6HV 3fMw== X-Forwarded-Encrypted: i=1; AJvYcCVCn+Bd3C9F/k7AGaNW608nH1s9mmfe3ly4hussk+5KNnSPNetwDDWwm4n7NMxMaH9cMk9DQA7XsXIa8cbYsqtV@lists.infradead.org X-Gm-Message-State: AOJu0YyGtrquGZ/P/8hDrD+csJxLPreZYz4XSqnO2Ye0OpcayDMQV3bN ybfQkZOs1NbB47wFhMjji3ox5nk1/Y88vpw7UiVZ8JAkjBFsDVrZbgBzviHKrrUAtoDqc9WMHIW cwIjoIzPDJIwc4GZJEjv3Gw== X-Google-Smtp-Source: AGHT+IFgxxxf/V5F3C4Umac3vVzbQvZzBINLSdgbE5epwponp/6FMAwKjTUlKz+vvV7fNkbmaLpz3mFpw652zxYq X-Received: from wmcn18-n1.prod.google.com ([2002:a05:600c:c0d2:10b0:477:a0a1:eae8]) (user=vdonnefort job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:1909:b0:477:b642:9dc6 with SMTP id 5b1f17b1804b1-477c020137fmr430039125e9.34.1764668211970; Tue, 02 Dec 2025 01:36:51 -0800 (PST) Date: Tue, 2 Dec 2025 09:36:14 +0000 In-Reply-To: <20251202093623.2337860-1-vdonnefort@google.com> Mime-Version: 1.0 References: <20251202093623.2337860-1-vdonnefort@google.com> X-Mailer: git-send-email 2.52.0.107.ga0afd4fd5b-goog Message-ID: <20251202093623.2337860-22-vdonnefort@google.com> Subject: [PATCH v9 21/30] KVM: arm64: Initialise hyp_nr_cpus for nVHE hyp From: Vincent Donnefort To: rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com, linux-trace-kernel@vger.kernel.org, maz@kernel.org, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com Cc: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, jstultz@google.com, qperret@google.com, will@kernel.org, aneesh.kumar@kernel.org, kernel-team@android.com, linux-kernel@vger.kernel.org, Vincent Donnefort Content-Type: text/plain; charset="UTF-8" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251202_013655_799399_4442E905 X-CRM114-Status: GOOD ( 12.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Knowing the number of CPUs is necessary for determining the boundaries of per-cpu variables, which will be used for upcoming hypervisor tracing. hyp_nr_cpus which stores this value, is only initialised for the pKVM hypervisor. Make it accessible for the nVHE hypervisor as well. With the kernel now responsible for initialising hyp_nr_cpus, the nr_cpus parameter is no longer needed in __pkvm_init. Signed-off-by: Vincent Donnefort diff --git a/arch/arm64/include/asm/kvm_hyp.h b/arch/arm64/include/asm/kvm_hyp.h index e6be1f5d0967..b169d85458f9 100644 --- a/arch/arm64/include/asm/kvm_hyp.h +++ b/arch/arm64/include/asm/kvm_hyp.h @@ -128,8 +128,7 @@ void __noreturn __hyp_do_panic(struct kvm_cpu_context *host_ctxt, u64 spsr, #ifdef __KVM_NVHE_HYPERVISOR__ void __pkvm_init_switch_pgd(phys_addr_t pgd, unsigned long sp, void (*fn)(void)); -int __pkvm_init(phys_addr_t phys, unsigned long size, unsigned long nr_cpus, - unsigned long *per_cpu_base, u32 hyp_va_bits); +int __pkvm_init(phys_addr_t phys, unsigned long size, unsigned long *per_cpu_base, u32 hyp_va_bits); void __noreturn __host_enter(struct kvm_cpu_context *host_ctxt); #endif @@ -146,5 +145,6 @@ extern u64 kvm_nvhe_sym(id_aa64smfr0_el1_sys_val); extern unsigned long kvm_nvhe_sym(__icache_flags); extern unsigned int kvm_nvhe_sym(kvm_arm_vmid_bits); extern unsigned int kvm_nvhe_sym(kvm_host_sve_max_vl); +extern unsigned long kvm_nvhe_sym(hyp_nr_cpus); #endif /* __ARM64_KVM_HYP_H__ */ diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c index 052bf0d4d0b0..7ba427f9608c 100644 --- a/arch/arm64/kvm/arm.c +++ b/arch/arm64/kvm/arm.c @@ -35,6 +35,7 @@ #include #include #include +#include #include #include #include @@ -2396,7 +2397,7 @@ static int __init do_pkvm_init(u32 hyp_va_bits) preempt_disable(); cpu_hyp_init_context(); ret = kvm_call_hyp_nvhe(__pkvm_init, hyp_mem_base, hyp_mem_size, - num_possible_cpus(), kern_hyp_va(per_cpu_base), + kern_hyp_va(per_cpu_base), hyp_va_bits); cpu_hyp_init_features(); @@ -2605,6 +2606,8 @@ static int __init init_hyp_mode(void) kvm_nvhe_sym(kvm_arm_hyp_percpu_base)[cpu] = (unsigned long)page_addr; } + kvm_nvhe_sym(hyp_nr_cpus) = num_possible_cpus(); + /* * Map the Hyp-code called directly from the host */ diff --git a/arch/arm64/kvm/hyp/include/nvhe/mem_protect.h b/arch/arm64/kvm/hyp/include/nvhe/mem_protect.h index 5f9d56754e39..f8a7b8c04c49 100644 --- a/arch/arm64/kvm/hyp/include/nvhe/mem_protect.h +++ b/arch/arm64/kvm/hyp/include/nvhe/mem_protect.h @@ -30,8 +30,6 @@ enum pkvm_component_id { PKVM_ID_FFA, }; -extern unsigned long hyp_nr_cpus; - int __pkvm_prot_finalize(void); int __pkvm_host_share_hyp(u64 pfn); int __pkvm_host_unshare_hyp(u64 pfn); diff --git a/arch/arm64/kvm/hyp/nvhe/hyp-main.c b/arch/arm64/kvm/hyp/nvhe/hyp-main.c index 29430c031095..34546dce57ff 100644 --- a/arch/arm64/kvm/hyp/nvhe/hyp-main.c +++ b/arch/arm64/kvm/hyp/nvhe/hyp-main.c @@ -482,17 +482,15 @@ static void handle___pkvm_init(struct kvm_cpu_context *host_ctxt) { DECLARE_REG(phys_addr_t, phys, host_ctxt, 1); DECLARE_REG(unsigned long, size, host_ctxt, 2); - DECLARE_REG(unsigned long, nr_cpus, host_ctxt, 3); - DECLARE_REG(unsigned long *, per_cpu_base, host_ctxt, 4); - DECLARE_REG(u32, hyp_va_bits, host_ctxt, 5); + DECLARE_REG(unsigned long *, per_cpu_base, host_ctxt, 3); + DECLARE_REG(u32, hyp_va_bits, host_ctxt, 4); /* * __pkvm_init() will return only if an error occurred, otherwise it * will tail-call in __pkvm_init_finalise() which will have to deal * with the host context directly. */ - cpu_reg(host_ctxt, 1) = __pkvm_init(phys, size, nr_cpus, per_cpu_base, - hyp_va_bits); + cpu_reg(host_ctxt, 1) = __pkvm_init(phys, size, per_cpu_base, hyp_va_bits); } static void handle___pkvm_cpu_set_vector(struct kvm_cpu_context *host_ctxt) diff --git a/arch/arm64/kvm/hyp/nvhe/setup.c b/arch/arm64/kvm/hyp/nvhe/setup.c index 90bd014e952f..d8e5b563fd3d 100644 --- a/arch/arm64/kvm/hyp/nvhe/setup.c +++ b/arch/arm64/kvm/hyp/nvhe/setup.c @@ -341,8 +341,7 @@ void __noreturn __pkvm_init_finalise(void) __host_enter(host_ctxt); } -int __pkvm_init(phys_addr_t phys, unsigned long size, unsigned long nr_cpus, - unsigned long *per_cpu_base, u32 hyp_va_bits) +int __pkvm_init(phys_addr_t phys, unsigned long size, unsigned long *per_cpu_base, u32 hyp_va_bits) { struct kvm_nvhe_init_params *params; void *virt = hyp_phys_to_virt(phys); @@ -355,7 +354,6 @@ int __pkvm_init(phys_addr_t phys, unsigned long size, unsigned long nr_cpus, return -EINVAL; hyp_spin_lock_init(&pkvm_pgd_lock); - hyp_nr_cpus = nr_cpus; ret = divide_memory_pool(virt, size); if (ret) -- 2.52.0.107.ga0afd4fd5b-goog