Re: [PATCH 2/4] dt-bindings: arm: Document Microchip LAN969x

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1984 bytes --]

On Wed, Dec 03, 2025 at 01:21:30PM +0100, Robert Marko wrote:
> Microchip LAN969x is a series of multi-port, multi-gigabit switches based
> on ARMv8 Cortex-A53 CPU.
> 
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> ---
>  .../bindings/arm/microchip,lan969x.yaml       | 32 +++++++++++++++++++

This should not be in a unique file, put it in with the other microchip
arm devices please. Also, the wildcard in the compatible is not
permitted, only way it'd make sense is if these are different binnings
of the same silicon. If that's the case, you need to explain why,
because compatibles are meant to be soc-specific.

pw-bot: changes-requested

>  1 file changed, 32 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/arm/microchip,lan969x.yaml
> 
> diff --git a/Documentation/devicetree/bindings/arm/microchip,lan969x.yaml b/Documentation/devicetree/bindings/arm/microchip,lan969x.yaml
> new file mode 100644
> index 000000000000..3fa1d4ed40d1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/microchip,lan969x.yaml
> @@ -0,0 +1,32 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/microchip,lan969x.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Microchip LAN969x Boards
> +
> +maintainers:
> +  - Robert Marko <robert.marko@sartura.hr>
> +
> +description: |+
> +   The Microchip LAN969x SoC is a ARMv8-based used in a family of
> +   multi-port, multi-gigabit switches.
> +
> +properties:
> +  $nodename:
> +    const: '/'
> +  compatible:
> +    oneOf:
> +      - description: The LAN969x EVB (EV23X71A) is a 24x 1G + 4x 10G
> +          Ethernet development system board.
> +        items:
> +          - const: microchip,ev23x71a
> +          - const: microchip,lan969x
> +
> +required:
> +  - compatible
> +
> +additionalProperties: true
> +
> +...
> -- 
> 2.52.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]