From: Joey Gouly <joey.gouly@arm.com>
To: Marc Zyngier <maz@kernel.org>
Cc: kvmarm@lists.linux.dev, kvm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Oliver Upton <oupton@kernel.org>,
Zenghui Yu <yuzenghui@huawei.com>,
Ben Horgan <ben.horgan@arm.com>,
Yao Yuan <yaoyuan@linux.alibaba.com>
Subject: Re: [PATCH v3 1/9] arm64: Repaint ID_AA64MMFR2_EL1.IDS description
Date: Thu, 4 Dec 2025 10:32:00 +0000 [thread overview]
Message-ID: <20251204103200.GA98666@e124191.cambridge.arm.com> (raw)
In-Reply-To: <20251204094806.3846619-2-maz@kernel.org>
On Thu, Dec 04, 2025 at 09:47:58AM +0000, Marc Zyngier wrote:
> ID_AA64MMFR2_EL1.IDS, as described in the sysreg file, is pretty horrible
> as it diesctly give the ESR value. Repaint it using the usual NI/IMP
typo: directly
> identifiers to describe the absence/presence of FEAT_IDST.
>
> Signed-off-by: Marc Zyngier <maz@kernel.org>
Reviewed-by: Joey Gouly <joey.gouly@arm.com>
> ---
> arch/arm64/kvm/hyp/nvhe/sys_regs.c | 2 +-
> arch/arm64/tools/sysreg | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/kvm/hyp/nvhe/sys_regs.c b/arch/arm64/kvm/hyp/nvhe/sys_regs.c
> index 82da9b03692d4..107d62921b168 100644
> --- a/arch/arm64/kvm/hyp/nvhe/sys_regs.c
> +++ b/arch/arm64/kvm/hyp/nvhe/sys_regs.c
> @@ -134,7 +134,7 @@ static const struct pvm_ftr_bits pvmid_aa64mmfr2[] = {
> MAX_FEAT(ID_AA64MMFR2_EL1, UAO, IMP),
> MAX_FEAT(ID_AA64MMFR2_EL1, IESB, IMP),
> MAX_FEAT(ID_AA64MMFR2_EL1, AT, IMP),
> - MAX_FEAT_ENUM(ID_AA64MMFR2_EL1, IDS, 0x18),
> + MAX_FEAT_ENUM(ID_AA64MMFR2_EL1, IDS, IMP),
> MAX_FEAT(ID_AA64MMFR2_EL1, TTL, IMP),
> MAX_FEAT(ID_AA64MMFR2_EL1, BBM, 2),
> MAX_FEAT(ID_AA64MMFR2_EL1, E0PD, IMP),
> diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg
> index 1c6cdf9d54bba..3261e8791ac03 100644
> --- a/arch/arm64/tools/sysreg
> +++ b/arch/arm64/tools/sysreg
> @@ -2257,8 +2257,8 @@ UnsignedEnum 43:40 FWB
> 0b0001 IMP
> EndEnum
> Enum 39:36 IDS
> - 0b0000 0x0
> - 0b0001 0x18
> + 0b0000 NI
> + 0b0001 IMP
> EndEnum
> UnsignedEnum 35:32 AT
> 0b0000 NI
> --
> 2.47.3
>
next prev parent reply other threads:[~2025-12-04 10:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-04 9:47 [PATCH v3 0/9] KVM: arm64: Add support for FEAT_IDST Marc Zyngier
2025-12-04 9:47 ` [PATCH v3 1/9] arm64: Repaint ID_AA64MMFR2_EL1.IDS description Marc Zyngier
2025-12-04 10:32 ` Joey Gouly [this message]
2025-12-04 10:36 ` Ben Horgan
2025-12-04 10:48 ` Marc Zyngier
2025-12-04 11:13 ` Ben Horgan
2025-12-04 12:02 ` Marc Zyngier
2025-12-04 9:47 ` [PATCH v3 2/9] KVM: arm64: Add trap routing for GMID_EL1 Marc Zyngier
2025-12-04 9:48 ` [PATCH v3 3/9] KVM: arm64: Add a generic synchronous exception injection primitive Marc Zyngier
2025-12-04 9:48 ` [PATCH v3 4/9] KVM: arm64: Handle FEAT_IDST for sysregs without specific handlers Marc Zyngier
2025-12-04 10:52 ` Joey Gouly
2025-12-05 6:10 ` Yao Yuan
2025-12-04 9:48 ` [PATCH v3 5/9] KVM: arm64: Handle CSSIDR2_EL1 and SMIDR_EL1 in a generic way Marc Zyngier
2025-12-05 6:25 ` Yao Yuan
2025-12-04 9:48 ` [PATCH v3 6/9] KVM: arm64: Force trap of GMID_EL1 when the guest doesn't have MTE Marc Zyngier
2025-12-05 6:02 ` Yao Yuan
2025-12-04 9:48 ` [PATCH v3 7/9] KVM: arm64: pkvm: Add a generic synchronous exception injection primitive Marc Zyngier
2025-12-04 9:48 ` [PATCH v3 8/9] KVM: arm64: pkvm: Report optional ID register traps with a 0x18 syndrome Marc Zyngier
2025-12-04 10:51 ` Ben Horgan
2025-12-04 12:06 ` Marc Zyngier
2025-12-04 9:48 ` [PATCH v3 9/9] KVM: arm64: selftests: Add a test for FEAT_IDST Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251204103200.GA98666@e124191.cambridge.arm.com \
--to=joey.gouly@arm.com \
--cc=ben.horgan@arm.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=maz@kernel.org \
--cc=oupton@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=yaoyuan@linux.alibaba.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).