From: Vladimir Oltean <olteanv@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Daniel Golle <daniel@makrotopia.org>,
Frank Wunderlich <frankwu@gmx.de>,
Krzysztof Kozlowski <krzk@kernel.org>,
Chen Minqiang <ptpt52@gmail.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
"Chester A. Unal" <chester.a.unal@arinc9.com>,
DENG Qingfang <dqfext@gmail.com>,
Sean Wang <sean.wang@mediatek.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, netdev@vger.kernel.org
Subject: Re: [PATCH v3 2/2] net: dsa: mt7530: Use GPIO polarity to generate correct reset sequence
Date: Thu, 4 Dec 2025 17:37:21 +0200 [thread overview]
Message-ID: <20251204153721.ubmxifrev4cre6ab@skbuf> (raw)
In-Reply-To: <7aacc2c2-50d0-4a08-9800-dc4a572dffcb@lunn.ch>
On Thu, Dec 04, 2025 at 04:22:10PM +0100, Andrew Lunn wrote:
> > If this is blocking progress for new device trees, can we just construct,
> > using of_machine_is_compatible(), a list of all boards where the device
> > tree defines incorrect reset polarity that shouldn't be trusted by the
> > driver when driving the reset GPIO? If we do this, we can also leave
> > those existing device trees alone.
>
> I've still not seen a good answer to my question, why not just leave
> it 'broken', and document the fact.
>
> Does the fact it is inverted in both DT and the driver prevent us from
> making some board work?
>
> Why do we need to fix this?
>
> Sometimes it is better to just leave it alone, if it is not hurting
> anybody.
>
> Andrew
Frank said that the fact the driver expecting a wrong device tree is
forcing him to keep introducing even more wrong device trees for new
boards.
next prev parent reply other threads:[~2025-12-04 15:37 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-29 23:46 [PATCH v3 1/2] ARM64: dts: mediatek: fix MT7531 reset GPIO polarity on multiple boards Chen Minqiang
2025-11-29 23:46 ` [PATCH v3 2/2] net: dsa: mt7530: Use GPIO polarity to generate correct reset sequence Chen Minqiang
2025-11-30 1:11 ` Andrew Lunn
2025-11-30 8:07 ` Vladimir Oltean
2025-11-30 20:17 ` Andrew Lunn
2025-12-01 7:48 ` Krzysztof Kozlowski
2025-12-02 11:52 ` Frank Wunderlich
2025-12-02 12:20 ` Daniel Golle
2025-12-04 13:16 ` Vladimir Oltean
2025-12-04 13:50 ` Daniel Golle
2025-12-04 15:45 ` Vladimir Oltean
2025-12-04 14:49 ` Krzysztof Kozlowski
2025-12-04 16:02 ` Vladimir Oltean
2025-12-04 16:48 ` Krzysztof Kozlowski
2025-12-04 17:11 ` Vladimir Oltean
2025-12-04 17:23 ` Krzysztof Kozlowski
2025-12-04 17:32 ` Krzysztof Kozlowski
2025-12-04 20:47 ` Russell King (Oracle)
2025-12-04 17:45 ` Russell King (Oracle)
2025-12-04 18:21 ` Vladimir Oltean
2025-12-04 15:22 ` Andrew Lunn
2025-12-04 15:37 ` Vladimir Oltean [this message]
2025-12-04 15:50 ` Andrew Lunn
2025-12-04 15:52 ` Krzysztof Kozlowski
2025-12-04 16:33 ` Vladimir Oltean
2025-11-30 8:22 ` Vladimir Oltean
2025-12-01 7:50 ` Krzysztof Kozlowski
2025-11-30 1:00 ` [PATCH v3 1/2] ARM64: dts: mediatek: fix MT7531 reset GPIO polarity on multiple boards Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251204153721.ubmxifrev4cre6ab@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chester.a.unal@arinc9.com \
--cc=conor+dt@kernel.org \
--cc=daniel@makrotopia.org \
--cc=dqfext@gmail.com \
--cc=frankwu@gmx.de \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=ptpt52@gmail.com \
--cc=robh@kernel.org \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox