From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D3683D6ACFB for ; Thu, 18 Dec 2025 12:57:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tBDcvlSJdqaE/FhBeajz0HQZsvPrdYdKBwg6m1HcfQ0=; b=Wo3RUHDiX4FMBuD9TNvxUr7OYP F72gBh/YKgSFP+subbxmkkz3CpaMpcIy9lB5DK0qbnNRY1jFbJj/Br73V1Gpi8ZRkXTKDmtjaIA5G Z0FttU6fmTv6qIqWHDFfqvhZNrbJSPCJ9y5UmG4GQVoZccK+PLpEpixf5OyZ5qCcaU3zQ1mk/8zwy 3ftIa7WIg7ng6ePK66I23k4dBtdbrSAzHA16NCaA8uAVoo8GTNbTAjR2kJu46Pz0sZ5EC6u0fMiVM EUTgSl15iUTTIYNeNF2H3MZcuOT042kkdCM7A+Mh8X2XpMLpB0RsjESEDB84T0DtoP8B+gTnbRJrH s0V2+SrQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vWDZO-00000008T5J-2amD; Thu, 18 Dec 2025 12:57:26 +0000 Received: from sender4-pp-f112.zoho.com ([136.143.188.112]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vWDZG-00000008Svm-42rj; Thu, 18 Dec 2025 12:57:25 +0000 ARC-Seal: i=1; a=rsa-sha256; t=1766062628; cv=none; d=zohomail.com; s=zohoarc; b=a3RznC4ewP125V3q7BziIQCrVaMVP537rFCNtBU9hfZuB8XUzFmnSHCuxXGBXen0aP8RgAafC5+sEI8gbvTuCNSEPdJk0tEQOImYhfHBBpI4J9WWsgE2/RVgpQ6XOtKgFSkBFmOxLflpMt26cXz6upwJxiqfvVDahyoHbu4ztN4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766062628; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=tBDcvlSJdqaE/FhBeajz0HQZsvPrdYdKBwg6m1HcfQ0=; b=g0AsiAY3iih1z2uxpdQcCKuOVFoNNQ0ahhib8I0XzBqSX52wGRE6KABU3DFm6f2QNc77t2X/ZQ+pu0xqrzZR+x5qe/E3NR8ZaHAzVks6xUiyNfb+T6hganHpYAWaw7WLCAHDrPzApnYHaEnL+jUWTvHrUOyaMO2bcQm5hBIJnCE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1766062628; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=tBDcvlSJdqaE/FhBeajz0HQZsvPrdYdKBwg6m1HcfQ0=; b=TXrbXtvn4RVxLZPS40ooO+3NTCHPKCUHj0XQ/fixHp9L/9PfpLUsuFxOKCF+Gcer iN7DXc1baXOuGZCpHpHEdW0Wyfin8iwY0sAxlok+lBjyWXJGbDc7KLUOPVjxD9ghX/Z hun4PI8LAciEyqaZDXG3/13iiRuAJc3K2efPgjsk= Received: by mx.zohomail.com with SMTPS id 176606262695595.52766682896265; Thu, 18 Dec 2025 04:57:06 -0800 (PST) From: Nicolas Frattaroli Date: Thu, 18 Dec 2025 13:55:05 +0100 Subject: [PATCH v4 15/25] scsi: ufs: mediatek: Remove mediatek,ufs-broken-rtc property MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20251218-mt8196-ufs-v4-15-ddec7a369dd2@collabora.com> References: <20251218-mt8196-ufs-v4-0-ddec7a369dd2@collabora.com> In-Reply-To: <20251218-mt8196-ufs-v4-0-ddec7a369dd2@collabora.com> To: Alim Akhtar , Avri Altman , Bart Van Assche , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Chunfeng Yun , Vinod Koul , Kishon Vijay Abraham I , Peter Wang , Stanley Jhu , "James E.J. Bottomley" , "Martin K. Petersen" , Philipp Zabel , Liam Girdwood , Mark Brown , Chaotian Jing , Neil Armstrong Cc: Louis-Alexis Eyraud , kernel@collabora.com, linux-scsi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, Nicolas Frattaroli X-Mailer: b4 0.14.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251218_045719_121432_40AA1068 X-CRM114-Status: GOOD ( 10.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This flag property was never described in the binding, and its capability wrapper seems pointless. If one of the MediaTek SoCs needs the ufshcd quirk applied, then this can be done per-compatible, without needing to give the device tree author the option to forget to set it. Remove it and the associated capability flag wrapping code. Signed-off-by: Nicolas Frattaroli --- drivers/ufs/host/ufs-mediatek.c | 5 ----- drivers/ufs/host/ufs-mediatek.h | 2 -- 2 files changed, 7 deletions(-) diff --git a/drivers/ufs/host/ufs-mediatek.c b/drivers/ufs/host/ufs-mediatek.c index 89e3fa5d7d10..ffd52b8c295a 100644 --- a/drivers/ufs/host/ufs-mediatek.c +++ b/drivers/ufs/host/ufs-mediatek.c @@ -657,9 +657,6 @@ static void ufs_mtk_init_host_caps(struct ufs_hba *hba) if (of_property_read_bool(np, "mediatek,ufs-rtff-mtcmos")) host->caps |= UFS_MTK_CAP_RTFF_MTCMOS; - if (of_property_read_bool(np, "mediatek,ufs-broken-rtc")) - host->caps |= UFS_MTK_CAP_MCQ_BROKEN_RTC; - dev_info(hba->dev, "caps: 0x%x", host->caps); } @@ -1203,8 +1200,6 @@ static int ufs_mtk_init(struct ufs_hba *hba) hba->quirks |= UFSHCI_QUIRK_SKIP_MANUAL_WB_FLUSH_CTRL; hba->quirks |= UFSHCD_QUIRK_MCQ_BROKEN_INTR; - if (host->caps & UFS_MTK_CAP_MCQ_BROKEN_RTC) - hba->quirks |= UFSHCD_QUIRK_MCQ_BROKEN_RTC; hba->vps->wb_flush_threshold = UFS_WB_BUF_REMAIN_PERCENT(80); diff --git a/drivers/ufs/host/ufs-mediatek.h b/drivers/ufs/host/ufs-mediatek.h index bf8122af69f0..5f096ed3f850 100644 --- a/drivers/ufs/host/ufs-mediatek.h +++ b/drivers/ufs/host/ufs-mediatek.h @@ -138,8 +138,6 @@ enum ufs_mtk_host_caps { UFS_MTK_CAP_DISABLE_MCQ = 1 << 8, /* Control MTCMOS with RTFF */ UFS_MTK_CAP_RTFF_MTCMOS = 1 << 9, - - UFS_MTK_CAP_MCQ_BROKEN_RTC = 1 << 10, }; struct ufs_mtk_crypt_cfg { -- 2.52.0