From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F69FD6ACFF for ; Thu, 18 Dec 2025 12:56:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=L4FVB0oYChYLlDwfcvsV37MKzm2n6cyg4ekMnI4E9H4=; b=uJT4SRV+LxAJlSQDvYdTvfEYL8 oELF8WSMfjXvk42D2deiuAJ2enfyszL1And6AmctEQsbKfnjX5P0D4rRf2Hw36cEXJzbFGGmrlke3 PwHek51ZiyGe3q2lNWVqdgnY7qKApra8tAnrqxxp183TM5r3ZfJgoynOw/iDYc7daXnlND23myet7 Pa5mn+Wwaua5LC2Zi6TJJ/vreEvjHcVexhCuVJxsE9uq/n+yHAyOZlidqjDhPGyUW6G4EXFRs5355 +7/0Aw6A9Y80ZvBP4+kl6bcY4KcEbevN6mgmM9iqZsLXx5MjSXwZ9R1lERmF/XXxLsK28nZpLI2yP pgZboFnw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vWDY8-00000008Rm0-2Iqc; Thu, 18 Dec 2025 12:56:08 +0000 Received: from sender4-pp-f112.zoho.com ([136.143.188.112]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vWDY0-00000008RiA-3JlW; Thu, 18 Dec 2025 12:56:03 +0000 ARC-Seal: i=1; a=rsa-sha256; t=1766062550; cv=none; d=zohomail.com; s=zohoarc; b=B8vnSIVKVSZPXJ8U4+CaiqhGWT2VkqJe3XSJZalf6If7XtyBw1/KqjtYMf4huFZAdZdLHNUJxLHsMVD9bdP6TDk6w/ncC4YjiO7m928/fYLVMFILVIgfEg0C4YDuAzDM+xCdYnfsy9h1vyOod32z2alczRuK96SJmReQuIAYI8Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1766062550; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=L4FVB0oYChYLlDwfcvsV37MKzm2n6cyg4ekMnI4E9H4=; b=T3+dsyHqClZXVjRTsk+4R/5copT6bf7ZdIEODPQngvBXAytF3OUHC0pdivgGHhwg7hvLkZ688cqrG6ZjimBeIrJytxvD8JGO1dmBUWxFJYKfDr2tzC6FPPJ8o82eo7Gl7jn+VXRvzN72R/FS3ujamA3qO3OK50GKGHTEH994MiI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1766062550; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=L4FVB0oYChYLlDwfcvsV37MKzm2n6cyg4ekMnI4E9H4=; b=X7B+NgtsDYUJXhsRkrfcx6IlgF7hJT32lNTB5JA5wD+v7z5X5rjrACkwgYZ3uhXL yqTuR9RNZTaox9LRNKlca3fIgi/ZiUBOJNgX+VyQz6rB0b+SYxGqcPyJoSd6rt5GzAN Qv95fiHq+yyxbuDXrvr3V2i3RdyrVs2swtdWTnMM= Received: by mx.zohomail.com with SMTPS id 1766062549961270.54454758878353; Thu, 18 Dec 2025 04:55:49 -0800 (PST) From: Nicolas Frattaroli Date: Thu, 18 Dec 2025 13:54:53 +0100 Subject: [PATCH v4 03/25] dt-bindings: ufs: mediatek,ufs: Add mt8196 variant MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20251218-mt8196-ufs-v4-3-ddec7a369dd2@collabora.com> References: <20251218-mt8196-ufs-v4-0-ddec7a369dd2@collabora.com> In-Reply-To: <20251218-mt8196-ufs-v4-0-ddec7a369dd2@collabora.com> To: Alim Akhtar , Avri Altman , Bart Van Assche , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Chunfeng Yun , Vinod Koul , Kishon Vijay Abraham I , Peter Wang , Stanley Jhu , "James E.J. Bottomley" , "Martin K. Petersen" , Philipp Zabel , Liam Girdwood , Mark Brown , Chaotian Jing , Neil Armstrong Cc: Louis-Alexis Eyraud , kernel@collabora.com, linux-scsi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, Nicolas Frattaroli X-Mailer: b4 0.14.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251218_045602_582169_E55D02DB X-CRM114-Status: GOOD ( 11.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The MediaTek MT8196 SoC's UFS controller uses three additional clocks compared to the MT8195, and a different set of supplies. It is therefore not compatible with the MT8195. While it does have a AVDD09_UFS_1 pin in addition to the AVDD09_UFS pin, it appears that these two pins are commoned together, as the board schematic I have access to uses the same supply for both, and the downstream driver does not distinguish between the two supplies either. Add a compatible for it, and modify the binding correspondingly. Signed-off-by: Nicolas Frattaroli --- .../devicetree/bindings/ufs/mediatek,ufs.yaml | 58 +++++++++++++++++++++- 1 file changed, 57 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml b/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml index e0aef3e5f56b..a82119ecbfe8 100644 --- a/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml +++ b/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml @@ -16,10 +16,11 @@ properties: - mediatek,mt8183-ufshci - mediatek,mt8192-ufshci - mediatek,mt8195-ufshci + - mediatek,mt8196-ufshci clocks: minItems: 1 - maxItems: 13 + maxItems: 16 clock-names: minItems: 1 @@ -37,6 +38,9 @@ properties: - const: crypt_perf - const: ufs_rx_symbol0 - const: ufs_rx_symbol1 + - const: ufs_sel + - const: ufs_sel_min_src + - const: ufs_sel_max_src operating-points-v2: true @@ -131,9 +135,27 @@ allOf: properties: clocks: minItems: 13 + maxItems: 13 clock-names: minItems: 13 + maxItems: 13 avdd09-supply: false + - if: + properties: + compatible: + contains: + const: mediatek,mt8196-ufshci + then: + properties: + clocks: + minItems: 16 + maxItems: 16 + clock-names: + minItems: 16 + maxItems: 16 + avdd18-supply: false + required: + - operating-points-v2 examples: - | @@ -183,3 +205,37 @@ examples: mediatek,ufs-disable-mcq; }; + - | + #include + #include + + ufshci@16810000 { + compatible = "mediatek,mt8196-ufshci"; + reg = <0x16810000 0x2a00>; + interrupts = ; + + clocks = <&ufs_ao_clk 6>, <&ufs_ao_clk 7>, <&clk26m>, <&ufs_ao_clk 3>, + <&clk26m>, <&ufs_ao_clk 4>, <&ufs_ao_clk 0>, + <&topckgen 7>, <&topckgen 41>, <&topckgen 105>, <&topckgen 83>, + <&ufs_ao_clk 1>, <&ufs_ao_clk 2>, <&topckgen 42>, + <&topckgen 84>, <&topckgen 102>; + clock-names = "ufs", "ufs_aes", "ufs_tick", "unipro_sysclk", + "unipro_tick", "unipro_mp_bclk", "ufs_tx_symbol", + "ufs_mem_sub", "crypt_mux", "crypt_lp", "crypt_perf", + "ufs_rx_symbol0", "ufs_rx_symbol1", "ufs_sel", + "ufs_sel_min_src", "ufs_sel_max_src"; + + operating-points-v2 = <&ufs_opp_table>; + + phys = <&ufsphy>; + + avdd09-supply = <&mt6363_vsram_modem>; + vcc-supply = <&mt6363_vemc>; + vccq-supply = <&mt6363_vufs12>; + + resets = <&ufs_ao_clk MT8196_UFSAO_RST1_UFS_UNIPRO>, + <&ufs_ao_clk MT8196_UFSAO_RST1_UFS_CRYPTO>, + <&ufs_ao_clk MT8196_UFSAO_RST1_UFSHCI>; + reset-names = "unipro", "crypto", "hci"; + mediatek,ufs-disable-mcq; + }; -- 2.52.0