From: Jonathan Cameron <jonathan.cameron@huawei.com>
To: Ben Horgan <ben.horgan@arm.com>
Cc: <amitsinght@marvell.com>, <baisheng.gao@unisoc.com>,
<baolin.wang@linux.alibaba.com>, <carl@os.amperecomputing.com>,
<dave.martin@arm.com>, <david@kernel.org>,
<dfustini@baylibre.com>, <fenghuay@nvidia.com>,
<gshan@redhat.com>, <james.morse@arm.com>, <kobak@nvidia.com>,
<lcherian@marvell.com>, <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <peternewman@google.com>,
<punit.agrawal@oss.qualcomm.com>, <quic_jiles@quicinc.com>,
<reinette.chatre@intel.com>, <rohit.mathew@arm.com>,
<scott@os.amperecomputing.com>, <sdonthineni@nvidia.com>,
<tan.shaopeng@fujitsu.com>, <xhao@linux.alibaba.com>,
<catalin.marinas@arm.com>, <will@kernel.org>, <corbet@lwn.net>,
<maz@kernel.org>, <oupton@kernel.org>, <joey.gouly@arm.com>,
<suzuki.poulose@arm.com>, <kvmarm@lists.linux.dev>,
kernel test robot <lkp@intel.com>,
Dan Carpenter <dan.carpenter@linaro.org>
Subject: Re: [PATCH v2 01/45] arm_mpam: Stop using uninitialized variables in __ris_msmon_read()
Date: Tue, 23 Dec 2025 11:58:01 +0000 [thread overview]
Message-ID: <20251223115801.000033cb@huawei.com> (raw)
In-Reply-To: <20251219181147.3404071-2-ben.horgan@arm.com>
On Fri, 19 Dec 2025 18:11:03 +0000
Ben Horgan <ben.horgan@arm.com> wrote:
> Dan has reported two uses of uninitialized variables in __ris_msmon_read().
> If an unknown monitor type is encountered then the local variable, now, is
> used uninitialized. Fix this by returning early on error. If a non-mbwu
> monitor is being read then the local variable, overflow, is not initialized
> but still read. Initialize it to false as overflow is not relevant for csu
> monitors.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Closes: https://lore.kernel.org/r/202512091519.RBwiJcSq-lkp@intel.com/
> Closes: https://lore.kernel.org/r/202512100547.N7QPYgfb-lkp@intel.com/
> Signed-off-by: Ben Horgan <ben.horgan@arm.com>
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
next prev parent reply other threads:[~2025-12-23 12:08 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-19 18:11 [PATCH v2 00/45] arm_mpam: Add KVM/arm64 and resctrl glue code Ben Horgan
2025-12-19 18:11 ` [PATCH v2 01/45] arm_mpam: Stop using uninitialized variables in __ris_msmon_read() Ben Horgan
2025-12-23 11:58 ` Jonathan Cameron [this message]
2025-12-19 18:11 ` [PATCH v2 02/45] arm_mpam: Remove duplicate linux/srcu.h header Ben Horgan
2025-12-23 12:10 ` Jonathan Cameron
2025-12-19 18:11 ` [PATCH v2 03/45] arm_mpam: Use non-atomic bitops when modifying feature bitmap Ben Horgan
2025-12-19 18:11 ` [PATCH v2 04/45] arm64/sysreg: Add MPAMSM_EL1 register Ben Horgan
2025-12-19 18:11 ` [PATCH v2 05/45] KVM: arm64: Preserve host MPAM configuration when changing traps Ben Horgan
2025-12-19 20:01 ` Oliver Upton
2025-12-19 18:11 ` [PATCH v2 06/45] KVM: arm64: Make MPAMSM_EL1 accesses UNDEF Ben Horgan
2025-12-19 18:11 ` [PATCH v2 07/45] arm64: mpam: Context switch the MPAM registers Ben Horgan
2025-12-19 18:11 ` [PATCH v2 08/45] arm64: mpam: Re-initialise MPAM regs when CPU comes online Ben Horgan
2025-12-19 18:11 ` [PATCH v2 09/45] arm64: mpam: Advertise the CPUs MPAM limits to the driver Ben Horgan
2025-12-19 18:11 ` [PATCH v2 10/45] arm64: mpam: Add cpu_pm notifier to restore MPAM sysregs Ben Horgan
2025-12-19 18:11 ` [PATCH v2 11/45] arm64: mpam: Initialise and context switch the MPAMSM_EL1 register Ben Horgan
2025-12-19 18:11 ` [PATCH v2 12/45] arm64: mpam: Add helpers to change a task or cpu's MPAM PARTID/PMG values Ben Horgan
2025-12-19 18:11 ` [PATCH v2 13/45] KVM: arm64: Force guest EL1 to use user-space's partid configuration Ben Horgan
2025-12-19 20:10 ` Oliver Upton
2025-12-19 18:11 ` [PATCH v2 14/45] KVM: arm64: Use kernel-space partid configuration for hypercalls Ben Horgan
2025-12-19 18:11 ` [PATCH v2 15/45] arm_mpam: resctrl: Add boilerplate cpuhp and domain allocation Ben Horgan
2025-12-19 18:11 ` [PATCH v2 16/45] arm_mpam: resctrl: Sort the order of the domain lists Ben Horgan
2025-12-19 18:11 ` [PATCH v2 17/45] arm_mpam: resctrl: Pick the caches we will use as resctrl resources Ben Horgan
2025-12-19 18:11 ` [PATCH v2 18/45] arm_mpam: resctrl: Implement resctrl_arch_reset_all_ctrls() Ben Horgan
2025-12-19 18:11 ` [PATCH v2 19/45] arm_mpam: resctrl: Add resctrl_arch_get_config() Ben Horgan
2025-12-19 18:11 ` [PATCH v2 20/45] arm_mpam: resctrl: Implement helpers to update configuration Ben Horgan
2025-12-19 18:11 ` [PATCH v2 21/45] arm_mpam: resctrl: Add plumbing against arm64 task and cpu hooks Ben Horgan
2025-12-19 18:11 ` [PATCH v2 22/45] arm_mpam: resctrl: Add CDP emulation Ben Horgan
2025-12-19 18:11 ` [PATCH v2 23/45] arm_mpam: resctrl: Add rmid index helpers Ben Horgan
2025-12-19 18:11 ` [PATCH v2 24/45] arm_mpam: resctrl: Convert to/from MPAMs fixed-point formats Ben Horgan
2025-12-19 18:11 ` [PATCH v2 25/45] arm_mpam: resctrl: Add support for 'MB' resource Ben Horgan
2025-12-27 8:10 ` [PATCH v2 0/45] arm_mpam: Add KVM/arm64 and resctrl glue code Zeng Heng
2025-12-19 18:11 ` [PATCH v2 26/45] arm_mpam: resctrl: Add kunit test for control format conversions Ben Horgan
2025-12-19 18:11 ` [PATCH v2 27/45] arm_mpam: resctrl: Add support for csu counters Ben Horgan
2025-12-19 18:11 ` [PATCH v2 28/45] arm_mpam: resctrl: Pick classes for use as mbm counters Ben Horgan
2025-12-19 18:11 ` [PATCH v2 29/45] arm_mpam: resctrl: Pre-allocate free running monitors Ben Horgan
2025-12-19 18:11 ` [PATCH v2 30/45] arm_mpam: resctrl: Pre-allocate assignable monitors Ben Horgan
2025-12-19 18:11 ` [PATCH v2 31/45] arm_mpam: resctrl: Add kunit test for ABMC/CDP interactions Ben Horgan
2025-12-19 18:11 ` [PATCH v2 32/45] arm_mpam: resctrl: Add resctrl_arch_config_cntr() for ABMC use Ben Horgan
2025-12-19 18:11 ` [PATCH v2 33/45] arm_mpam: resctrl: Allow resctrl to allocate monitors Ben Horgan
2025-12-19 18:11 ` [PATCH v2 34/45] arm_mpam: resctrl: Add resctrl_arch_rmid_read() and resctrl_arch_reset_rmid() Ben Horgan
2025-12-19 18:11 ` [PATCH v2 35/45] arm_mpam: resctrl: Add resctrl_arch_cntr_read() & resctrl_arch_reset_cntr() Ben Horgan
2025-12-19 18:11 ` [PATCH v2 36/45] arm_mpam: resctrl: Update the rmid reallocation limit Ben Horgan
2025-12-19 18:11 ` [PATCH v2 37/45] arm_mpam: resctrl: Add empty definitions for assorted resctrl functions Ben Horgan
2025-12-19 18:11 ` [PATCH v2 38/45] arm64: mpam: Select ARCH_HAS_CPU_RESCTRL Ben Horgan
2025-12-19 18:11 ` [PATCH v2 39/45] arm_mpam: resctrl: Call resctrl_init() on platforms that can support resctrl Ben Horgan
2025-12-19 18:11 ` [PATCH v2 40/45] arm_mpam: Generate a configuration for min controls Ben Horgan
2025-12-19 18:11 ` [PATCH v2 41/45] arm_mpam: Add quirk framework Ben Horgan
2025-12-19 18:11 ` [PATCH v2 42/45] arm_mpam: Add workaround for T241-MPAM-1 Ben Horgan
2025-12-19 18:11 ` [PATCH v2 43/45] arm_mpam: Add workaround for T241-MPAM-4 Ben Horgan
2025-12-19 18:11 ` [PATCH v2 44/45] arm_mpam: Add workaround for T241-MPAM-6 Ben Horgan
2025-12-19 18:11 ` [PATCH v2 45/45] arm_mpam: Quirk CMN-650's CSU NRDY behaviour Ben Horgan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251223115801.000033cb@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=amitsinght@marvell.com \
--cc=baisheng.gao@unisoc.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=ben.horgan@arm.com \
--cc=carl@os.amperecomputing.com \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=dan.carpenter@linaro.org \
--cc=dave.martin@arm.com \
--cc=david@kernel.org \
--cc=dfustini@baylibre.com \
--cc=fenghuay@nvidia.com \
--cc=gshan@redhat.com \
--cc=james.morse@arm.com \
--cc=joey.gouly@arm.com \
--cc=kobak@nvidia.com \
--cc=kvmarm@lists.linux.dev \
--cc=lcherian@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=maz@kernel.org \
--cc=oupton@kernel.org \
--cc=peternewman@google.com \
--cc=punit.agrawal@oss.qualcomm.com \
--cc=quic_jiles@quicinc.com \
--cc=reinette.chatre@intel.com \
--cc=rohit.mathew@arm.com \
--cc=scott@os.amperecomputing.com \
--cc=sdonthineni@nvidia.com \
--cc=suzuki.poulose@arm.com \
--cc=tan.shaopeng@fujitsu.com \
--cc=will@kernel.org \
--cc=xhao@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).