From: Rob Herring <robh@kernel.org>
To: Vladimir Zapolskiy <vz@mleia.com>
Cc: "Uwe Kleine-König" <ukleinek@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Frank Li" <Frank.Li@nxp.com>,
"Piotr Wojtaszczyk" <piotr.wojtaszczyk@timesys.com>,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] arm: dts: lpc32xx: add clocks property to Motor Control PWM device tree node
Date: Tue, 30 Dec 2025 11:59:33 -0600 [thread overview]
Message-ID: <20251230175933.GA864856-robh@kernel.org> (raw)
In-Reply-To: <20251228224907.1729627-3-vz@mleia.com>
On Mon, Dec 29, 2025 at 12:49:07AM +0200, Vladimir Zapolskiy wrote:
> Motor Control PWM depends on its own supply clock, the clock gate control
> is present in TIMCLK_CTRL1 register.
You say it is required, so does that mean this hasn't ever worked? Or it
happened to work because something else turned on the clock?
>
Fixes tag?
> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
> ---
> arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi b/arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi
> index 39af48470ed5..abd401fda94e 100644
> --- a/arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi
> +++ b/arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi
> @@ -304,6 +304,7 @@ i2c2: i2c@400a8000 {
> mpwm: pwm@400e8000 {
> compatible = "nxp,lpc3220-motor-pwm";
> reg = <0x400e8000 0x78>;
> + clocks = <&clk LPC32XX_CLK_MCPWM>;
> #pwm-cells = <3>;
> status = "disabled";
> };
> --
> 2.43.0
>
next prev parent reply other threads:[~2025-12-30 17:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-28 22:49 [PATCH 0/2] arm: dts: lpc32xx: Set motor control PWM clock as required one Vladimir Zapolskiy
2025-12-28 22:49 ` [PATCH 1/2] dt-bindings: pwm: nxp,lpc32xx-pwm: Specify clocks property as mandatory Vladimir Zapolskiy
2025-12-30 17:59 ` Rob Herring (Arm)
2025-12-28 22:49 ` [PATCH 2/2] arm: dts: lpc32xx: add clocks property to Motor Control PWM device tree node Vladimir Zapolskiy
2025-12-30 17:59 ` Rob Herring [this message]
2025-12-30 23:36 ` Vladimir Zapolskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251230175933.GA864856-robh@kernel.org \
--to=robh@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=piotr.wojtaszczyk@timesys.com \
--cc=ukleinek@kernel.org \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).