From: Eric Biggers <ebiggers@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Shuah Khan" <skhan@linuxfoundation.org>,
"Matthew Schwartz" <matthew.schwartz@linux.dev>,
"Thomas Weißschuh" <linux@weissschuh.net>,
"Mikhail Gavrilov" <mikhail.v.gavrilov@gmail.com>,
"Mario Limonciello" <superm1@kernel.org>,
"Johannes Berg" <johannes@sipsolutions.net>,
quan.zhou@mediatek.com, "Felix Fietkau" <nbd@nbd.name>,
lorenzo@kernel.org, ryder.lee@mediatek.com,
linux-wireless@vger.kernel.org,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
linux-mediatek@lists.infradead.org, shuah <shuah@kernel.org>
Subject: Re: Linux 6.19-rc1 mediatek mt7921e broke badly
Date: Tue, 30 Dec 2025 17:57:12 -0800 [thread overview]
Message-ID: <20251231015712.GA2299@sol> (raw)
In-Reply-To: <CAHk-=wh6WP0Wq=rbC2Md6vsFrV-+nvDjxgfx9NpMzUmVFNkJ9A@mail.gmail.com>
On Tue, Dec 30, 2025 at 05:27:13PM -0800, Linus Torvalds wrote:
> On Tue, 30 Dec 2025 at 15:57, Shuah Khan <skhan@linuxfoundation.org> wrote:
> >
> > I would recommend reverting f804a5895eba instead of trying
> > fix it. Then find a better way to eliminate extra newline that
> > shows up in dmesg when firmware build date happens to have
> > a newline.
>
> Yeah. Let's revert it.
>
> And the way to fix the extra newline is trivial: just remove it from
> the "dev_info()" format string.
>
> Our kernel printing logic will add a newline for the next line anyway
> if it is missing (unless somebody explicitly uses PR_CONT).
>
> Can whoever saw the problem confirm that just a revert and a "remove
> \n from that dev_info()" fixes the output for them?
That works for me. The revert by itself makes the FORTIFY_SOURCE crash
go away and reintroduces a blank line in the log. Removing the \n from
the string passed to dev_info as well makes the blank line go away.
- Eric
next prev parent reply other threads:[~2025-12-31 1:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-27 9:07 Linux 6.19-rc1 mediatek mt7921e broke badly Shuah Khan
2025-12-27 12:25 ` Thomas Weißschuh
2025-12-30 0:41 ` Linus Torvalds
2025-12-30 4:21 ` Matthew Schwartz
2025-12-30 23:57 ` Shuah Khan
2025-12-31 1:27 ` Linus Torvalds
2025-12-31 1:57 ` Eric Biggers [this message]
2025-12-31 4:00 ` Shuah Khan
2025-12-31 4:07 ` Shuah Khan
2025-12-31 21:08 ` Shuah Khan
2025-12-31 10:36 ` Thomas Weißschuh
2025-12-31 16:21 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251231015712.GA2299@sol \
--to=ebiggers@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=lorenzo@kernel.org \
--cc=matthew.schwartz@linux.dev \
--cc=mikhail.v.gavrilov@gmail.com \
--cc=nbd@nbd.name \
--cc=quan.zhou@mediatek.com \
--cc=ryder.lee@mediatek.com \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=superm1@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).