linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3 1/3] dt-bindings: crypto: eip93: add clock gate and reset line
@ 2026-01-02 15:47 Aleksander Jan Bajkowski
  2026-01-02 15:47 ` [PATCH v3 2/3] dt-bindings: crypto: eip93: add support for Mediatek MT7621 SoC Aleksander Jan Bajkowski
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Aleksander Jan Bajkowski @ 2026-01-02 15:47 UTC (permalink / raw)
  To: benjamin.larsson, chester.a.unal, davem,
	angelogioacchino.delregno, ansuelsmth, conor+dt, herbert, krzk+dt,
	matthias.bgg, robh, sergio.paracuellos, tsbogend, devicetree,
	linux-arm-kernel, linux-crypto, linux-kernel, linux-mediatek,
	linux-mips
  Cc: Aleksander Jan Bajkowski

Add the clock gate and reset line, both of which are available
on the Airoha AN7581.

Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
---
v3:
- introduce patch
---
 .../crypto/inside-secure,safexcel-eip93.yaml       | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/Documentation/devicetree/bindings/crypto/inside-secure,safexcel-eip93.yaml b/Documentation/devicetree/bindings/crypto/inside-secure,safexcel-eip93.yaml
index 997bf9717f9e..c6c99c08dc68 100644
--- a/Documentation/devicetree/bindings/crypto/inside-secure,safexcel-eip93.yaml
+++ b/Documentation/devicetree/bindings/crypto/inside-secure,safexcel-eip93.yaml
@@ -48,20 +48,34 @@ properties:
   interrupts:
     maxItems: 1
 
+  clocks:
+    maxItems: 1
+
+  resets:
+    maxItems: 1
+
 required:
   - compatible
   - reg
   - interrupts
+  - clocks
+  - resets
 
 additionalProperties: false
 
 examples:
   - |
+    #include <dt-bindings/clock/en7523-clk.h>
     #include <dt-bindings/interrupt-controller/arm-gic.h>
+    #include <dt-bindings/reset/airoha,en7581-reset.h>
 
     crypto@1e004000 {
       compatible = "airoha,en7581-eip93", "inside-secure,safexcel-eip93ies";
       reg = <0x1fb70000 0x1000>;
 
+      clocks = <&scuclk EN7523_CLK_CRYPTO>;
+
       interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>;
+
+      resets = <&scuclk EN7581_CRYPTO_RST>;
     };
-- 
2.47.3



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH v3 2/3] dt-bindings: crypto: eip93: add support for Mediatek MT7621 SoC
  2026-01-02 15:47 [PATCH v3 1/3] dt-bindings: crypto: eip93: add clock gate and reset line Aleksander Jan Bajkowski
@ 2026-01-02 15:47 ` Aleksander Jan Bajkowski
  2026-01-02 17:38   ` Rob Herring (Arm)
  2026-01-02 15:47 ` [PATCH v3 3/3] mips: dts: ralink: mt7621: add crypto offload support Aleksander Jan Bajkowski
  2026-01-03 14:11 ` [PATCH v3 1/3] dt-bindings: crypto: eip93: add clock gate and reset line Krzysztof Kozlowski
  2 siblings, 1 reply; 5+ messages in thread
From: Aleksander Jan Bajkowski @ 2026-01-02 15:47 UTC (permalink / raw)
  To: benjamin.larsson, chester.a.unal, davem,
	angelogioacchino.delregno, ansuelsmth, conor+dt, herbert, krzk+dt,
	matthias.bgg, robh, sergio.paracuellos, tsbogend, devicetree,
	linux-arm-kernel, linux-crypto, linux-kernel, linux-mediatek,
	linux-mips
  Cc: Aleksander Jan Bajkowski

Add compatible for Mediatek MT7621 SoC. The implementation is exactly the
same os in the Airoha SoC.

Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
---
v3:
- Use enum
v2:
- Corrected commit description
---
 .../bindings/crypto/inside-secure,safexcel-eip93.yaml         | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/crypto/inside-secure,safexcel-eip93.yaml b/Documentation/devicetree/bindings/crypto/inside-secure,safexcel-eip93.yaml
index c6c99c08dc68..acd7c68178dc 100644
--- a/Documentation/devicetree/bindings/crypto/inside-secure,safexcel-eip93.yaml
+++ b/Documentation/devicetree/bindings/crypto/inside-secure,safexcel-eip93.yaml
@@ -31,7 +31,9 @@ properties:
   compatible:
     oneOf:
       - items:
-          - const: airoha,en7581-eip93
+          - enum:
+            - airoha,en7581-eip93
+            - mediatek,mt7621-eip93
           - const: inside-secure,safexcel-eip93ies
       - items:
           - not: {}
-- 
2.47.3



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH v3 3/3] mips: dts: ralink: mt7621: add crypto offload support
  2026-01-02 15:47 [PATCH v3 1/3] dt-bindings: crypto: eip93: add clock gate and reset line Aleksander Jan Bajkowski
  2026-01-02 15:47 ` [PATCH v3 2/3] dt-bindings: crypto: eip93: add support for Mediatek MT7621 SoC Aleksander Jan Bajkowski
@ 2026-01-02 15:47 ` Aleksander Jan Bajkowski
  2026-01-03 14:11 ` [PATCH v3 1/3] dt-bindings: crypto: eip93: add clock gate and reset line Krzysztof Kozlowski
  2 siblings, 0 replies; 5+ messages in thread
From: Aleksander Jan Bajkowski @ 2026-01-02 15:47 UTC (permalink / raw)
  To: benjamin.larsson, chester.a.unal, davem,
	angelogioacchino.delregno, ansuelsmth, conor+dt, herbert, krzk+dt,
	matthias.bgg, robh, sergio.paracuellos, tsbogend, devicetree,
	linux-arm-kernel, linux-crypto, linux-kernel, linux-mediatek,
	linux-mips
  Cc: Aleksander Jan Bajkowski

Add support for the built-in cryptographic accelerator. This accelerator
supports 3DES, AES (128/192/256 bit), ARC4, MD5, SHA1, SHA224, and SHA256.
It also supports full IPSEC, SRTP and TLS offload.

Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
---
v3:
- Add reset line and clock gate
- Change commit description
- Wrap long line
---
 arch/mips/boot/dts/ralink/mt7621.dtsi | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/arch/mips/boot/dts/ralink/mt7621.dtsi b/arch/mips/boot/dts/ralink/mt7621.dtsi
index 0704eab4a80b..e1047dd861c0 100644
--- a/arch/mips/boot/dts/ralink/mt7621.dtsi
+++ b/arch/mips/boot/dts/ralink/mt7621.dtsi
@@ -361,6 +361,19 @@ cdmm: cdmm@1fbf8000 {
 		reg = <0x1fbf8000 0x8000>;
 	};
 
+	crypto@1e004000 {
+		compatible = "mediatek,mt7621-eip93",
+			     "inside-secure,safexcel-eip93ies";
+		reg = <0x1e004000 0x1000>;
+
+		clocks = <&sysc MT7621_CLK_CRYPTO>;
+
+		interrupt-parent = <&gic>;
+		interrupts = <GIC_SHARED 19 IRQ_TYPE_LEVEL_HIGH>;
+
+		resets = <&sysc MT7621_RST_CRYPTO>;
+	};
+
 	ethernet: ethernet@1e100000 {
 		compatible = "mediatek,mt7621-eth";
 		reg = <0x1e100000 0x10000>;
-- 
2.47.3



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v3 2/3] dt-bindings: crypto: eip93: add support for Mediatek MT7621 SoC
  2026-01-02 15:47 ` [PATCH v3 2/3] dt-bindings: crypto: eip93: add support for Mediatek MT7621 SoC Aleksander Jan Bajkowski
@ 2026-01-02 17:38   ` Rob Herring (Arm)
  0 siblings, 0 replies; 5+ messages in thread
From: Rob Herring (Arm) @ 2026-01-02 17:38 UTC (permalink / raw)
  To: Aleksander Jan Bajkowski
  Cc: matthias.bgg, sergio.paracuellos, tsbogend, linux-crypto,
	linux-mediatek, ansuelsmth, devicetree, benjamin.larsson,
	linux-mips, linux-kernel, conor+dt, herbert, krzk+dt,
	chester.a.unal, angelogioacchino.delregno, davem,
	linux-arm-kernel


On Fri, 02 Jan 2026 16:47:34 +0100, Aleksander Jan Bajkowski wrote:
> Add compatible for Mediatek MT7621 SoC. The implementation is exactly the
> same os in the Airoha SoC.
> 
> Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
> ---
> v3:
> - Use enum
> v2:
> - Corrected commit description
> ---
>  .../bindings/crypto/inside-secure,safexcel-eip93.yaml         | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/crypto/inside-secure,safexcel-eip93.yaml:35:13: [warning] wrong indentation: expected 14 but found 12 (indentation)

dtschema/dtc warnings/errors:

doc reference errors (make refcheckdocs):

See https://patchwork.kernel.org/project/devicetree/patch/20260102155341.3682013-2-olek2@wp.pl

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v3 1/3] dt-bindings: crypto: eip93: add clock gate and reset line
  2026-01-02 15:47 [PATCH v3 1/3] dt-bindings: crypto: eip93: add clock gate and reset line Aleksander Jan Bajkowski
  2026-01-02 15:47 ` [PATCH v3 2/3] dt-bindings: crypto: eip93: add support for Mediatek MT7621 SoC Aleksander Jan Bajkowski
  2026-01-02 15:47 ` [PATCH v3 3/3] mips: dts: ralink: mt7621: add crypto offload support Aleksander Jan Bajkowski
@ 2026-01-03 14:11 ` Krzysztof Kozlowski
  2 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2026-01-03 14:11 UTC (permalink / raw)
  To: Aleksander Jan Bajkowski
  Cc: benjamin.larsson, chester.a.unal, davem,
	angelogioacchino.delregno, ansuelsmth, conor+dt, herbert, krzk+dt,
	matthias.bgg, robh, sergio.paracuellos, tsbogend, devicetree,
	linux-arm-kernel, linux-crypto, linux-kernel, linux-mediatek,
	linux-mips

On Fri, Jan 02, 2026 at 04:47:33PM +0100, Aleksander Jan Bajkowski wrote:
> Add the clock gate and reset line, both of which are available
> on the Airoha AN7581.
> 
> Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
> ---
> v3:
> - introduce patch
> ---
>  .../crypto/inside-secure,safexcel-eip93.yaml       | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/crypto/inside-secure,safexcel-eip93.yaml b/Documentation/devicetree/bindings/crypto/inside-secure,safexcel-eip93.yaml
> index 997bf9717f9e..c6c99c08dc68 100644
> --- a/Documentation/devicetree/bindings/crypto/inside-secure,safexcel-eip93.yaml
> +++ b/Documentation/devicetree/bindings/crypto/inside-secure,safexcel-eip93.yaml
> @@ -48,20 +48,34 @@ properties:
>    interrupts:
>      maxItems: 1
>  
> +  clocks:
> +    maxItems: 1
> +
> +  resets:
> +    maxItems: 1
> +
>  required:
>    - compatible
>    - reg
>    - interrupts
> +  - clocks
> +  - resets

That's ABI break without explanation in the commit msg.

Best regards,
Krzysztof



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-01-03 14:11 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-02 15:47 [PATCH v3 1/3] dt-bindings: crypto: eip93: add clock gate and reset line Aleksander Jan Bajkowski
2026-01-02 15:47 ` [PATCH v3 2/3] dt-bindings: crypto: eip93: add support for Mediatek MT7621 SoC Aleksander Jan Bajkowski
2026-01-02 17:38   ` Rob Herring (Arm)
2026-01-02 15:47 ` [PATCH v3 3/3] mips: dts: ralink: mt7621: add crypto offload support Aleksander Jan Bajkowski
2026-01-03 14:11 ` [PATCH v3 1/3] dt-bindings: crypto: eip93: add clock gate and reset line Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).