linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: interrupt-controller: arm: Drop redundant node name restrictions
@ 2025-12-31 11:30 Pankaj Patil
  2026-01-02 21:47 ` Rob Herring
  0 siblings, 1 reply; 2+ messages in thread
From: Pankaj Patil @ 2025-12-31 11:30 UTC (permalink / raw)
  To: maz, tglx, robh, krzk+dt, conor+dt
  Cc: linux-arm-kernel, linux-kernel, devicetree

Drop the redundant 'false' patterns so that allowed names
('msi-controller', 'gic-its', and 'interrupt-controller') work as intended

GICv3 binding currently disallows child nodes named 'gic-its@' and
'interrupt-controller@' via patternProperties set to 'false'. However,
these names are already permitted (though not preferred) by a subsequent
pattern that applies the correct schema.

Since the 'false' patterns take precedence, valid nodes such as
'gic-its@<addr>' and 'interrupt-controller@<addr>' fail dtbs_check with
"False schema does not allow" errors

Signed-off-by: Pankaj Patil <pankaj.patil@oss.qualcomm.com>
---
 .../devicetree/bindings/interrupt-controller/arm,gic-v3.yaml    | 2 --
 1 file changed, 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.yaml b/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.yaml
index bfd30aae682b..462305f8047d 100644
--- a/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.yaml
+++ b/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.yaml
@@ -186,8 +186,6 @@ required:
   - reg
 
 patternProperties:
-  "^gic-its@": false
-  "^interrupt-controller@[0-9a-f]+$": false
   # msi-controller is preferred, but allow other names
   "^(msi-controller|gic-its|interrupt-controller)@[0-9a-f]+$":
     type: object
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] dt-bindings: interrupt-controller: arm: Drop redundant node name restrictions
  2025-12-31 11:30 [PATCH] dt-bindings: interrupt-controller: arm: Drop redundant node name restrictions Pankaj Patil
@ 2026-01-02 21:47 ` Rob Herring
  0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2026-01-02 21:47 UTC (permalink / raw)
  To: Pankaj Patil
  Cc: maz, tglx, krzk+dt, conor+dt, linux-arm-kernel, linux-kernel,
	devicetree

On Wed, Dec 31, 2025 at 05:00:26PM +0530, Pankaj Patil wrote:
> Drop the redundant 'false' patterns so that allowed names
> ('msi-controller', 'gic-its', and 'interrupt-controller') work as intended
> 
> GICv3 binding currently disallows child nodes named 'gic-its@' and
> 'interrupt-controller@' via patternProperties set to 'false'. However,
> these names are already permitted (though not preferred) by a subsequent
> pattern that applies the correct schema.
> 
> Since the 'false' patterns take precedence, valid nodes such as
> 'gic-its@<addr>' and 'interrupt-controller@<addr>' fail dtbs_check with
> "False schema does not allow" errors

The reason it is done this way is so that we both check the child nodes 
and warn on deprecated names. 

Fix your .dts files ITS node name to be "msi-controller".

If the node names are fixed everywhere now, then we could just change 
this to "^msi-controller@[0-9a-f]+$".

Rob


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-01-02 21:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-31 11:30 [PATCH] dt-bindings: interrupt-controller: arm: Drop redundant node name restrictions Pankaj Patil
2026-01-02 21:47 ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).