linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3 0/2] Add OrangePi 6 Plus board
@ 2026-01-04  7:53 Gary Yang
  2026-01-04  7:53 ` [PATCH v3 1/2] dt-bindings: arm: cix: add " Gary Yang
  2026-01-04  7:54 ` [PATCH v3 2/2] arm64: dts: cix: Add OrangePi 6 Plus board support Gary Yang
  0 siblings, 2 replies; 10+ messages in thread
From: Gary Yang @ 2026-01-04  7:53 UTC (permalink / raw)
  To: peter.chen, fugang.duan, robh, krzk+dt, conor+dt
  Cc: linux-cix-kernel-upstream, linux-arm-kernel, devicetree,
	linux-kernel, Gary Yang

Patch 1: add compatible strings for OrangePi 6 Plus board
Patch 2: add dts file for OrangePi 6 Plus board

v3 changes:
-Pass dts build check with below commands:
make O=$OUTKNL dt_binding_check
make O=$OUTKNL dt_binding_check DT_SCHEMA_FILES=arm/cix.yaml
scripts/checkpatch.pl 000*.patch
make O=$OUTKNL CHECK_DTBS=y W=1 cix/sky1-orion-o6.dtb
- Fix the description of board
- Fix the commit message length within 75 words

v2 changes:
-Pass dts build check with below commands:
make O=$OUTKNL dt_binding_check
make O=$OUTKNL dt_binding_check DT_SCHEMA_FILES=arm/cix.yaml
scripts/checkpatch.pl 000*.patch
make O=$OUTKNL CHECK_DTBS=y W=1 cix/sky1-orion-o6.dtb
- Fix the description of board

Gary Yang (2):
  dt-bindings: arm: cix: add OrangePi 6 Plus board
  arm64: dts: cix: Add OrangePi 6 Plus board support

 .../devicetree/bindings/arm/cix.yaml          | 11 ++-
 arch/arm64/boot/dts/cix/Makefile              |  1 +
 arch/arm64/boot/dts/cix/sky1-xcp.dts          | 83 +++++++++++++++++++
 3 files changed, 93 insertions(+), 2 deletions(-)
 create mode 100644 arch/arm64/boot/dts/cix/sky1-xcp.dts

-- 
2.49.0



^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH v3 1/2] dt-bindings: arm: cix: add OrangePi 6 Plus board
  2026-01-04  7:53 [PATCH v3 0/2] Add OrangePi 6 Plus board Gary Yang
@ 2026-01-04  7:53 ` Gary Yang
  2026-01-05  8:21   ` Krzysztof Kozlowski
  2026-01-04  7:54 ` [PATCH v3 2/2] arm64: dts: cix: Add OrangePi 6 Plus board support Gary Yang
  1 sibling, 1 reply; 10+ messages in thread
From: Gary Yang @ 2026-01-04  7:53 UTC (permalink / raw)
  To: peter.chen, fugang.duan, robh, krzk+dt, conor+dt
  Cc: linux-cix-kernel-upstream, linux-arm-kernel, devicetree,
	linux-kernel, Gary Yang

OrangePi 6 Plus adopts CIX CD8180/CD8160 SoC, built-in 12-core 64-bit
processor + NPU processor,integrated graphics processor, equipped with
16GB/32GB/64GB LPDDR5, and provides two M.2 KEY-M interfaces 2280 for NVMe
SSD,as well as SPI FLASH and TF slots to meet the needs of fast read/write
and high-capacity storage

Signed-off-by: Gary Yang <gary.yang@cixtech.com>
---
 Documentation/devicetree/bindings/arm/cix.yaml | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/arm/cix.yaml b/Documentation/devicetree/bindings/arm/cix.yaml
index 114dab4bc4d2..9e132e609b7b 100644
--- a/Documentation/devicetree/bindings/arm/cix.yaml
+++ b/Documentation/devicetree/bindings/arm/cix.yaml
@@ -16,9 +16,16 @@ properties:
   compatible:
     oneOf:
 
-      - description: Radxa Orion O6
+      - description: Radxa Orion O6 board
         items:
-          - const: radxa,orion-o6
+          - enum:
+              - radxa,orion-o6
+          - const: cix,sky1
+
+      - description: Xunlong orangepi 6 plus board
+        items:
+          - enum:
+              - xunlong,orangepi-6-plus
           - const: cix,sky1
 
 additionalProperties: true
-- 
2.49.0



^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH v3 2/2] arm64: dts: cix: Add OrangePi 6 Plus board support
  2026-01-04  7:53 [PATCH v3 0/2] Add OrangePi 6 Plus board Gary Yang
  2026-01-04  7:53 ` [PATCH v3 1/2] dt-bindings: arm: cix: add " Gary Yang
@ 2026-01-04  7:54 ` Gary Yang
  1 sibling, 0 replies; 10+ messages in thread
From: Gary Yang @ 2026-01-04  7:54 UTC (permalink / raw)
  To: peter.chen, fugang.duan, robh, krzk+dt, conor+dt
  Cc: linux-cix-kernel-upstream, linux-arm-kernel, devicetree,
	linux-kernel, Gary Yang

OrangePi 6 Plus adopts CIX CD8180/CD8160 SoC, built-in 12-core 64-bit
processor + NPU processor,integrated graphics processor, equipped with
16GB/32GB/64GB LPDDR5, and provides two M.2 KEY-M interfaces 2280 for NVMe
SSD,as well as SPI FLASH and TF slots to meet the needs of fast read/write
and high-capacity storage

Signed-off-by: Gary Yang <gary.yang@cixtech.com>
---
 arch/arm64/boot/dts/cix/Makefile     |  1 +
 arch/arm64/boot/dts/cix/sky1-xcp.dts | 83 ++++++++++++++++++++++++++++
 2 files changed, 84 insertions(+)
 create mode 100644 arch/arm64/boot/dts/cix/sky1-xcp.dts

diff --git a/arch/arm64/boot/dts/cix/Makefile b/arch/arm64/boot/dts/cix/Makefile
index ed3713982012..8a6c6fdc4ec0 100644
--- a/arch/arm64/boot/dts/cix/Makefile
+++ b/arch/arm64/boot/dts/cix/Makefile
@@ -1,2 +1,3 @@
 # SPDX-License-Identifier: GPL-2.0
 dtb-$(CONFIG_ARCH_CIX) += sky1-orion-o6.dtb
+dtb-$(CONFIG_ARCH_CIX) += sky1-xcp.dtb
diff --git a/arch/arm64/boot/dts/cix/sky1-xcp.dts b/arch/arm64/boot/dts/cix/sky1-xcp.dts
new file mode 100644
index 000000000000..1fae52dc9bb0
--- /dev/null
+++ b/arch/arm64/boot/dts/cix/sky1-xcp.dts
@@ -0,0 +1,83 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright 2025 Cix Technology Group Co., Ltd.
+ *
+ */
+
+/dts-v1/;
+
+#include "sky1.dtsi"
+#include "sky1-pinfunc.h"
+
+/ {
+	model = "Xunlong,OrangePi 6 Plus";
+	compatible = "xunlong,orangepi-6-plus", "cix,sky1";
+
+	aliases {
+		serial2 = &uart2;
+	};
+
+	chosen {
+		stdout-path = &uart2;
+	};
+
+	reserved-memory {
+		#address-cells = <2>;
+		#size-cells = <2>;
+		ranges;
+
+		linux,cma {
+			compatible = "shared-dma-pool";
+			reusable;
+			size = <0x0 0x28000000>;
+			linux,cma-default;
+		};
+	};
+
+};
+
+&iomuxc {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_hog>;
+
+	pinctrl_hog: hog-cfg {
+		pins {
+			pinmux = <CIX_PAD_GPIO144_FUNC_GPIO144>,
+				<CIX_PAD_GPIO145_FUNC_GPIO145>,
+				<CIX_PAD_GPIO146_FUNC_GPIO146>,
+				<CIX_PAD_GPIO147_FUNC_GPIO147>;
+			bias-pull-down;
+			drive-strength = <8>;
+		};
+	};
+};
+
+&iomuxc_s5 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_hog_s5>;
+
+	pinctrl_hog_s5: hog-s5-cfg {
+		pins {
+			pinmux = <CIX_PAD_GPIO014_FUNC_GPIO014>;
+			bias-pull-up;
+			drive-strength = <8>;
+
+		};
+	};
+};
+
+&pcie_x8_rc {
+	status = "okay";
+};
+
+&pcie_x2_rc {
+	status = "okay";
+};
+
+&pcie_x1_1_rc {
+	status = "okay";
+};
+
+&uart2 {
+	status = "okay";
+};
-- 
2.49.0



^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH v3 1/2] dt-bindings: arm: cix: add OrangePi 6 Plus board
  2026-01-04  7:53 ` [PATCH v3 1/2] dt-bindings: arm: cix: add " Gary Yang
@ 2026-01-05  8:21   ` Krzysztof Kozlowski
  2026-01-05  8:49     ` 回复: " Gary Yang
  0 siblings, 1 reply; 10+ messages in thread
From: Krzysztof Kozlowski @ 2026-01-05  8:21 UTC (permalink / raw)
  To: Gary Yang
  Cc: peter.chen, fugang.duan, robh, krzk+dt, conor+dt,
	linux-cix-kernel-upstream, linux-arm-kernel, devicetree,
	linux-kernel

On Sun, Jan 04, 2026 at 03:53:59PM +0800, Gary Yang wrote:
> OrangePi 6 Plus adopts CIX CD8180/CD8160 SoC, built-in 12-core 64-bit
> processor + NPU processor,integrated graphics processor, equipped with
> 16GB/32GB/64GB LPDDR5, and provides two M.2 KEY-M interfaces 2280 for NVMe
> SSD,as well as SPI FLASH and TF slots to meet the needs of fast read/write
> and high-capacity storage
> 
> Signed-off-by: Gary Yang <gary.yang@cixtech.com>
> ---
>  Documentation/devicetree/bindings/arm/cix.yaml | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/cix.yaml b/Documentation/devicetree/bindings/arm/cix.yaml
> index 114dab4bc4d2..9e132e609b7b 100644
> --- a/Documentation/devicetree/bindings/arm/cix.yaml
> +++ b/Documentation/devicetree/bindings/arm/cix.yaml
> @@ -16,9 +16,16 @@ properties:
>    compatible:
>      oneOf:
>  
> -      - description: Radxa Orion O6
> +      - description: Radxa Orion O6 board
>          items:
> -          - const: radxa,orion-o6
> +          - enum:
> +              - radxa,orion-o6
> +          - const: cix,sky1
> +
> +      - description: Xunlong orangepi 6 plus board
> +        items:
> +          - enum:
> +              - xunlong,orangepi-6-plus

Previous patch was correct, not this one.

<form letter>
This is a friendly reminder during the review process.

It looks like you received a tag and forgot to add it.

If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions of patchset, under or above your Signed-off-by tag, unless
patch changed significantly (e.g. new properties added to the DT
bindings). Tag is "received", when provided in a message replied to you
on the mailing list. Tools like b4 can help here. However, there's no
need to repost patches *only* to add the tags. The upstream maintainer
will do that for tags received on the version they apply.

Please read:
https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577

If a tag was not added on purpose, please state why and what changed.
</form letter>

Read last sentence and linked documentation. Where did you explain
ignoring/dropping my tag?

Best regards,
Krzysztof



^ permalink raw reply	[flat|nested] 10+ messages in thread

* 回复: [PATCH v3 1/2] dt-bindings: arm: cix: add OrangePi 6 Plus board
  2026-01-05  8:21   ` Krzysztof Kozlowski
@ 2026-01-05  8:49     ` Gary Yang
  2026-01-05  9:05       ` Krzysztof Kozlowski
  0 siblings, 1 reply; 10+ messages in thread
From: Gary Yang @ 2026-01-05  8:49 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Peter Chen, Fugang Duan, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, linux-cix-kernel-upstream@cixtech.com,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org

Hi Krzysztof:

Thanks for your comments

> EXTERNAL EMAIL
> 
> On Sun, Jan 04, 2026 at 03:53:59PM +0800, Gary Yang wrote:
> > OrangePi 6 Plus adopts CIX CD8180/CD8160 SoC, built-in 12-core 64-bit
> > processor + NPU processor,integrated graphics processor, equipped with
> > 16GB/32GB/64GB LPDDR5, and provides two M.2 KEY-M interfaces 2280 for
> > NVMe SSD,as well as SPI FLASH and TF slots to meet the needs of fast
> > read/write and high-capacity storage
> >
> > Signed-off-by: Gary Yang <gary.yang@cixtech.com>
> > ---
> >  Documentation/devicetree/bindings/arm/cix.yaml | 11 +++++++++--
> >  1 file changed, 9 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/cix.yaml
> > b/Documentation/devicetree/bindings/arm/cix.yaml
> > index 114dab4bc4d2..9e132e609b7b 100644
> > --- a/Documentation/devicetree/bindings/arm/cix.yaml
> > +++ b/Documentation/devicetree/bindings/arm/cix.yaml
> > @@ -16,9 +16,16 @@ properties:
> >    compatible:
> >      oneOf:
> >
> > -      - description: Radxa Orion O6
> > +      - description: Radxa Orion O6 board
> >          items:
> > -          - const: radxa,orion-o6
> > +          - enum:
> > +              - radxa,orion-o6
> > +          - const: cix,sky1
> > +
> > +      - description: Xunlong orangepi 6 plus board
> > +        items:
> > +          - enum:
> > +              - xunlong,orangepi-6-plus
> 
> Previous patch was correct, not this one.
> 
> <form letter>
> This is a friendly reminder during the review process.
> 
> It looks like you received a tag and forgot to add it.
> 
> If you do not know the process, here is a short explanation:
> Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions
> of patchset, under or above your Signed-off-by tag, unless patch changed
> significantly (e.g. new properties added to the DT bindings). Tag is "received",
> when provided in a message replied to you on the mailing list. Tools like b4 can
> help here. However, there's no need to repost patches *only* to add the tags.
> The upstream maintainer will do that for tags received on the version they
> apply.
> 
> Please read:
> https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/sub
> mitting-patches.rst#L577
> 
> If a tag was not added on purpose, please state why and what changed.
> </form letter>
> 
> Read last sentence and linked documentation. Where did you explain
> ignoring/dropping my tag?
> 

Yes, the previous version was acked by you before.

When apply it, we found that orangepi 6 plus and Radxa Orion O6 belongs the different boards.

So we need to add a new item for it. Like these from qcom.yaml

      - description: Qualcomm Technologies, Inc. Distributed Unit 1000 platform
        items:
          - enum:
              - qcom,qdu1000-idp
              - qcom,qdu1000-x100
          - const: qcom,qdu1000

      - description: Qualcomm Technologies, Inc. Radio Unit 1000 platform
        items:
          - enum:
              - qcom,qru1000-idp
          - const: qcom,qru1000

Best Regards
Gary

> Best regards,
> Krzysztof



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: 回复: [PATCH v3 1/2] dt-bindings: arm: cix: add OrangePi 6 Plus board
  2026-01-05  8:49     ` 回复: " Gary Yang
@ 2026-01-05  9:05       ` Krzysztof Kozlowski
  2026-01-06  4:52         ` 回复: " Gary Yang
  0 siblings, 1 reply; 10+ messages in thread
From: Krzysztof Kozlowski @ 2026-01-05  9:05 UTC (permalink / raw)
  To: Gary Yang
  Cc: Peter Chen, Fugang Duan, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, linux-cix-kernel-upstream@cixtech.com,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org

On 05/01/2026 09:49, Gary Yang wrote:
> Hi Krzysztof:
> 
> Thanks for your comments
> 
>> EXTERNAL EMAIL
>>
>> On Sun, Jan 04, 2026 at 03:53:59PM +0800, Gary Yang wrote:
>>> OrangePi 6 Plus adopts CIX CD8180/CD8160 SoC, built-in 12-core 64-bit
>>> processor + NPU processor,integrated graphics processor, equipped with
>>> 16GB/32GB/64GB LPDDR5, and provides two M.2 KEY-M interfaces 2280 for
>>> NVMe SSD,as well as SPI FLASH and TF slots to meet the needs of fast
>>> read/write and high-capacity storage
>>>
>>> Signed-off-by: Gary Yang <gary.yang@cixtech.com>
>>> ---
>>>  Documentation/devicetree/bindings/arm/cix.yaml | 11 +++++++++--
>>>  1 file changed, 9 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/cix.yaml
>>> b/Documentation/devicetree/bindings/arm/cix.yaml
>>> index 114dab4bc4d2..9e132e609b7b 100644
>>> --- a/Documentation/devicetree/bindings/arm/cix.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/cix.yaml
>>> @@ -16,9 +16,16 @@ properties:
>>>    compatible:
>>>      oneOf:
>>>
>>> -      - description: Radxa Orion O6
>>> +      - description: Radxa Orion O6 board
>>>          items:
>>> -          - const: radxa,orion-o6
>>> +          - enum:
>>> +              - radxa,orion-o6
>>> +          - const: cix,sky1
>>> +
>>> +      - description: Xunlong orangepi 6 plus board
>>> +        items:
>>> +          - enum:
>>> +              - xunlong,orangepi-6-plus
>>
>> Previous patch was correct, not this one.
>>
>> <form letter>
>> This is a friendly reminder during the review process.
>>
>> It looks like you received a tag and forgot to add it.
>>
>> If you do not know the process, here is a short explanation:
>> Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions
>> of patchset, under or above your Signed-off-by tag, unless patch changed
>> significantly (e.g. new properties added to the DT bindings). Tag is "received",
>> when provided in a message replied to you on the mailing list. Tools like b4 can
>> help here. However, there's no need to repost patches *only* to add the tags.
>> The upstream maintainer will do that for tags received on the version they
>> apply.
>>
>> Please read:
>> https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/sub
>> mitting-patches.rst#L577
>>
>> If a tag was not added on purpose, please state why and what changed.
>> </form letter>
>>
>> Read last sentence and linked documentation. Where did you explain
>> ignoring/dropping my tag?
>>
> 
> Yes, the previous version was acked by you before.

I stressed what I expect twice. In form letter and later explicitly. You
still ignored it.

> 
> When apply it, we found that orangepi 6 plus and Radxa Orion O6 belongs the different boards.
> 
> So we need to add a new item for it. Like these from qcom.yaml
> 
>       - description: Qualcomm Technologies, Inc. Distributed Unit 1000 platform
>         items:
>           - enum:
>               - qcom,qdu1000-idp
>               - qcom,qdu1000-x100
>           - const: qcom,qdu1000
> 
>       - description: Qualcomm Technologies, Inc. Radio Unit 1000 platform
>         items:
>           - enum:
>               - qcom,qru1000-idp
>           - const: qcom,qru1000

No, look at SoCs. Different SocS.


Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 10+ messages in thread

* 回复: 回复: [PATCH v3 1/2] dt-bindings: arm: cix: add OrangePi 6 Plus board
  2026-01-05  9:05       ` Krzysztof Kozlowski
@ 2026-01-06  4:52         ` Gary Yang
  2026-01-06  7:04           ` Krzysztof Kozlowski
  0 siblings, 1 reply; 10+ messages in thread
From: Gary Yang @ 2026-01-06  4:52 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Peter Chen, Fugang Duan, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, linux-cix-kernel-upstream@cixtech.com,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org

Hi Krzysztof:

Thanks for your comments

> EXTERNAL EMAIL
> 
> On 05/01/2026 09:49, Gary Yang wrote:
> > Hi Krzysztof:
> >
> > Thanks for your comments
> >
> >> EXTERNAL EMAIL
> >>
> >> On Sun, Jan 04, 2026 at 03:53:59PM +0800, Gary Yang wrote:
> >>> OrangePi 6 Plus adopts CIX CD8180/CD8160 SoC, built-in 12-core
> >>> 64-bit processor + NPU processor,integrated graphics processor,
> >>> equipped with 16GB/32GB/64GB LPDDR5, and provides two M.2 KEY-M
> >>> interfaces 2280 for NVMe SSD,as well as SPI FLASH and TF slots to
> >>> meet the needs of fast read/write and high-capacity storage
> >>>
> >>> Signed-off-by: Gary Yang <gary.yang@cixtech.com>
> >>> ---
> >>>  Documentation/devicetree/bindings/arm/cix.yaml | 11 +++++++++--
> >>>  1 file changed, 9 insertions(+), 2 deletions(-)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/arm/cix.yaml
> >>> b/Documentation/devicetree/bindings/arm/cix.yaml
> >>> index 114dab4bc4d2..9e132e609b7b 100644
> >>> --- a/Documentation/devicetree/bindings/arm/cix.yaml
> >>> +++ b/Documentation/devicetree/bindings/arm/cix.yaml
> >>> @@ -16,9 +16,16 @@ properties:
> >>>    compatible:
> >>>      oneOf:
> >>>
> >>> -      - description: Radxa Orion O6
> >>> +      - description: Radxa Orion O6 board
> >>>          items:
> >>> -          - const: radxa,orion-o6
> >>> +          - enum:
> >>> +              - radxa,orion-o6
> >>> +          - const: cix,sky1
> >>> +
> >>> +      - description: Xunlong orangepi 6 plus board
> >>> +        items:
> >>> +          - enum:
> >>> +              - xunlong,orangepi-6-plus
> >>
> >> Previous patch was correct, not this one.
> >>
> >> <form letter>
> >> This is a friendly reminder during the review process.
> >>
> >> It looks like you received a tag and forgot to add it.
> >>
> >> If you do not know the process, here is a short explanation:
> >> Please add Acked-by/Reviewed-by/Tested-by tags when posting new
> >> versions of patchset, under or above your Signed-off-by tag, unless
> >> patch changed significantly (e.g. new properties added to the DT
> >> bindings). Tag is "received", when provided in a message replied to
> >> you on the mailing list. Tools like b4 can help here. However, there's no
> need to repost patches *only* to add the tags.
> >> The upstream maintainer will do that for tags received on the version
> >> they apply.
> >>
> >> Please read:
> >> https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/proce
> >> ss/sub
> >> mitting-patches.rst#L577
> >>
> >> If a tag was not added on purpose, please state why and what changed.
> >> </form letter>
> >>
> >> Read last sentence and linked documentation. Where did you explain
> >> ignoring/dropping my tag?
> >>
> >
> > Yes, the previous version was acked by you before.
> 
> I stressed what I expect twice. In form letter and later explicitly. You still
> ignored it.
> 
> >
> > When apply it, we found that orangepi 6 plus and Radxa Orion O6 belongs
> the different boards.
> >
> > So we need to add a new item for it. Like these from qcom.yaml
> >
> >       - description: Qualcomm Technologies, Inc. Distributed Unit 1000
> platform
> >         items:
> >           - enum:
> >               - qcom,qdu1000-idp
> >               - qcom,qdu1000-x100
> >           - const: qcom,qdu1000
> >
> >       - description: Qualcomm Technologies, Inc. Radio Unit 1000 platform
> >         items:
> >           - enum:
> >               - qcom,qru1000-idp
> >           - const: qcom,qru1000
> 
> No, look at SoCs. Different SocS.
> 

Please Look at rockchip.yaml, the same Socs, and the different boards

      - description: 96boards RK3399 Ficus (ROCK960 Enterprise Edition)
        items:
          - const: vamrs,ficus
          - const: rockchip,rk3399

      - description: 96boards RK3399 Rock960 (ROCK960 Consumer Edition)
        items:
          - const: vamrs,rock960
          - const: rockchip,rk3399

For the different boards,please give your professional suggestions,Thanks a lot

Best Regards
Gary
> 
> Best regards,
> Krzysztof

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: 回复: 回复: [PATCH v3 1/2] dt-bindings: arm: cix: add OrangePi 6 Plus board
  2026-01-06  4:52         ` 回复: " Gary Yang
@ 2026-01-06  7:04           ` Krzysztof Kozlowski
  2026-01-06  7:41             ` 回复: " Gary Yang
  0 siblings, 1 reply; 10+ messages in thread
From: Krzysztof Kozlowski @ 2026-01-06  7:04 UTC (permalink / raw)
  To: Gary Yang
  Cc: Peter Chen, Fugang Duan, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, linux-cix-kernel-upstream@cixtech.com,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org

On 06/01/2026 05:52, Gary Yang wrote:
> Hi Krzysztof:
> 
> Thanks for your comments
> 
>> EXTERNAL EMAIL
>>
>> On 05/01/2026 09:49, Gary Yang wrote:
>>> Hi Krzysztof:
>>>
>>> Thanks for your comments
>>>
>>>> EXTERNAL EMAIL
>>>>
>>>> On Sun, Jan 04, 2026 at 03:53:59PM +0800, Gary Yang wrote:
>>>>> OrangePi 6 Plus adopts CIX CD8180/CD8160 SoC, built-in 12-core
>>>>> 64-bit processor + NPU processor,integrated graphics processor,
>>>>> equipped with 16GB/32GB/64GB LPDDR5, and provides two M.2 KEY-M
>>>>> interfaces 2280 for NVMe SSD,as well as SPI FLASH and TF slots to
>>>>> meet the needs of fast read/write and high-capacity storage
>>>>>
>>>>> Signed-off-by: Gary Yang <gary.yang@cixtech.com>
>>>>> ---
>>>>>  Documentation/devicetree/bindings/arm/cix.yaml | 11 +++++++++--
>>>>>  1 file changed, 9 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/arm/cix.yaml
>>>>> b/Documentation/devicetree/bindings/arm/cix.yaml
>>>>> index 114dab4bc4d2..9e132e609b7b 100644
>>>>> --- a/Documentation/devicetree/bindings/arm/cix.yaml
>>>>> +++ b/Documentation/devicetree/bindings/arm/cix.yaml
>>>>> @@ -16,9 +16,16 @@ properties:
>>>>>    compatible:
>>>>>      oneOf:
>>>>>
>>>>> -      - description: Radxa Orion O6
>>>>> +      - description: Radxa Orion O6 board
>>>>>          items:
>>>>> -          - const: radxa,orion-o6
>>>>> +          - enum:
>>>>> +              - radxa,orion-o6
>>>>> +          - const: cix,sky1
>>>>> +
>>>>> +      - description: Xunlong orangepi 6 plus board
>>>>> +        items:
>>>>> +          - enum:
>>>>> +              - xunlong,orangepi-6-plus
>>>>
>>>> Previous patch was correct, not this one.
>>>>
>>>> <form letter>
>>>> This is a friendly reminder during the review process.
>>>>
>>>> It looks like you received a tag and forgot to add it.
>>>>
>>>> If you do not know the process, here is a short explanation:
>>>> Please add Acked-by/Reviewed-by/Tested-by tags when posting new
>>>> versions of patchset, under or above your Signed-off-by tag, unless
>>>> patch changed significantly (e.g. new properties added to the DT
>>>> bindings). Tag is "received", when provided in a message replied to
>>>> you on the mailing list. Tools like b4 can help here. However, there's no
>> need to repost patches *only* to add the tags.
>>>> The upstream maintainer will do that for tags received on the version
>>>> they apply.
>>>>
>>>> Please read:
>>>> https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/proce
>>>> ss/sub
>>>> mitting-patches.rst#L577
>>>>
>>>> If a tag was not added on purpose, please state why and what changed.
>>>> </form letter>
>>>>
>>>> Read last sentence and linked documentation. Where did you explain
>>>> ignoring/dropping my tag?
>>>>
>>>
>>> Yes, the previous version was acked by you before.
>>
>> I stressed what I expect twice. In form letter and later explicitly. You still
>> ignored it.
>>
>>>
>>> When apply it, we found that orangepi 6 plus and Radxa Orion O6 belongs
>> the different boards.
>>>
>>> So we need to add a new item for it. Like these from qcom.yaml
>>>
>>>       - description: Qualcomm Technologies, Inc. Distributed Unit 1000
>> platform
>>>         items:
>>>           - enum:
>>>               - qcom,qdu1000-idp
>>>               - qcom,qdu1000-x100
>>>           - const: qcom,qdu1000
>>>
>>>       - description: Qualcomm Technologies, Inc. Radio Unit 1000 platform
>>>         items:
>>>           - enum:
>>>               - qcom,qru1000-idp
>>>           - const: qcom,qru1000
>>
>> No, look at SoCs. Different SocS.
>>
> 
> Please Look at rockchip.yaml, the same Socs, and the different boards
> 
>       - description: 96boards RK3399 Ficus (ROCK960 Enterprise Edition)
>         items:
>           - const: vamrs,ficus
>           - const: rockchip,rk3399
> 
>       - description: 96boards RK3399 Rock960 (ROCK960 Consumer Edition)
>         items:
>           - const: vamrs,rock960
>           - const: rockchip,rk3399
> 
> For the different boards,please give your professional suggestions,Thanks a lot

I gave you already.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 10+ messages in thread

* 回复: 回复: 回复: [PATCH v3 1/2] dt-bindings: arm: cix: add OrangePi 6 Plus board
  2026-01-06  7:04           ` Krzysztof Kozlowski
@ 2026-01-06  7:41             ` Gary Yang
  2026-01-06  7:47               ` Krzysztof Kozlowski
  0 siblings, 1 reply; 10+ messages in thread
From: Gary Yang @ 2026-01-06  7:41 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Peter Chen, Fugang Duan, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, linux-cix-kernel-upstream@cixtech.com,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org

Hi Krzysztof:

Thanks for you commets

> EXTERNAL EMAIL
> 
> On 06/01/2026 05:52, Gary Yang wrote:
> > Hi Krzysztof:
> >
> > Thanks for your comments
> >
> >> EXTERNAL EMAIL
> >>
> >> On 05/01/2026 09:49, Gary Yang wrote:
> >>> Hi Krzysztof:
> >>>
> >>> Thanks for your comments
> >>>
> >>>> EXTERNAL EMAIL
> >>>>
> >>>> On Sun, Jan 04, 2026 at 03:53:59PM +0800, Gary Yang wrote:
> >>>>> OrangePi 6 Plus adopts CIX CD8180/CD8160 SoC, built-in 12-core
> >>>>> 64-bit processor + NPU processor,integrated graphics processor,
> >>>>> equipped with 16GB/32GB/64GB LPDDR5, and provides two M.2 KEY-M
> >>>>> interfaces 2280 for NVMe SSD,as well as SPI FLASH and TF slots to
> >>>>> meet the needs of fast read/write and high-capacity storage
> >>>>>
> >>>>> Signed-off-by: Gary Yang <gary.yang@cixtech.com>
> >>>>> ---
> >>>>>  Documentation/devicetree/bindings/arm/cix.yaml | 11 +++++++++--
> >>>>>  1 file changed, 9 insertions(+), 2 deletions(-)
> >>>>>
> >>>>> diff --git a/Documentation/devicetree/bindings/arm/cix.yaml
> >>>>> b/Documentation/devicetree/bindings/arm/cix.yaml
> >>>>> index 114dab4bc4d2..9e132e609b7b 100644
> >>>>> --- a/Documentation/devicetree/bindings/arm/cix.yaml
> >>>>> +++ b/Documentation/devicetree/bindings/arm/cix.yaml
> >>>>> @@ -16,9 +16,16 @@ properties:
> >>>>>    compatible:
> >>>>>      oneOf:
> >>>>>
> >>>>> -      - description: Radxa Orion O6
> >>>>> +      - description: Radxa Orion O6 board
> >>>>>          items:
> >>>>> -          - const: radxa,orion-o6
> >>>>> +          - enum:
> >>>>> +              - radxa,orion-o6
> >>>>> +          - const: cix,sky1
> >>>>> +
> >>>>> +      - description: Xunlong orangepi 6 plus board
> >>>>> +        items:
> >>>>> +          - enum:
> >>>>> +              - xunlong,orangepi-6-plus
> >>>>
> >>>> Previous patch was correct, not this one.
> >>>>
> >>>> <form letter>
> >>>> This is a friendly reminder during the review process.
> >>>>
> >>>> It looks like you received a tag and forgot to add it.
> >>>>
> >>>> If you do not know the process, here is a short explanation:
> >>>> Please add Acked-by/Reviewed-by/Tested-by tags when posting new
> >>>> versions of patchset, under or above your Signed-off-by tag, unless
> >>>> patch changed significantly (e.g. new properties added to the DT
> >>>> bindings). Tag is "received", when provided in a message replied to
> >>>> you on the mailing list. Tools like b4 can help here. However,
> >>>> there's no
> >> need to repost patches *only* to add the tags.
> >>>> The upstream maintainer will do that for tags received on the
> >>>> version they apply.
> >>>>
> >>>> Please read:
> >>>> https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/pro
> >>>> ce
> >>>> ss/sub
> >>>> mitting-patches.rst#L577
> >>>>
> >>>> If a tag was not added on purpose, please state why and what changed.
> >>>> </form letter>
> >>>>
> >>>> Read last sentence and linked documentation. Where did you explain
> >>>> ignoring/dropping my tag?
> >>>>
> >>>
> >>> Yes, the previous version was acked by you before.
> >>
> >> I stressed what I expect twice. In form letter and later explicitly.
> >> You still ignored it.
> >>
> >>>
> >>> When apply it, we found that orangepi 6 plus and Radxa Orion O6
> >>> belongs
> >> the different boards.
> >>>
> >>> So we need to add a new item for it. Like these from qcom.yaml
> >>>
> >>>       - description: Qualcomm Technologies, Inc. Distributed Unit
> >>> 1000
> >> platform
> >>>         items:
> >>>           - enum:
> >>>               - qcom,qdu1000-idp
> >>>               - qcom,qdu1000-x100
> >>>           - const: qcom,qdu1000
> >>>
> >>>       - description: Qualcomm Technologies, Inc. Radio Unit 1000
> platform
> >>>         items:
> >>>           - enum:
> >>>               - qcom,qru1000-idp
> >>>           - const: qcom,qru1000
> >>
> >> No, look at SoCs. Different SocS.
> >>
> >
> > Please Look at rockchip.yaml, the same Socs, and the different boards
> >
> >       - description: 96boards RK3399 Ficus (ROCK960 Enterprise Edition)
> >         items:
> >           - const: vamrs,ficus
> >           - const: rockchip,rk3399
> >
> >       - description: 96boards RK3399 Rock960 (ROCK960 Consumer
> Edition)
> >         items:
> >           - const: vamrs,rock960
> >           - const: rockchip,rk3399
> >
> > For the different boards,please give your professional
> > suggestions,Thanks a lot
> 
> I gave you already.
> 

We find these codes below from qcom.yaml, Can we do the same things?

      - description: Acer Chromebook Spin 513 with LTE (rev1 - 2)
        items:
          - const: google,lazor-rev1-sku0
          - const: google,lazor-rev2-sku0
          - const: qcom,sc7180

      - description: Acer Chromebook Spin 513 with LTE (rev3 - 8)
        items:
          - const: google,lazor-rev3-sku0
          - const: google,lazor-rev4-sku0
          - const: google,lazor-rev5-sku0
          - const: google,lazor-rev6-sku0
          - const: google,lazor-rev7-sku0
          - const: google,lazor-rev8-sku0
          - const: qcom,sc7180

      - description: Acer Chromebook Spin 513 with LTE (rev9)
        items:
          - const: google,lazor-rev9-sku0
          - const: google,lazor-rev9-sku10
          - const: qcom,sc7180

      - description: Acer Chromebook Spin 513 with LTE (newest rev)
        items:
          - const: google,lazor-sku0
          - const: google,lazor-sku10
          - const: qcom,sc7180

Best Regards
Gary


> Best regards,
> Krzysztof

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: 回复: 回复: 回复: [PATCH v3 1/2] dt-bindings: arm: cix: add OrangePi 6 Plus board
  2026-01-06  7:41             ` 回复: " Gary Yang
@ 2026-01-06  7:47               ` Krzysztof Kozlowski
  0 siblings, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2026-01-06  7:47 UTC (permalink / raw)
  To: Gary Yang
  Cc: Peter Chen, Fugang Duan, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, linux-cix-kernel-upstream@cixtech.com,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org

On 06/01/2026 08:41, Gary Yang wrote:
> Hi Krzysztof:
> 
> Thanks for you commets
> 
>> EXTERNAL EMAIL
>>
>> On 06/01/2026 05:52, Gary Yang wrote:
>>> Hi Krzysztof:
>>>
>>> Thanks for your comments
>>>
>>>> EXTERNAL EMAIL
>>>>
>>>> On 05/01/2026 09:49, Gary Yang wrote:
>>>>> Hi Krzysztof:
>>>>>
>>>>> Thanks for your comments
>>>>>
>>>>>> EXTERNAL EMAIL
>>>>>>
>>>>>> On Sun, Jan 04, 2026 at 03:53:59PM +0800, Gary Yang wrote:
>>>>>>> OrangePi 6 Plus adopts CIX CD8180/CD8160 SoC, built-in 12-core
>>>>>>> 64-bit processor + NPU processor,integrated graphics processor,
>>>>>>> equipped with 16GB/32GB/64GB LPDDR5, and provides two M.2 KEY-M
>>>>>>> interfaces 2280 for NVMe SSD,as well as SPI FLASH and TF slots to
>>>>>>> meet the needs of fast read/write and high-capacity storage
>>>>>>>
>>>>>>> Signed-off-by: Gary Yang <gary.yang@cixtech.com>
>>>>>>> ---
>>>>>>>  Documentation/devicetree/bindings/arm/cix.yaml | 11 +++++++++--
>>>>>>>  1 file changed, 9 insertions(+), 2 deletions(-)
>>>>>>>
>>>>>>> diff --git a/Documentation/devicetree/bindings/arm/cix.yaml
>>>>>>> b/Documentation/devicetree/bindings/arm/cix.yaml
>>>>>>> index 114dab4bc4d2..9e132e609b7b 100644
>>>>>>> --- a/Documentation/devicetree/bindings/arm/cix.yaml
>>>>>>> +++ b/Documentation/devicetree/bindings/arm/cix.yaml
>>>>>>> @@ -16,9 +16,16 @@ properties:
>>>>>>>    compatible:
>>>>>>>      oneOf:
>>>>>>>
>>>>>>> -      - description: Radxa Orion O6
>>>>>>> +      - description: Radxa Orion O6 board
>>>>>>>          items:
>>>>>>> -          - const: radxa,orion-o6
>>>>>>> +          - enum:
>>>>>>> +              - radxa,orion-o6
>>>>>>> +          - const: cix,sky1
>>>>>>> +
>>>>>>> +      - description: Xunlong orangepi 6 plus board
>>>>>>> +        items:
>>>>>>> +          - enum:
>>>>>>> +              - xunlong,orangepi-6-plus
>>>>>>
>>>>>> Previous patch was correct, not this one.
>>>>>>
>>>>>> <form letter>
>>>>>> This is a friendly reminder during the review process.
>>>>>>
>>>>>> It looks like you received a tag and forgot to add it.
>>>>>>
>>>>>> If you do not know the process, here is a short explanation:
>>>>>> Please add Acked-by/Reviewed-by/Tested-by tags when posting new
>>>>>> versions of patchset, under or above your Signed-off-by tag, unless
>>>>>> patch changed significantly (e.g. new properties added to the DT
>>>>>> bindings). Tag is "received", when provided in a message replied to
>>>>>> you on the mailing list. Tools like b4 can help here. However,
>>>>>> there's no
>>>> need to repost patches *only* to add the tags.
>>>>>> The upstream maintainer will do that for tags received on the
>>>>>> version they apply.
>>>>>>
>>>>>> Please read:
>>>>>> https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/pro
>>>>>> ce
>>>>>> ss/sub
>>>>>> mitting-patches.rst#L577
>>>>>>
>>>>>> If a tag was not added on purpose, please state why and what changed.
>>>>>> </form letter>
>>>>>>
>>>>>> Read last sentence and linked documentation. Where did you explain
>>>>>> ignoring/dropping my tag?
>>>>>>
>>>>>
>>>>> Yes, the previous version was acked by you before.
>>>>
>>>> I stressed what I expect twice. In form letter and later explicitly.
>>>> You still ignored it.
>>>>
>>>>>
>>>>> When apply it, we found that orangepi 6 plus and Radxa Orion O6
>>>>> belongs
>>>> the different boards.
>>>>>
>>>>> So we need to add a new item for it. Like these from qcom.yaml
>>>>>
>>>>>       - description: Qualcomm Technologies, Inc. Distributed Unit
>>>>> 1000
>>>> platform
>>>>>         items:
>>>>>           - enum:
>>>>>               - qcom,qdu1000-idp
>>>>>               - qcom,qdu1000-x100
>>>>>           - const: qcom,qdu1000
>>>>>
>>>>>       - description: Qualcomm Technologies, Inc. Radio Unit 1000
>> platform
>>>>>         items:
>>>>>           - enum:
>>>>>               - qcom,qru1000-idp
>>>>>           - const: qcom,qru1000
>>>>
>>>> No, look at SoCs. Different SocS.
>>>>
>>>
>>> Please Look at rockchip.yaml, the same Socs, and the different boards
>>>
>>>       - description: 96boards RK3399 Ficus (ROCK960 Enterprise Edition)
>>>         items:
>>>           - const: vamrs,ficus
>>>           - const: rockchip,rk3399
>>>
>>>       - description: 96boards RK3399 Rock960 (ROCK960 Consumer
>> Edition)
>>>         items:
>>>           - const: vamrs,rock960
>>>           - const: rockchip,rk3399
>>>
>>> For the different boards,please give your professional
>>> suggestions,Thanks a lot
>>
>> I gave you already.
>>
> 
> We find these codes below from qcom.yaml, Can we do the same things?

Open your binding. How many SKUs you have? ZERO.

Why do you ask if you can add more SKUs? To make the bindings fake? I
already told you what you have to do and you completely ignored it.
Previous code was correct, but you need to fix description. And look how
Qualcomm or IMX organizes this file.

I finished responding here, because you just don't bother to read my
replies.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2026-01-06  7:47 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-04  7:53 [PATCH v3 0/2] Add OrangePi 6 Plus board Gary Yang
2026-01-04  7:53 ` [PATCH v3 1/2] dt-bindings: arm: cix: add " Gary Yang
2026-01-05  8:21   ` Krzysztof Kozlowski
2026-01-05  8:49     ` 回复: " Gary Yang
2026-01-05  9:05       ` Krzysztof Kozlowski
2026-01-06  4:52         ` 回复: " Gary Yang
2026-01-06  7:04           ` Krzysztof Kozlowski
2026-01-06  7:41             ` 回复: " Gary Yang
2026-01-06  7:47               ` Krzysztof Kozlowski
2026-01-04  7:54 ` [PATCH v3 2/2] arm64: dts: cix: Add OrangePi 6 Plus board support Gary Yang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).