From: Andreas Kemnade <andreas@kemnade.info>
To: Wentao Liang <vulab@iscas.ac.cn>
Cc: aaro.koskinen@iki.fi, khilman@baylibre.com, rogerq@kernel.org,
tony@atomide.com, linux@armlinux.org.uk,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] ARM: omap2: Fix reference count leaks in omap_control_init()
Date: Mon, 5 Jan 2026 10:27:04 +0100 [thread overview]
Message-ID: <20260105102704.77d4c9d1@kemnade.info> (raw)
In-Reply-To: <20251217142122.1861292-1-vulab@iscas.ac.cn>
On Wed, 17 Dec 2025 14:21:22 +0000
Wentao Liang <vulab@iscas.ac.cn> wrote:
> The of_get_child_by_name() function increments the reference count
> of child nodes, causing multiple reference leaks in omap_control_init():
>
> 1. scm_conf node never released in normal/error paths
> 2. clocks node leak when checking existence
> 3. Missing scm_conf release before np in error paths
>
> Fix these leaks by adding proper of_node_put() calls and separate error
> handling.
>
> Fixes: e5b635742e98 ("ARM: OMAP2+: control: add syscon support for register accesses")
> Cc: stable@vger.kernel.org
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
Reviewed-by: Andreas Kemnade <andreas@kemnade.info>
next prev parent reply other threads:[~2026-01-05 9:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-17 14:21 [PATCH] ARM: omap2: Fix reference count leaks in omap_control_init() Wentao Liang
2026-01-05 9:27 ` Andreas Kemnade [this message]
2026-01-05 20:15 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260105102704.77d4c9d1@kemnade.info \
--to=andreas@kemnade.info \
--cc=aaro.koskinen@iki.fi \
--cc=khilman@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=rogerq@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tony@atomide.com \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox