From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4BAC7CEFCE1 for ; Tue, 6 Jan 2026 17:44:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JDHGpV83FwUsUgMDu8AtpObbsVJVBRDFol87Uk0j7Tg=; b=MdKFExl3S5vOY8wXKPvUYu0Qf+ pL40GFxs5XwROuWOsao8ranW6TJobvmA+TsmhI5jjMSed3BRygjk+jAvmY/LGFiW8r7gCeGCrTBdK A1etyBTHrj9qHY12bIXmvFXGna84TxOqc8RuLwRqVELpL6XeYocl7w4d1VbrhsXMWM9fycuuFfobW sawraqsUnYdKp189LErPTKClY0Y3Ey6RgR8Ost4HBFXwhVQ/Gv8+l1+/oUMpUMACGUHkEMzFaBoFP 9OKUW9yy6lNhTqJHvSu5648dRsGtxCOvfRLWM4VyzaRp1p+cc4a0lF41ruoCLCjNkWNEP1gnIVu/M ZDl+eWLA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vdB6E-0000000DbX4-3En5; Tue, 06 Jan 2026 17:44:06 +0000 Received: from smtpout-03.galae.net ([185.246.85.4]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vdB6B-0000000DbS0-2O1T for linux-arm-kernel@lists.infradead.org; Tue, 06 Jan 2026 17:44:05 +0000 Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 21B254E41FB6; Tue, 6 Jan 2026 17:44:02 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id E9ABC60739; Tue, 6 Jan 2026 17:44:01 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 20B52103C833E; Tue, 6 Jan 2026 18:43:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1767721440; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=JDHGpV83FwUsUgMDu8AtpObbsVJVBRDFol87Uk0j7Tg=; b=xgP7Bkyy1BI/gRGT6UjwDm/7XYFZRkP0Bs/5+HLLZFuKeGTQ5wvqfHB3ujyqc67yPGQ7jX XtMSvJSh4/1dJBTtPi/ajhEL/4GGdkEhAzmpI1yMokzfIyg5+Ir12+KIhc9OA8POwpwKsi 4K+Cm9qtIprYxGOibcIVKJSx4ijhT6fKxHkrhulJUeYhUmnSTTZT9AVBpP163fVUdztOc8 A01ss45KsDeMukzOaf92+HVwQzuJiPbLDD9Kh+C3akcv5NhCaIyftQaHlhp9JO2XDXn/2y YNBb0sPLQdTsTUOgBy79kM79YBIfjuqKufHUSxs+r+VYcErJw44WItM860zr3A== From: "Kory Maincent (TI.com)" Date: Tue, 06 Jan 2026 18:42:27 +0100 Subject: [PATCH v3 11/22] drm/tilcdc: Rename external_encoder and external_connector to encoder and connector MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260106-feature_tilcdc-v3-11-9bad0f742164@bootlin.com> References: <20260106-feature_tilcdc-v3-0-9bad0f742164@bootlin.com> In-Reply-To: <20260106-feature_tilcdc-v3-0-9bad0f742164@bootlin.com> To: Jyri Sarha , Tomi Valkeinen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Russell King , Bartosz Golaszewski , Tony Lindgren , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec Cc: Markus Schneider-Pargmann , Bajjuri Praneeth , Luca Ceresoli , Louis Chauvet , Thomas Petazzoni , Miguel Gazquez , Herve Codina , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, "Kory Maincent (TI.com)" X-Mailer: b4 0.14.3 X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260106_094403_887127_04D0A2C4 X-CRM114-Status: GOOD ( 16.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Remove the "external_" prefix from encoder and connector members in the tilcdc driver. These are internal driver structures and the "external" naming is misleading. The simpler names better reflect that these are the primary encoder and connector managed by this driver. Also rename tilcdc_attach_external_device() to tilcdc_encoder_create() for consistency and to better describe the function's purpose. Reviewed-by: Luca Ceresoli Signed-off-by: Kory Maincent (TI.com) --- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 4 ++-- drivers/gpu/drm/tilcdc/tilcdc_drv.h | 4 ++-- drivers/gpu/drm/tilcdc/tilcdc_external.c | 21 +++++++++------------ drivers/gpu/drm/tilcdc/tilcdc_external.h | 2 +- 4 files changed, 14 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c index a753cc47a59d7..bf6cd763ecd0f 100644 --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c @@ -344,11 +344,11 @@ static int tilcdc_init(const struct drm_driver *ddrv, struct device *dev) } #endif - ret = tilcdc_attach_external_device(ddev); + ret = tilcdc_encoder_create(ddev); if (ret) goto unregister_cpufreq_notif; - if (!priv->external_connector) { + if (!priv->connector) { dev_err(dev, "no encoders/connectors found\n"); ret = -EPROBE_DEFER; goto unregister_cpufreq_notif; diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.h b/drivers/gpu/drm/tilcdc/tilcdc_drv.h index 717529a331009..dafb00908d1d4 100644 --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.h +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.h @@ -75,8 +75,8 @@ struct tilcdc_drm_private { struct drm_crtc *crtc; - struct drm_encoder *external_encoder; - struct drm_connector *external_connector; + struct drm_encoder *encoder; + struct drm_connector *connector; bool irq_enabled; }; diff --git a/drivers/gpu/drm/tilcdc/tilcdc_external.c b/drivers/gpu/drm/tilcdc/tilcdc_external.c index 81c90c2754c6c..11ac9673ba98a 100644 --- a/drivers/gpu/drm/tilcdc/tilcdc_external.c +++ b/drivers/gpu/drm/tilcdc/tilcdc_external.c @@ -37,21 +37,20 @@ int tilcdc_attach_bridge(struct drm_device *ddev, struct drm_bridge *bridge) struct tilcdc_drm_private *priv = ddev->dev_private; int ret; - priv->external_encoder->possible_crtcs = BIT(0); + priv->encoder->possible_crtcs = BIT(0); - ret = drm_bridge_attach(priv->external_encoder, bridge, NULL, 0); + ret = drm_bridge_attach(priv->encoder, bridge, NULL, 0); if (ret) return ret; - priv->external_connector = - tilcdc_encoder_find_connector(ddev, priv->external_encoder); - if (!priv->external_connector) + priv->connector = tilcdc_encoder_find_connector(ddev, priv->encoder); + if (!priv->connector) return -ENODEV; return 0; } -int tilcdc_attach_external_device(struct drm_device *ddev) +int tilcdc_encoder_create(struct drm_device *ddev) { struct tilcdc_drm_private *priv = ddev->dev_private; struct drm_bridge *bridge; @@ -65,13 +64,11 @@ int tilcdc_attach_external_device(struct drm_device *ddev) else if (ret) return ret; - priv->external_encoder = devm_kzalloc(ddev->dev, - sizeof(*priv->external_encoder), - GFP_KERNEL); - if (!priv->external_encoder) + priv->encoder = devm_kzalloc(ddev->dev, sizeof(*priv->encoder), GFP_KERNEL); + if (!priv->encoder) return -ENOMEM; - ret = drm_simple_encoder_init(ddev, priv->external_encoder, + ret = drm_simple_encoder_init(ddev, priv->encoder, DRM_MODE_ENCODER_NONE); if (ret) { dev_err(ddev->dev, "drm_encoder_init() failed %d\n", ret); @@ -94,6 +91,6 @@ int tilcdc_attach_external_device(struct drm_device *ddev) return 0; err_encoder_cleanup: - drm_encoder_cleanup(priv->external_encoder); + drm_encoder_cleanup(priv->encoder); return ret; } diff --git a/drivers/gpu/drm/tilcdc/tilcdc_external.h b/drivers/gpu/drm/tilcdc/tilcdc_external.h index 285a132f3035d..c8f87f59024e6 100644 --- a/drivers/gpu/drm/tilcdc/tilcdc_external.h +++ b/drivers/gpu/drm/tilcdc/tilcdc_external.h @@ -7,5 +7,5 @@ #ifndef __TILCDC_EXTERNAL_H__ #define __TILCDC_EXTERNAL_H__ -int tilcdc_attach_external_device(struct drm_device *ddev); +int tilcdc_encoder_create(struct drm_device *ddev); #endif /* __TILCDC_SLAVE_H__ */ -- 2.43.0