Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: Kendall Willis <k-willis@ti.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
	Tero Kristo <kristo@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, <d-gole@ti.com>,
	<vishalm@ti.com>, <sebin.francis@ti.com>, <msp@baylibre.com>,
	<khilman@baylibre.com>, <a-kaur@ti.com>, <s-kochidanadu@ti.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 4/5] arm64: dts: ti: k3-am62p5-sk: Enable Main UART wakeup
Date: Tue, 6 Jan 2026 05:57:25 -0600	[thread overview]
Message-ID: <20260106115725.qqyg6isf5q7cg52g@renewable> (raw)
In-Reply-To: <44b21f10-2ad4-4c88-a8e8-f485ecb53af9@ti.com>

On 16:06-20260105, Kendall Willis wrote:
> On 1/5/26 07:52, Nishanth Menon wrote:
> > On 20:38-20251230, Kendall Willis wrote:
> > > The Main UART can resume from suspend to RAM states when PIN_WKUP_EN
> > > is enabled. Add the necessary pins needed to wakeup the system. Add the
> > > system idle states that the Main UART can wakeup the system from.
> > 
> > Is the tx and rx pin register states both lost? I wonder why during
> > "wakeup" we set PIN_WKUP_EN ? is'nt that supposed to be set while
> > entering "suspend" state?
> > 
> 
> The UART driver uses the default pinctrl state when the system is active.
> During the process of suspend, the wakeup pinctrl state is selected by the
> UART driver in order to allow wakeup. Upon resume, the default pinctrl state
> is selected again.
> 
> > if the tx pin register state is not lost, then all we need to do is
> > play with the rx pin state (and leave pinctrl-0 as is)?
> > 
> 
> Yes, it can be done where the pinctrl-0 does not change, and there is an
> additional pinctrl pins that has the TX and RX with PIN_WKUP_EN. The logic
> behind both implementations are the same, just a different approach.
> 

Keep the diff to as minimal as needed + update the commit message
please.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
https://ti.com/opensource


  reply	other threads:[~2026-01-06 11:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-31  2:38 [PATCH v2 0/5] arm64: dts: ti: k3-am62: Support Main UART wakeup Kendall Willis
2025-12-31  2:38 ` [PATCH v2 1/5] arm64: dts: ti: k3-am62l: Define possible system states Kendall Willis
2025-12-31  2:38 ` [PATCH v2 2/5] arm64: dts: ti: k3-am62x-sk-common: Enable Main UART wakeup Kendall Willis
2025-12-31  2:38 ` [PATCH v2 3/5] arm64: dts: ti: k3-am62a7-sk: " Kendall Willis
2025-12-31  2:38 ` [PATCH v2 4/5] arm64: dts: ti: k3-am62p5-sk: " Kendall Willis
2026-01-05 13:52   ` Nishanth Menon
2026-01-05 22:06     ` Kendall Willis
2026-01-06 11:57       ` Nishanth Menon [this message]
2025-12-31  2:38 ` [PATCH v2 5/5] arm64: dts: ti: k3-am62l3-evm: " Kendall Willis
2026-01-05 10:33 ` [PATCH v2 0/5] arm64: dts: ti: k3-am62: Support " Markus Schneider-Pargmann
2026-01-05 13:17 ` Dhruva Gole

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260106115725.qqyg6isf5q7cg52g@renewable \
    --to=nm@ti.com \
    --cc=a-kaur@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=d-gole@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=k-willis@ti.com \
    --cc=khilman@baylibre.com \
    --cc=kristo@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=msp@baylibre.com \
    --cc=robh@kernel.org \
    --cc=s-kochidanadu@ti.com \
    --cc=sebin.francis@ti.com \
    --cc=vigneshr@ti.com \
    --cc=vishalm@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox