From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8AC7DCF6BE2 for ; Wed, 7 Jan 2026 03:48:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lVfOOsMtVesahSpJ7NzEZB2a7bFJ+2QiFmRNgCZu9gM=; b=D2L7nwEU/Yo3BZJu4OviHGzIzr Sv+35TSDg3unVY+XAulWh5li+ojAljynyGZUpfDdiU6HVPcJ8vTjvM0aB1oVvBCoZ6+LyUjs3EPpt Y7tEf5fyR7A5gv5Ek0zCAiehgSq2HhpFHW7KA+bZIfM9e56Ux7wjt1RaGOO5r6nxwHWmt8xwZTIGB dAS2X5a+s5IxX8+gDZHCD0hQYFjh+q+l9s/MAwJSVefB+uRS8961vdihPoyOYM/MK2hKwr3z86S/E L7gEK+AOGRPrwD4zRvSoTwoqldDT67f8zQp87599818aRqaG8NhsSNOVEs8AjKu0A1ElvgVufRwBr NNoquXew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vdKXS-0000000E8RR-1d9C; Wed, 07 Jan 2026 03:48:50 +0000 Received: from mail-dy1-x1333.google.com ([2607:f8b0:4864:20::1333]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vdKXP-0000000E8Ql-28Yr for linux-arm-kernel@lists.infradead.org; Wed, 07 Jan 2026 03:48:48 +0000 Received: by mail-dy1-x1333.google.com with SMTP id 5a478bee46e88-2ae61424095so982235eec.1 for ; Tue, 06 Jan 2026 19:48:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767757726; x=1768362526; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lVfOOsMtVesahSpJ7NzEZB2a7bFJ+2QiFmRNgCZu9gM=; b=ZwLzwL7hKjF72Owe+M5yKpO3lYU4Vuw/BoU9nu9UYcaOYi9SWdAvDuEtoyUmPTrCV8 gRka6/wsEmzUgqXpB8d1huq23pa+3gQHGbEahh+L2dxr+zdjDmBdFufTMbYCigP1K+Sy T/SQ/sncr3OTxx/IgSnx2mswj3KJ7JZ31qetMXmZXv4loeH+kawcn7SdyW96/KIJczzy WDPpnd5jBltDeJ+2oZqGvtTmZosLUhYbfMGE4+sWDzU72fYFmfs+benzAUGMrvTW2Cup chLaJAalrpRm5x9EwRJt2oVmZXc6AgD0aLDyxEDr95HU8lYqQ2hZO20OuzceGIlNiloL mRHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767757726; x=1768362526; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=lVfOOsMtVesahSpJ7NzEZB2a7bFJ+2QiFmRNgCZu9gM=; b=UhdeN7dxZtv7tptLFXk3kXKZC5GQ4II1qYu+UGy4rUE5uA99QLjVc8NymmnUqGoScJ 3IUPqm7COwQ3LAq0hMLGK/12FECDHWoaSeL9f4o3/GCwICn1wjmnmG6uk+UOIA8Fnixz 63+TKXRFVDROZmO127nCp2c6efDE3HRmdgUr6T1KjEP3+1EHFLlRiTZe2IFtEzpt7Uir Xotjd9MOYdw7nLqNOgb4d/7xmhL5P+CkHhof9Fp5//GWkAz1EDpaEE5G2BBOpQTt1DDn U3rpShuTRYnl3xdCgoF0Nm7noAPPkzVaHhGvlbW+UG/Wdcbvt6TBEhipAK7hSGJNygyo 12SA== X-Forwarded-Encrypted: i=1; AJvYcCVrmXHvEpqIjMNQ9Dgs13J1zla7n24Y6ZsBamqC1HUK0sPqGLwjnR5KFEShRso9/E5uumEdsYJPAxinHp0RThpO@lists.infradead.org X-Gm-Message-State: AOJu0YxAOCjQIuQ7c+FqhmK5qaT/zMTv/imHPExJpYHGH4VS0FPSmZek WCzwv0hk/rrJf0MpcUaZB4KzBbe08WxGu+uIRVsCCZsXSjn+F5Ai0NKi X-Gm-Gg: AY/fxX5jCOkFGwfa3L2nDIr3F1Xt5SZHln9SNZVKmkjQma+U2ln7N+7CaCKF4FjNvKr 90LLw3QVK8PWWoF4M+ZJ9zNb5spyzOW8hGKQu9Jdzj57n0r4c7CuI56RAmkO3/qvrh2E4jNsImk w+0nHVJ8K88LA+kTU1EpDrdP43NmonnjILpqCncN+btM77S19Az40kj1EK7un+087d6XuSZ/DZk EuM/81GaEzYQAZXX5o0LjdK7kv7s7rJNs3cAJj0fhSZyoZVm2i4+fLzpDHK23O162HCCKtJJJWx JirGneeiYfKoA6FdKdMIiISh4GVZs64kznPdPIsv1e3NoaAeU/sLUEmv8XnCn7UO1M3YwEfEEDK D5quuSsvPRDjPHTTNl33Q1TeDiw1IQ5ehq7r5oH0ZiSFG/bHN/ONfT9SE4aPuxgU= X-Google-Smtp-Source: AGHT+IH/ZbpZvf+ufhdSrgq15FQAA5DMOGdsUeBWMvuc3LZNVn+XAns8eGMqcOV8TZ1Q54ktkq+I7A== X-Received: by 2002:a05:7301:578d:b0:2a4:3593:c7c5 with SMTP id 5a478bee46e88-2b17d1f058bmr978905eec.5.1767757725777; Tue, 06 Jan 2026 19:48:45 -0800 (PST) Received: from gmail.com ([2a09:bac5:1f0d:28::4:33f]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b1707b2256sm5392191eec.25.2026.01.06.19.48.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jan 2026 19:48:45 -0800 (PST) From: Qingfang Deng To: Eric Biggers Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Ard Biesheuvel , "Jason A. Donenfeld" , Herbert Xu , linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org, Holger Dengler , Harald Freudenberger Subject: Re: [PATCH 30/36] crypto: inside-secure - Use new AES library API Date: Wed, 7 Jan 2026 11:48:33 +0800 Message-ID: <20260107034834.1447-1-dqfext@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260105051311.1607207-31-ebiggers@kernel.org> References: <20260105051311.1607207-1-ebiggers@kernel.org> <20260105051311.1607207-31-ebiggers@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260106_194847_559194_1CF0799B X-CRM114-Status: GOOD ( 14.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, 4 Jan 2026 21:13:03 -0800, Eric Biggers wrote: > --- a/drivers/crypto/inside-secure/safexcel_cipher.c > +++ b/drivers/crypto/inside-secure/safexcel_cipher.c > @@ -2505,37 +2505,35 @@ static int safexcel_aead_gcm_setkey(struct crypto_aead *ctfm, const u8 *key, > unsigned int len) > { > struct crypto_tfm *tfm = crypto_aead_tfm(ctfm); > struct safexcel_cipher_ctx *ctx = crypto_tfm_ctx(tfm); > struct safexcel_crypto_priv *priv = ctx->base.priv; > - struct crypto_aes_ctx aes; > + struct aes_enckey aes; > u32 hashkey[AES_BLOCK_SIZE >> 2]; > int ret, i; > > - ret = aes_expandkey(&aes, key, len); > - if (ret) { > - memzero_explicit(&aes, sizeof(aes)); > + ret = aes_prepareenckey(&aes, key, len); > + if (ret) > return ret; > - } > > if (priv->flags & EIP197_TRC_CACHE && ctx->base.ctxr_dma) { > for (i = 0; i < len / sizeof(u32); i++) { > - if (le32_to_cpu(ctx->key[i]) != aes.key_enc[i]) { > + if (ctx->key[i] != get_unaligned((__le32 *)key + i)) { "key" is big-endian. Casting it to __le32 does not seem correct. Did you mean "get_unaligned_le32", which also convert the endianness? > ctx->base.needs_inv = true; > break; > } > } > } > > for (i = 0; i < len / sizeof(u32); i++) > - ctx->key[i] = cpu_to_le32(aes.key_enc[i]); > + ctx->key[i] = get_unaligned((__le32 *)key + i); Same here. > > ctx->key_len = len; > > /* Compute hash key by encrypting zeroes with cipher key */ > memset(hashkey, 0, AES_BLOCK_SIZE); > - aes_encrypt(&aes, (u8 *)hashkey, (u8 *)hashkey); > + aes_encrypt_new(&aes, (u8 *)hashkey, (u8 *)hashkey); > > if (priv->flags & EIP197_TRC_CACHE && ctx->base.ctxr_dma) { > for (i = 0; i < AES_BLOCK_SIZE / sizeof(u32); i++) { > if (be32_to_cpu(ctx->base.ipad.be[i]) != hashkey[i]) { > ctx->base.needs_inv = true;