From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F1287CF6C1F for ; Wed, 7 Jan 2026 09:33:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=NFQOrtK+tg2TysdxGOWC9rmBFC1igKdPXW8mzr4SK/4=; b=dlEsigNf+bVtn59Es1k3IUSc5x pI5/DEnlnX3xwfhiFFkh8Yav+pb1NJLeArNVUJsVeZiuMGh9d9Iox6JD9z9fi2UjayEeuTpal5U1j ZOfM5/o7Jf6ogZ7msFK1iR0ATur2VYnjSk3txZPtFwK04Yx+MyOU065vFiT2VBcFbHW5smZN/UubU FxsJb4GjgkUzYieu2q8T+gBWgMLPc1P+qcjl/O+vcHVjQdPsKW2BTYWdT+SUtho2RMRR2k0JMmenr DJk7SzizDX1rK99dlHmUSuGI5YBNQYebEauBuZp63o22djWOi8dIVvNQu3u2Q6UxFKDomU5vN85JP p56COwzQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vdPui-0000000EXQe-2Ywl; Wed, 07 Jan 2026 09:33:12 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vdPug-0000000EXPD-3vKh for linux-arm-kernel@lists.infradead.org; Wed, 07 Jan 2026 09:33:12 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id A3C6140A9C; Wed, 7 Jan 2026 09:33:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3A78CC4CEF7; Wed, 7 Jan 2026 09:33:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1767778387; bh=TfF9D+qVcE7KhaMOBidzdDMgqFFU7TjF55XdJnpwhf8=; h=From:To:Cc:Subject:Date:From; b=bxstRZ3Il9zbuuPo0RG4B3t8wRaJuvxfx7zTBsu65mtjykufDJkOt5WQ8CBclNpOs F2tiQGKzIiV+E//pB6s3VN1zaZTJcYv5lDCFpdEZqXQpcIs9NNauJag3cNmFQ3ooJD SPfAbuvp01uz6kkguS+su5gKY/P6+Fa/a3bt/WEDpDsNSTzxuTPzyxw58MBF6nCYtf rtaLg2jn1LLVr1PwMY4/gJbTluRCJ+WG2iUn0Zo/O5jPNuwgFFbL0BE7bZlaEHSY+I S/dUzNlLv56NI9vITzLPZ3SBG4rSOmepFrM6i6zZTW0wbneFh6uwnqa6XdboLOGHEQ WtGFdHRK+F9OA== From: Jiri Olsa To: Masami Hiramatsu , Steven Rostedt , Will Deacon Cc: Mahe Tardy , Peter Zijlstra , bpf@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, x86@kernel.org, Yonghong Song , Song Liu , Andrii Nakryiko , Mark Rutland Subject: [PATCH bpf-next 1/2] arm64/ftrace,bpf: Fix partial regs after bpf_prog_run Date: Wed, 7 Jan 2026 10:32:55 +0100 Message-ID: <20260107093256.54616-1-jolsa@kernel.org> X-Mailer: git-send-email 2.52.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260107_013311_017978_FC8CE574 X-CRM114-Status: GOOD ( 16.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Mahe reported issue with bpf_override_return helper not working when executed from kprobe.multi bpf program on arm. The problem is that on arm we use alternate storage for pt_regs object that is passed to bpf_prog_run and if any register is changed (which is the case of bpf_override_return) it's not propagated back to actual pt_regs object. Fixing this by introducing and calling ftrace_partial_regs_update function to propagate the values of changed registers (ip and stack). Fixes: b9b55c8912ce ("tracing: Add ftrace_partial_regs() for converting ftrace_regs to pt_regs") Reported-by: Mahe Tardy Signed-off-by: Jiri Olsa --- v1 changes: - used ftrace_partial_regs_update with comments from Steven arch/arm64/include/asm/ftrace.h | 24 ++++++++++++++++++++++++ include/linux/ftrace.h | 3 +++ kernel/trace/bpf_trace.c | 1 + 3 files changed, 28 insertions(+) diff --git a/arch/arm64/include/asm/ftrace.h b/arch/arm64/include/asm/ftrace.h index 1621c84f44b3..177c7bbf3b84 100644 --- a/arch/arm64/include/asm/ftrace.h +++ b/arch/arm64/include/asm/ftrace.h @@ -157,6 +157,30 @@ ftrace_partial_regs(const struct ftrace_regs *fregs, struct pt_regs *regs) return regs; } +/* + * ftrace_partial_regs_update - update the original ftrace_regs from regs + * @fregs: The ftrace_regs to update from @regs + * @regs: The partial regs from ftrace_partial_regs() that was updated + * + * Some architectures have the partial regs living in the ftrace_regs + * structure, whereas other architectures need to make a different copy + * of the @regs. If a partial @regs is retrieved by ftrace_partial_regs() and + * if the code using @regs updates a field (like the instruction pointer or + * stack pointer) it may need to propagate that change to the original @fregs + * it retrieved the partial @regs from. Use this function to guarantee that + * update happens. + */ +static __always_inline void +ftrace_partial_regs_update(const struct ftrace_regs *fregs, struct pt_regs *regs) +{ + struct __arch_ftrace_regs *afregs = arch_ftrace_regs(fregs); + + if (afregs->pc != regs->pc) { + afregs->pc = regs->pc; + afregs->regs[0] = regs->regs[0]; + } +} + #define arch_ftrace_fill_perf_regs(fregs, _regs) do { \ (_regs)->pc = arch_ftrace_regs(fregs)->pc; \ (_regs)->regs[29] = arch_ftrace_regs(fregs)->fp; \ diff --git a/include/linux/ftrace.h b/include/linux/ftrace.h index 770f0dc993cc..ae22559b4099 100644 --- a/include/linux/ftrace.h +++ b/include/linux/ftrace.h @@ -213,6 +213,9 @@ ftrace_partial_regs(struct ftrace_regs *fregs, struct pt_regs *regs) return regs; } +static __always_inline void +ftrace_partial_regs_update(struct ftrace_regs *fregs, struct pt_regs *regs) { } + #endif /* !CONFIG_HAVE_DYNAMIC_FTRACE_WITH_ARGS || CONFIG_HAVE_FTRACE_REGS_HAVING_PT_REGS */ #ifdef CONFIG_HAVE_DYNAMIC_FTRACE_WITH_ARGS diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c index 6e076485bf70..3a17f79b20c2 100644 --- a/kernel/trace/bpf_trace.c +++ b/kernel/trace/bpf_trace.c @@ -2564,6 +2564,7 @@ kprobe_multi_link_prog_run(struct bpf_kprobe_multi_link *link, old_run_ctx = bpf_set_run_ctx(&run_ctx.session_ctx.run_ctx); err = bpf_prog_run(link->link.prog, regs); bpf_reset_run_ctx(old_run_ctx); + ftrace_partial_regs_update(fregs, bpf_kprobe_multi_pt_regs_ptr()); rcu_read_unlock(); out: -- 2.52.0