From: Kory Maincent <kory.maincent@bootlin.com>
To: Andrew Davis <afd@ti.com>
Cc: Jyri Sarha <jyri.sarha@iki.fi>,
Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Russell King <linux@armlinux.org.uk>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
Tony Lindgren <tony@atomide.com>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
"Robert Foss" <rfoss@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
Markus Schneider-Pargmann <msp@baylibre.com>,
Bajjuri Praneeth <praneeth@ti.com>,
Luca Ceresoli <luca.ceresoli@bootlin.com>,
Louis Chauvet <louis.chauvet@bootlin.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Miguel Gazquez <miguel.gazquez@bootlin.com>,
Herve Codina <herve.codina@bootlin.com>,
<dri-devel@lists.freedesktop.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-omap@vger.kernel.org>
Subject: Re: [PATCH v3 04/22] drm/tilcdc: Add support for DRM bus flags and simplify panel config
Date: Wed, 7 Jan 2026 10:36:55 +0100 [thread overview]
Message-ID: <20260107103655.2d25bcc3@kmaincent-XPS-13-7390> (raw)
In-Reply-To: <f9fb8050-89f9-4449-bc2c-ff284873be79@ti.com>
On Tue, 6 Jan 2026 13:30:40 -0600
Andrew Davis <afd@ti.com> wrote:
> > static int tilcdc_init(const struct drm_driver *ddrv, struct device *dev)
> > {
> > struct drm_device *ddev;
> > struct platform_device *pdev = to_platform_device(dev);
> > struct device_node *node = dev->of_node;
> > + const struct of_device_id *of_id;
> > struct tilcdc_drm_private *priv;
> > u32 bpp = 0;
> > int ret;
> > @@ -209,6 +222,10 @@ static int tilcdc_init(const struct drm_driver *ddrv,
> > struct device *dev) if (IS_ERR(ddev))
> > return PTR_ERR(ddev);
> >
> > + of_id = of_match_node(tilcdc_of_match, node);
>
> You should be able to use `device_get_match_data()` here, then you would
> also be able to keep the tilcdc_of_match table down were it was before.
Indeed. Didn't know this helper.
Thanks you!
--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2026-01-07 9:37 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-06 17:42 [PATCH v3 00/22] Clean and update tilcdc driver to support DRM_BRIDGE_ATTACH_NO_CONNECTOR Kory Maincent (TI.com)
2026-01-06 17:42 ` [PATCH v3 01/22] dt-bindings: display: tilcdc: Convert to DT schema Kory Maincent (TI.com)
2026-01-07 7:53 ` Krzysztof Kozlowski
2026-01-06 17:42 ` [PATCH v3 02/22] dt-bindings: display: tilcdc: Mark panel binding as deprecated Kory Maincent (TI.com)
2026-01-06 17:42 ` [PATCH v3 03/22] drm/tilcdc: Remove simulate_vesa_sync flag Kory Maincent (TI.com)
2026-01-06 17:42 ` [PATCH v3 04/22] drm/tilcdc: Add support for DRM bus flags and simplify panel config Kory Maincent (TI.com)
2026-01-06 19:30 ` Andrew Davis
2026-01-07 9:36 ` Kory Maincent [this message]
2026-01-06 17:42 ` [PATCH v3 05/22] drm/tilcdc: Convert legacy panel binding via DT overlay at boot time Kory Maincent (TI.com)
2026-01-06 19:38 ` Andrew Davis
2026-01-07 9:57 ` Kory Maincent
2026-01-06 17:42 ` [PATCH v3 06/22] drm/tilcdc: Remove tilcdc panel driver Kory Maincent (TI.com)
2026-01-06 17:42 ` [PATCH v3 07/22] drm/tilcdc: Remove component framework support Kory Maincent (TI.com)
2026-01-06 17:42 ` [PATCH v3 08/22] drm/tilcdc: Remove tilcdc_panel_info structure Kory Maincent (TI.com)
2026-01-06 17:42 ` [PATCH v3 09/22] drm/tilcdc: Remove redundant #endif/#ifdef in debugfs code Kory Maincent (TI.com)
2026-01-06 17:42 ` [PATCH v3 10/22] drm/tilcdc: Remove unused encoder and connector tracking arrays Kory Maincent (TI.com)
2026-01-06 17:42 ` [PATCH v3 11/22] drm/tilcdc: Rename external_encoder and external_connector to encoder and connector Kory Maincent (TI.com)
2026-01-06 17:42 ` [PATCH v3 12/22] drm/tilcdc: Rename tilcdc_external to tilcdc_encoder Kory Maincent (TI.com)
2026-01-06 17:42 ` [PATCH v3 13/22] drm/tilcdc: Remove the useless module list support Kory Maincent (TI.com)
2026-01-06 17:42 ` [PATCH v3 14/22] drm/tilcdc: Use drm_module_platform_driver() helper Kory Maincent (TI.com)
2026-01-06 17:42 ` [PATCH v3 15/22] drm/tilcdc: Move tilcdc_init/fini closer to probe/remove Kory Maincent (TI.com)
2026-01-06 17:42 ` [PATCH v3 16/22] drm/tilcdc: Modernize driver initialization and cleanup paths Kory Maincent (TI.com)
2026-01-06 17:42 ` [PATCH v3 17/22] drm/tilcdc: Remove the use of drm_device private_data Kory Maincent (TI.com)
2026-01-06 17:42 ` [PATCH v3 18/22] drm/bridge: tda998x: Remove component support Kory Maincent (TI.com)
2026-01-06 17:42 ` [PATCH v3 19/22] drm/bridge: tda998x: Move tda998x_create/destroy into probe and remove Kory Maincent (TI.com)
2026-01-06 17:42 ` [PATCH v3 20/22] drm/bridge: tda998x: Remove useless tda998x_connector_destroy wrapper Kory Maincent (TI.com)
2026-01-06 17:42 ` [PATCH v3 21/22] drm/bridge: tda998x: Add support for DRM_BRIDGE_ATTACH_NO_CONNECTOR Kory Maincent (TI.com)
2026-01-06 17:42 ` [PATCH v3 22/22] drm/tilcdc: " Kory Maincent (TI.com)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260107103655.2d25bcc3@kmaincent-XPS-13-7390 \
--to=kory.maincent@bootlin.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=afd@ti.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=herve.codina@bootlin.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=jyri.sarha@iki.fi \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=louis.chauvet@bootlin.com \
--cc=luca.ceresoli@bootlin.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=miguel.gazquez@bootlin.com \
--cc=mripard@kernel.org \
--cc=msp@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=praneeth@ti.com \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=thomas.petazzoni@bootlin.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=tony@atomide.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox