From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BB8D0D0D171 for ; Wed, 7 Jan 2026 21:56:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=CWbYS1PWWwziLddhvpqLVmHnAcvw25qM8FhFwh1XOz8=; b=lMoXCEyFoYipxIeaTHNZ/WzMYc OTfhi6j3uO8EbpcRHfrqtlBDyIGZgYxZB3c9HB4znhjARSG2fAhc6t/yf1guPlZmDnonHZqNrVFgX cLjBWDrg3EhKZ/j3ItE92malNEsgrE9H6huGDXNmz6B4MlbrVgHPlT0LNCFjCgP1yJJQuCdOC2byh K3dcMt9DEsVfScr/tED5/j9zWfF3CHJoLpGnlg2C2EE1KhaUXclU3FKZmGlmUTCrZZpTDeh/uZSe9 z2seRrqbgp94gIpih1acfiV1Ua7rNyiMyo1YaHyKyS9F9HDh1BUNjzW9AuD/Hja7qWcqlbNHF95jf KchCJaZw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vdbVs-0000000FgPy-3WEH; Wed, 07 Jan 2026 21:56:20 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vdbVn-0000000FgPJ-3vZ0 for linux-arm-kernel@lists.infradead.org; Wed, 07 Jan 2026 21:56:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767822973; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=CWbYS1PWWwziLddhvpqLVmHnAcvw25qM8FhFwh1XOz8=; b=b8d9bpf39MmmctW/Evz386oDsv15UZ9Lg7kYsmaELu4kOGcRGzLHdpMh0BzDqD7cDJB7XJ QT9J0eU4xpt2cpbY5BCBZcogxO2uBaZugX7aznOcM9eQUmx7wyhDbYOMIYcMUxcH/sV4KT AxHN/fWEMfZg4/BvwxknJF+BC62CgwQ= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-319-ONoBIn6kOfaA6fo4rpJTXA-1; Wed, 07 Jan 2026 16:54:34 -0500 X-MC-Unique: ONoBIn6kOfaA6fo4rpJTXA-1 X-Mimecast-MFC-AGG-ID: ONoBIn6kOfaA6fo4rpJTXA_1767822873 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C2B3C1800447; Wed, 7 Jan 2026 21:54:32 +0000 (UTC) Received: from llong-thinkpadp16vgen1.westford.csb (unknown [10.22.81.77]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4A62618007D2; Wed, 7 Jan 2026 21:54:30 +0000 (UTC) From: Waiman Long To: Marc Zyngier , Thomas Gleixner , Sebastian Andrzej Siewior , Clark Williams , Steven Rostedt Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev, Waiman Long Subject: [PATCH] irqchip/gic-v3-its: Don't acquire rt_spin_lock in allocate_vpe_l1_table() Date: Wed, 7 Jan 2026 16:53:53 -0500 Message-ID: <20260107215353.75612-1-longman@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260107_135616_134207_1866C660 X-CRM114-Status: GOOD ( 19.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org When running a PREEMPT_RT debug kernel on a 2-socket Grace arm64 system, the following bug report was produced at bootup time. BUG: sleeping function called from invalid context at kernel/locking/spinlock_rt.c:48 in_atomic(): 1, irqs_disabled(): 1, non_block: 0, pid: 0, name: swapper/72 preempt_count: 1, expected: 0 RCU nest depth: 1, expected: 1 : CPU: 72 UID: 0 PID: 0 Comm: swapper/72 Tainted: G W 6.19.0-rc4-test+ #4 PREEMPT_{RT,(full)} Tainted: [W]=WARN Call trace: : rt_spin_lock+0xe4/0x408 rmqueue_bulk+0x48/0x1de8 __rmqueue_pcplist+0x410/0x650 rmqueue.constprop.0+0x6a8/0x2b50 get_page_from_freelist+0x3c0/0xe68 __alloc_frozen_pages_noprof+0x1dc/0x348 alloc_pages_mpol+0xe4/0x2f8 alloc_frozen_pages_noprof+0x124/0x190 allocate_slab+0x2f0/0x438 new_slab+0x4c/0x80 ___slab_alloc+0x410/0x798 __slab_alloc.constprop.0+0x88/0x1e0 __kmalloc_cache_noprof+0x2dc/0x4b0 allocate_vpe_l1_table+0x114/0x788 its_cpu_init_lpis+0x344/0x790 its_cpu_init+0x60/0x220 gic_starting_cpu+0x64/0xe8 cpuhp_invoke_callback+0x438/0x6d8 __cpuhp_invoke_callback_range+0xd8/0x1f8 notify_cpu_starting+0x11c/0x178 secondary_start_kernel+0xc8/0x188 __secondary_switched+0xc0/0xc8 This is due to the fact that allocate_vpe_l1_table() will call kzalloc() to allocate a cpumask_t when the first CPU of the second node of the 72-cpu Grace system is being called from the CPUHP_AP_MIPS_GIC_TIMER_STARTING state inside the starting section of the CPU hotplug bringup pipeline where interrupt is disabled. This is an atomic context where sleeping is not allowed and acquiring a sleeping rt_spin_lock within kzalloc() may lead to system hang in case there is a lock contention. To work around this issue, a static buffer is used for cpumask allocation when running a PREEMPT_RT kernel via the newly introduced vpe_alloc_cpumask() helper. The static buffer is currently set to be 4 kbytes in size. As only one cpumask is needed per node, the current size should be big enough as long as (cpumask_size() * nr_node_ids) is not bigger than 4k. Signed-off-by: Waiman Long --- drivers/irqchip/irq-gic-v3-its.c | 26 +++++++++++++++++++++++++- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c index ada585bfa451..9185785524dc 100644 --- a/drivers/irqchip/irq-gic-v3-its.c +++ b/drivers/irqchip/irq-gic-v3-its.c @@ -2896,6 +2896,30 @@ static bool allocate_vpe_l2_table(int cpu, u32 id) return true; } +static void *vpe_alloc_cpumask(void) +{ + /* + * With PREEMPT_RT kernel, we can't call any k*alloc() APIs as they + * may acquire a sleeping rt_spin_lock in an atomic context. So use + * a pre-allocated buffer instead. + */ + if (IS_ENABLED(CONFIG_PREEMPT_RT)) { + static unsigned long mask_buf[512]; + static atomic_t alloc_idx; + int idx, mask_size = cpumask_size(); + int nr_cpumasks = sizeof(mask_buf)/mask_size; + + /* + * Fetch an allocation index and if it points to a buffer within + * mask_buf[], return that. Fall back to kzalloc() otherwise. + */ + idx = atomic_fetch_inc(&alloc_idx); + if (idx < nr_cpumasks) + return &mask_buf[idx * mask_size/sizeof(long)]; + } + return kzalloc(sizeof(cpumask_t), GFP_ATOMIC); +} + static int allocate_vpe_l1_table(void) { void __iomem *vlpi_base = gic_data_rdist_vlpi_base(); @@ -2927,7 +2951,7 @@ static int allocate_vpe_l1_table(void) if (val & GICR_VPROPBASER_4_1_VALID) goto out; - gic_data_rdist()->vpe_table_mask = kzalloc(sizeof(cpumask_t), GFP_ATOMIC); + gic_data_rdist()->vpe_table_mask = vpe_alloc_cpumask(); if (!gic_data_rdist()->vpe_table_mask) return -ENOMEM; -- 2.52.0