public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: rockchip: Drop unsupported properties
@ 2026-01-08 23:06 Rob Herring (Arm)
  2026-01-09 19:51 ` Heiko Stuebner
  0 siblings, 1 reply; 2+ messages in thread
From: Rob Herring (Arm) @ 2026-01-08 23:06 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner
  Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel

"pinctrl-names" is not valid without a pinctrl-N property.

"max-freq" is not a defined property name. Maybe it was supposed to be
"spi-max-frequency", but changing to that would be a change in behavior.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts | 1 -
 arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts   | 1 -
 2 files changed, 2 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
index 78a7775c3b22..b2de018a7d36 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
@@ -425,7 +425,6 @@ &pcie_phy {
 &pcie0 {
 	ep-gpios = <&gpio2 RK_PD4 GPIO_ACTIVE_HIGH>;
 	num-lanes = <2>;
-	pinctrl-names = "default";
 	status = "okay";
 
 	vpcie12v-supply = <&vcc12v_dcin>;
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
index eaaca08a7601..810ab6ff4e67 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
@@ -969,7 +969,6 @@ &sdhci {
 };
 
 &spi1 {
-	max-freq = <10000000>;
 	status = "okay";
 
 	spiflash: flash@0 {
-- 
2.51.0



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] arm64: dts: rockchip: Drop unsupported properties
  2026-01-08 23:06 [PATCH] arm64: dts: rockchip: Drop unsupported properties Rob Herring (Arm)
@ 2026-01-09 19:51 ` Heiko Stuebner
  0 siblings, 0 replies; 2+ messages in thread
From: Heiko Stuebner @ 2026-01-09 19:51 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Conor Dooley, Rob Herring (Arm)
  Cc: Heiko Stuebner, devicetree, linux-arm-kernel, linux-rockchip,
	linux-kernel


On Thu, 08 Jan 2026 17:06:07 -0600, Rob Herring (Arm) wrote:
> "pinctrl-names" is not valid without a pinctrl-N property.
> 
> "max-freq" is not a defined property name. Maybe it was supposed to be
> "spi-max-frequency", but changing to that would be a change in behavior.
> 
> 

Applied, thanks!

[1/1] arm64: dts: rockchip: Drop unsupported properties
      commit: 56e7cc8dadf91cd2164e5d6dac9258f448d50182

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-01-09 19:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-08 23:06 [PATCH] arm64: dts: rockchip: Drop unsupported properties Rob Herring (Arm)
2026-01-09 19:51 ` Heiko Stuebner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox