* Re: [PATCH 6.1.y RESEND v2] KVM: arm64: sys_regs: disable -Wuninitialized-const-pointer warning
2025-12-05 22:51 [PATCH 6.1.y RESEND v2] KVM: arm64: sys_regs: disable -Wuninitialized-const-pointer warning Justin Stitt
@ 2025-12-30 2:22 ` Tiffany Yang
2026-01-08 13:36 ` Patch "KVM: arm64: sys_regs: disable -Wuninitialized-const-pointer warning" has been added to the 6.1-stable tree gregkh
1 sibling, 0 replies; 3+ messages in thread
From: Tiffany Yang @ 2025-12-30 2:22 UTC (permalink / raw)
To: Justin Stitt
Cc: Marc Zyngier, Oliver Upton, Alexandru Elisei, Joey Gouly,
Suzuki K Poulose, Catalin Marinas, Zenghui Yu, Will Deacon,
Nathan Chancellor, Christopher Covington, linux-arm-kernel,
kvmarm, linux-kernel, llvm, stable
Justin Stitt <justinstitt@google.com> writes:
> A new warning in Clang 22 [1] complains that @clidr passed to
> get_clidr_el1() is an uninitialized const pointer. get_clidr_el1()
> doesn't really care since it casts away the const-ness anyways -- it is
> a false positive.
<snip>
Reviewed-by: Tiffany Yang <ynaffit@google.com>
--
Tiffany Y. Yang
^ permalink raw reply [flat|nested] 3+ messages in thread
* Patch "KVM: arm64: sys_regs: disable -Wuninitialized-const-pointer warning" has been added to the 6.1-stable tree
2025-12-05 22:51 [PATCH 6.1.y RESEND v2] KVM: arm64: sys_regs: disable -Wuninitialized-const-pointer warning Justin Stitt
2025-12-30 2:22 ` Tiffany Yang
@ 2026-01-08 13:36 ` gregkh
1 sibling, 0 replies; 3+ messages in thread
From: gregkh @ 2026-01-08 13:36 UTC (permalink / raw)
To: alexandru.elisei, catalin.marinas, cov, gregkh, joey.gouly,
justinstitt, kvmarm, linux-arm-kernel, llvm, maz, nathan,
oliver.upton, suzuki.poulose, will, ynaffit, yuzenghui
Cc: stable-commits
This is a note to let you know that I've just added the patch titled
KVM: arm64: sys_regs: disable -Wuninitialized-const-pointer warning
to the 6.1-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
kvm-arm64-sys_regs-disable-wuninitialized-const-pointer-warning.patch
and it can be found in the queue-6.1 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.
From justinstitt@google.com Thu Jan 8 14:27:57 2026
From: Justin Stitt <justinstitt@google.com>
Date: Fri, 05 Dec 2025 14:51:41 -0800
Subject: KVM: arm64: sys_regs: disable -Wuninitialized-const-pointer warning
To: Marc Zyngier <maz@kernel.org>, Oliver Upton <oliver.upton@linux.dev>, Alexandru Elisei <alexandru.elisei@arm.com>, Joey Gouly <joey.gouly@arm.com>, Suzuki K Poulose <suzuki.poulose@arm.com>, Catalin Marinas <catalin.marinas@arm.com>, Zenghui Yu <yuzenghui@huawei.com>, Will Deacon <will@kernel.org>, Nathan Chancellor <nathan@kernel.org>, Christopher Covington <cov@codeaurora.org>
Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, stable@vger.kernel.org, Justin Stitt <justinstitt@google.com>
Message-ID: <20251205-stable-disable-unit-ptr-warn-v2-1-cec53a8f736b@google.com>
From: Justin Stitt <justinstitt@google.com>
A new warning in Clang 22 [1] complains that @clidr passed to
get_clidr_el1() is an uninitialized const pointer. get_clidr_el1()
doesn't really care since it casts away the const-ness anyways -- it is
a false positive.
This patch isn't needed for anything past 6.1 as this code section was
reworked in Commit 7af0c2534f4c ("KVM: arm64: Normalize cache
configuration") which incidentally removed the aforementioned warning.
Since there is no upstream equivalent, this patch just needs to be
applied to 6.1.
Disable this warning for sys_regs.o instead of backporting the patches
from 6.2+ that modified this code area.
Cc: stable@vger.kernel.org
Fixes: 7c8c5e6a9101e ("arm64: KVM: system register handling")
Link: https://github.com/llvm/llvm-project/commit/00dacf8c22f065cb52efb14cd091d441f19b319e [1]
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Justin Stitt <justinstitt@google.com>
Reviewed-by: Tiffany Yang <ynaffit@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
arch/arm64/kvm/Makefile | 3 +++
1 file changed, 3 insertions(+)
--- a/arch/arm64/kvm/Makefile
+++ b/arch/arm64/kvm/Makefile
@@ -24,6 +24,9 @@ kvm-y += arm.o mmu.o mmio.o psci.o hyper
kvm-$(CONFIG_HW_PERF_EVENTS) += pmu-emul.o pmu.o
+# Work around a false positive Clang 22 -Wuninitialized-const-pointer warning
+CFLAGS_sys_regs.o := $(call cc-disable-warning, uninitialized-const-pointer)
+
always-y := hyp_constants.h hyp-constants.s
define rule_gen_hyp_constants
Patches currently in stable-queue which might be from justinstitt@google.com are
queue-6.1/kvm-arm64-sys_regs-disable-wuninitialized-const-pointer-warning.patch
^ permalink raw reply [flat|nested] 3+ messages in thread