From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andi Shyti <andi@smida.it>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Qianfeng Rong <rongqianfeng@vivo.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linux-rockchip@lists.infradead.org
Cc: Khalil Blaiech <kblaiech@nvidia.com>,
Asmaa Mnebhi <asmaa@nvidia.com>,
Andi Shyti <andi.shyti@kernel.org>,
Qii Wang <qii.wang@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Linus Walleij <linusw@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Patrice Chotard <patrice.chotard@foss.st.com>,
Ard Biesheuvel <ardb@kernel.org>
Subject: [PATCH v1 4/7] i2c: nomadik: Use HZ_PER_GHZ constant instead of plain number
Date: Mon, 12 Jan 2026 14:46:12 +0100 [thread overview]
Message-ID: <20260112134900.4142954-5-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20260112134900.4142954-1-andriy.shevchenko@linux.intel.com>
Use defined constant to avoid the possible mistakes and to provide
an additional information on the units.
While at it, drop unneeded 64-bit division, all operands fit 32-bit.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/i2c/busses/i2c-nomadik.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-nomadik.c b/drivers/i2c/busses/i2c-nomadik.c
index 19b648fc094d..b63ee51c1652 100644
--- a/drivers/i2c/busses/i2c-nomadik.c
+++ b/drivers/i2c/busses/i2c-nomadik.c
@@ -31,6 +31,7 @@
#include <linux/pm_runtime.h>
#include <linux/regmap.h>
#include <linux/slab.h>
+#include <linux/units.h>
#define DRIVER_NAME "nmk-i2c"
@@ -419,10 +420,10 @@ static void setup_i2c_controller(struct nmk_i2c_dev *priv)
* modes are 250ns, 100ns, 10ns respectively.
*
* As the time for one cycle T in nanoseconds is
- * T = (1/f) * 1000000000 =>
- * slsu = cycles / (1000000000 / f) + 1
+ * T = (1/f) * HZ_PER_GHZ =>
+ * slsu = cycles / (HZ_PER_GHZ / f) + 1
*/
- ns = DIV_ROUND_UP_ULL(1000000000ULL, i2c_clk);
+ ns = DIV_ROUND_UP(HZ_PER_GHZ, i2c_clk);
switch (priv->sm) {
case I2C_FREQ_MODE_FAST:
case I2C_FREQ_MODE_FAST_PLUS:
--
2.50.1
next prev parent reply other threads:[~2026-01-12 13:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-12 13:46 [PATCH v1 0/7] i2c: busses: Introduce and use HZ_PER_GHZ Andy Shevchenko
2026-01-12 13:46 ` [PATCH v1 1/7] units: Add HZ_PER_GHZ Andy Shevchenko
2026-01-12 15:48 ` Linus Walleij
2026-01-13 14:23 ` Andi Shyti
2026-01-12 13:46 ` [PATCH v1 2/7] i2c: mlxbf: Use HZ_PER_GHZ constant instead of custom one Andy Shevchenko
2026-01-12 13:46 ` [PATCH v1 3/7] i2c: mt65xx: Use HZ_PER_GHZ constant instead of plain number Andy Shevchenko
2026-01-12 13:46 ` Andy Shevchenko [this message]
2026-01-12 15:52 ` [PATCH v1 4/7] i2c: nomadik: " Linus Walleij
2026-01-12 13:46 ` [PATCH v1 5/7] i2c: rk3x: " Andy Shevchenko
2026-01-13 15:10 ` Heiko Stübner
2026-01-12 13:46 ` [PATCH v1 6/7] i2c: st: " Andy Shevchenko
2026-01-13 15:29 ` Patrice CHOTARD
2026-01-12 13:46 ` [PATCH v1 7/7] i2c: synquacer: " Andy Shevchenko
2026-01-12 16:15 ` [PATCH v1 0/7] i2c: busses: Introduce and use HZ_PER_GHZ AngeloGioacchino Del Regno
2026-01-13 15:28 ` Wolfram Sang
2026-01-14 7:36 ` Andi Shyti
2026-01-14 8:23 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260112134900.4142954-5-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andi.shyti@kernel.org \
--cc=andi@smida.it \
--cc=angelogioacchino.delregno@collabora.com \
--cc=ardb@kernel.org \
--cc=asmaa@nvidia.com \
--cc=heiko@sntech.de \
--cc=kblaiech@nvidia.com \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=patrice.chotard@foss.st.com \
--cc=qii.wang@mediatek.com \
--cc=rongqianfeng@vivo.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox