public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH 1/3] dt-bindings: arm: mediatek: mmsys: Allow single vdo/mmsys endpoint
@ 2026-01-08 14:39 AngeloGioacchino Del Regno
  2026-01-08 14:39 ` [PATCH 2/3] arm64: dts: mediatek: mt8195-cherry: Fix warnings for vdosys0 endpoint AngeloGioacchino Del Regno
                   ` (3 more replies)
  0 siblings, 4 replies; 8+ messages in thread
From: AngeloGioacchino Del Regno @ 2026-01-08 14:39 UTC (permalink / raw)
  To: robh
  Cc: krzk+dt, conor+dt, matthias.bgg, angelogioacchino.delregno,
	devicetree, linux-kernel, linux-arm-kernel, linux-mediatek,
	kernel

The hardware supports using just a single output while leaving all
of the others unconfigured (disabled), but the binding did not
really allow specifying a single endpoint@0, because in this case
one must either:
 - Call the subnode `endpoint` and not declare any address and/or
   size cells; or
 - Call the subnode `endpoint@0` and have at least one more other
   endpoint(@1 or @2), and declare address/size cells.

Allow specifying a single `endpoint` subnode, without the `@0`
implicit suffix to suppress warnings happening on this kind of
valid usecase.

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
 .../bindings/arm/mediatek/mediatek,mmsys.yaml        | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml
index 3f4262e93c78..e3ef7540c24f 100644
--- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml
@@ -100,11 +100,12 @@ properties:
       the first component of one display pipeline, for example one of
       the available OVL or RDMA blocks.
       Some MediaTek SoCs support multiple display outputs per MMSYS.
-    properties:
-      endpoint@0:
+    patternProperties:
+      "^endpoint(@0)?$":
         $ref: /schemas/graph.yaml#/properties/endpoint
         description: Output to the primary display pipeline
 
+    properties:
       endpoint@1:
         $ref: /schemas/graph.yaml#/properties/endpoint
         description: Output to the secondary display pipeline
@@ -114,8 +115,11 @@ properties:
         description: Output to the tertiary display pipeline
 
     anyOf:
-      - required:
-          - endpoint@0
+      - oneOf:
+          - required:
+              - endpoint
+          - required:
+              - endpoint@0
       - required:
           - endpoint@1
       - required:
-- 
2.52.0



^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH 2/3] arm64: dts: mediatek: mt8195-cherry: Fix warnings for vdosys0 endpoint
  2026-01-08 14:39 [PATCH 1/3] dt-bindings: arm: mediatek: mmsys: Allow single vdo/mmsys endpoint AngeloGioacchino Del Regno
@ 2026-01-08 14:39 ` AngeloGioacchino Del Regno
  2026-01-12  8:18   ` Chen-Yu Tsai
  2026-01-08 14:39 ` [PATCH 3/3] arm64: dts: mediatek: mt8188-geralt: " AngeloGioacchino Del Regno
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 8+ messages in thread
From: AngeloGioacchino Del Regno @ 2026-01-08 14:39 UTC (permalink / raw)
  To: robh
  Cc: krzk+dt, conor+dt, matthias.bgg, angelogioacchino.delregno,
	devicetree, linux-kernel, linux-arm-kernel, linux-mediatek,
	kernel

This machine needs only one endpoint (@0) for vdosys0: remove the
address and size cells declaration and rename the endpoint@0 node
to `endpoint`.

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
 arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
index b3761b80cac7..d5b632489b1f 100644
--- a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
@@ -1512,11 +1512,7 @@ &uart0 {
 
 &vdosys0 {
 	port {
-		#address-cells = <1>;
-		#size-cells = <0>;
-
-		vdosys0_ep_main: endpoint@0 {
-			reg = <0>;
+		vdosys0_ep_main: endpoint {
 			remote-endpoint = <&ovl0_in>;
 		};
 	};
-- 
2.52.0



^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH 3/3] arm64: dts: mediatek: mt8188-geralt: Fix warnings for vdosys0 endpoint
  2026-01-08 14:39 [PATCH 1/3] dt-bindings: arm: mediatek: mmsys: Allow single vdo/mmsys endpoint AngeloGioacchino Del Regno
  2026-01-08 14:39 ` [PATCH 2/3] arm64: dts: mediatek: mt8195-cherry: Fix warnings for vdosys0 endpoint AngeloGioacchino Del Regno
@ 2026-01-08 14:39 ` AngeloGioacchino Del Regno
  2026-01-12  8:18   ` Chen-Yu Tsai
  2026-01-12  7:49 ` [PATCH 1/3] dt-bindings: arm: mediatek: mmsys: Allow single vdo/mmsys endpoint Chen-Yu Tsai
  2026-01-13 22:53 ` Rob Herring
  3 siblings, 1 reply; 8+ messages in thread
From: AngeloGioacchino Del Regno @ 2026-01-08 14:39 UTC (permalink / raw)
  To: robh
  Cc: krzk+dt, conor+dt, matthias.bgg, angelogioacchino.delregno,
	devicetree, linux-kernel, linux-arm-kernel, linux-mediatek,
	kernel

This machine needs only one endpoint (@0) for vdosys0: remove the
address and size cells declaration and rename the endpoint@0 node
to `endpoint`.

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
 arch/arm64/boot/dts/mediatek/mt8188-geralt.dtsi | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt8188-geralt.dtsi b/arch/arm64/boot/dts/mediatek/mt8188-geralt.dtsi
index 7fedbacdac44..64a4e798a05f 100644
--- a/arch/arm64/boot/dts/mediatek/mt8188-geralt.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8188-geralt.dtsi
@@ -1279,11 +1279,7 @@ &ssusb2 {
 
 &vdosys0 {
 	port {
-		#address-cells = <1>;
-		#size-cells = <0>;
-
-		vdosys0_ep_main: endpoint@0 {
-			reg = <0>;
+		vdosys0_ep_main: endpoint {
 			remote-endpoint = <&ovl0_in>;
 		};
 	};
-- 
2.52.0



^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/3] dt-bindings: arm: mediatek: mmsys: Allow single vdo/mmsys endpoint
  2026-01-08 14:39 [PATCH 1/3] dt-bindings: arm: mediatek: mmsys: Allow single vdo/mmsys endpoint AngeloGioacchino Del Regno
  2026-01-08 14:39 ` [PATCH 2/3] arm64: dts: mediatek: mt8195-cherry: Fix warnings for vdosys0 endpoint AngeloGioacchino Del Regno
  2026-01-08 14:39 ` [PATCH 3/3] arm64: dts: mediatek: mt8188-geralt: " AngeloGioacchino Del Regno
@ 2026-01-12  7:49 ` Chen-Yu Tsai
  2026-01-13 22:53 ` Rob Herring
  3 siblings, 0 replies; 8+ messages in thread
From: Chen-Yu Tsai @ 2026-01-12  7:49 UTC (permalink / raw)
  To: AngeloGioacchino Del Regno
  Cc: robh, krzk+dt, conor+dt, matthias.bgg, devicetree, linux-kernel,
	linux-arm-kernel, linux-mediatek, kernel

On Thu, Jan 8, 2026 at 10:39 PM AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com> wrote:
>
> The hardware supports using just a single output while leaving all
> of the others unconfigured (disabled), but the binding did not
> really allow specifying a single endpoint@0, because in this case
> one must either:
>  - Call the subnode `endpoint` and not declare any address and/or
>    size cells; or
>  - Call the subnode `endpoint@0` and have at least one more other
>    endpoint(@1 or @2), and declare address/size cells.
>
> Allow specifying a single `endpoint` subnode, without the `@0`
> implicit suffix to suppress warnings happening on this kind of
> valid usecase.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>

Looks correct to me.


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 2/3] arm64: dts: mediatek: mt8195-cherry: Fix warnings for vdosys0 endpoint
  2026-01-08 14:39 ` [PATCH 2/3] arm64: dts: mediatek: mt8195-cherry: Fix warnings for vdosys0 endpoint AngeloGioacchino Del Regno
@ 2026-01-12  8:18   ` Chen-Yu Tsai
  0 siblings, 0 replies; 8+ messages in thread
From: Chen-Yu Tsai @ 2026-01-12  8:18 UTC (permalink / raw)
  To: AngeloGioacchino Del Regno
  Cc: robh, krzk+dt, conor+dt, matthias.bgg, devicetree, linux-kernel,
	linux-arm-kernel, linux-mediatek, kernel

On Thu, Jan 8, 2026 at 10:39 PM AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com> wrote:
>
> This machine needs only one endpoint (@0) for vdosys0: remove the
> address and size cells declaration and rename the endpoint@0 node
> to `endpoint`.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 3/3] arm64: dts: mediatek: mt8188-geralt: Fix warnings for vdosys0 endpoint
  2026-01-08 14:39 ` [PATCH 3/3] arm64: dts: mediatek: mt8188-geralt: " AngeloGioacchino Del Regno
@ 2026-01-12  8:18   ` Chen-Yu Tsai
  0 siblings, 0 replies; 8+ messages in thread
From: Chen-Yu Tsai @ 2026-01-12  8:18 UTC (permalink / raw)
  To: AngeloGioacchino Del Regno
  Cc: robh, krzk+dt, conor+dt, matthias.bgg, devicetree, linux-kernel,
	linux-arm-kernel, linux-mediatek, kernel

On Thu, Jan 8, 2026 at 10:40 PM AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com> wrote:
>
> This machine needs only one endpoint (@0) for vdosys0: remove the
> address and size cells declaration and rename the endpoint@0 node
> to `endpoint`.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/3] dt-bindings: arm: mediatek: mmsys: Allow single vdo/mmsys endpoint
  2026-01-08 14:39 [PATCH 1/3] dt-bindings: arm: mediatek: mmsys: Allow single vdo/mmsys endpoint AngeloGioacchino Del Regno
                   ` (2 preceding siblings ...)
  2026-01-12  7:49 ` [PATCH 1/3] dt-bindings: arm: mediatek: mmsys: Allow single vdo/mmsys endpoint Chen-Yu Tsai
@ 2026-01-13 22:53 ` Rob Herring
  2026-01-14  8:27   ` AngeloGioacchino Del Regno
  3 siblings, 1 reply; 8+ messages in thread
From: Rob Herring @ 2026-01-13 22:53 UTC (permalink / raw)
  To: AngeloGioacchino Del Regno
  Cc: krzk+dt, conor+dt, matthias.bgg, devicetree, linux-kernel,
	linux-arm-kernel, linux-mediatek, kernel

On Thu, Jan 08, 2026 at 03:39:32PM +0100, AngeloGioacchino Del Regno wrote:
> The hardware supports using just a single output while leaving all
> of the others unconfigured (disabled), but the binding did not
> really allow specifying a single endpoint@0, because in this case
> one must either:
>  - Call the subnode `endpoint` and not declare any address and/or
>    size cells; or
>  - Call the subnode `endpoint@0` and have at least one more other
>    endpoint(@1 or @2), and declare address/size cells.
> 
> Allow specifying a single `endpoint` subnode, without the `@0`
> implicit suffix to suppress warnings happening on this kind of
> valid usecase.

This series isn't needed. We've dropped this check from dtc. I'll do a 
sync with upstream.

In any case, it's also a W=1 warning which wouldn't be my top priority.

Rob


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/3] dt-bindings: arm: mediatek: mmsys: Allow single vdo/mmsys endpoint
  2026-01-13 22:53 ` Rob Herring
@ 2026-01-14  8:27   ` AngeloGioacchino Del Regno
  0 siblings, 0 replies; 8+ messages in thread
From: AngeloGioacchino Del Regno @ 2026-01-14  8:27 UTC (permalink / raw)
  To: Rob Herring
  Cc: krzk+dt, conor+dt, matthias.bgg, devicetree, linux-kernel,
	linux-arm-kernel, linux-mediatek, kernel

Il 13/01/26 23:53, Rob Herring ha scritto:
> On Thu, Jan 08, 2026 at 03:39:32PM +0100, AngeloGioacchino Del Regno wrote:
>> The hardware supports using just a single output while leaving all
>> of the others unconfigured (disabled), but the binding did not
>> really allow specifying a single endpoint@0, because in this case
>> one must either:
>>   - Call the subnode `endpoint` and not declare any address and/or
>>     size cells; or
>>   - Call the subnode `endpoint@0` and have at least one more other
>>     endpoint(@1 or @2), and declare address/size cells.
>>
>> Allow specifying a single `endpoint` subnode, without the `@0`
>> implicit suffix to suppress warnings happening on this kind of
>> valid usecase.
> 
> This series isn't needed. We've dropped this check from dtc. I'll do a
> sync with upstream.
> 
> In any case, it's also a W=1 warning which wouldn't be my top priority.
> 
> Rob

Oh, okay! Thanks for the feedback :D

Cheers,
Angelo


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2026-01-14  8:27 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-08 14:39 [PATCH 1/3] dt-bindings: arm: mediatek: mmsys: Allow single vdo/mmsys endpoint AngeloGioacchino Del Regno
2026-01-08 14:39 ` [PATCH 2/3] arm64: dts: mediatek: mt8195-cherry: Fix warnings for vdosys0 endpoint AngeloGioacchino Del Regno
2026-01-12  8:18   ` Chen-Yu Tsai
2026-01-08 14:39 ` [PATCH 3/3] arm64: dts: mediatek: mt8188-geralt: " AngeloGioacchino Del Regno
2026-01-12  8:18   ` Chen-Yu Tsai
2026-01-12  7:49 ` [PATCH 1/3] dt-bindings: arm: mediatek: mmsys: Allow single vdo/mmsys endpoint Chen-Yu Tsai
2026-01-13 22:53 ` Rob Herring
2026-01-14  8:27   ` AngeloGioacchino Del Regno

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox