From: Rob Herring <robh@kernel.org>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: Andy Yan <andyshrk@163.com>,
heiko@sntech.de, dmitry.baryshkov@oss.qualcomm.com,
krzk+dt@kernel.org, conor+dt@kernel.org,
cristian.ciocaltea@collabora.com,
Laurent.pinchart@ideasonboard.com, mripard@kernel.org,
hjc@rock-chips.com, tzimmermann@suse.de,
devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
Andy Yan <andy.yan@rock-chips.com>
Subject: Re: [PATCH 1/5] dt-bindings: display: rockchip: Add rk3576 DisplayPort
Date: Thu, 15 Jan 2026 11:18:05 -0600 [thread overview]
Message-ID: <20260115171805.GA907039-robh@kernel.org> (raw)
In-Reply-To: <aWa5i52PTNQ_QTQ7@venus>
On Tue, Jan 13, 2026 at 10:33:52PM +0100, Sebastian Reichel wrote:
> Hi,
>
> On Fri, Jan 09, 2026 at 04:00:44PM +0800, Andy Yan wrote:
> > From: Andy Yan <andy.yan@rock-chips.com>
> >
> > The DisplayPort found on RK3576 is very similar to that of RK3588,
> > but work in dual pixel mode. And itself does not depend on the I2S
> > clock or the SPDIF clock when transmit audio.
> >
> > Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
> >
> > ---
> >
> > .../display/rockchip/rockchip,dw-dp.yaml | 29 +++++++++++++++++--
> > 1 file changed, 26 insertions(+), 3 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-dp.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-dp.yaml
> > index 6345f0132d43..1bfe1bd6404a 100644
> > --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-dp.yaml
> > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-dp.yaml
> > @@ -27,13 +27,11 @@ description: |
> > * Pixel clock up to 594MHz
> > * I2S, SPDIF audio interface
> >
> > -allOf:
> > - - $ref: /schemas/sound/dai-common.yaml#
> > -
> > properties:
> > compatible:
> > enum:
> > - rockchip,rk3588-dp
> > + - rockchip,rk3576-dp
> >
> > reg:
> > maxItems: 1
> > @@ -42,6 +40,7 @@ properties:
> > maxItems: 1
> >
> > clocks:
> > + minItems: 3
> > items:
> > - description: Peripheral/APB bus clock
> > - description: DisplayPort AUX clock
> > @@ -50,6 +49,7 @@ properties:
> > - description: SPDIF interfce clock
> >
> > clock-names:
> > + minItems: 3
> > items:
> > - const: apb
> > - const: aux
> > @@ -95,6 +95,29 @@ required:
> > - ports
> > - resets
> >
> > +allOf:
> > + - $ref: /schemas/sound/dai-common.yaml#
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + enum:
> > + - rockchip,rk3588-dp
> > + then:
> > + properties:
> > + clocks:
> > + minItems: 5
> > + maxItems: 5
> > + clock-names:
> > + minItems: 5
> > + maxItems: 5
>
> I think maxItems is not needed, since 6 items would not work for the
> specified items list anyways. Otherwise:
Correct.
Rob
next prev parent reply other threads:[~2026-01-15 17:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-09 8:00 [PATCH 0/5] Add DisplayPort support for rk3576 Andy Yan
2026-01-09 8:00 ` [PATCH 1/5] dt-bindings: display: rockchip: Add rk3576 DisplayPort Andy Yan
2026-01-13 21:33 ` Sebastian Reichel
2026-01-15 17:18 ` Rob Herring [this message]
2026-01-09 8:00 ` [PATCH 2/5] drm/bridge: synopsys: dw-dp: Set pixel mode by platform data Andy Yan
2026-01-13 21:36 ` Sebastian Reichel
2026-01-20 10:43 ` Heiko Stuebner
2026-01-09 8:00 ` [PATCH 3/5] drm/bridge: synopsys: dw-dp: Make i2s/spdif clk optional Andy Yan
2026-01-13 21:37 ` Sebastian Reichel
2026-01-09 8:00 ` [PATCH 4/5] drm/rockchip: dw_dp: Add DisplayPort support for rk3576 Andy Yan
2026-01-13 21:37 ` Sebastian Reichel
2026-01-09 8:00 ` [PATCH 5/5] arm64: dts: rockchip: Add DisplayPort dt node " Andy Yan
2026-01-13 21:43 ` Sebastian Reichel
2026-01-13 21:51 ` [PATCH 0/5] Add DisplayPort support " Sebastian Reichel
2026-01-14 1:42 ` Chaoyi Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260115171805.GA907039-robh@kernel.org \
--to=robh@kernel.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=andy.yan@rock-chips.com \
--cc=andyshrk@163.com \
--cc=conor+dt@kernel.org \
--cc=cristian.ciocaltea@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mripard@kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox