From: Alexander Dahl <ada@thorsis.com>
To: Claudiu Beznea <claudiu.beznea@tuxon.dev>
Cc: Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Ryan Wanner <ryan.wanner@microchip.com>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Cristian Birsan <cristian.birsan@microchip.com>,
Varshini Rajendran <varshini.rajendran@microchip.com>,
Balamanikandan Gunasundar
<balamanikandan.gunasundar@microchip.com>
Subject: [PATCH v3 06/19] clk: at91: Allow enabling main_rc_osc through DT
Date: Tue, 20 Jan 2026 15:37:27 +0100 [thread overview]
Message-ID: <20260120143759.904013-7-ada@thorsis.com> (raw)
In-Reply-To: <20260120143759.904013-1-ada@thorsis.com>
SAM9X60 Datasheet (DS60001579G) Section "23.4 Product Dependencies"
says:
"The OTPC is clocked through the Power Management Controller (PMC).
The user must power on the main RC oscillator and enable the
peripheral clock of the OTPC prior to reading or writing the OTP
memory."
The code for enabling/disabling that clock is already present, it was
just not possible to hook into DT anymore, after at91 clk devicetree
binding rework back in 2018 for kernel v4.19.
Do it for all controllers with an OTPC controller, where the main rc
oscillator is required for proper operation.
Signed-off-by: Alexander Dahl <ada@thorsis.com>
---
Notes:
v3:
- no changes
v2:
- split out dt-bindings changes into separate patch
- extend to drivers for other SoCs providing the OTPC
drivers/clk/at91/sam9x60.c | 1 +
drivers/clk/at91/sam9x7.c | 1 +
drivers/clk/at91/sama7d65.c | 1 +
drivers/clk/at91/sama7g5.c | 1 +
4 files changed, 4 insertions(+)
diff --git a/drivers/clk/at91/sam9x60.c b/drivers/clk/at91/sam9x60.c
index dbcdb1d2161a9..a9f293a8e3b26 100644
--- a/drivers/clk/at91/sam9x60.c
+++ b/drivers/clk/at91/sam9x60.c
@@ -227,6 +227,7 @@ static void __init sam9x60_pmc_setup(struct device_node *np)
50000000);
if (IS_ERR(hw))
goto err_free;
+ sam9x60_pmc->chws[SAM9X60_PMC_MAIN_RC] = hw;
hw = at91_clk_register_main_osc(regmap, "main_osc", mainxtal_name, NULL, 0);
if (IS_ERR(hw))
diff --git a/drivers/clk/at91/sam9x7.c b/drivers/clk/at91/sam9x7.c
index 07eadb712a1e4..9a5afd258cb86 100644
--- a/drivers/clk/at91/sam9x7.c
+++ b/drivers/clk/at91/sam9x7.c
@@ -764,6 +764,7 @@ static void __init sam9x7_pmc_setup(struct device_node *np)
50000000);
if (IS_ERR(hw))
goto err_free;
+ sam9x7_pmc->chws[SAM9X7_PMC_MAIN_RC] = hw;
hw = at91_clk_register_main_osc(regmap, "main_osc", mainxtal_name, NULL, 0);
if (IS_ERR(hw))
diff --git a/drivers/clk/at91/sama7d65.c b/drivers/clk/at91/sama7d65.c
index 4ccffa8db43a5..5d8973aa50a53 100644
--- a/drivers/clk/at91/sama7d65.c
+++ b/drivers/clk/at91/sama7d65.c
@@ -1135,6 +1135,7 @@ static void __init sama7d65_pmc_setup(struct device_node *np)
50000000);
if (IS_ERR(main_rc_hw))
goto err_free;
+ sama7d65_pmc->chws[SAMA7D65_PMC_MAIN_RC] = hw;
bypass = of_property_read_bool(np, "atmel,osc-bypass");
diff --git a/drivers/clk/at91/sama7g5.c b/drivers/clk/at91/sama7g5.c
index 99b4c1d9bdcca..9a6f0f30b2b7e 100644
--- a/drivers/clk/at91/sama7g5.c
+++ b/drivers/clk/at91/sama7g5.c
@@ -1014,6 +1014,7 @@ static void __init sama7g5_pmc_setup(struct device_node *np)
50000000);
if (IS_ERR(main_rc_hw))
goto err_free;
+ sama7g5_pmc->chws[SAMA7G5_PMC_MAIN_RC] = hw;
bypass = of_property_read_bool(np, "atmel,osc-bypass");
--
2.47.3
next prev parent reply other threads:[~2026-01-20 14:39 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-20 14:37 [PATCH v3 00/19] Microchip OTPC driver on SAM9X60 exposing UIDxR as additional nvmem device Alexander Dahl
2026-01-20 14:37 ` [PATCH v3 01/19] MAINTAINERS: Add sam9/sama to (AT91) SoC support Alexander Dahl
2026-01-20 14:37 ` [PATCH v3 02/19] dt-bindings: clock: at91: Split up per SoC partially Alexander Dahl
2026-01-22 16:46 ` Rob Herring (Arm)
2026-01-31 15:43 ` Claudiu Beznea
2026-01-20 14:37 ` [PATCH v3 03/19] dt-bindings: clock: at91: Allow referencing main rc oscillator in DT Alexander Dahl
2026-01-31 15:44 ` Claudiu Beznea
2026-02-09 8:08 ` Alexander Dahl
2026-03-08 16:43 ` Claudiu Beznea
2026-01-20 14:37 ` [PATCH v3 04/19] clk: at91: Use new PMC bindings Alexander Dahl
2026-01-31 15:44 ` Claudiu Beznea
2026-01-20 14:37 ` [PATCH v3 05/19] clk: at91: sama7d65: Use highest PMC definition as max index Alexander Dahl
2026-01-31 15:45 ` Claudiu Beznea
2026-01-20 14:37 ` Alexander Dahl [this message]
2026-01-31 15:45 ` [PATCH v3 06/19] clk: at91: Allow enabling main_rc_osc through DT Claudiu Beznea
2026-01-20 14:37 ` [PATCH v3 07/19] clk: at91: Add peripheral id for OTPC Alexander Dahl
2026-01-31 15:45 ` Claudiu Beznea
2026-01-20 15:44 ` Alexander Dahl
2026-01-20 15:44 ` [PATCH v3 08/19] dt-bindings: nvmem: microchip-otpc: Add compatible for SAM9X60 Alexander Dahl
2026-01-20 15:44 ` [PATCH v3 09/19] dt-bindings: nvmem: microchip-otpc: Add required clocks Alexander Dahl
2026-01-20 16:30 ` Rob Herring (Arm)
2026-01-31 15:47 ` Claudiu Beznea
2026-01-31 15:51 ` Claudiu Beznea
2026-02-20 9:58 ` Alexander Dahl
2026-03-08 16:42 ` Claudiu Beznea
2026-03-08 16:45 ` Claudiu Beznea
2026-01-20 15:44 ` [PATCH v3 10/19] nvmem: microchip-otpc: Avoid reading a write-only register Alexander Dahl
2026-01-31 15:58 ` Claudiu Beznea
2026-01-20 15:44 ` [PATCH v3 11/19] nvmem: microchip-otpc: Fix swapped 'sleep' and 'timeout' parameters Alexander Dahl
2026-01-31 16:00 ` Claudiu Beznea
2026-01-20 15:44 ` [PATCH v3 12/19] nvmem: microchip-otpc: Add SAM9X60 support Alexander Dahl
2026-01-31 15:53 ` Claudiu Beznea
2026-01-20 15:44 ` [PATCH v3 13/19] nvmem: microchip-otpc: Enable necessary clocks Alexander Dahl
2026-01-31 16:03 ` Claudiu Beznea
2026-01-20 15:44 ` [PATCH v3 14/19] nvmem: microchip-otpc: Expose UID registers as 2nd nvmem device Alexander Dahl
2026-01-31 16:11 ` Claudiu Beznea
2026-02-20 10:38 ` Alexander Dahl
2026-03-08 16:40 ` Claudiu Beznea
2026-01-20 15:44 ` [PATCH v3 15/19] ARM: dts: microchip: Use new PMC bindings Alexander Dahl
2026-01-20 15:44 ` [PATCH v3 16/19] ARM: dts: microchip: sama7g5: Add OTPC clocks Alexander Dahl
2026-01-20 15:44 ` [PATCH v3 17/19] ARM: dts: microchip: sam9x60: Add OTPC node Alexander Dahl
2026-01-20 15:44 ` [PATCH v3 18/19] ARM: dts: microchip: sam9x60_curiosity: Enable OTP Controller Alexander Dahl
2026-01-20 15:44 ` [PATCH v3 19/19] dt-bindings: clock: at91: Remove old PMC definitions Alexander Dahl
2026-01-22 16:47 ` Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260120143759.904013-7-ada@thorsis.com \
--to=ada@thorsis.com \
--cc=alexandre.belloni@bootlin.com \
--cc=balamanikandan.gunasundar@microchip.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=cristian.birsan@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=nicolas.ferre@microchip.com \
--cc=ryan.wanner@microchip.com \
--cc=sboyd@kernel.org \
--cc=varshini.rajendran@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox