From: Leo Yan <leo.yan@arm.com>
To: Will Deacon <will@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Alexandru Elisei <alexandru.elisei@arm.com>,
James Clark <james.clark@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] perf: arm_spe: Correct setting the PERF_HES_STOPPED flag
Date: Tue, 20 Jan 2026 18:15:47 +0000 [thread overview]
Message-ID: <20260120181547.GI2732125@e132581.arm.com> (raw)
In-Reply-To: <aW-wfy3u5OD3BQAQ@willie-the-truck>
On Tue, Jan 20, 2026 at 04:42:39PM +0000, Will Deacon wrote:
[...]
> Ok, so looking at this and the next patch I wonder if we could simplify
> things a little by having arm_spe_perf_aux_output_begin() return an 'int'
> to indicate success/failure instead of touching 'hwc->state'.
>
> Then arm_spe_pmu_start() and the interrupt handler could call into
> arm_spe_pmu_stop() if they get an error code back. Would that work?
Yes, your suggested approach is cleaner. I will respin patches.
Thanks for the suggestions!
Leo
next prev parent reply other threads:[~2026-01-20 18:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-10 16:28 [PATCH v2 0/2] perf: arm_spe: Fix trace disabling for invalid limits Leo Yan
2025-11-10 16:28 ` [PATCH v2 1/2] perf: arm_spe: Correct setting the PERF_HES_STOPPED flag Leo Yan
2025-11-24 16:14 ` Will Deacon
2025-11-24 18:48 ` Leo Yan
2025-11-24 18:54 ` Leo Yan
2025-11-24 19:02 ` Will Deacon
2025-11-25 14:20 ` Leo Yan
2026-01-08 16:23 ` Will Deacon
2026-01-14 17:52 ` Leo Yan
2026-01-20 16:42 ` Will Deacon
2026-01-20 18:15 ` Leo Yan [this message]
2025-11-10 16:28 ` [PATCH v2 2/2] perf: arm_spe: Ensure profiling buffer is properly disabled Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260120181547.GI2732125@e132581.arm.com \
--to=leo.yan@arm.com \
--cc=alexandru.elisei@arm.com \
--cc=james.clark@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox